Merge remote-tracking branch 'origin/peppe/common_test/test_categories'

* origin/peppe/common_test/test_categories:
  Reintroduce functions for backwards compatibility
  Update handling of failing all/0 function in test suites
  Add tests for the get_testspec_terms functionality
  Introduce test categories for OTP tests

OTP-11962

3 files changed, 54 insertions, 3 deletions

diff --git a/lib/common_test/test/ct_testspec_3_SUITE_data/tests1/t11_SUITE.erl b/lib/common_test/test/ct_testspec_3_SUITE_data/tests1/t11_SUITE.erl
index b8216c3596..cfc6fa93d7 100644
--- a/lib/common_test/test/ct_testspec_3_SUITE_data/tests1/t11_SUITE.erl
+++ b/lib/common_test/test/ct_testspec_3_SUITE_data/tests1/t11_SUITE.erl
@@ -41,8 +41,12 @@ suite() ->
 %% @end
 %%--------------------------------------------------------------------
 init_per_suite(Config) ->
+
+    TCName = ct:get_config(tcname),
+    CfgFiles = ct:get_config(file,undefined,[all]),
+
     %% verify that expected config file can be read
-    case {ct:get_config(tcname),ct:get_config(file,undefined,[all])} of
+    case {TCName,CfgFiles} of
 	{start_separate,[cfg11]} -> ok;
 	{start_join,[cfg11,cfg21]} -> ok;
 	{incl_separate1,[cfg11]} -> ok;
@@ -56,6 +60,28 @@ init_per_suite(Config) ->
 	_ -> ok
 
     end,
+
+    %% test the get_testspec_terms functionality
+    if CfgFiles /= undefined ->
+	    TSTerms = case ct:get_testspec_terms() of
+			  undefined -> exit('testspec should not be undefined');
+			  Result -> Result
+		      end,
+	    true = lists:keymember(config, 1, TSTerms),
+	    {config,TSCfgFiles} = ct:get_testspec_terms(config),
+	    [{config,TSCfgFiles},{tests,Tests}] = 
+		ct:get_testspec_terms([config,tests]),
+	    CfgNames = [list_to_atom(filename:basename(TSCfgFile)) ||
+			   {Node,TSCfgFile} <- TSCfgFiles, Node == node()],
+	    true = (length(CfgNames) == length(CfgFiles)),
+	    [true = lists:member(CfgName,CfgFiles) || CfgName <- CfgNames],
+	    true = lists:any(fun({{_Node,_Dir},Suites}) ->
+				     lists:keymember(?MODULE, 1, Suites)
+			     end, Tests);
+       true ->
+	    ok
+    end,
+
     Config.
 
 %%--------------------------------------------------------------------
diff --git a/lib/common_test/test/ct_testspec_3_SUITE_data/tests1/t12_SUITE.erl b/lib/common_test/test/ct_testspec_3_SUITE_data/tests1/t12_SUITE.erl
index 7c51aca246..c3faebbd64 100644
--- a/lib/common_test/test/ct_testspec_3_SUITE_data/tests1/t12_SUITE.erl
+++ b/lib/common_test/test/ct_testspec_3_SUITE_data/tests1/t12_SUITE.erl
@@ -55,7 +55,7 @@ init_per_suite(Config) ->
 	{incl_both2,[cfg11,cfg12,cfg21]} -> ok;
 	{incl_both2,[cfg21]} -> ok;
 	_ -> ok
-    end,
+    end, 
     Config.
 
 %%--------------------------------------------------------------------
diff --git a/lib/common_test/test/ct_testspec_3_SUITE_data/tests2/t21_SUITE.erl b/lib/common_test/test/ct_testspec_3_SUITE_data/tests2/t21_SUITE.erl
index 36c1b4279b..e189b168c7 100644
--- a/lib/common_test/test/ct_testspec_3_SUITE_data/tests2/t21_SUITE.erl
+++ b/lib/common_test/test/ct_testspec_3_SUITE_data/tests2/t21_SUITE.erl
@@ -41,8 +41,11 @@ suite() ->
 %% @end
 %%--------------------------------------------------------------------
 init_per_suite(Config) ->
+    TCName = ct:get_config(tcname),
+    CfgFiles = ct:get_config(file,undefined,[all]),
+
     %% verify that expected config file can be read
-    case {ct:get_config(tcname),ct:get_config(file,undefined,[all])} of
+    case {TCName,CfgFiles} of 
 	{start_separate,[cfg11]} -> ok;
 	{start_join,[cfg11,cfg21]} -> ok;
 	{incl_separate1,[cfg11]} -> ok;
@@ -55,6 +58,28 @@ init_per_suite(Config) ->
 	{incl_both2,[cfg11]} -> ok;
 	_ -> ok
     end,
+
+     %% test the get_testspec_terms functionality
+    if CfgFiles /= undefined ->
+	    TSTerms = case ct:get_testspec_terms() of
+			  undefined -> exit('testspec should not be undefined');
+			  Result -> Result
+		      end,
+	    true = lists:keymember(config, 1, TSTerms),
+	    {config,TSCfgFiles} = ct:get_testspec_terms(config),
+	    [{config,TSCfgFiles},{tests,Tests}] = 
+		ct:get_testspec_terms([config,tests]),
+	    CfgNames = [list_to_atom(filename:basename(TSCfgFile)) ||
+			   {Node,TSCfgFile} <- TSCfgFiles, Node == node()],
+	    true = (length(CfgNames) == length(CfgFiles)),
+	    [true = lists:member(CfgName,CfgFiles) || CfgName <- CfgNames],
+	    true = lists:any(fun({{_Node,_Dir},Suites}) ->
+				     lists:keymember(?MODULE, 1, Suites)
+			     end, Tests);
+       true ->
+	    ok
+    end,
+
     Config.
 
 %%--------------------------------------------------------------------