Merge branch 'siri/string-new-api'

* siri/string-new-api: (28 commits)
  hipe (test): Do not use deprecated functions in string(3)
  dialyzer (test): Do not use deprecated functions in string(3)
  eunit (test): Do not use deprecated functions in string(3)
  system (test): Do not use deprecated functions in string(3)
  system (test): Do not use deprecated functions in string(3)
  mnesia (test): Do not use deprecated functions in string(3)
  Deprecate old string functions
  observer: Do not use deprecated functions in string(3)
  common_test: Do not use deprecated functions in string(3)
  eldap: Do not use deprecated functions in string(3)
  et: Do not use deprecated functions in string(3)
  os_mon: Do not use deprecated functions in string(3)
  debugger: Do not use deprecated functions in string(3)
  runtime_tools: Do not use deprecated functions in string(3)
  asn1: Do not use deprecated functions in string(3)
  compiler: Do not use deprecated functions in string(3)
  sasl: Do not use deprecated functions in string(3)
  reltool: Do not use deprecated functions in string(3)
  kernel: Do not use deprecated functions in string(3)
  hipe: Do not use deprecated functions in string(3)
  ...

Conflicts:
	lib/eunit/src/eunit_lib.erl
	lib/observer/src/crashdump_viewer.erl
	lib/reltool/src/reltool_target.erl

6 files changed, 23 insertions, 29 deletions

diff --git a/lib/common_test/test_server/ts.erl b/lib/common_test/test_server/ts.erl
index 5bfea9f4de..330652e73f 100644
--- a/lib/common_test/test_server/ts.erl
+++ b/lib/common_test/test_server/ts.erl
@@ -583,7 +583,7 @@ is_list_of_suites(List) ->
 		      S = if is_atom(Suite) -> atom_to_list(Suite);
 			     true -> Suite
 			  end,
-		      try lists:last(string:tokens(S,"_")) of
+		      try lists:last(string:lexemes(S,"_")) of
 			  "SUITE" -> true;
 			  "suite" -> true;
 			  _ -> false
diff --git a/lib/common_test/test_server/ts_autoconf_win32.erl b/lib/common_test/test_server/ts_autoconf_win32.erl
index 52e5ac8e69..6f6caaeb70 100644
--- a/lib/common_test/test_server/ts_autoconf_win32.erl
+++ b/lib/common_test/test_server/ts_autoconf_win32.erl
@@ -228,7 +228,7 @@ make(Vars) ->
     end.
 
 find_make(MakeCmd, Vars) ->
-    [Make|_] = string:tokens(MakeCmd, " \t"),
+    [Make|_] = string:lexemes(MakeCmd, " \t"),
     case os:find_executable(Make) of
 	false ->
 	    {no, Vars};
@@ -248,9 +248,9 @@ javac(Vars) ->
     end.
 
 is_debug_build() ->
-    case catch string:str(erlang:system_info(system_version), "debug") of
-	Int when is_integer(Int), Int > 0 ->
-	    true;
-	_ ->
-	    false
+    case catch string:find(erlang:system_info(system_version), "debug") of
+        nomatch ->
+            false;
+	_Else ->
+	    true
     end.
diff --git a/lib/common_test/test_server/ts_erl_config.erl b/lib/common_test/test_server/ts_erl_config.erl
index 032593bdda..c7fe4ccf83 100644
--- a/lib/common_test/test_server/ts_erl_config.erl
+++ b/lib/common_test/test_server/ts_erl_config.erl
@@ -311,7 +311,7 @@ lib_dir(Vars, Lib) ->
 			  end,
 	    CLibDir = filename:join(CLibDirList),
 	    Cmd = "ls -d " ++ CLibDir ++ "*",
-	    XLibDir = lists:last(string:tokens(os:cmd(Cmd),"\n")),
+	    XLibDir = lists:last(string:lexemes(os:cmd(Cmd),"\n")),
 	    case file:list_dir(XLibDir) of
 		{error, enoent} ->
 		    [];
@@ -361,15 +361,11 @@ emu_vars(Vars) ->
      {erl_name, atom_to_list(lib:progname())}|Vars].
 
 is_source_build() ->
-    string:str(erlang:system_info(system_version), "[source]") > 0.
+    string:find(erlang:system_info(system_version), "source") =/= nomatch.
 
 is_debug_build() ->
-    case catch string:str(erlang:system_info(system_version), "debug") of
-	Int when is_integer(Int), Int > 0 ->
-	    true;
-	_ ->
-	    false
-    end.
+    string:find(erlang:system_info(system_version), "debug") =/= nomatch.
+
 %%
 %% ssl_libdir
 %%
diff --git a/lib/common_test/test_server/ts_install.erl b/lib/common_test/test_server/ts_install.erl
index c5631fb9c3..048e5493d2 100644
--- a/lib/common_test/test_server/ts_install.erl
+++ b/lib/common_test/test_server/ts_install.erl
@@ -115,7 +115,7 @@ get_vars(_, _, _, _) ->
 config_flags() ->
     case os:getenv("CONFIG_FLAGS") of
 	false -> [];
-	CF -> string:tokens(CF, " \t\n")
+	CF -> string:lexemes(CF, " \t\n")
     end.
 
 unix_autoconf(XConf) ->
@@ -127,7 +127,7 @@ unix_autoconf(XConf) ->
     Threads = [" --enable-shlib-thread-safety" ||
 		  erlang:system_info(threads) /= false],
     Debug = [" --enable-debug-mode" ||
-		string:str(erlang:system_info(system_version),"debug") > 0],
+		string:find(erlang:system_info(system_version),"debug") =/= nomatch],
     MXX_Build = [Y || Y <- config_flags(),
 		      Y == "--enable-m64-build"
 			  orelse Y == "--enable-m32-build"],
@@ -159,10 +159,8 @@ assign_vars([]) ->
 assign_vars([{VAR,FlagsStr} | VARs]) ->
     [{VAR,assign_vars(FlagsStr)} | assign_vars(VARs)];
 assign_vars(FlagsStr) ->
-    Flags = [assign_all_vars(Str,[]) || Str <- string:tokens(FlagsStr, [$ ])],
-    string:strip(lists:flatten(lists:map(fun(Flag) ->
-						 Flag ++ " "
-					 end, Flags)), right).
+    Flags = [assign_all_vars(Str,[]) || Str <- string:lexemes(FlagsStr, [$\s])],
+    lists:flatten(lists:join(" ", Flags)).
 
 assign_all_vars([$$ | Rest], FlagSoFar) ->
     {VarName,Rest1} = get_var_name(Rest, []),
@@ -292,7 +290,7 @@ add_vars(Vars0, Opts0) ->
 get_testcase_callback() ->
     case os:getenv("TS_TESTCASE_CALLBACK") of
 	ModFunc when is_list(ModFunc), ModFunc /= "" ->
-	    case string:tokens(ModFunc, " ") of
+	    case string:lexemes(ModFunc, " ") of
 		[_Mod,_Func] -> ModFunc;
 		_ -> ""
 	    end;
@@ -430,8 +428,8 @@ bind_type() ->
 					
 
 debug() ->
-    case string:str(erlang:system_info(system_version), "debug") of
-	0 -> "";
+    case string:find(erlang:system_info(system_version), "debug") of
+	nomatch -> "";
 	_ -> "/Debug"
     end.
 
diff --git a/lib/common_test/test_server/ts_lib.erl b/lib/common_test/test_server/ts_lib.erl
index ea039a2c2b..da8d676b18 100644
--- a/lib/common_test/test_server/ts_lib.erl
+++ b/lib/common_test/test_server/ts_lib.erl
@@ -99,7 +99,7 @@ specialized_specs(Dir,PostFix) ->
     sort_tests([begin
 		    DirPart = filename:dirname(Name),
 		    AppTest = hd(lists:reverse(filename:split(DirPart))),
-		    list_to_atom(string:substr(AppTest, 1, length(AppTest)-5))
+		    list_to_atom(string:slice(AppTest, 0, string:length(AppTest)-5))
 		end || Name <- Specs]).
 
 specs(Dir) ->
@@ -111,9 +111,9 @@ specs(Dir) ->
 			      [Spec,TestDir|_] =
 				  lists:reverse(filename:split(FullName)),
 			      [_TestSuffix|TDParts] = 
-				  lists:reverse(string:tokens(TestDir,[$_,$.])),
+				  lists:reverse(string:lexemes(TestDir,[$_,$.])),
 			      [_SpecSuffix|SParts] = 
-				  lists:reverse(string:tokens(Spec,[$_,$.])),
+				  lists:reverse(string:lexemes(Spec,[$_,$.])),
 			      if TDParts == SParts ->
 				      [filename_to_atom(FullName)];	  
 				 true ->
@@ -273,7 +273,7 @@ do_test(Rest, Vars, Test) ->
 get_arg([$(|Rest], Vars, Stop, _) ->		
     get_arg(Rest, Vars, Stop, []); 
 get_arg([Stop|Rest], Vars, Stop, Acc) ->
-    Arg = string:strip(lists:reverse(Acc)),
+    Arg = string:trim(lists:reverse(Acc),both,[$\s]),
     Subst = subst(Arg, Vars),
     {Subst,Rest};
 get_arg([C|Rest], Vars, Stop, Acc) ->
diff --git a/lib/common_test/test_server/ts_run.erl b/lib/common_test/test_server/ts_run.erl
index 2736010551..3f594236bc 100644
--- a/lib/common_test/test_server/ts_run.erl
+++ b/lib/common_test/test_server/ts_run.erl
@@ -464,4 +464,4 @@ split_one(Path) ->
     filename:split(Path).
 
 split_path(Path) ->
-    string:tokens(Path,";").
+    string:lexemes(Path,";").