Merge remote-tracking branch 'origin/peppe/common_test/ct_netconfc_action_ok' into maint

* origin/peppe/common_test/ct_netconfc_action_ok:
  Handle {ok,Data} in RPC reply (decode_rpc_reply)

OTP-12491

3 files changed, 20 insertions, 4 deletions

diff --git a/lib/common_test/src/ct_netconfc.erl b/lib/common_test/src/ct_netconfc.erl
index bded5a15cb..85fb1ea8d2 100644
--- a/lib/common_test/src/ct_netconfc.erl
+++ b/lib/common_test/src/ct_netconfc.erl
@@ -759,8 +759,9 @@ action(Client,Action) ->
       Client :: client(),
       Action :: simple_xml(),
       Timeout :: timeout(),
-      Result :: {ok,[simple_xml()]} | {error,error_reason()}.
-%% @doc Execute an action.
+      Result :: ok | {ok,[simple_xml()]} | {error,error_reason()}.
+%% @doc Execute an action. If the return type is void, <c>ok</c> will
+%%      be returned instead of <c>{ok,[simple_xml()]}</c>.
 %%
 %% @end
 %%----------------------------------------------------------------------
@@ -1570,6 +1571,9 @@ decode_ok(Other) ->
 
 decode_data([{Tag,Attrs,Content}]) ->
     case get_local_name_atom(Tag) of
+	ok ->
+	    %% when action has return type void
+	    ok;	
 	data ->
 	    %% Since content of data has nothing from the netconf
 	    %% namespace, we remove the parent's xmlns attribute here
diff --git a/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl b/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
index 2bcfeeec0c..6f5db21f57 100644
--- a/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
+++ b/lib/common_test/test/ct_netconfc_SUITE_data/netconfc1_SUITE.erl
@@ -488,8 +488,15 @@ action(Config) ->
     DataDir = ?config(data_dir,Config),
     {ok,Client} = open_success(DataDir),
     Data = [{myactionreturn,[{xmlns,"myns"}],["value"]}],
-    ?NS:expect_reply(action,{data,Data}),
-    {ok,Data} = ct_netconfc:action(Client,{myaction,[{xmlns,"myns"}],[]}),
+    %% test either to receive {data,Data} or {ok,Data},
+    %% both need to be handled
+    {Reply,RetVal} = case element(3, now()) rem 2 of
+			 0 -> {{data,Data},{ok,Data}};
+			 1 -> {{ok,Data},ok}
+		     end,
+    ct:log("Client will receive {~w,Data}", [element(1,Reply)]),
+    ?NS:expect_reply(action,Reply),
+    RetVal = ct_netconfc:action(Client,{myaction,[{xmlns,"myns"}],[]}),
     ?NS:expect_do_reply('close-session',close,ok),
     ?ok = ct_netconfc:close_session(Client),
     ok.
diff --git a/lib/common_test/test/ct_netconfc_SUITE_data/ns.erl b/lib/common_test/test/ct_netconfc_SUITE_data/ns.erl
index fb0734d48e..f503825c4e 100644
--- a/lib/common_test/test/ct_netconfc_SUITE_data/ns.erl
+++ b/lib/common_test/test/ct_netconfc_SUITE_data/ns.erl
@@ -540,8 +540,13 @@ make_msg({hello,SessionId,Stuff}) ->
 	  SessionIdXml/binary,"</hello>">>);
 make_msg(ok) ->
     xml(rpc_reply("<ok/>"));
+
+make_msg({ok,Data}) ->
+    xml(rpc_reply(from_simple({ok,Data})));
+
 make_msg({data,Data}) ->
     xml(rpc_reply(from_simple({data,Data})));
+
 make_msg(event) ->
     xml(<<"<notification xmlns=\"",?NETCONF_NOTIF_NAMESPACE,"\">"
 	  "<eventTime>2012-06-14T14:50:54+02:00</eventTime>"