diff options
| author | Björn Gustavsson <[email protected]> | 2015-10-05 06:43:12 +0200 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2015-10-05 12:47:55 +0200 |
| commit | 76bb9f0e9a0b36ea7c9720c2bf90f6b52a4eabf8 (patch) | |
| tree | 47e29acaeafb5025531d8736ffb7ded30cf678a3 /lib/compiler/test/Makefile | |
| parent | 7dd616c1832c54370be7f796a4b6578a8d9aedd9 (diff) | |
| download | otp-76bb9f0e9a0b36ea7c9720c2bf90f6b52a4eabf8.tar.gz otp-76bb9f0e9a0b36ea7c9720c2bf90f6b52a4eabf8.tar.bz2 otp-76bb9f0e9a0b36ea7c9720c2bf90f6b52a4eabf8.zip | |
beam_reorder: Eliminate compiler crash
c288ab87 added beam_reorder to move get_tuple_element instructions.
Compiling code such as the following would crash the compiler:
alloc(_U1, _U2, R) ->
V = R#alloc.version,
Res = id(V),
_ = id(0),
Res.
The crash would occur because the following two instructions:
{get_tuple_element,{x,2},1,{x,1}}.
{allocate_zero,1,2}.
were swapped and rewritten to:
{allocate_zero,1,1}.
{get_tuple_element,{x,2},1,{x,1}}.
That transformation is not safe because the allocate_zero instruction
would kill {x,2}, which is the register that is holding the reference
to the tuple. Only do the transformation when the tuple reference is
in an x register with a lower number than the destination register.
Diffstat (limited to 'lib/compiler/test/Makefile')
| -rw-r--r-- | lib/compiler/test/Makefile | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/compiler/test/Makefile b/lib/compiler/test/Makefile index 0cd8618730..400565100f 100644 --- a/lib/compiler/test/Makefile +++ b/lib/compiler/test/Makefile @@ -11,6 +11,7 @@ MODULES= \ beam_validator_SUITE \ beam_disasm_SUITE \ beam_except_SUITE \ + beam_reorder_SUITE \ beam_type_SUITE \ beam_utils_SUITE \ bs_bincomp_SUITE \ @@ -44,6 +45,7 @@ NO_OPT= \ andor \ apply \ beam_except \ + beam_reorder \ beam_type \ beam_utils \ bs_construct \ |