diff options
| author | Björn Gustavsson <[email protected]> | 2015-04-26 07:12:26 +0200 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2015-04-29 12:25:06 +0200 |
| commit | c64199f4fce6c47323014b29623f78d0b3aad24f (patch) | |
| tree | 3d28cb822a3c105e4ced0c3c4ced9aea6b058ca4 /lib/compiler/test | |
| parent | 31779e0772006d822bb35b3f3fe0f0623d021aff (diff) | |
| download | otp-c64199f4fce6c47323014b29623f78d0b3aad24f.tar.gz otp-c64199f4fce6c47323014b29623f78d0b3aad24f.tar.bz2 otp-c64199f4fce6c47323014b29623f78d0b3aad24f.zip | |
beam_asm: Speed up encoding of large numbers
The misc_SUITE:integer_encoding/1 test case is annoyingly slow.
Rewrite the encoding of integers in beam_asm to use the
binary:encode_unsigned/1 BIF.
Also tweak the test case itself. Scale the down the maximum
size of the numbers being generated, but also add test of
numbers around boundaries of power of two (which are the numbers
most likely to expose bugs in the encoding).
Diffstat (limited to 'lib/compiler/test')
| -rw-r--r-- | lib/compiler/test/misc_SUITE.erl | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/lib/compiler/test/misc_SUITE.erl b/lib/compiler/test/misc_SUITE.erl index 68a31f14d5..f3b92aad5b 100644 --- a/lib/compiler/test/misc_SUITE.erl +++ b/lib/compiler/test/misc_SUITE.erl @@ -338,8 +338,16 @@ integer_encoding_1(Config) -> ?line do_integer_encoding(-(id(1) bsl 10000), Src, Data), ?line do_integer_encoding(id(1) bsl 10000, Src, Data), - ?line do_integer_encoding(2048, 0, Src, Data), - + do_integer_encoding(1024, 0, Src, Data), + _ = [begin + B = 1 bsl I, + do_integer_encoding(-B-1, Src, Data), + do_integer_encoding(-B, Src, Data), + do_integer_encoding(-B+1, Src, Data), + do_integer_encoding(B-1, Src, Data), + do_integer_encoding(B, Src, Data), + do_integer_encoding(B+1, Src, Data) + end || I <- lists:seq(1, 128)], io:put_chars(Src, "Last].\n\n"), ?line ok = file:close(Src), io:put_chars(Data, "0].\n\n"), @@ -372,11 +380,9 @@ do_integer_encoding(N, I0, Src, Data) -> do_integer_encoding(I, Src, Data) -> Str = integer_to_list(I), - io:put_chars(Src, Str), - io:put_chars(Src, ", \n"), - io:put_chars(Data, Str), - io:put_chars(Data, ", \n"). - + io:put_chars(Src, [Str,",\n"]), + io:put_chars(Data, [Str,",\n"]). + id(I) -> I. |