beam_validator: Stop validating the 'aligned' flag for binaries

The run-time system stopped paying attention the 'aligned' flag in bit
syntax construction and matching when bitstrings were introduced in
language.

The beam_asm compiler pass will crash if the 'aligned' flag is given
in bit syntax instructions.

beam_validator still validates the 'aligned' flag. Before
912fea0b712a (which removed the possibility to validate existing
BEAM files), the 'aligned' flag could actually be encountered
when validating a BEAM file.

Since the validation of 'aligned' no longer serves any useful
purpose, remove the validation code.

3 files changed, 7 insertions, 67 deletions

diff --git a/lib/compiler/test/beam_validator_SUITE.erl b/lib/compiler/test/beam_validator_SUITE.erl
index 6779a2cfec..e64dd6b9c3 100644
--- a/lib/compiler/test/beam_validator_SUITE.erl
+++ b/lib/compiler/test/beam_validator_SUITE.erl
@@ -28,7 +28,7 @@
 	 overwrite_catchtag/1,overwrite_trytag/1,accessing_tags/1,bad_catch_try/1,
 	 cons_guard/1,
 	 freg_range/1,freg_uninit/1,freg_state/1,
-	 bad_bin_match/1,bin_aligned/1,bad_dsetel/1,
+	 bad_bin_match/1,bad_dsetel/1,
 	 state_after_fault_in_catch/1,no_exception_in_catch/1,
 	 undef_label/1,illegal_instruction/1,failing_gc_guard_bif/1,
 	 map_field_lists/1]).
@@ -57,7 +57,7 @@ groups() ->
        unsafe_catch,dead_code,
        overwrite_catchtag,overwrite_trytag,accessing_tags,
        bad_catch_try,cons_guard,freg_range,freg_uninit,
-       freg_state,bad_bin_match,bin_aligned,bad_dsetel,
+       freg_state,bad_bin_match,bad_dsetel,
        state_after_fault_in_catch,no_exception_in_catch,
        undef_label,illegal_instruction,failing_gc_guard_bif,
        map_field_lists]}].
@@ -178,7 +178,7 @@ unsafe_catch(Config) when is_list(Config) ->
     ?line
 	[{{t,small,2},
 	  {{bs_put_integer,{f,0},{integer,16},1,
-	    {field_flags,[aligned,unsigned,big]},{y,0}},
+	    {field_flags,[unsigned,big]},{y,0}},
 	   20,
 	   {unassigned,{y,0}}}}] = Errors,
     ok.
@@ -299,19 +299,6 @@ bad_bin_match(Config) when is_list(Config) ->
 		do_val(bad_bin_match, Config),
 	ok.
 
-bin_aligned(Config) when is_list(Config) ->
-    Errors = do_val(bin_aligned, Config),
-    ?line
-	[{{t,decode,1},
-	  {{bs_put_integer,{f,0},
-	    {integer,5},
-	    1,
-	    {field_flags,[unsigned,big,aligned]},
-	    {integer,0}},
-	   10,
-	   {aligned_flag_set,{bits,3}}}}] = Errors,
-    ok.
-
 bad_dsetel(Config) when is_list(Config) ->
     Errors = do_val(bad_dsetel, Config),
     ?line
diff --git a/lib/compiler/test/beam_validator_SUITE_data/bin_aligned.S b/lib/compiler/test/beam_validator_SUITE_data/bin_aligned.S
deleted file mode 100644
index a59f7ccc03..0000000000
--- a/lib/compiler/test/beam_validator_SUITE_data/bin_aligned.S
+++ /dev/null
@@ -1,47 +0,0 @@
-{module, bin_aligned}.  %% version = 0
-
-{exports, [{decode,1},{module_info,0},{module_info,1}]}.
-
-{attributes, []}.
-
-{labels, 7}.
-
-
-{function, decode, 1, 2}.
-  {label,1}.
-    {func_info,{atom,t},{atom,decode},1}.
-  {label,2}.
-    {move,{integer,1},{x,1}}.
-    {bif,size,{f,0},[{x,0}],{x,2}}.
-    {bs_add,{f,0},[{x,1},{x,2},1],{x,1}}.
-    {bs_init2,{f,0},{x,1},0,1,{field_flags,[]},{x,1}}.
-    {bs_put_integer,{f,0},
-                    {integer,3},
-                    1,
-                    {field_flags,[aligned,unsigned,big]},
-                    {integer,0}}.
-    {bs_put_binary,{f,0},{atom,all},8,{field_flags,[unsigned,big]},{x,0}}.
-    {bs_put_integer,{f,0},
-                    {integer,5},
-                    1,
-                    {field_flags,[unsigned,big,aligned]},
-                    {integer,0}}.
-    {move,{x,1},{x,0}}.
-    return.
-
-
-{function, module_info, 0, 4}.
-  {label,3}.
-    {func_info,{atom,t},{atom,module_info},0}.
-  {label,4}.
-    {move,{atom,t},{x,0}}.
-    {call_ext_only,1,{extfunc,erlang,get_module_info,1}}.
-
-
-{function, module_info, 1, 6}.
-  {label,5}.
-    {func_info,{atom,t},{atom,module_info},1}.
-  {label,6}.
-    {move,{x,0},{x,1}}.
-    {move,{atom,t},{x,0}}.
-    {call_ext_only,2,{extfunc,erlang,get_module_info,2}}.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/unsafe_catch.S b/lib/compiler/test/beam_validator_SUITE_data/unsafe_catch.S
index 500ac11377..f7d3f805b3 100644
--- a/lib/compiler/test/beam_validator_SUITE_data/unsafe_catch.S
+++ b/lib/compiler/test/beam_validator_SUITE_data/unsafe_catch.S
@@ -17,7 +17,7 @@
     {bs_put_integer,{f,0},
                     {integer,8},
                     1,
-                    {field_flags,[aligned,unsigned,big]},
+                    {field_flags,[unsigned,big]},
                     {x,0}}.
     {move,{x,1},{y,0}}.
     {move,{x,2},{x,0}}.
@@ -34,7 +34,7 @@
     {bs_put_integer,{f,0},
                     {integer,16},
                     1,
-                    {field_flags,[aligned,unsigned,big]},
+                    {field_flags,[unsigned,big]},
                     {y,0}}.
     {move,{x,0},{y,0}}.
     {move,{x,1},{x,0}}.
@@ -55,12 +55,12 @@
     {bs_put_binary,{f,0},
                    {atom,all},
                    8,
-                   {field_flags,[aligned,unsigned,big]},
+                   {field_flags,[unsigned,big]},
                    {y,0}}.
     {bs_put_binary,{f,0},
                    {atom,all},
                    8,
-                   {field_flags,[aligned,unsigned,big]},
+                   {field_flags,[unsigned,big]},
                    {x,0}}.
     {move,{x,1},{x,0}}.
     {deallocate,2}.