diff options
author | Björn Gustavsson <[email protected]> | 2011-02-23 14:15:20 +0100 |
---|---|---|
committer | Björn Gustavsson <[email protected]> | 2011-02-23 14:15:20 +0100 |
commit | 22ad9ca8677a372c9a7b615157f7fb7892211a0b (patch) | |
tree | 08ae1c049904febf40fc9d27335c4ca05b256677 /lib/compiler | |
parent | 6dfa9a9a775fe0c73d08dc7f2f5fa67edd9ece25 (diff) | |
download | otp-22ad9ca8677a372c9a7b615157f7fb7892211a0b.tar.gz otp-22ad9ca8677a372c9a7b615157f7fb7892211a0b.tar.bz2 otp-22ad9ca8677a372c9a7b615157f7fb7892211a0b.zip |
v3_kernel_pp: Eliminate dialyzer warning
Use conditional compilation instead of a run-time test.
Will also improve the coverage of the code.
Diffstat (limited to 'lib/compiler')
-rw-r--r-- | lib/compiler/src/v3_kernel_pp.erl | 37 |
1 files changed, 19 insertions, 18 deletions
diff --git a/lib/compiler/src/v3_kernel_pp.erl b/lib/compiler/src/v3_kernel_pp.erl index 9bd13f7032..e363a5387a 100644 --- a/lib/compiler/src/v3_kernel_pp.erl +++ b/lib/compiler/src/v3_kernel_pp.erl @@ -1,7 +1,7 @@ %% %% %CopyrightBegin% %% -%% Copyright Ericsson AB 1999-2010. All Rights Reserved. +%% Copyright Ericsson AB 1999-2011. All Rights Reserved. %% %% The contents of this file are subject to the Erlang Public License, %% Version 1.1, (the "License"); you may not use this file except in @@ -20,10 +20,12 @@ -module(v3_kernel_pp). --include("v3_kernel.hrl"). - -export([format/1]). +%%-define(INCLUDE_ANNOTATIONS, 1). + +-include("v3_kernel.hrl"). + %% These are "internal" structures in sys_kernel which are here for %% debugging purposes. -record(iset, {anno=[],vars,arg,body}). @@ -62,22 +64,21 @@ format(Node, Ctxt) -> end) end. -format_anno(Anno, Ctxt0, ObjFun) -> - case annotations_enabled() of - true -> - Ctxt1 = ctxt_bump_indent(Ctxt0, 1), - ["( ", - ObjFun(Ctxt0), - nl_indent(Ctxt1), - "-| ",io_lib:write(Anno), - " )"]; - false -> - ObjFun(Ctxt0) - end. -%% By default, don't show annotations since they clutter up the output. -annotations_enabled() -> - false. +-ifndef(INCLUDE_ANNOTATIONS). +%% Don't include annotations (for readability). +format_anno(_Anno, Ctxt, ObjFun) -> + ObjFun(Ctxt). +-else. +%% Include annotations (for debugging of annotations). +format_anno(Anno, Ctxt0, ObjFun) -> + Ctxt1 = ctxt_bump_indent(Ctxt0, 1), + ["( ", + ObjFun(Ctxt0), + nl_indent(Ctxt1), + "-| ",io_lib:write(Anno), + " )"]. +-endif. %% format_1(Kexpr, Context) -> string(). |