diff options
| author | Anthony Ramine <[email protected]> | 2014-03-01 18:13:15 +0100 |
|---|---|---|
| committer | Björn Gustavsson <[email protected]> | 2014-03-06 10:10:58 +0100 |
| commit | b08ffc15e1d9ad105dd6385bbac41c97c09b48bc (patch) | |
| tree | de094dd9e3a19bdd920b473f6a613a2d433fa923 /lib/compiler | |
| parent | c199bd2923e7d733e60beb9bd27b3852cbb2e699 (diff) | |
| download | otp-b08ffc15e1d9ad105dd6385bbac41c97c09b48bc.tar.gz otp-b08ffc15e1d9ad105dd6385bbac41c97c09b48bc.tar.bz2 otp-b08ffc15e1d9ad105dd6385bbac41c97c09b48bc.zip | |
Do not emit blatantly illformed apply expressions in core_inline
Code such as apply 'f'/1 () should not be emitted by the Core Erlang inliner.
Commit 1b8ad68361db59477013bf96e485d5293723ff42 added a test case
and correction in v3_core.
Diffstat (limited to 'lib/compiler')
| -rw-r--r-- | lib/compiler/src/cerl_inline.erl | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/lib/compiler/src/cerl_inline.erl b/lib/compiler/src/cerl_inline.erl index 44293bb8ce..bc9bdc67a4 100644 --- a/lib/compiler/src/cerl_inline.erl +++ b/lib/compiler/src/cerl_inline.erl @@ -51,7 +51,7 @@ catch_body/1, clause_body/1, clause_guard/1, clause_pats/1, clause_vars/1, concrete/1, cons_hd/1, cons_tl/1, data_arity/1, data_es/1, data_type/1, - fun_body/1, fun_vars/1, get_ann/1, int_val/1, + fname_arity/1, fun_body/1, fun_vars/1, get_ann/1, int_val/1, is_c_atom/1, is_c_cons/1, is_c_fname/1, is_c_int/1, is_c_list/1, is_c_seq/1, is_c_tuple/1, is_c_var/1, is_data/1, is_literal/1, is_literal_term/1, let_arg/1, @@ -1030,8 +1030,16 @@ i_apply(E, Ctxt, Ren, Env, S) -> visit_and_count_size(Opnd, S) end, S3, Opnds), - N = apply_size(length(Es)), - {update_c_apply(E, E1, Es), count_size(N, S4)} + Arity = length(Es), + E2 = case is_c_fname(E1) andalso length(Es) =/= fname_arity(E1) of + true -> + V = new_var(Env), + update_c_let(E, [V], E1, update_c_apply(E, V, Es)); + false -> + update_c_apply(E, E1, Es) + end, + N = apply_size(Arity), + {E2, count_size(N, S4)} end. apply_size(A) -> |