Merge branch 'lars/remove_now/OTP-12687'

* lars/remove_now/OTP-12687:
  [orber, cos*] Remove usage of erlang:now() in test suites
  [orber] Use rand instead of random
  [orber, cos*] Bump versions and update dependencies in app file
  [orber, cos*] Remove usage of erlang:now()

8 files changed, 60 insertions, 53 deletions

diff --git a/lib/cosNotification/src/CosNotification_Common.erl b/lib/cosNotification/src/CosNotification_Common.erl
index af9b2d4368..cdaaeee7f8 100644
--- a/lib/cosNotification/src/CosNotification_Common.erl
+++ b/lib/cosNotification/src/CosNotification_Common.erl
@@ -2,7 +2,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2011. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -39,8 +39,9 @@
 %%--------------- EXPORTS ------------------------------------
 %% External MISC
 -export([get_option/3, 
-         create_name/2, 
+         create_name/0,
          create_name/1,
+         create_name/2, 
 	 create_id/0,
 	 create_id/1,
          is_debug_compiled/0,
@@ -110,17 +111,20 @@ get_option(Key, OptionList, DefaultList) ->
                     {error, "Invalid option"}
             end
     end.
-%%-----------------------------------------------------------%
-%% function : create_name/2
+
+%%------------------------------------------------------------
+%% function : create_name
 %% Arguments: 
 %% Returns  : 
-%% Exception: 
-%% Effect   : 
+%% Effect   : Create a unique name to use when, for eaxmple, starting
+%%            a new server.
 %%------------------------------------------------------------
-create_name(Name,Type) ->
-    {MSec, Sec, USec} = erlang:now(),
-    lists:concat(['oe_',node(),'_',Type,'_',Name,'_',MSec, '_', Sec, '_', USec]).
- 
+create_name() ->
+    Time = erlang:system_time(),
+    Unique = erlang:unique_integer([positive]),
+    lists:concat(['oe_',node(),'_',Time,'_',Unique]).
+
+
 %%-----------------------------------------------------------%
 %% function : create_name/1
 %% Arguments: 
@@ -129,8 +133,21 @@ create_name(Name,Type) ->
 %% Effect   : 
 %%------------------------------------------------------------ 
 create_name(Type) ->
-    {MSec, Sec, USec} = erlang:now(),
-    lists:concat(['oe_',node(),'_',Type,'_',MSec, '_', Sec, '_', USec]).
+    Time = erlang:system_time(),
+    Unique = erlang:unique_integer([positive]),
+    lists:concat(['oe_',node(),'_',Type,'_',Time,'_',Unique]).
+
+%%-----------------------------------------------------------%
+%% function : create_name/2
+%% Arguments: 
+%% Returns  : 
+%% Exception: 
+%% Effect   : 
+%%------------------------------------------------------------
+create_name(Name,Type) ->
+    Time = erlang:system_time(),
+    Unique = erlang:unique_integer([positive]),
+    lists:concat(['oe_',node(),'_',Type,'_',Name,'_',Time,'_',Unique]).
  
 %%------------------------------------------------------------
 %% function : create_id/0
@@ -146,16 +163,16 @@ create_name(Type) ->
 %%------------------------------------------------------------
 create_id(-1) ->
     1;
-create_id( 2147483647) ->
+create_id(2147483647) ->
     -2147483648;
 create_id(OldID) ->
     OldID+1.
 
 create_id() ->
-    {_A,_B,C}=now(),
+    {_A,_B,C}=erlang:timestamp(),
     C.
  
-%%-----------------------------------------------------------%
+%%------------------------------------------------------------
 %% function : type_check
 %% Arguments: Obj  - objectrefernce to test.
 %%            Mod  - Module which contains typeID/0.
diff --git a/lib/cosNotification/src/CosNotification_Definitions.hrl b/lib/cosNotification/src/CosNotification_Definitions.hrl
index 8325b5aa5e..5db081ec2e 100644
--- a/lib/cosNotification/src/CosNotification_Definitions.hrl
+++ b/lib/cosNotification/src/CosNotification_Definitions.hrl
@@ -2,7 +2,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1999-2010. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -315,7 +315,9 @@
 			       {tty, false},
 			       {logfile, false},
 			       {server_options, []}]).
--define(not_CreateDBKey, term_to_binary({now(), node()})).
+-define(not_CreateDBKey, term_to_binary({{erlang:system_time(), 
+					  erlang:unique_integer()}, 
+					node()})).
 
 -define(DEBUG_LEVEL, 3).
 
diff --git a/lib/cosNotification/src/PullerSupplier_impl.erl b/lib/cosNotification/src/PullerSupplier_impl.erl
index 9f12f9c742..22e8355f3a 100644
--- a/lib/cosNotification/src/PullerSupplier_impl.erl
+++ b/lib/cosNotification/src/PullerSupplier_impl.erl
@@ -2,7 +2,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2009. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -887,7 +887,7 @@ callAny(_OE_THIS, OE_FROM, State, EventIn, Status) ->
 %% Start timers which send a message each time we should push events. Only used
 %% when this objects is defined to supply sequences.
 start_timer(State) ->
-    TS = now(),
+    TS = erlang:timestamp(),
     case catch timer:send_after(timer:seconds(?get_PacingInterval(State)), 
 				{pacing, TS}) of
 	{ok,PacTRef} ->
diff --git a/lib/cosNotification/src/cosNotification.app.src b/lib/cosNotification/src/cosNotification.app.src
index ad02eb4421..09bf8f01fc 100644
--- a/lib/cosNotification/src/cosNotification.app.src
+++ b/lib/cosNotification/src/cosNotification.app.src
@@ -117,6 +117,6 @@
   {applications, [orber, stdlib, kernel]},
   {env, []},
   {mod, {cosNotificationApp, []}},
-  {runtime_dependencies, ["stdlib-2.0","orber-3.6.27","kernel-3.0","erts-6.0",
+  {runtime_dependencies, ["stdlib-2.0","orber-3.6.27","kernel-3.0","erts-7.0",
 			  "cosTime-1.1.14","cosEvent-2.1.15"]}
 ]}.
diff --git a/lib/cosNotification/src/cosNotificationApp.erl b/lib/cosNotification/src/cosNotificationApp.erl
index ba44163272..251779c558 100644
--- a/lib/cosNotification/src/cosNotificationApp.erl
+++ b/lib/cosNotification/src/cosNotificationApp.erl
@@ -2,7 +2,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2009. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -221,7 +221,7 @@ start_global_factory() ->
     
 start_global_factory(Args) when is_list(Args) ->
     SO = 'CosNotification_Common':get_option(server_options, Args, ?not_DEFAULT_SETTINGS),
-    Name = create_name(),
+    Name = 'CosNotification_Common':create_name(),
     SPEC = ['CosNotifyChannelAdmin_EventChannelFactory',Args,
 	    [{sup_child, true}, 
 	     {regname, {global, Name}}|SO]],
@@ -432,16 +432,4 @@ init(app_init) ->
 	    'CosNotifyChannelAdmin_EventChannel_impl']}]}}.
 
 
-
-%%------------------------------------------------------------
-%% function : create_name
-%% Arguments: 
-%% Returns  : 
-%% Effect   : Create a unique name to use when, for eaxmple, starting
-%%            a new server.
-%%------------------------------------------------------------
-create_name() ->
-    {MSec, Sec, USec} = erlang:now(),
-    lists:concat(['oe_',node(),'_',MSec, '_', Sec, '_', USec]).
-
 %%--------------- END OF MODULE ------------------------------
diff --git a/lib/cosNotification/src/cosNotification_eventDB.erl b/lib/cosNotification/src/cosNotification_eventDB.erl
index 89332d53f2..f8e2384d15 100644
--- a/lib/cosNotification/src/cosNotification_eventDB.erl
+++ b/lib/cosNotification/src/cosNotification_eventDB.erl
@@ -2,7 +2,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2000-2009. All Rights Reserved.
+%% Copyright Ericsson AB 2000-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -71,10 +71,8 @@
 %%   that the first and last Key change place. {K1,K2}<->{K2,K1} and 
 %%   {K1,K2,K3}<->{K3,K2,K1}.
 %%----------------------------------------------------------------------
-
 -module(cosNotification_eventDB).
 
-
 %%--------------- INCLUDES -----------------------------------
 -include_lib("orber/include/corba.hrl").
 -include_lib("orber/include/ifr_types.hrl").
@@ -221,16 +219,16 @@ gc_events(DBRef, _Priority) when ?is_TimeoutNotUsed(DBRef) ->
 gc_events(DBRef, _Priority) when ?is_StopTNotSupported(DBRef) ->
     ok;
 gc_events(DBRef, Priority) ->
-    {M,S,U} = now(),
+    TS = erlang:monotonic_time(),
+    {resolution, TR} = lists:keyfind(resolution, 1, erlang:system_info(os_monotonic_time_source)),
     case get(oe_GC_timestamp) of
-	Num when {M,S,U} > Num ->
-	    put(oe_GC_timestamp, {M,S+?get_GCTime(DBRef),U}),
+	Num when TS > Num ->
+	    put(oe_GC_timestamp, TS + ?get_GCTime(DBRef) * TR),
 	    spawn_link(?MODULE, gc_start, [DBRef, Priority]);
 	_->
 	    ok
     end.
 
-
 %%------------------------------------------------------------
 %% function : gc_start
 %% Arguments: 
@@ -266,13 +264,13 @@ gc_discard_DB({Key1, Key2, Key3}, DRef) ->
 %% Returns  : 
 %%------------------------------------------------------------
 create_FIFO_Key() ->
-    {M, S, U} = erlang:now(),
+    {M, S, U} = erlang:timestamp(), 
     -M*1000000000000 - S*1000000 - U.
 
 %%------------------------------------------------------------
 %% function : convert_FIFO_Key
 %% Arguments: 
-%% Returns  : A now tuple
+%% Returns  : A timestamp tuple
 %% Comment  : Used when we must reuse a timestamp, i.e., only
 %%            when we must reorder the DB.
 %%------------------------------------------------------------
@@ -322,7 +320,7 @@ extract_start_time(#'CosNotification_StructuredEvent'
 	     _ ->
 		 false
 	 end,
-    convert_time(ST, TRef, now());
+    convert_time(ST, TRef, erlang:timestamp());
 extract_start_time(_, _, _) ->
     false.
 
@@ -337,12 +335,12 @@ extract_start_time(_, _, _) ->
 %%             - undefined eq. value needed but no filter associated.
 %%            Now - used when we want to reuse old TimeStamp which
 %%                  must be done when changing QoS.
-%% Returns  : A modified return from now().
+%% Returns  : A modified return from erlang:timestamp().
 %%------------------------------------------------------------
 extract_deadline(_, _, _, _, false) ->
     false;
 extract_deadline(Event, DefaultT, StopTSupported, TRef, MappingVal) ->
-    extract_deadline(Event, DefaultT, StopTSupported, TRef, MappingVal, now()).
+    extract_deadline(Event, DefaultT, StopTSupported, TRef, MappingVal, erlang:timestamp()).
 
 extract_deadline(_, _, _, _, false, _) ->
     false;
@@ -403,14 +401,14 @@ get_time_diff(UTC, TRef) ->
     UB-LB.
 
 check_deadline(DL) when is_tuple(DL) ->
-    {M,S,U}  = now(),
+    {M,S,U}  = erlang:timestamp(),
     DL >= {-M,-S,-U};
 check_deadline(_DL) ->
     %% This case will cover if no timeout is set.
     false.
 
 check_start_time(ST) when is_tuple(ST) ->
-    {M,S,U}  = now(),
+    {M,S,U}  = erlang:timestamp(),
     ST >= {-M,-S,-U};
 check_start_time(_ST) ->
     %% This case will cover if no earliest delivery time is set.
@@ -1139,8 +1137,10 @@ create_db(QoS, GCTime, GCLimit, TimeRef) ->
 	?is_TimeoutNotUsed(DBRef), ?is_StopTNotSupported(DBRef) ->	
 	    ok;
 	true ->
-	    {M,S,U} = now(),
-	    put(oe_GC_timestamp, {M,S+GCTime,U})
+	    TS = erlang:monotonic_time(),
+	    {resolution, TR} = lists:keyfind(resolution, 1, 
+					     erlang:system_info(os_monotonic_time_source)),
+	    put(oe_GC_timestamp, TS+GCTime*TR)
     end,
     DBRef.
 
diff --git a/lib/cosNotification/test/notify_test_impl.erl b/lib/cosNotification/test/notify_test_impl.erl
index dae7777089..4fe246ef16 100644
--- a/lib/cosNotification/test/notify_test_impl.erl
+++ b/lib/cosNotification/test/notify_test_impl.erl
@@ -289,10 +289,10 @@ disconnect_pull_supplier(_Self, State) ->
 %%--------------- LOCAL FUNCTIONS ----------------------------
 
 delay(Obj, Event, Time, Mod, F) ->
-    io:format("notify_test:delay(~p)  TIME: ~p~n",[Event, now()]),
+    io:format("notify_test:delay(~p)  TIME: ~p~n",[Event, erlang:timestamp()]),
     timer:sleep(Time),
     Mod:F(Obj, Event),
-    io:format("notify_test:delay() DONE: ~p~n",[now()]),
+    io:format("notify_test:delay() DONE: ~p~n",[erlang:timestamp()]),
     ok.
 
 %%--------------- END OF MODULE ------------------------------
diff --git a/lib/cosNotification/vsn.mk b/lib/cosNotification/vsn.mk
index 28d6ec71bf..c1affdf0de 100644
--- a/lib/cosNotification/vsn.mk
+++ b/lib/cosNotification/vsn.mk
@@ -1,2 +1,2 @@
-COSNOTIFICATION_VSN = 1.1.21
+COSNOTIFICATION_VSN = 1.2