diff options
| author | Hans Nilsson <[email protected]> | 2018-12-03 10:21:09 +0100 |
|---|---|---|
| committer | Hans Nilsson <[email protected]> | 2018-12-03 10:21:09 +0100 |
| commit | a86d641607b7b5ba0be455725b33ded0a5470509 (patch) | |
| tree | 53131053c356619d29cc919c9b9ef73bd2735dcc /lib/crypto/test | |
| parent | d5632bfb023ac2c0ae25783f7eae3b060164de0b (diff) | |
| parent | a277535507728c760210f9c5aaf0ba1ce9971ce4 (diff) | |
| download | otp-a86d641607b7b5ba0be455725b33ded0a5470509.tar.gz otp-a86d641607b7b5ba0be455725b33ded0a5470509.tar.bz2 otp-a86d641607b7b5ba0be455725b33ded0a5470509.zip | |
Merge branch 'hans/crypto/valgrind-warnings/OTP-15467' into maint
* hans/crypto/valgrind-warnings/OTP-15467:
crypto: Engine valgrind fix
crypto: Fix valgrind error in dh_generate/dh_compute
crypto: Fix valgrind errors in pkey_crypt_nif
crypto: Add some crypto:engine_unload in engine test suite
crypto: Fix valgrind errors in privkey_to_pubkey
crypto: Fix valgrind error for keys with passwords in Engines
Diffstat (limited to 'lib/crypto/test')
| -rw-r--r-- | lib/crypto/test/engine_SUITE.erl | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/lib/crypto/test/engine_SUITE.erl b/lib/crypto/test/engine_SUITE.erl index 42d8edf4d2..8a45fc9076 100644 --- a/lib/crypto/test/engine_SUITE.erl +++ b/lib/crypto/test/engine_SUITE.erl @@ -587,11 +587,11 @@ ctrl_cmd_string(Config) when is_list(Config) -> {ok, E} -> case crypto:engine_ctrl_cmd_string(E, <<"TEST">>, <<"17">>) of ok -> + ok = crypto:engine_unload(E), ct:fail(fail_ctrl_cmd_should_fail); {error,ctrl_cmd_failed} -> - ok - end, - ok = crypto:engine_unload(E); + ok = crypto:engine_unload(E) + end; {error, bad_engine_id} -> {skip, "Dynamic Engine not supported"} end @@ -617,11 +617,12 @@ ctrl_cmd_string_optional(Config) when is_list(Config) -> {ok, E} -> case crypto:engine_ctrl_cmd_string(E, <<"TEST">>, <<"17">>, true) of ok -> - ok; - _ -> + ok = crypto:engine_unload(E); + Err -> + ct:log("Error: ~p",[Err]), + ok = crypto:engine_unload(E), ct:fail(fail_ctrl_cmd_string) - end, - ok = crypto:engine_unload(E); + end; {error, bad_engine_id} -> {skip, "Dynamic Engine not supported"} end |