dialyzer_typesig: Add map support

11 files changed, 335 insertions, 0 deletions

diff --git a/lib/dialyzer/test/map_SUITE_data/src/bad_argument.erl b/lib/dialyzer/test/map_SUITE_data/src/bad_argument.erl
new file mode 100644
index 0000000000..95e2b32ddc
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/bad_argument.erl
@@ -0,0 +1,19 @@
+-module(bad_argument).
+
+-export([t/0, t2/0, t3/0]).
+
+t() ->
+    _=(id1(#{a=>q}))#{b:=9}.
+
+t2() ->
+    _ = id2(4),
+    X = id2(3),
+    _ = (#{ X => q})#{3 := p},
+    X.
+
+t3() ->
+    (id3(not_a_map))#{a => b}.
+
+id1(X) -> X.
+id2(X) -> X.
+id3(X) -> X.
diff --git a/lib/dialyzer/test/map_SUITE_data/src/contract.erl b/lib/dialyzer/test/map_SUITE_data/src/contract.erl
new file mode 100644
index 0000000000..2b31be0d58
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/contract.erl
@@ -0,0 +1,14 @@
+-module(missing).
+
+-export([t1/0, t2/0, t3/0, t4/0]).
+
+-spec f(#{a := 1, b => 2, c => 3}) -> ok.
+f(_) -> ok.
+
+t1() -> f(#{b => 2}).
+
+t2() -> f(#{a => 1, c => 4}).
+
+t3() -> f(#{a => 1, b => 2, e => 3}).
+
+t4() -> f(#{a => 1, b => 2}).
diff --git a/lib/dialyzer/test/map_SUITE_data/src/is_map_guard.erl b/lib/dialyzer/test/map_SUITE_data/src/is_map_guard.erl
new file mode 100644
index 0000000000..ceb4a8763a
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/is_map_guard.erl
@@ -0,0 +1,17 @@
+-module(is_map_guard).
+
+-export([t1/0, t2/0, implicit/1, explicit/1
+	]).
+
+t1() ->
+    _ = implicit(#{}),
+    implicit(not_a_map).
+
+implicit(M) ->
+    M#{}.
+
+t2() ->
+    explicit(#{q=>d}),
+    explicit(still_not_map).
+
+explicit(M) when is_map(M) -> ok.
diff --git a/lib/dialyzer/test/map_SUITE_data/src/map_in_guard.erl b/lib/dialyzer/test/map_SUITE_data/src/map_in_guard.erl
new file mode 100644
index 0000000000..6176ef1fdf
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/map_in_guard.erl
@@ -0,0 +1,35 @@
+-module(map_in_guard).
+
+-export([test/0, raw_expr/0]).
+
+test() ->
+    false = assoc_guard(#{}),
+    true  = assoc_guard(not_a_map),
+    #{a := true} = assoc_update(#{}),
+    {'EXIT', {{badmap, not_a_map}, [{?MODULE, assoc_update, 1, _}|_]}}
+	= (catch assoc_update(not_a_map)),
+    ok = assoc_guard_clause(#{}),
+    {'EXIT', {function_clause, [{?MODULE, assoc_guard_clause, _, _}|_]}}
+	= (catch assoc_guard_clause(not_a_map)),
+    true = exact_guard(#{a=>1}),
+    {'EXIT', {function_clause, [{?MODULE, assoc_guard_clause, _, _}|_]}}
+    %% There's nothing we can do to find the error here, is there?
+	= (catch (begin true = exact_guard(#{}) end)),
+    ok = exact_guard_clause(#{a => q}),
+    {'EXIT', {function_clause, [{?MODULE, exact_guard_clause, _, _}|_]}}
+	= (catch exact_guard_clause(#{})),
+    ok.
+
+assoc_guard(M) when is_map(M#{a => b}) -> true;
+assoc_guard(Q) -> false.
+
+assoc_update(M) -> M#{a => true}.
+
+assoc_guard_clause(M) when is_map(M#{a => 3}) -> ok.
+
+exact_guard(M) when (false =/= M#{a := b}) -> true;
+exact_guard(_) -> false.
+
+exact_guard_clause(M) when (false =/= M#{a := b}) -> ok.
+
+raw_expr() when #{}; true -> ok. %% Must not warn here!
diff --git a/lib/dialyzer/test/map_SUITE_data/src/map_in_guard2.erl b/lib/dialyzer/test/map_SUITE_data/src/map_in_guard2.erl
new file mode 100644
index 0000000000..ac2205e8fa
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/map_in_guard2.erl
@@ -0,0 +1,27 @@
+-module(map_in_guard2).
+
+-export([test/0]).
+
+test() ->
+    false = assoc_guard(not_a_map),
+    {'EXIT', {{badmap, not_a_map}, [{?MODULE, assoc_update, 1, _}|_]}}
+	= (catch assoc_update(not_a_map)),
+    {'EXIT', {function_clause, [{?MODULE, assoc_guard_clause, _, _}|_]}}
+	= (catch assoc_guard_clause(not_a_map)),
+    {'EXIT', {function_clause, [{?MODULE, assoc_guard_clause, _, _}|_]}}
+	= (catch (begin true = exact_guard(#{}) end)),
+    {'EXIT', {function_clause, [{?MODULE, exact_guard_clause, _, _}|_]}}
+	= (catch exact_guard_clause(#{})),
+    ok.
+
+assoc_guard(M) when is_map(M#{a => b}) -> true;
+assoc_guard(_) -> false.
+
+assoc_update(M) -> M#{a => true}.
+
+assoc_guard_clause(M) when is_map(M#{a => 3}) -> ok.
+
+exact_guard(M) when (false =/= M#{a := b}) -> true;
+exact_guard(_) -> false.
+
+exact_guard_clause(M) when (false =/= M#{a := b}) -> ok.
diff --git a/lib/dialyzer/test/map_SUITE_data/src/map_size.erl b/lib/dialyzer/test/map_SUITE_data/src/map_size.erl
new file mode 100644
index 0000000000..2da4f6904e
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/map_size.erl
@@ -0,0 +1,36 @@
+-module(map_size).
+
+-export([t1/0, e1/0, t2/0, t3/0, t4/0, t5/1, t6/1, t7/1]).
+
+t1() ->
+    0 = maps:size(#{}),
+    1 = maps:size(#{}).
+
+e1() ->
+    0 = map_size(#{}),
+    1 = map_size(#{}).
+
+t2() -> p(#{a=>x}).
+
+p(M) when map_size(M) =:= 0 -> ok.
+
+t3() ->
+    1 = map_size(cio()),
+    2 = map_size(cio()),
+    3 = map_size(cio()),
+    4 = map_size(cio()).
+
+t4() ->
+    0 = map_size(cio()).
+
+t5(M) when map_size(M) =:= 0 ->
+    #{a := _} = M. %% Only t5 has no local return; want better message
+
+t6(M) when map_size(M) =:= 0 ->
+    #{} = M.
+
+t7(M=#{a := _}) when map_size(M) =:= 1 ->
+    #{b := _} = M. %% We should warn here too
+
+-spec cio() -> #{3 := ok, 9 => _, 11 => x}.
+cio() -> binary_to_term(<<131,116,0,0,0,2,97,3,100,0,2,111,107,97,9,97,6>>).
diff --git a/lib/dialyzer/test/map_SUITE_data/src/order.erl b/lib/dialyzer/test/map_SUITE_data/src/order.erl
new file mode 100644
index 0000000000..51868d7e94
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/order.erl
@@ -0,0 +1,56 @@
+-module(order).
+
+-export([t1/0, t2/0, t3/0, t4/0, t5/0, t6/0]).
+
+t1() ->
+    case maps:get(a, #{a=>1, a=>b}) of
+	Int when is_integer(Int) -> fail;
+	Atom when is_atom(Atom) -> error(ok);
+	_Else -> fail
+    end.
+
+t2() ->
+    case maps:get(a, #{a=>id_1(1), a=>id_b(b)}) of
+	Int when is_integer(Int) -> fail;
+	Atom when is_atom(Atom) -> error(ok);
+	_Else -> fail
+    end.
+
+t3() ->
+    case maps:get(a, #{a=>id_1(1), id_a(a)=>id_b(b)}) of
+	Int when is_integer(Int) -> fail;
+	Atom when is_atom(Atom) -> error(ok);
+	_Else -> fail
+    end.
+
+t4() ->
+    case maps:get(a, #{a=>id_1(1), a_or_b()=>id_b(b)}) of
+	Int when is_integer(Int) -> ok;
+	Atom when is_atom(Atom) -> ok;
+	_Else -> fail
+    end.
+
+t5() ->
+    case maps:get(c, #{c=>id_1(1), a_or_b()=>id_b(b)}) of
+	Int when is_integer(Int) -> error(ok);
+	Atom when is_atom(Atom) -> fail;
+	_Else -> fail
+    end.
+
+t6() ->
+    case maps:get(a, #{a_or_b()=>id_1(1), id_a(a)=>id_b(b)}) of
+	Int when is_integer(Int) -> fail;
+	Atom when is_atom(Atom) -> error(ok);
+	_Else -> fail
+    end.
+
+id_1(X) -> X.
+
+id_a(X) -> X.
+
+id_b(X) -> X.
+
+any() -> binary_to_term(<<>>).
+
+-spec a_or_b() -> a | b.
+a_or_b() -> any().
diff --git a/lib/dialyzer/test/map_SUITE_data/src/subtract_value_flip.erl b/lib/dialyzer/test/map_SUITE_data/src/subtract_value_flip.erl
new file mode 100644
index 0000000000..97e6b54e3c
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/subtract_value_flip.erl
@@ -0,0 +1,9 @@
+-module(subtract_value_flip).
+
+-export([t1/1]).
+
+t1(#{type := _Smth} = Map) ->
+    case Map of
+	#{type := a} -> ok;
+	#{type := b} -> error
+    end.
diff --git a/lib/dialyzer/test/map_SUITE_data/src/typeflow.erl b/lib/dialyzer/test/map_SUITE_data/src/typeflow.erl
new file mode 100644
index 0000000000..b43fd6897b
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/typeflow.erl
@@ -0,0 +1,25 @@
+-module(typeflow).
+
+-export([t1/1, t2/1, t3/1, t4/1]).
+
+t1(M = #{}) ->
+    a_is_integer(M),
+    case M of
+	#{a := X} when is_integer(X) -> ok;
+	_ -> fail
+    end.
+
+a_is_integer(#{a := X}) when is_integer(X) -> ok.
+
+t2(M = #{}) ->
+    a_is_integer(M),
+    lists:sort(maps:get(a, M)),
+    ok.
+
+t3(M = #{}) ->
+    lists:sort(maps:get(a, M)),
+    ok.
+
+t4(M) ->
+    lists:sort(maps:get(a, M)),
+    ok.
diff --git a/lib/dialyzer/test/map_SUITE_data/src/typeflow2.erl b/lib/dialyzer/test/map_SUITE_data/src/typeflow2.erl
new file mode 100644
index 0000000000..71a9657a60
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/typeflow2.erl
@@ -0,0 +1,88 @@
+-module(typeflow2).
+
+-export([t1/1, t2/1, t3/1, t4/1, t5/1, t6/1, t7/1, optional3/1]).
+
+t1(L) ->
+    M = only_integers_and_lists(L),
+    optional(M),
+    case M of
+	#{a := X} when is_integer(X) -> ok;
+	#{a := X} when is_list(X) -> ok; %% Must warn here
+	#{a := X} when is_pid(X) -> ok;
+	_ -> fail
+    end.
+
+optional(#{a:=X}) ->
+    true = is_integer(X);
+optional(#{}) ->
+    true.
+
+only_integers_and_lists(L) -> only_integers_and_lists(L, #{}).
+
+only_integers_and_lists([], M) -> M;
+only_integers_and_lists([{K,V}|T], M) when is_integer(V); is_list(V)->
+    only_integers_and_lists(T, M#{K => V}).
+
+t2(L) ->
+    M = only_integers_and_lists(L),
+    optional(M),
+    lists:sort(maps:get(a, M)),
+    ok.
+
+t3(L) ->
+    M = only_integers_and_lists(L),
+    lists:sort(maps:get(a, M)),
+    ok.
+
+t4(V) ->
+    M=map_with(a,V),
+    optional2(M),
+    case M of
+	#{a := X} when is_integer(X) -> ok;
+	#{a := X} when is_list(X) -> ok; %% Must warn here
+	_ -> fail
+    end.
+
+optional2(#{a:=X}) ->
+    true = is_integer(X);
+optional2(#{}) ->
+    true.
+
+map_with(K, V) when is_integer(V); is_list(V); is_atom(V) -> #{K => V}.
+
+t5(L) ->
+    M = only_integers_and_lists(L),
+    optional3(M),
+    case M of
+	#{a := X} when is_integer(X) -> ok;
+	#{a := X} when is_list(X) -> ok; %% Must warn here
+	#{a := X} when is_pid(X) -> ok; %% Must warn here
+	#{a := X} when is_atom(X) -> ok;
+	_ -> fail
+    end.
+
+t6(L) ->
+    M = only_integers_and_lists(L),
+    case M of
+	#{a := X} when is_integer(X) -> ok;
+	#{a := X} when is_list(X) -> ok; %% Must not warn here
+	_ -> fail
+    end.
+
+optional3(#{a:=X}) ->
+    true = is_integer(X);
+optional3(#{}) ->
+    true.
+
+t7(M) ->
+    optional4(M),
+    case M of
+	#{a := X} when is_integer(X) -> ok;
+	#{a := X} when is_list(X) -> ok;
+	#{a := X} when is_pid(X) -> ok; %% Must warn here
+	#{a := X} when is_atom(X) -> ok; %% Must warn here
+	_ -> fail %% Must not warn here (requires parsing)
+    end.
+
+-spec optional4(#{a=>integer()|list()}) -> true.
+optional4(#{}) -> true.
diff --git a/lib/dialyzer/test/map_SUITE_data/src/typesig.erl b/lib/dialyzer/test/map_SUITE_data/src/typesig.erl
new file mode 100644
index 0000000000..b50511af41
--- /dev/null
+++ b/lib/dialyzer/test/map_SUITE_data/src/typesig.erl
@@ -0,0 +1,9 @@
+-module(typesig).
+
+-export([t1/0, t2/0, t3/0, test/1]).
+
+t1() -> test(#{a=>1}).
+t2() -> test(#{a=>{b}}).
+t3() -> test(#{a=>{3}}).
+
+test(#{a:={X}}) -> X+1.