diff options
| author | Hans Bolinder <[email protected]> | 2019-04-29 16:13:37 +0200 |
|---|---|---|
| committer | Hans Bolinder <[email protected]> | 2019-05-03 12:17:02 +0200 |
| commit | 60e47cba35ff565a33b25ecb01e96881ab7fe0da (patch) | |
| tree | 511707cede18a65f93dd4d3d852de4da7b97c1e3 /lib/dialyzer | |
| parent | e4c8e5a7997205ccc371415ae5c1caf544b025c6 (diff) | |
| download | otp-60e47cba35ff565a33b25ecb01e96881ab7fe0da.tar.gz otp-60e47cba35ff565a33b25ecb01e96881ab7fe0da.tar.bz2 otp-60e47cba35ff565a33b25ecb01e96881ab7fe0da.zip | |
stdlib: Do not allow specs for functions in other modules
See also https://bugs.erlang.org/browse/ERL-845.
[Kostis:]
My suggestion is that the compiler refuses to compile modules that
contain specs for functions that are not from this module. I do not
remember when / why this `feature' was introduced, but thinking about
it I see a lot of (ugly) semantics issues with it. For example, should
one be allowed to declare in the foo module that lists:flatten/1 takes
an integer() as an argument and returns a binary()? Should one be
allowed to declare a spec in some module m1 for a function of m2 that
is not defined in m2?
There are all kinds of checks that will need to be added to dialyzer
to protect itself from these semantics issues. The compiler already
refuses to compile modules that contain specs for non-existing
functions of the module. Similarly, it should refuse to compile
modules that contain specs for functions of other modules - unless it
can somehow check that these functions are indeed defined, but it is
not how the compiler currently works.
Diffstat (limited to 'lib/dialyzer')
| -rw-r--r-- | lib/dialyzer/test/small_SUITE_data/results/spec_other_module | 2 | ||||
| -rw-r--r-- | lib/dialyzer/test/small_SUITE_data/src/spec_other_module.erl | 7 |
2 files changed, 0 insertions, 9 deletions
diff --git a/lib/dialyzer/test/small_SUITE_data/results/spec_other_module b/lib/dialyzer/test/small_SUITE_data/results/spec_other_module deleted file mode 100644 index ab2e35cf55..0000000000 --- a/lib/dialyzer/test/small_SUITE_data/results/spec_other_module +++ /dev/null @@ -1,2 +0,0 @@ - -spec_other_module.erl:7: Contract for function that does not exist: lists:flatten/1 diff --git a/lib/dialyzer/test/small_SUITE_data/src/spec_other_module.erl b/lib/dialyzer/test/small_SUITE_data/src/spec_other_module.erl deleted file mode 100644 index b36742b1bd..0000000000 --- a/lib/dialyzer/test/small_SUITE_data/src/spec_other_module.erl +++ /dev/null @@ -1,7 +0,0 @@ --module(spec_other_module). - -%% OTP-15562 and ERL-845. Example provided by Kostis. - --type deep_list(A) :: [A | deep_list(A)]. - --spec lists:flatten(deep_list(A)) -> [A]. |