aboutsummaryrefslogtreecommitdiffstats
path: root/lib/diameter/include/diameter_gen.hrl
diff options
context:
space:
mode:
authorAnders Svensson <[email protected]>2014-05-22 11:01:45 +0200
committerAnders Svensson <[email protected]>2014-05-26 13:52:04 +0200
commit0058430352420a8c0dc053900f108e7086f52fad (patch)
tree544c700d2d3b6fb467b766e4aa81a39ca71af5d2 /lib/diameter/include/diameter_gen.hrl
parent6202139d7680be7df2fc5a6d6138409c1ae780d6 (diff)
downloadotp-0058430352420a8c0dc053900f108e7086f52fad.tar.gz
otp-0058430352420a8c0dc053900f108e7086f52fad.tar.bz2
otp-0058430352420a8c0dc053900f108e7086f52fad.zip
Replace traffic-related log reports with no-op function calls
The former were a little over-enthusiastic and could cause a node to be logged to death if a peer Diameter node was sufficiently ill-willed. The function calls are to diameter_lib:log/4, the arguments of which identify the happening in question, and which does nothing but provide a function to trace on. Many existing log calls have been shrunk. The only remaining traffic-related report (hopefully) is that resulting from {answer_errors, report} config, and this has been slimmed.
Diffstat (limited to 'lib/diameter/include/diameter_gen.hrl')
-rw-r--r--lib/diameter/include/diameter_gen.hrl6
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/diameter/include/diameter_gen.hrl b/lib/diameter/include/diameter_gen.hrl
index c8f706dc3e..319ad5a783 100644
--- a/lib/diameter/include/diameter_gen.hrl
+++ b/lib/diameter/include/diameter_gen.hrl
@@ -320,10 +320,12 @@ d(Name, Avp, {Avps, Acc}) ->
%% respond sensibly to. Log the occurence for traceability,
%% but the peer will also receive info in the resulting
%% answer-message.
- diameter_lib:log({decode, failure},
+ Stack = diameter_lib:get_stacktrace(),
+ diameter_lib:log(decode_error,
?MODULE,
?LINE,
- {Reason, Avp, erlang:get_stacktrace()}),
+ {Reason, AvpName, Stack}),
+
{Rec, Failed} = Acc,
{[Avp|Avps], {Rec, [rc(Reason, Avp) | Failed]}}
after