aboutsummaryrefslogtreecommitdiffstats
path: root/lib/diameter/src/base/diameter_traffic.erl
diff options
context:
space:
mode:
authorAnders Svensson <[email protected]>2014-08-05 12:28:04 +0200
committerAnders Svensson <[email protected]>2014-08-05 16:32:52 +0200
commite2d4c35bb9ac11b5039514276f73dce4d2332100 (patch)
tree0d4eadb1280e9a0bb95499a62ead647dda9962a8 /lib/diameter/src/base/diameter_traffic.erl
parent461dc05384eece7b4b7d84370fb0a2cf96ed2f6d (diff)
downloadotp-e2d4c35bb9ac11b5039514276f73dce4d2332100.tar.gz
otp-e2d4c35bb9ac11b5039514276f73dce4d2332100.tar.bz2
otp-e2d4c35bb9ac11b5039514276f73dce4d2332100.zip
Fix counting of outgoing requests
Commit df19c272 broke this in avoiding counting on arbitrary keys. It didn't break it sufficiently for the only counters usage in the test suites to fail however: watchdog counters worked as intended, but no others, not even CER and DPR. More testcases are needed. This commit does change/fix the previous semantics somewhat: - Retransmissions are no longer counted. This previously made it impossible to distinguish between these and unanswered requests, since both counted as an outgoing request. There should probably be a retransmission counter but it should be distinct from the sent request counter. - The counting is always on the node from which diameter:call/4 is invoked, not the node on which the transport resides, as was previously the case. (Although they're typically one and the same.) Note that none of these semantics are documented as yet, so we're not changing a documented interface.
Diffstat (limited to 'lib/diameter/src/base/diameter_traffic.erl')
-rw-r--r--lib/diameter/src/base/diameter_traffic.erl1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/diameter/src/base/diameter_traffic.erl b/lib/diameter/src/base/diameter_traffic.erl
index 5fac61f416..937d08dc4f 100644
--- a/lib/diameter/src/base/diameter_traffic.erl
+++ b/lib/diameter/src/base/diameter_traffic.erl
@@ -1396,6 +1396,7 @@ send_R(Pkt0,
packet = Pkt0},
try
+ incr(send, Pkt, TPid, Dict),
TRef = send_request(TPid, Pkt, Req, SvcName, Timeout),
Pid ! Ref, %% tell caller a send has been attempted
handle_answer(SvcName,