diff options
| author | Anders Svensson <[email protected]> | 2013-11-29 18:44:41 +0100 |
|---|---|---|
| committer | Anders Svensson <[email protected]> | 2013-11-29 18:44:41 +0100 |
| commit | abea7186dd2590a0283396e94cf03dfb087277e5 (patch) | |
| tree | 0b7c7cba00cb558c4d2b8230ee5c7ac0d16067a6 /lib/diameter/src/base/diameter_watchdog.erl | |
| parent | 20641fe0f2ea745873fc7557448d3a7deb1bd639 (diff) | |
| download | otp-abea7186dd2590a0283396e94cf03dfb087277e5.tar.gz otp-abea7186dd2590a0283396e94cf03dfb087277e5.tar.bz2 otp-abea7186dd2590a0283396e94cf03dfb087277e5.zip | |
Rename reconnect_timer -> connect_timer
The former was misleading since the timer only applies to initial
connection attempts, reconnection attempts being governed by
watchdog_timer. The name is a historic remnant from a (dark, pre-OTP)
time in which RFC 3539 was followed less slavishly than it is now, and
the timer actually did apply to reconnection attempts.
Note that connect_timer corresponds to RFC 6733 Tc, while watchdog_timer
corresponds to RFC 3539 TwInit. The latter RFC makes clear that TwInit
should apply to reconnection attempts. It's less clear if only RFC 6733
is read.
Note also that reconnect_timer is still accepted for backwards
compatibility. It would be possible to add an option to make
reconnect_timer behave strictly as the name suggests (ie. ignore RFC 3539
and interpret RFC 6733 at face value; something that has some value for
testing at least) but no such option is implemented in this commit.
Diffstat (limited to 'lib/diameter/src/base/diameter_watchdog.erl')
| -rw-r--r-- | lib/diameter/src/base/diameter_watchdog.erl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/diameter/src/base/diameter_watchdog.erl b/lib/diameter/src/base/diameter_watchdog.erl index 7e75801718..55d46fadea 100644 --- a/lib/diameter/src/base/diameter_watchdog.erl +++ b/lib/diameter/src/base/diameter_watchdog.erl @@ -329,7 +329,7 @@ code_change(_, State, _) -> %% the commentary is ours. %% Service or watchdog is telling the watchdog of an accepting -%% transport to die after reconnect_timer expiry or reestablished +%% transport to die after connect_timer expiry or reestablished %% connection (in another transport process) respectively. transition(close, #watchdog{status = down}) -> {{accept, _}, _, _} = getr(restart), %% assert |