Merge branch 'anders/diameter/18/OTP-12588'

* anders/diameter/18/OTP-12588:
  vsn -> 1.10
  Remove dead upgrade-related code
  Update appup for 18
  Fix release note typo
  Fix comment typo

4 files changed, 17 insertions, 115 deletions

diff --git a/lib/diameter/src/base/diameter_peer_fsm.erl b/lib/diameter/src/base/diameter_peer_fsm.erl
index 2255d0a76b..6547ad204b 100644
--- a/lib/diameter/src/base/diameter_peer_fsm.erl
+++ b/lib/diameter/src/base/diameter_peer_fsm.erl
@@ -119,7 +119,6 @@
          service      :: #diameter_service{},
          dpr = false  :: false
                        | true  %% DPR received, DPA sent
-                       | {uint32(), uint32()}  %% set in old code
                        | {boolean(), uint32(), uint32()},
                        %% hop by hop and end to end identifiers in
                        %% outgoing DPR; boolean says whether or not
@@ -155,8 +154,7 @@
 %% # start/3
 %% ---------------------------------------------------------------------------
 
--spec start(T, [Opt], {[diameter:service_opt()]
-                       | diameter:sequence(),  %% from old code
+-spec start(T, [Opt], {[diameter:service_opt()],
                        [node()],
                        module(),
                        #diameter_service{}})
@@ -195,9 +193,6 @@ init(T) ->
     proc_lib:init_ack({ok, self()}),
     gen_server:enter_loop(?MODULE, [], i(T)).
 
-i({Ack, WPid, T, Opts, {{_,_} = Mask, Nodes, Dict0, Svc}}) -> %% from old code
-    i({Ack, WPid, T, Opts, {[{sequence, Mask}], Nodes, Dict0, Svc}});
-
 i({Ack, WPid, {M, Ref} = T, Opts, {SvcOpts, Nodes, Dict0, Svc}}) ->
     erlang:monitor(process, WPid),
     wait(Ack, WPid),
@@ -329,14 +324,11 @@ handle_info(T, #state{} = State) ->
         {?MODULE, Tag, Reason}  ->
             ?LOG(stop, Tag),
             {stop, {shutdown, Reason}, State}
-    end;
+    end.
 %% The form of the throw caught here is historical. It's
 %% significant that it's not a 2-tuple, as in ?FAILURE(Reason),
 %% since these are caught elsewhere.
 
-handle_info(T, S) ->  %% started in old code
-    handle_info(T, #state{} = erlang:append_element(S, infinity)).
-
 %% Note that there's no guarantee that the service and transport
 %% capabilities are good enough to build a CER/CEA that can be
 %% succesfully encoded. It's not checked at diameter:add_transport/2
@@ -366,9 +358,6 @@ eraser(Key) ->
 
 %% transition/2
 
-transition(T, #state{dpr = {Hid, Eid}} = S) -> %% DPR sent from old code
-    transition(T, S#state{dpr = {false, Hid, Eid}});
-
 %% Connection to peer.
 transition({diameter, {TPid, connected, Remote}},
            #state{transport = TPid,
@@ -1296,25 +1285,15 @@ dpa_timer(Tmo) ->
     erlang:send_after(Tmo, self(), dpa_timeout).
 
 dpa_timeout() ->
-    dpa_timeout(getr(?DPA_KEY)).
-
-dpa_timeout({_, Tmo}) ->
-    Tmo;
-dpa_timeout(undefined) ->  %% set in old code
-    ?DPA_TIMEOUT;
-dpa_timeout(Tmo) ->        %% ditto
+    {_, Tmo} = getr(?DPA_KEY),
     Tmo.
 
 dpr_timer() ->
     dpa_timer(dpr_timeout()).
 
 dpr_timeout() ->
-    dpr_timeout(getr(?DPA_KEY)).
-
-dpr_timeout({Tmo, _}) ->
-    Tmo;
-dpr_timeout(_) ->  %% set in old code
-    ?DPR_TIMEOUT.
+    {Tmo, _} = getr(?DPA_KEY),
+    Tmo.
 
 %% register_everywhere/1
 %%
diff --git a/lib/diameter/src/base/diameter_traffic.erl b/lib/diameter/src/base/diameter_traffic.erl
index 230a05fa11..7fdc3fc4fb 100644
--- a/lib/diameter/src/base/diameter_traffic.erl
+++ b/lib/diameter/src/base/diameter_traffic.erl
@@ -97,9 +97,6 @@
 %% # make_recvdata/1
 %% ---------------------------------------------------------------------------
 
-make_recvdata([SvcName, PeerT, Apps, {_,_} = Mask | _]) ->  %% from old code
-    make_recvdata([SvcName, PeerT, Apps, [{sequence, Mask}]]);
-
 make_recvdata([SvcName, PeerT, Apps, SvcOpts | _]) ->
     {_,_} = Mask = proplists:get_value(sequence, SvcOpts),
     #recvdata{service_name = SvcName,
@@ -301,13 +298,7 @@ recv_request(TPid,
                   RecvData),
            TPid,
            Dict0,
-           RecvData);
-
-recv_request(TPid, Pkt, Dict0, RecvData) -> %% from old code
-    recv_request(TPid,
-                 Pkt,
-                 Dict0,
-                 #recvdata{} = erlang:append_element(RecvData, [])).
+           RecvData).
 
 %% recv_R/5
 
@@ -1642,9 +1633,6 @@ pick_peer(SvcName,
                                      Filter,
                                      Xtra})).
 
-pick({{_,_,_} = Transport, Mask}) ->  %% from old code; dialyzer complains
-    {Transport, Mask, []};            %% about this
-
 pick(false) ->
     {error, no_connection};
 
diff --git a/lib/diameter/src/base/diameter_watchdog.erl b/lib/diameter/src/base/diameter_watchdog.erl
index de9c4bca33..c7b476a569 100644
--- a/lib/diameter/src/base/diameter_watchdog.erl
+++ b/lib/diameter/src/base/diameter_watchdog.erl
@@ -810,9 +810,6 @@ restart(S) ->  %% reconnect has won race with timeout
 %% state down rather then initial when receiving notification of an
 %% open connection.
 
-restart({T, Opts, Svc}, S) ->  %% put in old code
-    restart({T, Opts, Svc, []}, S);
-
 restart({{connect, _} = T, Opts, Svc, SvcOpts},
         #watchdog{parent = Pid,
                   restrict = {R,_},
@@ -827,7 +824,7 @@ restart({{connect, _} = T, Opts, Svc, SvcOpts},
 %% die. Note that a state machine never enters state REOPEN in this
 %% case.
 restart({{accept, _}, _, _, _}, #watchdog{restrict = {_, false}}) ->
-    stop;  %% 'DOWN' was in old code: 'close' was not sent
+    stop;
 
 %% Otherwise hang around until told to die, either by the service or
 %% by another watchdog.
diff --git a/lib/diameter/src/diameter.appup.src b/lib/diameter/src/diameter.appup.src
index b89859ed24..221930a9cc 100644
--- a/lib/diameter/src/diameter.appup.src
+++ b/lib/diameter/src/diameter.appup.src
@@ -37,42 +37,11 @@
   {"1.5",     [{restart_application, diameter}]},  %% R16B03
   {"1.6",     [{restart_application, diameter}]},  %% 17.0
   {"1.7",     [{restart_application, diameter}]},  %% 17.[12]
-  {<<"^1\\.(7\\.1|8)$">>,                          %% 17.[34]
-              [{load_module, diameter_lib},
-               {load_module, diameter_peer},
-               {load_module, diameter_reg},
-               {load_module, diameter_session},
-               {load_module, diameter_stats},
-               {load_module, diameter_sync},
-               {load_module, diameter_capx},
-               {load_module, diameter_codec},
-               {load_module, diameter_types},
-               {load_module, diameter_traffic},
-               {load_module, diameter_service},
-               {load_module, diameter_peer_fsm},
-               {load_module, diameter_watchdog},
-               {load_module, diameter_tcp},
-               {load_module, diameter_sctp},
-               {load_module, diameter_config},
-               {load_module, diameter},
-               {load_module, diameter_gen_base_rfc6733},
-               {load_module, diameter_gen_acct_rfc6733},
-               {load_module, diameter_gen_base_rfc3588},
-               {load_module, diameter_gen_base_accounting},
-               {load_module, diameter_gen_relay},
-               {update, diameter_transport_sup, supervisor},
-               {update, diameter_service_sup, supervisor},
-               {update, diameter_sup, supervisor}]},
-  {"1.9",     [{load_module, diameter_codec},      %% 17.5
-               {load_module, diameter_traffic},
-               {load_module, diameter_sctp},
-               {load_module, diameter_gen_base_rfc6733},
-               {load_module, diameter_gen_acct_rfc6733},
-               {load_module, diameter_gen_base_rfc3588},
-               {load_module, diameter_gen_base_accounting},
-               {load_module, diameter_gen_relay}]},
-  {"1.9.1",   [{load_module, diameter_traffic},    %% 17.5.3
-               {load_module, diameter_sctp}]}
+  {"1.7.1",   [{restart_application, diameter}]},  %% 17.3
+  {"1.8",     [{restart_application, diameter}]},  %% 17.4
+  {"1.9",     [{restart_application, diameter}]},  %% 17.5
+  {"1.9.1",   [{restart_application, diameter}]},  %% 17.5.3
+  {"1.9.2",   [{restart_application, diameter}]}   %% 17.5.5
  ],
  [
   {"0.9",     [{restart_application, diameter}]},
@@ -92,41 +61,10 @@
   {"1.5",     [{restart_application, diameter}]},
   {"1.6",     [{restart_application, diameter}]},
   {"1.7",     [{restart_application, diameter}]},
-  {<<"^1\\.(7\\.1|8)$">>,
-              [{update, diameter_sup, supervisor},
-               {update, diameter_service_sup, supervisor},
-               {update, diameter_transport_sup, supervisor},
-               {load_module, diameter_gen_relay},
-               {load_module, diameter_gen_base_accounting},
-               {load_module, diameter_gen_base_rfc3588},
-               {load_module, diameter_gen_acct_rfc6733},
-               {load_module, diameter_gen_base_rfc6733},
-               {load_module, diameter},
-               {load_module, diameter_config},
-               {load_module, diameter_sctp},
-               {load_module, diameter_tcp},
-               {load_module, diameter_watchdog},
-               {load_module, diameter_peer_fsm},
-               {load_module, diameter_service},
-               {load_module, diameter_traffic},
-               {load_module, diameter_types},
-               {load_module, diameter_codec},
-               {load_module, diameter_capx},
-               {load_module, diameter_sync},
-               {load_module, diameter_stats},
-               {load_module, diameter_session},
-               {load_module, diameter_reg},
-               {load_module, diameter_peer},
-               {load_module, diameter_lib}]},
-  {"1.9",     [{load_module, diameter_gen_relay},
-               {load_module, diameter_gen_base_accounting},
-               {load_module, diameter_gen_base_rfc3588},
-               {load_module, diameter_gen_acct_rfc6733},
-               {load_module, diameter_gen_base_rfc6733},
-               {load_module, diameter_sctp},
-               {load_module, diameter_traffic},
-               {load_module, diameter_codec}]},
-  {"1.9.1",   [{load_module, diameter_sctp},
-               {load_module, diameter_traffic}]}
+  {"1.7.1",   [{restart_application, diameter}]},
+  {"1.8",     [{restart_application, diameter}]},
+  {"1.9",     [{restart_application, diameter}]},
+  {"1.9.1",   [{restart_application, diameter}]},
+  {"1.9.2",   [{restart_application, diameter}]}
  ]
 }.