Merge branch 'anders/diameter/pool/OTP-12428' into maint

* anders/diameter/pool/OTP-12428:
  Fix SCTP match blunder in suites
  Be backwards compatible with diameter_sctp listener state
  Add gen_tcp testcase that fails sporadically
  Simplify transport suite
  Remove (ancient) dead code
  Don't orphan slave nodes in example suite
  Refresh example code
  Improve language consistency in diameter(1)
  Add pool suite to test transport_opt() pool_size
  Adapt tcp/sctp transport modules for pool_size > 1
  Add transport_opt() pool_size

1 files changed, 133 insertions, 0 deletions

diff --git a/lib/diameter/test/diameter_pool_SUITE.erl b/lib/diameter/test/diameter_pool_SUITE.erl
new file mode 100644
index 0000000000..a59cd66a2e
--- /dev/null
+++ b/lib/diameter/test/diameter_pool_SUITE.erl
@@ -0,0 +1,133 @@
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 2015. All Rights Reserved.
+%%
+%% The contents of this file are subject to the Erlang Public License,
+%% Version 1.1, (the "License"); you may not use this file except in
+%% compliance with the License. You should have received a copy of the
+%% Erlang Public License along with this software. If not, it can be
+%% retrieved online at http://www.erlang.org/.
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
+%% the License for the specific language governing rights and limitations
+%% under the License.
+%%
+%% %CopyrightEnd%
+%%
+
+%%
+%% Test of the pool_size option in connecting nodes with multiple
+%% connections.
+%%
+
+-module(diameter_pool_SUITE).
+
+-export([suite/0,
+         all/0,
+         init_per_testcase/2,
+         end_per_testcase/2,
+         init_per_suite/1,
+         end_per_suite/1]).
+
+%% testcases
+-export([tcp_connect/1,
+         sctp_connect/1,
+         any_connect/1]).
+
+%% ===========================================================================
+
+-define(util, diameter_util).
+
+%% Config for diameter:start_service/2.
+-define(SERVICE(Host),
+        [{'Origin-Host', Host ++ ".ericsson.com"},
+         {'Origin-Realm', "ericsson.com"},
+         {'Host-IP-Address', [{127,0,0,1}]},
+         {'Vendor-Id', 12345},
+         {'Product-Name', "OTP/diameter"},
+         {'Auth-Application-Id', [0]},  %% common
+         {'Acct-Application-Id', [3]},  %% accounting
+         {restrict_connections, false},
+         {application, [{alias, common},
+                        {dictionary, diameter_gen_base_rfc6733},
+                        {module, diameter_callback}]},
+         {application, [{alias, accounting},
+                        {dictionary, diameter_gen_acct_rfc6733},
+                        {module, diameter_callback}]}]).
+
+%% ===========================================================================
+
+suite() ->
+    [{timetrap, {seconds, 30}}].
+
+all() ->
+    [tcp_connect,
+     sctp_connect,
+     any_connect].
+
+init_per_testcase(_Name, Config) ->
+    Config.
+
+end_per_testcase(_Name, _Config) ->
+    diameter:stop().
+
+init_per_suite(Config) ->
+    [{sctp, ?util:have_sctp()} | Config].
+
+end_per_suite(_Config) ->
+    ok.
+
+%% ===========================================================================
+
+tcp_connect(_Config) ->
+    connect(tcp, tcp).
+
+sctp_connect(Config) ->
+    case lists:member({sctp, true}, Config) of
+       true  -> connect(sctp, sctp);
+       false -> {skip, no_sctp}
+    end.
+
+any_connect(_Config) ->
+    connect(any, tcp).
+
+%% connect/2
+
+%% Establish multiple connections between a client and server.
+connect(ClientProt, ServerProt) ->
+    ok = diameter:start(),
+    [] = [{S,T} || S <- ["server", "client"],
+                   T <- [diameter:start_service(S, ?SERVICE(S))],
+                   T /= ok],
+    %% Listen with a single transport with pool_size = 4. Ensure the
+    %% expected number of transport processes are started.
+    LRef = ?util:listen("server", ServerProt, [{pool_size, 4}]),
+    {4,0} = count("server", LRef, accept), %% 4 transports, no connections
+    %% Establish 5 connections.
+    Ref = ?util:connect("client", ClientProt, LRef, [{pool_size, 5}]),
+    {5,5} = count("client", Ref, pool),    %% 5 connections
+    %% Ensure the server has started replacement transports within a
+    %% reasonable time. Sleepsince there's no guarantee the
+    %% replacements have been started before the client has received
+    %% 'up' events. (Although it's likely.)
+    sleep(),
+    {9,5} = count("server", LRef, accept), %% 5 connections + 4 accepting
+    %% Ensure ther are still the expected number of accepting transports
+    %% after stopping the client service.
+    ok = diameter:stop_service("client"),
+    sleep(),
+    {4,0} = count("server", LRef, accept), %% 4 transports, no connections
+    %% Done.
+    ok = diameter:stop_service("server").
+
+count(Name, Ref, Key) ->
+    [{transport, [[{ref, Ref} | T]]},
+     {connections, Cs}]
+        = diameter:service_info(Name, [transport, connections]),
+    {Key, Ps} = lists:keyfind(Key, 1, T),
+    {length(Ps), length(Cs)}.  %% number of processes, connections
+
+sleep() ->
+    receive after 1000 -> ok end.