Merge branch 'anders/diameter/grouped_decode/OTP-12475' into maint

* anders/diameter/grouped_decode/OTP-12475:
  Allow encode of decoded diameter_avp list
  Add testcases for diameter_avp decode
  Fix handling of length errors on Grouped AVPs
  Don't discard component diameter_avp list on Grouped AVP decode error
  Fix process dictionary manipulation during message decode

1 files changed, 185 insertions, 3 deletions

diff --git a/lib/diameter/test/diameter_codec_SUITE.erl b/lib/diameter/test/diameter_codec_SUITE.erl
index cd8ca41f66..64ea90554d 100644
--- a/lib/diameter/test/diameter_codec_SUITE.erl
+++ b/lib/diameter/test/diameter_codec_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2010-2013. All Rights Reserved.
+%% Copyright Ericsson AB 2010-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -29,6 +29,9 @@
 
 -export([suite/0,
          all/0,
+         groups/0,
+         init_per_group/2,
+         end_per_group/2,
          init_per_testcase/2,
          end_per_testcase/2]).
 
@@ -36,9 +39,13 @@
 -export([base/1,
          gen/1,
          lib/1,
-         unknown/1]).
+         unknown/1,
+         success/1,
+         grouped_error/1,
+         failed_error/1]).
 
 -include("diameter_ct.hrl").
+-include("diameter.hrl").
 
 -define(L, atom_to_list).
 
@@ -48,7 +55,19 @@ suite() ->
     [{timetrap, {seconds, 10}}].
 
 all() ->
-    [base, gen, lib, unknown].
+    [base, gen, lib, unknown, {group, recode}].
+
+groups() ->
+    [{recode, [], [success,
+                   grouped_error,
+                   failed_error]}].
+
+init_per_group(recode, Config) ->
+    ok = diameter:start(),
+    Config.
+
+end_per_group(_, _) ->
+    ok =  diameter:stop().
 
 init_per_testcase(gen, Config) ->
     [{application, ?APP, App}] = diameter_util:consult(?APP, app),
@@ -98,3 +117,166 @@ compile(File) ->
 
 compile(File, Opts) ->
     compile:file(File, [return | Opts]).
+
+%% ===========================================================================
+
+%% Ensure a Grouped AVP is represented by a list in the avps field.
+success(_) ->
+    Avps = [{295, <<1:32>>},  %% Termination-Cause
+            {284, [{280, "Proxy-Host"}, %% Proxy-Info
+                   {33, "Proxy-State"}, %%
+                   {295, <<2:32>>}]}],  %% Termination-Cause
+    #diameter_packet{avps = [#diameter_avp{code = 295,
+                                           value = 1,
+                                           data = <<1:32>>},
+                             [#diameter_avp{code = 284},
+                              #diameter_avp{code = 280},
+                              #diameter_avp{code = 33},
+                              #diameter_avp{code = 295,
+                                            value = 2,
+                                            data = <<2:32>>}]],
+                     errors = []}
+        = str(recode(str(Avps))).
+
+%% ===========================================================================
+
+%% Ensure a Grouped AVP is represented by a list in the avps field
+%% even in the case of a decode error on a component AVP.
+grouped_error(_) ->
+    Avps = [{295, <<1:32>>},  %% Termination-Cause
+            {284, [{295, <<0:32>>},      %% Proxy-Info, Termination-Cause
+                   {280, "Proxy-Host"},
+                   {33, "Proxy-State"}]}],
+    #diameter_packet{avps = [#diameter_avp{code = 295,
+                                           value = 1,
+                                           data = <<1:32>>},
+                             [#diameter_avp{code = 284},
+                              #diameter_avp{code = 295,
+                                            value = undefined,
+                                            data = <<0:32>>},
+                              #diameter_avp{code = 280},
+                              #diameter_avp{code = 33}]],
+                     errors = [{5004, #diameter_avp{code = 284}}]}
+        = str(recode(str(Avps))).
+
+%% ===========================================================================
+
+%% Ensure that a failed decode in Failed-AVP is acceptable, and that
+%% the component AVPs are decoded if possible.
+failed_error(_) ->
+    Avps = [{279, [{295, <<0:32>>},    %% Failed-AVP, Termination-Cause
+                   {258, <<1:32>>},             %% Auth-Application-Id
+                   {284, [{280, "Proxy-Host"},  %% Proxy-Info
+                          {33, "Proxy-State"},
+                          {295, <<0:32>>},      %% Termination-Cause, invalid
+                          {258, <<2:32>>}]}]}], %% Auth-Application-Id
+    #diameter_packet{avps = [[#diameter_avp{code = 279},
+                              #diameter_avp{code = 295,
+                                            value = undefined,
+                                            data = <<0:32>>},
+                              #diameter_avp{code = 258,
+                                            value = 1,
+                                            data = <<1:32>>},
+                              [#diameter_avp{code = 284},
+                               #diameter_avp{code = 280},
+                               #diameter_avp{code = 33},
+                               #diameter_avp{code = 295,
+                                             value = undefined},
+                               #diameter_avp{code = 258,
+                                             value = 2,
+                                             data = <<2:32>>}]]],
+                     errors = []}
+        = sta(recode(sta(Avps))).
+
+%% ===========================================================================
+
+%% str/1
+
+str(#diameter_packet{avps = [#diameter_avp{code = 263},
+                             #diameter_avp{code = 264},
+                             #diameter_avp{code = 296},
+                             #diameter_avp{code = 283},
+                             #diameter_avp{code = 258,
+                                           value = 0}
+                             | T]}
+    = Pkt) ->
+    Pkt#diameter_packet{avps = T};
+
+str(Avps) ->
+    OH = "diameter.erlang.org",
+    OR = "erlang.org",
+    DR = "example.com",
+    Sid = "diameter.erlang.org;123;456",
+
+    [#diameter_header{version = 1,
+                      cmd_code = 275,  %% STR
+                      is_request = true,
+                      application_id = 0,
+                      hop_by_hop_id = 17,
+                      end_to_end_id = 42,
+                      is_proxiable = false,
+                      is_error = false,
+                      is_retransmitted = false}
+     | avp([{263, Sid},  %% Session-Id
+            {264, OH},   %% Origin-Host
+            {296, OR},   %% Origin-Realm
+            {283, DR},   %% Destination-Realm
+            {258, <<0:32>>}]  %% Auth-Application-Id
+           ++ Avps)].
+
+%% sta/1
+
+sta(#diameter_packet{avps = [#diameter_avp{code = 263},
+                             #diameter_avp{code = 268},
+                             #diameter_avp{code = 264},
+                             #diameter_avp{code = 296},
+                             #diameter_avp{code = 278,
+                                           value = 4}
+                             | T]}
+    = Pkt) ->
+    Pkt#diameter_packet{avps = T};
+
+sta(Avps) ->
+    OH = "diameter.erlang.org",
+    OR = "erlang.org",
+    Sid = "diameter.erlang.org;123;456",
+
+    [#diameter_header{version = 1,
+                      cmd_code = 275,  %% STA
+                      is_request = false,
+                      application_id = 0,
+                      hop_by_hop_id = 17,
+                      end_to_end_id = 42,
+                      is_proxiable = false,
+                      is_error = false,
+                      is_retransmitted = false}
+     | avp([{263, Sid},         %% Session-Id
+            {268, <<2002:32>>}, %% Result-Code
+            {264, OH},          %% Origin-Host
+            {296, OR},          %% Origin-Realm
+            {278, <<4:32>>}]    %% Origin-State-Id
+           ++ Avps)].
+
+avp({Code, Data}) ->
+    #diameter_avp{code = Code,
+                  data = avp(Data)};
+
+avp(#diameter_avp{} = A) ->
+    A;
+
+avp([{_,_} | _] = Avps) ->
+    lists:map(fun avp/1, Avps);
+
+avp(V) ->
+    V.
+
+%% recode/1
+
+recode(Msg) ->
+    recode(Msg, diameter_gen_base_rfc6733).
+
+recode(#diameter_packet{} = Pkt, Dict) ->
+    diameter_codec:decode(Dict, diameter_codec:encode(Dict, Pkt));
+
+recode(Msg, Dict) ->
+    recode(#diameter_packet{msg = Msg}, Dict).