Add config suite

To verify return values from diameter:start_service/2 and
diameter:add_transport/2 when passing various config.

2 files changed, 262 insertions, 0 deletions

diff --git a/lib/diameter/test/diameter_config_SUITE.erl b/lib/diameter/test/diameter_config_SUITE.erl
new file mode 100644
index 0000000000..47def9c8c9
--- /dev/null
+++ b/lib/diameter/test/diameter_config_SUITE.erl
@@ -0,0 +1,261 @@
+%% coding: utf-8
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 2013. All Rights Reserved.
+%%
+%% The contents of this file are subject to the Erlang Public License,
+%% Version 1.1, (the "License"); you may not use this file except in
+%% compliance with the License. You should have received a copy of the
+%% Erlang Public License along with this software. If not, it can be
+%% retrieved online at http://www.erlang.org/.
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
+%% the License for the specific language governing rights and limitations
+%% under the License.
+%%
+%% %CopyrightEnd%
+%%
+
+%%
+%% Test service and transport config. In particular, of the detection
+%% of config errors.
+%%
+
+-module(diameter_config_SUITE).
+
+-export([suite/0,
+         all/0]).
+
+%% testcases
+-export([start/1,
+         start_service/1,
+         add_transport/1,
+         stop/1]).
+
+-define(util, diameter_util).
+
+%% Lists of {Key, GoodConfigList, BadConfigList} with which to
+%% configure.
+
+-define(SERVICE_CONFIG,
+        [{application,
+          [[[{dictionary, diameter_gen_base_rfc6733},
+             {module, ?MODULE}]]
+           | [[[{dictionary, D},
+                {module, M},
+                {alias, A},
+                {state, S},
+                {answer_errors, AE},
+                {request_errors, RE},
+                {call_mutates_state, C}]]
+              || D <- [diameter_gen_base_rfc3588, diameter_gen_base_rfc6733],
+                 M <- [?MODULE, [?MODULE, now()]],
+                 A <- [0, common, make_ref()],
+                 S <- [[], make_ref()],
+                 AE <- [report, callback, discard],
+                 RE <- [answer_3xxx, answer, callback],
+                 C <- [true, false]]],
+          [[x],
+           [[]],
+           [[{dictionary, diameter_gen_base_rfc3588}]],
+           [[{module, ?MODULE}]]
+           | [[[{dictionary, diameter_gen_base_rfc6733},
+                {module, ?MODULE},
+                {K,x}]]
+              || K <- [answer_errors,
+                       request_errors,
+                       call_mutates_state]]]},
+         {restrict_connections,
+          [[false], [node], [nodes], [[node(), node()]]],
+          []},
+         {sequence,
+          [[{0,32}], [{1,31}]],
+          [[{2,31}]]},
+         {share_peers,
+          [[true],
+           [false],
+           [[node()]]],
+          [[x]]},
+         {use_shared_peers,
+          [[true],
+           [false],
+           [[node(), node()]]],
+          [[x]]}]).
+
+-define(TRANSPORT_CONFIG,
+        [{transport_module,
+          [[?MODULE]],
+          [[[?MODULE]]]},
+         {transport_config,
+          [[{}, 3000],
+           [{}, infinity]],
+          [[{}, x]]},
+         {applications,
+          [[[1, a, [x]]]],
+          [[x]]},
+         {capabilities,
+          [[[{'Origin-Host', "diameter.erlang.org"}]],
+           [[{'Origin-Realm', "erlang.org"}]]]
+          ++ [[[{'Host-IP-Address', L}]]
+              || L <- [[{127,0,0,1}],
+                       ["127.0.0.1"],
+                       ["127.0.0.1", "FFFF::1", "::1", {1,2,3,4,5,6,7,8}]]]
+          ++ [[[{'Product-Name', N}]]
+              || N <- [["Product", $-, ["Name"]],
+                       "Norðurálfa",
+                       "ᚠᚢᚦᚨᚱᚲ"]]
+          ++ [[[{K,V}]]
+              || K <- ['Vendor-Id',
+                       'Origin-State-Id',
+                       'Firmware-Revision'],
+                 V <- [0, 256, 16#FFFF]]
+          ++ [[[{K,V}]]
+              || K <- ['Supported-Vendor-Id',
+                       'Auth-Application-Id',
+                       'Acct-Application-Id',
+                       'Inband-Security-Id'],
+                 V <- [[17], [0, 256, 16#FFFF]]]
+          ++ [[[{'Vendor-Specific-Application-Id',
+                 [[{'Vendor-Id', V},
+                   {'Auth-Application-Id', [0]},
+                   {'Acct-Application-Id', [4]}]]}]]
+              || V <- [1, [1]]],
+          [[x], [[{'Origin-Host', "ᚠᚢᚦᚨᚱᚲ"}]]]
+          ++ [[[{'Host-IP-Address', A}]]
+              || A <- [{127,0,0,1}]]
+          ++ [[[{'Product-Name', N}]]
+              || N <- [x, 1]]
+          ++ [[[{K,V}]]
+              || K <- ['Vendor-Id',
+                       'Origin-State-Id',
+                       'Firmware-Revision'],
+                 V <- [x, [0], -1, 1 bsl 32]]
+          ++ [[[{K,V}]]
+              || K <- ['Supported-Vendor-Id',
+                       'Auth-Application-Id',
+                       'Acct-Application-Id',
+                       'Inband-Security-Id'],
+                 V <- [x, 17, [-1], [1 bsl 32]]]
+          ++ [[[{'Vendor-Specific-Application-Id', V}]]
+              || V <- [x,
+                       [[{'Vendor-Id', 1 bsl 32}]],
+                       [[{'Auth-Application-Id', 1}]]]]},
+         {capabilities_cb,
+          [[x]],
+          []},
+         {capx_timeout,
+          [[3000]],
+          [[{?MODULE, tmo, []}]]},
+         {disconnect_cb,
+          [[x]],
+          []},
+         {length_errors,
+          [[exit], [handle], [discard]],
+          [[x]]},
+         {reconnect_timer,
+          [[3000]],
+          [[infinity]]},
+         {watchdog_timer,
+          [[3000],
+           [{?MODULE, tmo, []}]],
+          [[infinity],
+           [-1]]},
+         {watchdog_config,
+          [[[{okay, 0}, {suspect, 0}]],
+           [[{okay, 1}]],
+           [[{suspect, 2}]]],
+          [[x],
+           [[{open, 0}]]]}]).
+
+%% ===========================================================================
+
+suite() ->
+    [{timetrap, {seconds, 60}}].
+
+all() ->
+    [start,
+     start_service,
+     add_transport,
+     stop].
+
+%% ===========================================================================
+
+start(_) ->
+    ok = diameter:start().
+
+start_service(T)
+  when is_tuple(T) ->
+    do(fun start/3, T);
+
+start_service(_) ->
+    [] = ?util:run([{?MODULE, start_service, [T]}
+                    || T <- [lists:keyfind(capabilities, 1, ?TRANSPORT_CONFIG)
+                             | ?SERVICE_CONFIG]]).
+
+add_transport(T)
+  when is_tuple(T) ->
+    do(fun add/3, T);
+
+add_transport(_) ->
+    [] = ?util:run([{?MODULE, add_transport, [T]}
+                    || T <- ?TRANSPORT_CONFIG]).
+
+stop(_) ->
+    ok = diameter:stop().
+
+%% ===========================================================================
+
+%% do/2
+
+do(F, {Key, Good, Bad}) ->
+    F(Key, Good, Bad).
+
+%% add/3
+
+add(Key, Good, Bad) ->
+    {[],[]} = {[{Vs,T} || Vs <- Good,
+                          T <- [add(Key, Vs)],
+                          [T] /= [T || {ok,_} <- [T]]],
+               [{Vs,T} || Vs <- Bad,
+                          T <- [add(Key, Vs)],
+                          [T] /= [T || {error,_} <- [T]]]}.
+
+add(Key, Vs) ->
+    T = list_to_tuple([Key | Vs]),
+    diameter:add_transport(make_ref(), {connect, [T]}).
+
+%% start/3
+
+start(Key, Good, Bad) ->
+    {[],[]} = {[{Vs,T} || Vs <- Good,
+                          T <- [start(Key, Vs)],
+                          T /= ok],
+               [{Vs,T} || Vs <- Bad,
+                          T <- [start(Key, Vs)],
+                          [T] /= [T || {error,_} <- [T]]]}.
+
+start(capabilities = K, [Vs]) ->
+    if is_list(Vs) ->
+            start(make_ref(), Vs ++ apps(K));
+       true ->
+            {error, Vs}
+    end;
+
+start(Key, Vs)
+  when is_atom(Key) ->
+    start(make_ref(), [list_to_tuple([Key | Vs]) | apps(Key)]);
+
+start(SvcName, Opts) ->
+    try
+        diameter:start_service(SvcName, Opts)
+    after
+        diameter:stop_service(SvcName)
+    end.
+
+apps(application) ->
+    [];
+apps(_) ->
+    [{application, [{dictionary, diameter_gen_base_rfc6733},
+                    {module, ?MODULE}]}].
diff --git a/lib/diameter/test/modules.mk b/lib/diameter/test/modules.mk
index beff588a02..f6a49d36ab 100644
--- a/lib/diameter/test/modules.mk
+++ b/lib/diameter/test/modules.mk
@@ -29,6 +29,7 @@ MODULES = \
 	diameter_capx_SUITE \
 	diameter_codec_SUITE \
 	diameter_codec_test \
+	diameter_config_SUITE \
 	diameter_compiler_SUITE \
 	diameter_dict_SUITE \
 	diameter_distribution_SUITE \