diff options
author | Kostis Sagonas <[email protected]> | 2010-11-15 15:44:54 +0200 |
---|---|---|
committer | Kostis Sagonas <[email protected]> | 2010-11-15 15:44:54 +0200 |
commit | e1f67dda7a9c2736f7b8d5d30fe84f2a2f39a8c1 (patch) | |
tree | 1e87864a13b04b776abc15b28ba66f19eff27b36 /lib/edoc/src/edoc_tags.erl | |
parent | 76378bb4a1a89d08b41d6f3df0edc6c26160bef7 (diff) | |
download | otp-e1f67dda7a9c2736f7b8d5d30fe84f2a2f39a8c1.tar.gz otp-e1f67dda7a9c2736f7b8d5d30fe84f2a2f39a8c1.tar.bz2 otp-e1f67dda7a9c2736f7b8d5d30fe84f2a2f39a8c1.zip |
Fix various dialyzer warnings
Add appropriate specs to shut off dialyzer's no_return warnings and
also fix an erroneous use of lists:concat/1 instead of lists:append/1.
Diffstat (limited to 'lib/edoc/src/edoc_tags.erl')
-rw-r--r-- | lib/edoc/src/edoc_tags.erl | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/lib/edoc/src/edoc_tags.erl b/lib/edoc/src/edoc_tags.erl index 1f2cb99c75..c0b861e08a 100644 --- a/lib/edoc/src/edoc_tags.erl +++ b/lib/edoc/src/edoc_tags.erl @@ -330,6 +330,10 @@ parse_typedef(Data, Line, _Env, _Where) -> Def end. +-type line() :: erl_scan:line(). + +-spec parse_file(_, line(), _, _) -> no_return(). + parse_file(Data, Line, Env, _Where) -> case edoc_lib:parse_expr(Data, Line) of {string, _, File0} -> @@ -344,6 +348,8 @@ parse_file(Data, Line, Env, _Where) -> throw_error(Line, file_not_string) end. +-spec parse_header(_, line(), _, _) -> no_return(). + parse_header(Data, Line, Env, {Where, _}) -> parse_header(Data, Line, Env, Where); parse_header(Data, Line, Env, Where) when is_list(Where) -> @@ -362,6 +368,13 @@ parse_header(Data, Line, Env, Where) when is_list(Where) -> throw_error(Line, file_not_string) end. +-type err() :: 'file_not_string' + | {'file_not_found', file:filename()} + | {'read_file', file:filename(), term()} + | string(). + +-spec throw_error(line(), err()) -> no_return(). + throw_error(L, {read_file, File, R}) -> throw_error(L, {"error reading file '~s': ~w", [edoc_lib:filename(File), R]}); |