Merge branch 'nox/fix-clang-warnings' into maint

* nox/fix-clang-warnings:
  Silence warnings about socklen_t pointers sign in erl_memory
  Compile in_heapfrag() only in debug mode
  Silence two warnings about tests being always true
  Conditionally compile my_gethostbyname_r and my_gethostbyaddr_r
  Silence a mismatching type pointer warning in ei_resolve
  Silence warnings about different buffer types in erl_memory
  erts: Remove unused file winsock_func.h
  Silence warnings about unused return values in ic
  Silence a warning in erl_poll about an empty loop body
  Fix erts_check_off_heap2 assertion
  Properly mark erl_assert_error as non-returning
  Remove uninitialized use of new_crr in erl_alloc_util

OTP-11517

1 files changed, 8 insertions, 1 deletions

diff --git a/lib/erl_interface/src/connect/ei_resolve.c b/lib/erl_interface/src/connect/ei_resolve.c
index 2545c5f3de..74dcba61a7 100644
--- a/lib/erl_interface/src/connect/ei_resolve.c
+++ b/lib/erl_interface/src/connect/ei_resolve.c
@@ -173,6 +173,8 @@ static int verify_dns_configuration(void)
 
 #endif    
 
+#if defined(VXWORKS) || _REENTRANT
+
 /* 
  * Copy the contents of one struct hostent to another, i.e. don't just
  * copy the pointers, copy all the data and create new pointers, etc.
@@ -226,7 +228,7 @@ static int copy_hostent(struct hostent *dest, const struct hostent *src, char *b
   
   while(*(src_aliases)) {
     if (buflen < sizeof(*pptr)) return -1;
-    *pptr = src_aliases;
+    *pptr = (char *)src_aliases;
     advance_buf(buffer,buflen,sizeof(*pptr));
     src_aliases++;
     pptr++;
@@ -357,6 +359,10 @@ static struct hostent *my_gethostbyname_r(const char *name,
   return rval;
 }
 
+#endif /* defined(VXWORKS) || _REENTRANT */
+
+#if defined(VXWORKS) || EI_THREADS != false
+
 static struct hostent *my_gethostbyaddr_r(const char *addr,
 					  int length, 
 					  int type, 
@@ -418,6 +424,7 @@ static struct hostent *my_gethostbyaddr_r(const char *addr,
   return rval;
 }
 
+#endif /* defined(VXWORKS) || EI_THREADS != false */
 
 #endif /* !HAVE_GETHOSTBYNAME_R */