aboutsummaryrefslogtreecommitdiffstats
path: root/lib/gs/src
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2014-02-24 17:08:31 +0100
committerBjörn Gustavsson <[email protected]>2014-02-24 17:08:31 +0100
commit60b771c936b3d5c1bf3f8c223f789e5fc639dbab (patch)
tree1f4c819a297200bca104b8f647f0e556651f59c4 /lib/gs/src
parenta157ffce8e25012512e0e5d88e05fb135792f161 (diff)
parentccc5b0aed7d23b189d71a9c2782d52a8eac05968 (diff)
downloadotp-60b771c936b3d5c1bf3f8c223f789e5fc639dbab.tar.gz
otp-60b771c936b3d5c1bf3f8c223f789e5fc639dbab.tar.bz2
otp-60b771c936b3d5c1bf3f8c223f789e5fc639dbab.zip
Merge branch 'bjorn/gs/warnings'
* bjorn/gs/warnings: gs: Turn compiler warnings into errors gs: Eliminate a compiler warning
Diffstat (limited to 'lib/gs/src')
-rw-r--r--lib/gs/src/Makefile2
-rw-r--r--lib/gs/src/gstk_generic.erl10
2 files changed, 6 insertions, 6 deletions
diff --git a/lib/gs/src/Makefile b/lib/gs/src/Makefile
index 0a63d5466e..f0200caf01 100644
--- a/lib/gs/src/Makefile
+++ b/lib/gs/src/Makefile
@@ -72,7 +72,7 @@ IMAGES=../priv/bitmap/fup.bm
# ----------------------------------------------------
# FLAGS
# ----------------------------------------------------
-ERL_COMPILE_FLAGS += +warn_obsolete_guard
+ERL_COMPILE_FLAGS += +warn_obsolete_guard -Werror
# ----------------------------------------------------
# Targets
diff --git a/lib/gs/src/gstk_generic.erl b/lib/gs/src/gstk_generic.erl
index 9b0efd07c1..573b4e05bb 100644
--- a/lib/gs/src/gstk_generic.erl
+++ b/lib/gs/src/gstk_generic.erl
@@ -323,11 +323,11 @@ handle_external_opt_call([Opt|Options],Gstkid,TkW,DB,ExtraArg,ExtRes,S,P,C) ->
end.
handle_external_read(Res) ->
- _ = case Res of
- {bad_result,{Objtype,Reason,Option}} ->
- {error,{Objtype,Reason,Option}};
- _ -> ok
- end,
+ %% We have removed dead code here that attempted to translate
+ %% a bad return value from {bad_result,{A,B,C}} to {error,{A,B,C}}.
+ %% Since the gs application is deprecated, we don't want to introduce
+ %% a potential incompatibility; thus we have removed the dead code
+ %% instead of correcting it.
Res.
%%----------------------------------------------------------------------