Merge branch 'kostis/hipe-bs-match-huge-bin' into maint

* kostis/hipe-bs-match-huge-bin:
  Fix matching with huge binaries
  Compile without errors for exported variables

OTP-13092

1 files changed, 105 insertions, 3 deletions

diff --git a/lib/hipe/test/bs_SUITE_data/bs_match.erl b/lib/hipe/test/bs_SUITE_data/bs_match.erl
index 7bc93a316b..b241ea8d35 100644
--- a/lib/hipe/test/bs_SUITE_data/bs_match.erl
+++ b/lib/hipe/test/bs_SUITE_data/bs_match.erl
@@ -1,8 +1,8 @@
 %%% -*- erlang-indent-level: 2 -*-
 %%%-------------------------------------------------------------------
 %%% File    : bs_match.erl
-%%% Author  : Per Gustafsson <[email protected]>
-%%% Purpose : Performs simple matching and construction of binaries
+%%% Authors : Per Gustafsson <[email protected]>, Kostis Sagonas <[email protected]>
+%%% Purpose : Tests matching and construction of binaries
 %%%    TODO : Add binary and float tests
 %%% Created : 20 Feb 2004
 %%%-------------------------------------------------------------------
@@ -13,7 +13,7 @@
 test() ->
   Funs = [fun test_aligned/0, fun test_unaligned/0,
 	  fun test_zero_tail/0, fun test_integer_matching/0,
-	  fun test_writable_bin/0],
+	  fun test_writable_bin/0, fun test_match_huge_bin/0],
   lists:foreach(fun (F) -> ok = F() end, Funs).
 
 %%-------------------------------------------------------------------
@@ -175,6 +175,9 @@ test_dynamic_integer_matching(N) ->
   <<12:N/integer-little, 0:S>> = <<12:N/integer-little, 0:S>>,
   ok.
 
+%%-------------------------------------------------------------------
+%% Test writable bin -- added by Sverker Eriksson
+
 test_writable_bin() ->
   test_writable_bin(<<>>, 0),
   ok.
@@ -185,3 +188,102 @@ test_writable_bin(Bin0, N) when N < 128 ->
   Bin1 = <<Bin0/binary, N>>,
   <<_/utf8, _/binary>> = Bin1,
   test_writable_bin(Bin1, N+1).
+
+%%-------------------------------------------------------------------
+%% Test matching with a huge bin -- taken from bs_match_bin_SUITE
+
+test_match_huge_bin() ->
+  Bin = <<0:(1 bsl 27),13:8>>,
+  skip_huge_bin_1(1 bsl 27, Bin),
+  16777216 = match_huge_bin_1(1 bsl 27, Bin),
+  %% Test overflowing the size of a binary field.
+  nomatch = overflow_huge_bin_skip_32(Bin),
+  nomatch = overflow_huge_bin_32(Bin),
+  nomatch = overflow_huge_bin_skip_64(Bin),
+  nomatch = overflow_huge_bin_64(Bin),
+  %% Size in variable
+  ok = overflow_huge_bin(Bin, lists:seq(25, 32)++lists:seq(50, 64)),
+  ok = overflow_huge_bin_unit128(Bin, lists:seq(25, 32)++lists:seq(50, 64)),
+  ok.
+
+overflow_huge_bin(Bin, [Sz0|Sizes]) ->
+  Sz = id(1 bsl Sz0),
+  case Bin of
+    <<_:Sz/binary-unit:8,0,_/binary>> ->
+      {error,Sz};
+    _ ->
+      case Bin of
+	<<NewBin:Sz/binary-unit:8,0,_/binary>> ->
+	  {error,Sz,size(NewBin)};
+	_ ->
+	  overflow_huge_bin(Bin, Sizes)
+      end
+  end;
+overflow_huge_bin(_, []) -> ok.
+
+overflow_huge_bin_unit128(Bin, [Sz0|Sizes]) ->
+  Sz = id(1 bsl Sz0),
+  case Bin of
+    <<_:Sz/binary-unit:128,0,_/binary>> ->
+      {error,Sz};
+    _ ->
+      case Bin of
+	<<NewBin:Sz/binary-unit:128,0,_/binary>> ->
+	  {error,Sz,size(NewBin)};
+	_ ->
+	  overflow_huge_bin_unit128(Bin, Sizes)
+      end
+  end;
+overflow_huge_bin_unit128(_, []) -> ok.
+
+skip_huge_bin_1(I, Bin) ->
+  <<_:I/binary-unit:1,13>> = Bin,
+  ok.
+
+match_huge_bin_1(I, Bin) ->
+  case Bin of
+    <<Val:I/binary-unit:1,13>> -> size(Val);
+    _ -> nomatch
+  end.
+
+overflow_huge_bin_skip_32(<<_:4294967296/binary,0,_/binary>>) -> 1; % 1 bsl 32
+overflow_huge_bin_skip_32(<<_:33554432/binary-unit:128,0,_/binary>>) -> 2; % 1 bsl 25
+overflow_huge_bin_skip_32(<<_:67108864/binary-unit:64,0,_/binary>>) -> 3; % 1 bsl 26
+overflow_huge_bin_skip_32(<<_:134217728/binary-unit:32,0,_/binary>>) -> 4; % 1 bsl 27
+overflow_huge_bin_skip_32(<<_:268435456/binary-unit:16,0,_/binary>>) -> 5; % 1 bsl 28
+overflow_huge_bin_skip_32(<<_:536870912/binary-unit:8,0,_/binary>>) -> 6; % 1 bsl 29
+overflow_huge_bin_skip_32(<<_:1073741824/binary-unit:8,0,_/binary>>) -> 7; % 1 bsl 30
+overflow_huge_bin_skip_32(<<_:2147483648/binary-unit:8,0,_/binary>>) -> 8; % 1 bsl 31
+overflow_huge_bin_skip_32(_) -> nomatch.
+
+overflow_huge_bin_32(<<Bin:4294967296/binary,_/binary>>) -> {1,Bin}; % 1 bsl 32
+overflow_huge_bin_32(<<Bin:33554432/binary-unit:128,0,_/binary>>) -> {2,Bin}; % 1 bsl 25
+overflow_huge_bin_32(<<Bin:67108864/binary-unit:128,0,_/binary>>) -> {3,Bin}; % 1 bsl 26
+overflow_huge_bin_32(<<Bin:134217728/binary-unit:128,0,_/binary>>) -> {4,Bin}; % 1 bsl 27
+overflow_huge_bin_32(<<Bin:268435456/binary-unit:128,0,_/binary>>) -> {5,Bin}; % 1 bsl 28
+overflow_huge_bin_32(<<Bin:536870912/binary-unit:128,0,_/binary>>) -> {6,Bin}; % 1 bsl 29
+overflow_huge_bin_32(<<Bin:1073741824/binary-unit:128,0,_/binary>>) -> {7,Bin}; % 1 bsl 30
+overflow_huge_bin_32(<<Bin:2147483648/binary-unit:128,0,_/binary>>) -> {8,Bin}; % 1 bsl 31
+overflow_huge_bin_32(_) -> nomatch.
+
+overflow_huge_bin_skip_64(<<_:18446744073709551616/binary,0,_/binary>>) -> 1; % 1 bsl 64
+overflow_huge_bin_skip_64(<<_:144115188075855872/binary-unit:128,0,_/binary>>) -> 2; % 1 bsl 57
+overflow_huge_bin_skip_64(<<_:288230376151711744/binary-unit:64,0,_/binary>>) -> 3; % 1 bsl 58
+overflow_huge_bin_skip_64(<<_:576460752303423488/binary-unit:32,0,_/binary>>) -> 4; % 1 bsl 59
+overflow_huge_bin_skip_64(<<_:1152921504606846976/binary-unit:16,0,_/binary>>) -> 5; % 1 bsl 60
+overflow_huge_bin_skip_64(<<_:2305843009213693952/binary-unit:8,0,_/binary>>) -> 6; % 1 bsl 61
+overflow_huge_bin_skip_64(<<_:4611686018427387904/binary-unit:8,0,_/binary>>) -> 7; % 1 bsl 62
+overflow_huge_bin_skip_64(<<_:9223372036854775808/binary-unit:8,_/binary>>) -> 8; % 1 bsl 63
+overflow_huge_bin_skip_64(_) -> nomatch.
+
+overflow_huge_bin_64(<<Bin:18446744073709551616/binary,_/binary>>) -> {1,Bin}; % 1 bsl 64
+overflow_huge_bin_64(<<Bin:144115188075855872/binary-unit:128,0,_/binary>>) -> {2,Bin}; % 1 bsl 57
+overflow_huge_bin_64(<<Bin:288230376151711744/binary-unit:128,0,_/binary>>) -> {3,Bin}; % 1 bsl 58
+overflow_huge_bin_64(<<Bin:576460752303423488/binary-unit:128,0,_/binary>>) -> {4,Bin}; % 1 bsl 59
+overflow_huge_bin_64(<<Bin:1152921504606846976/binary-unit:128,0,_/binary>>) -> {5,Bin}; % 1 bsl 60
+overflow_huge_bin_64(<<Bin:2305843009213693952/binary-unit:128,0,_/binary>>) -> {6,Bin}; % 1 bsl 61
+overflow_huge_bin_64(<<Bin:4611686018427387904/binary-unit:128,0,_/binary>>) -> {7,Bin}; % 1 bsl 62
+overflow_huge_bin_64(<<Bin:9223372036854775808/binary-unit:128,0,_/binary>>) -> {8,Bin}; % 1 bsl 63
+overflow_huge_bin_64(_) -> nomatch.
+
+id(I) -> I.