diff options
author | Hans Bolinder <[email protected]> | 2017-02-28 13:26:38 +0100 |
---|---|---|
committer | Hans Bolinder <[email protected]> | 2017-02-28 14:37:15 +0100 |
commit | 0d12ca4bb9fc85e9db980f1f4f990a7c81c5a7a4 (patch) | |
tree | dbad9f8dae2848924a6dae32a12e26e65b1643da /lib/hipe | |
parent | 4827fa95257c1d68bcdcac2c6d4a35cd8b56d8cd (diff) | |
download | otp-0d12ca4bb9fc85e9db980f1f4f990a7c81c5a7a4.tar.gz otp-0d12ca4bb9fc85e9db980f1f4f990a7c81c5a7a4.tar.bz2 otp-0d12ca4bb9fc85e9db980f1f4f990a7c81c5a7a4.zip |
dialyzer: Fix a weird warning
Diffstat (limited to 'lib/hipe')
-rw-r--r-- | lib/hipe/cerl/erl_types.erl | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/lib/hipe/cerl/erl_types.erl b/lib/hipe/cerl/erl_types.erl index 10e97ff54d..36652db176 100644 --- a/lib/hipe/cerl/erl_types.erl +++ b/lib/hipe/cerl/erl_types.erl @@ -543,14 +543,22 @@ t_find_opaque_mismatch(?list(T1, Tl1, _), ?list(T2, Tl2, _), TopType, Opaques) - t_find_opaque_mismatch_ordlists([T1, Tl1], [T2, Tl2], TopType, Opaques); t_find_opaque_mismatch(T1, ?opaque(_) = T2, TopType, Opaques) -> case is_opaque_type(T2, Opaques) of - false -> {ok, TopType, T2}; + false -> + case t_is_opaque(T1) andalso compatible_opaque_types(T1, T2) =/= [] of + true -> error; + false -> {ok, TopType, T2} + end; true -> t_find_opaque_mismatch(T1, t_opaque_structure(T2), TopType, Opaques) end; t_find_opaque_mismatch(?opaque(_) = T1, T2, TopType, Opaques) -> %% The generated message is somewhat misleading: case is_opaque_type(T1, Opaques) of - false -> {ok, TopType, T1}; + false -> + case t_is_opaque(T2) andalso compatible_opaque_types(T1, T2) =/= [] of + true -> error; + false -> {ok, TopType, T1} + end; true -> t_find_opaque_mismatch(t_opaque_structure(T1), T2, TopType, Opaques) end; @@ -3055,6 +3063,9 @@ inf_opaque_types(IsOpaque1, T1, IsOpaque2, T2, Opaques) -> end end. +compatible_opaque_types(?opaque(Es1), ?opaque(Es2)) -> + [{O1, O2} || O1 <- Es1, O2 <- Es2, is_compat_opaque_names(O1, O2)]. + is_compat_opaque_names(Opaque1, Opaque2) -> #opaque{mod = Mod1, name = Name1, args = Args1} = Opaque1, #opaque{mod = Mod2, name = Name2, args = Args2} = Opaque2, |