aboutsummaryrefslogtreecommitdiffstats
path: root/lib/inets/src/http_lib/http_response.erl
diff options
context:
space:
mode:
authorKirilll Zaborsky <[email protected]>2015-07-20 16:38:33 +0300
committerHenrik Nord <[email protected]>2015-10-13 11:15:34 +0200
commitf8750f121176c6cedc7b3162b6656ce201c9fe97 (patch)
treedd34f90b5f91ec81ecce16def8111bec585cb43d /lib/inets/src/http_lib/http_response.erl
parent981dd4509dbabcf3af3d4df611163987e10bca41 (diff)
downloadotp-f8750f121176c6cedc7b3162b6656ce201c9fe97.tar.gz
otp-f8750f121176c6cedc7b3162b6656ce201c9fe97.tar.bz2
otp-f8750f121176c6cedc7b3162b6656ce201c9fe97.zip
inets: fix suppport of HTTP headers with obs-fold
httpc should not fail when response contains (now deprecated) multiline HTTP headers constructed with obs-folds. And as RFC7230 specifies user agent should replace obs-folds with spaces.
Diffstat (limited to 'lib/inets/src/http_lib/http_response.erl')
-rw-r--r--lib/inets/src/http_lib/http_response.erl30
1 files changed, 21 insertions, 9 deletions
diff --git a/lib/inets/src/http_lib/http_response.erl b/lib/inets/src/http_lib/http_response.erl
index 58b30c4e9e..d13670700c 100644
--- a/lib/inets/src/http_lib/http_response.erl
+++ b/lib/inets/src/http_lib/http_response.erl
@@ -31,16 +31,11 @@
%% Value - string()
%%
%% Description: Creates a http_response_h-record used internally to
-%% handle http-headers.
+%% handle http-headers, assumes reversed list of headers
+%% to unfold multiline headers with obs-folds
%%-------------------------------------------------------------------------
-headers([], Headers) ->
- Headers;
-
-headers([Header | Tail], Headers) ->
- {Key, [$: | Value]} =
- lists:splitwith(fun($:) -> false; (_) -> true end, Header),
- headers(Tail, headers(http_util:to_lower(string:strip(Key)),
- string:strip(Value), Headers)).
+headers(RevLines, Headers) ->
+ fill_headers(RevLines, [], Headers).
%%-------------------------------------------------------------------------
%% headers(#http_response_h{}) -> HeaderList
@@ -68,6 +63,23 @@ header_list(Headers) ->
%%%========================================================================
%%% Internal functions
%%%========================================================================
+fill_headers([], _, Headers) ->
+ Headers;
+fill_headers([[Ch|HeaderFold]|Tail], Folded, Headers)
+ when Ch == $\t; Ch == $\s ->
+ fill_headers(Tail, [HeaderFold|Folded], Headers);
+fill_headers([Header | Tail], Folded, Headers) ->
+ Unfolded = unfold([Header|Folded]),
+ {Key, [$: | Value]} =
+ lists:splitwith(fun($:) -> false; (_) -> true end, Unfolded),
+ fill_headers(Tail, [], headers(http_util:to_lower(string:strip(Key)),
+ string:strip(Value), Headers)).
+
+unfold([L]) ->
+ L;
+unfold(Folded) ->
+ string:join(Folded, " ").
+
headers("cache-control", Value, Headers) ->
Headers#http_response_h{'cache-control'= Value};
headers("connection", Value, Headers) ->