inets: Remove use of httpd_conf:clean/1 and httpd_conf:custom_clean/3

Internal use of the function white_space_clean/1 could probably be done
in a much better way using re-module and removing a lot of legacy code.
But we will have to do this later, due to lack of time, we want to make
this commit as little work as possible.

1 files changed, 49 insertions, 45 deletions

diff --git a/lib/inets/src/http_server/httpd_conf.erl b/lib/inets/src/http_server/httpd_conf.erl
index e82ad5a637..89a7e96f3e 100644
--- a/lib/inets/src/http_server/httpd_conf.erl
+++ b/lib/inets/src/http_server/httpd_conf.erl
@@ -24,7 +24,7 @@
 	 remove/1, remove_all/1, get_config/3, get_config/4,
 	 lookup_socket_type/1, 
 	 lookup/2, lookup/3, lookup/4, 
-	 validate_properties/1]).
+	 validate_properties/1, white_space_clean/1]).
 
 %% Deprecated 
 -export([is_directory/1, is_file/1, make_integer/1, clean/1, 
@@ -80,7 +80,7 @@ load("MaxHeaderSize " ++ MaxHeaderSize, []) ->
         {ok, Integer} ->
             {ok, [], {max_header_size,Integer}};
         {error, _} ->
-            {error, ?NICE(clean(MaxHeaderSize)++
+            {error, ?NICE(string:strip(MaxHeaderSize)++
                           " is an invalid number of MaxHeaderSize")}
     end;
 
@@ -89,7 +89,7 @@ load("MaxURISize " ++ MaxHeaderSize, []) ->
         {ok, Integer} ->
             {ok, [], {max_uri_size, Integer}};
         {error, _} ->
-            {error, ?NICE(clean(MaxHeaderSize)++
+            {error, ?NICE(string:strip(MaxHeaderSize)++
                           " is an invalid number of MaxHeaderSize")}
     end;
 
@@ -98,12 +98,12 @@ load("MaxContentLength " ++ Max, []) ->
         {ok, Integer} ->
             {ok, [], {max_content_length, Integer}};
         {error, _} ->
-            {error, ?NICE(clean(Max) ++
+            {error, ?NICE(string:strip(Max) ++
 			      " is an invalid number of MaxContentLength")}
     end;
 
 load("ServerName " ++ ServerName, []) ->
-    {ok,[], {server_name, clean(ServerName)}};
+    {ok,[], {server_name, string:strip(ServerName)}};
 
 load("ServerTokens " ++ ServerTokens, []) ->
     %% These are the valid *plain* server tokens: 
@@ -111,28 +111,28 @@ load("ServerTokens " ++ ServerTokens, []) ->
     %% It can also be a "private" server token: private:<any string>
     case string:tokens(ServerTokens, [$:]) of
 	["private", Private] ->
-	    {ok,[], {server_tokens, clean(Private)}};
+	    {ok,[], {server_tokens, string:strip(Private)}};
 	[TokStr] ->
-	    Tok = list_to_atom(clean(TokStr)),
+	    Tok = list_to_atom(string:strip(TokStr)),
 	    case lists:member(Tok, [none, prod, major, minor, minimum, os, full]) of
 		true ->
 		    {ok,[], {server_tokens, Tok}};
 		false ->
-		    {error, ?NICE(clean(ServerTokens) ++ 
+		    {error, ?NICE(string:strip(ServerTokens) ++ 
 				  " is an invalid ServerTokens")}
 	    end;
 	_ ->
-	    {error, ?NICE(clean(ServerTokens) ++ " is an invalid ServerTokens")}
+	    {error, ?NICE(string:strip(ServerTokens) ++ " is an invalid ServerTokens")}
     end;
 
 load("SocketType " ++ SocketType, []) ->
     %% ssl is the same as HTTP_DEFAULT_SSL_KIND
     %% essl is the pure Erlang-based ssl (the "new" ssl)
-    case check_enum(clean(SocketType), ["ssl", "essl", "ip_comm"]) of
+    case check_enum(string:strip(SocketType), ["ssl", "essl", "ip_comm"]) of
 	{ok, ValidSocketType} ->
 	    {ok, [], {socket_type, ValidSocketType}};
 	{error,_} ->
-	    {error, ?NICE(clean(SocketType) ++ " is an invalid SocketType")}
+	    {error, ?NICE(string:strip(SocketType) ++ " is an invalid SocketType")}
     end;
 
 load("Port " ++ Port, []) ->
@@ -140,7 +140,7 @@ load("Port " ++ Port, []) ->
 	{ok, Integer} ->
 	    {ok, [], {port, Integer}};
 	{error, _} ->
-	    {error, ?NICE(clean(Port)++" is an invalid Port")}
+	    {error, ?NICE(string:strip(Port)++" is an invalid Port")}
     end;
 
 load("BindAddress " ++ Address0, []) ->
@@ -196,7 +196,7 @@ load("BindAddress " ++ Address0, []) ->
     end;
 
 load("KeepAlive " ++ OnorOff, []) ->
-    case list_to_atom(clean(OnorOff)) of
+    case list_to_atom(string:strip(OnorOff)) of
 	off ->
 	    {ok, [], {keep_alive, false}};
 	_ ->
@@ -208,7 +208,7 @@ load("MaxKeepAliveRequests " ++  MaxRequests, []) ->
 	{ok, Integer} ->
 	    {ok, [], {max_keep_alive_request, Integer}};
 	{error, _} ->
-	    {error, ?NICE(clean(MaxRequests) ++
+	    {error, ?NICE(string:strip(MaxRequests) ++
 			  " is an invalid MaxKeepAliveRequests")}
     end;
 
@@ -218,7 +218,7 @@ load("MaxKeepAliveRequest " ++  MaxRequests, []) ->
 	{ok, Integer} ->
 	    {ok, [], {max_keep_alive_request, Integer}};
 	{error, _} ->
-	    {error, ?NICE(clean(MaxRequests) ++
+	    {error, ?NICE(string:strip(MaxRequests) ++
 			  " is an invalid MaxKeepAliveRequest")}
     end;
 
@@ -227,7 +227,7 @@ load("KeepAliveTimeout " ++ Timeout, []) ->
 	{ok, Integer} ->
 	    {ok, [], {keep_alive_timeout, Integer}};
 	{error, _} ->
-	    {error, ?NICE(clean(Timeout)++" is an invalid KeepAliveTimeout")}
+	    {error, ?NICE(string:strip(Timeout)++" is an invalid KeepAliveTimeout")}
     end;
 
 load("Modules " ++ Modules, []) ->
@@ -235,18 +235,18 @@ load("Modules " ++ Modules, []) ->
     {ok, [], {modules,[list_to_atom(X) || X <- ModuleList]}};
 
 load("ServerAdmin " ++ ServerAdmin, []) ->
-    {ok, [], {server_admin,clean(ServerAdmin)}};
+    {ok, [], {server_admin,string:strip(ServerAdmin)}};
 
 load("ServerRoot " ++ ServerRoot, []) ->
-    case is_directory(clean(ServerRoot)) of
+    case is_directory(string:strip(ServerRoot)) of
 	{ok, Directory} ->
 	    {ok, [], [{server_root,string:strip(Directory,right,$/)}]};
 	{error, _} ->
-	    {error, ?NICE(clean(ServerRoot)++" is an invalid ServerRoot")}
+	    {error, ?NICE(string:strip(ServerRoot)++" is an invalid ServerRoot")}
     end;
 
 load("MimeTypes " ++ MimeTypes, []) ->
-    case load_mime_types(clean(MimeTypes)) of
+    case load_mime_types(white_space_clean(MimeTypes)) of
 	{ok, MimeTypesList} ->
 	    {ok, [], [{mime_types, MimeTypesList}]};
 	{error, Reason} ->
@@ -258,24 +258,24 @@ load("MaxClients " ++ MaxClients, []) ->
 	{ok, Integer} ->
 	    {ok, [], {max_clients,Integer}};
 	{error, _} ->
-	    {error, ?NICE(clean(MaxClients) ++
+	    {error, ?NICE(string:strip(MaxClients) ++
 			  " is an invalid number of MaxClients")}
     end;
 load("DocumentRoot " ++ DocumentRoot,[]) ->
-    case is_directory(clean(DocumentRoot)) of
+    case is_directory(string:strip(DocumentRoot)) of
 	{ok, Directory} ->
 	    {ok, [], {document_root,string:strip(Directory,right,$/)}};
 	{error, _} ->
-	    {error, ?NICE(clean(DocumentRoot)++" is an invalid DocumentRoot")}
+	    {error, ?NICE(string:strip(DocumentRoot)++" is an invalid DocumentRoot")}
     end;
 load("DefaultType " ++ DefaultType, []) ->
-    {ok, [], {default_type,clean(DefaultType)}};
+    {ok, [], {default_type,string:strip(DefaultType)}};
 load("SSLCertificateFile " ++ SSLCertificateFile, []) ->
-    case is_file(clean(SSLCertificateFile)) of
+    case is_file(string:strip(SSLCertificateFile)) of
 	{ok, File} ->
 	    {ok, [], {ssl_certificate_file,File}};
     {error, _} ->
-	    {error, ?NICE(clean(SSLCertificateFile)++
+	    {error, ?NICE(string:strip(SSLCertificateFile)++
 			  " is an invalid SSLCertificateFile")}
     end;
 load("SSLLogLevel " ++ SSLLogAlert, []) ->
@@ -286,69 +286,69 @@ load("SSLLogLevel " ++ SSLLogAlert, []) ->
 	    {ok, [], {ssl_log_alert, true}}
     end;
 load("SSLCertificateKeyFile " ++ SSLCertificateKeyFile, []) ->
-    case is_file(clean(SSLCertificateKeyFile)) of
+    case is_file(string:strip(SSLCertificateKeyFile)) of
 	{ok, File} ->
 	    {ok, [], {ssl_certificate_key_file,File}};
 	{error, _} ->
-	    {error, ?NICE(clean(SSLCertificateKeyFile)++
+	    {error, ?NICE(string:strip(SSLCertificateKeyFile)++
 			  " is an invalid SSLCertificateKeyFile")}
     end;
 load("SSLVerifyClient " ++ SSLVerifyClient, []) ->
-    case make_integer(clean(SSLVerifyClient)) of
+    case make_integer(string:strip(SSLVerifyClient)) of
 	{ok, Integer} when (Integer >=0) andalso (Integer =< 2) ->
 	    {ok, [], {ssl_verify_client,Integer}};
 	{ok, _Integer} ->
-	    {error,?NICE(clean(SSLVerifyClient) ++
+	    {error,?NICE(string:strip(SSLVerifyClient) ++
 			 " is an invalid SSLVerifyClient")};
 	{error, nomatch} ->
-	    {error,?NICE(clean(SSLVerifyClient) ++ 
+	    {error,?NICE(string:strip(SSLVerifyClient) ++ 
 			 " is an invalid SSLVerifyClient")}
     end;
 load("SSLVerifyDepth " ++ SSLVerifyDepth, []) ->
-    case make_integer(clean(SSLVerifyDepth)) of
+    case make_integer(string:strip(SSLVerifyDepth)) of
 	{ok, Integer} when Integer > 0 ->
 	    {ok, [], {ssl_verify_client_depth,Integer}};
 	{ok, _Integer} ->
-	    {error,?NICE(clean(SSLVerifyDepth) ++
+	    {error,?NICE(string:strip(SSLVerifyDepth) ++
 			 " is an invalid SSLVerifyDepth")};
 	{error, nomatch} ->
-	    {error,?NICE(clean(SSLVerifyDepth) ++
+	    {error,?NICE(string:strip(SSLVerifyDepth) ++
 			 " is an invalid SSLVerifyDepth")}
     end;
 load("SSLCiphers " ++ SSLCiphers, []) ->
-    {ok, [], {ssl_ciphers, clean(SSLCiphers)}};
+    {ok, [], {ssl_ciphers, string:strip(SSLCiphers)}};
 load("SSLCACertificateFile " ++ SSLCACertificateFile, []) ->
-    case is_file(clean(SSLCACertificateFile)) of
+    case is_file(string:strip(SSLCACertificateFile)) of
 	{ok, File} ->
 	    {ok, [], {ssl_ca_certificate_file,File}};
 	{error, _} ->
-	    {error, ?NICE(clean(SSLCACertificateFile)++
+	    {error, ?NICE(string:strip(SSLCACertificateFile)++
 			  " is an invalid SSLCACertificateFile")}
     end;
 load("SSLPasswordCallbackModule " ++ SSLPasswordCallbackModule, []) ->
     {ok, [], {ssl_password_callback_module,
-	      list_to_atom(clean(SSLPasswordCallbackModule))}};
+	      list_to_atom(string:strip(SSLPasswordCallbackModule))}};
 load("SSLPasswordCallbackFunction " ++ SSLPasswordCallbackFunction, []) ->
     {ok, [], {ssl_password_callback_function,
-	      list_to_atom(clean(SSLPasswordCallbackFunction))}};
+	      list_to_atom(string:strip(SSLPasswordCallbackFunction))}};
 load("SSLPasswordCallbackArguments " ++ SSLPasswordCallbackArguments, []) ->
     {ok, [], {ssl_password_callback_arguments, 
 	                         SSLPasswordCallbackArguments}};
 load("DisableChunkedTransferEncodingSend " ++ TrueOrFalse, []) ->
-    case list_to_atom(clean(TrueOrFalse)) of
+    case list_to_atom(string:strip(TrueOrFalse)) of
 	true ->
 	    {ok, [], {disable_chunked_transfer_encoding_send, true}};
 	_ ->
 	    {ok, [], {disable_chunked_transfer_encoding_send, false}}
     end;
 load("LogFormat " ++ LogFormat, []) ->
-    {ok,[],{log_format, list_to_atom(httpd_conf:clean(LogFormat))}};
+    {ok,[],{log_format, list_to_atom(string:strip(LogFormat))}};
 load("ErrorLogFormat " ++ LogFormat, []) ->
-    {ok,[],{error_log_format, list_to_atom(httpd_conf:clean(LogFormat))}}.
+    {ok,[],{error_log_format, list_to_atom(string:strip(LogFormat))}}.
 
 
 clean_address(Addr) ->
-    string:strip(string:strip(clean(Addr), left, $[), right, $]).
+    string:strip(string:strip(string:strip(Addr), left, $[), right, $]).
 
 
 make_ipfamily(IpFamilyStr) ->
@@ -974,7 +974,7 @@ verify_modules([]) ->
 verify_modules([Mod|Rest]) ->
     case code:which(Mod) of
 	non_existing ->
-	    {error, ?NICE(atom_to_list(Mod)++" does not exist")};
+	    {error, ?NICE(string:strip(atom_to_list(Mod), right, $\n) ++" does not exist")};
 	_Path ->
 	    verify_modules(Rest)
     end.
@@ -1016,7 +1016,7 @@ parse_mime_types(Stream,MimeTypesList) ->
 	    eof ->
 		eof;
 	    String ->
-		clean(String)
+		white_space_clean(String)
 	end,
     parse_mime_types(Stream, MimeTypesList, Line).
 parse_mime_types(Stream, MimeTypesList, eof) ->
@@ -1202,6 +1202,10 @@ plain_server_tokens() ->
 error_report(Where,M,F,Error) ->
     error_logger:error_report([{?MODULE, Where}, 
 			       {apply, {M, F, []}}, Error]).
+white_space_clean(String) ->
+    {ok,CleanedString,_} = 
+	inets_regexp:gsub(String, "^[ \t\n\r\f]*|[ \t\n\r\f]*\$",""),
+    CleanedString.
 
 
 %%%=========================================================================