inets: Use test_server app tests and remove legacy test_server code

FTP tests needed some refactoring as some tests where lost to
the ftp_suite_lib module that was not run.

1 files changed, 120 insertions, 249 deletions

diff --git a/lib/inets/test/httpc_cookie_SUITE.erl b/lib/inets/test/httpc_cookie_SUITE.erl
index 0eca3edae2..8140967bca 100644
--- a/lib/inets/test/httpc_cookie_SUITE.erl
+++ b/lib/inets/test/httpc_cookie_SUITE.erl
@@ -23,14 +23,8 @@
 -include_lib("common_test/include/ct.hrl").
 -include_lib("stdlib/include/ms_transform.hrl").
 
-%% Test server specific exports
--export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1, init_per_group/2,end_per_group/2, init_per_testcase/2, end_per_testcase/2]).
-
-%% Test cases must be exported.
--export([session_cookies_only/1, netscape_cookies/1, 
-	 cookie_cancel/1, cookie_expires/1, persistent_cookie/1,
-	 domain_cookie/1, secure_cookie/1, update_cookie/1, 
-	 update_cookie_session/1, cookie_attributes/1]).
+%% Note: This directive should only be used in test suites.
+-compile(export_all).
 
 -define(URL,        "http://myhost.cookie.test.org").
 -define(URL_DOMAIN, "http://myhost2.cookie.test.org").
@@ -38,86 +32,10 @@
 
 %% Test server callback functions
 
-%%--------------------------------------------------------------------
-%% Function: init_per_testcase(TestCase, Config) -> Config
-%% Case - atom()
-%%   Name of the test case that is about to be run.
-%% Config - [tuple()]
-%%   A list of key/value pairs, holding the test case configuration.
-%%
-%% Description: Initiation before each test case
-%%
-%% Note: This function is free to add any key/value pairs to the Config
-%% variable, but should NOT alter/remove any existing entries.
-%% Description: Initiation before each test case
-%%--------------------------------------------------------------------
-init_per_testcase(session_cookies_only = Case, Config0) ->
-    tsp("init_per_testcase(~p) -> entry with"
-	"~n   Config0: ~p", [Case, Config0]),
-    Config = init_workdir(Case, Config0), 
-    application:start(inets), 
-    httpc:set_options([{cookies, verify}]),
-    watch_dog(Config);
-
-init_per_testcase(Case, Config0) ->
-    tsp("init_per_testcase(~p) -> entry with"
-	"~n   Config0: ~p", [Case, Config0]),
-    Config = init_workdir(Case, Config0), 
-    CaseDir = ?config(case_top_dir, Config),
-    application:load(inets),
-    application:set_env(inets, services, [{httpc, {default, CaseDir}}]),
-    application:start(inets), 
-    httpc:set_options([{cookies, verify}]),
-    watch_dog(Config).
-
-watch_dog(Config) ->
-    Dog = test_server:timetrap(inets_test_lib:minutes(10)),
-    NewConfig = lists:keydelete(watchdog, 1, Config),
-    [{watchdog, Dog} | NewConfig].
-
-init_workdir(Case, Config) ->
-    PrivDir = ?config(priv_dir, Config),
-    SuiteTopDir = filename:join(PrivDir, ?MODULE),
-    case file:make_dir(SuiteTopDir) of
-        ok ->
-            ok;
-        {error, eexist} ->
-            ok;
-        Error ->
-            tsf({failed_creating_subsuite_top_dir, Error})
-    end,
-
-    CaseTopDir = filename:join(SuiteTopDir, Case),
-    ?line ok   = file:make_dir(CaseTopDir),
-    [{suite_top_dir, SuiteTopDir}, 
-     {case_top_dir,  CaseTopDir} | Config].
-
-
-%%--------------------------------------------------------------------
-%% Function: end_per_testcase(TestCase, Config) -> _
-%% Case - atom()
-%%   Name of the test case that is about to be run.
-%% Config - [tuple()]
-%%   A list of key/value pairs, holding the test case configuration.
-%% Description: Cleanup after each test case
-%%--------------------------------------------------------------------
-end_per_testcase(Case, Config) ->
-    tsp("end_per_testcase(~p) -> entry with"
-	"~n   Config: ~p", [Case, Config]),
-    application:stop(inets),
-    Dog = ?config(watchdog, Config),
-    test_server:timetrap_cancel(Dog),
-    ok.
-
-%%--------------------------------------------------------------------
-%% Function: all(Clause) -> TestCases
-%% Clause - atom() - suite | doc
-%% TestCases - [Case] 
-%% Case - atom()
-%%   Name of a test case.
-%% Description: Returns a list of all test cases in this test suite
-%%--------------------------------------------------------------------
-suite() -> [{ct_hooks,[ts_install_cth]}].
+suite() -> 
+    [{ct_hooks,[ts_install_cth]},
+     {timetrap,{seconds,15}}
+    ].
 
 all() -> 
     [
@@ -148,17 +66,55 @@ init_per_group(_GroupName, Config) ->
 end_per_group(_GroupName, Config) ->
     Config.
 
+init_per_testcase(session_cookies_only = Case, Config0) ->
+    Config = init_workdir(Case, Config0), 
+    application:start(inets), 
+    httpc:set_options([{cookies, verify}]),
+    Config;
+init_per_testcase(cookie_expires = Case, Config0) ->
+    Config = init_workdir(Case, Config0), 
+    CaseDir = proplists:get_value(case_top_dir, Config),
+    application:start(inets), 
+    application:set_env(inets, services, [{httpc, {default, CaseDir}}]),
+    application:start(inets), 
+    httpc:set_options([{cookies, verify}]),
+    Config;
+init_per_testcase(Case, Config0) ->
+    Config = init_workdir(Case, Config0), 
+    CaseDir = proplists:get_value(case_top_dir, Config),
+    application:load(inets),
+    application:set_env(inets, services, [{httpc, {default, CaseDir}}]),
+    application:start(inets), 
+    httpc:set_options([{cookies, verify}]),
+    Config.
+
+init_workdir(Case, Config) ->
+    PrivDir = proplists:get_value(priv_dir, Config),
+    SuiteTopDir = filename:join(PrivDir, ?MODULE),
+    case file:make_dir(SuiteTopDir) of
+        ok ->
+            ok;
+        {error, eexist} ->
+            ok;
+        Error ->
+           ct:fail({failed_creating_subsuite_top_dir, Error})
+    end,
+
+    CaseTopDir = filename:join(SuiteTopDir, Case),
+    ok   = file:make_dir(CaseTopDir),
+    [{suite_top_dir, SuiteTopDir}, 
+     {case_top_dir,  CaseTopDir} | Config].
+
+end_per_testcase(_, _) ->
+    application:stop(inets).
+
 
 %% Test cases starts here.
 %%--------------------------------------------------------------------
-session_cookies_only(doc) -> 
-    ["Test that all cookies are handled as session cookies if there"
-     "does not exist a directory to save presitent cookies in."];
-session_cookies_only(suite) -> 
-    [];
+session_cookies_only() -> 
+    [{doc, "Test that all cookies are handled as session cookies if there"
+     "does not exist a directory to save presitent cookies in."}].
 session_cookies_only(Config) when is_list(Config) -> 
-    tsp("session_cookies_only -> Cookies 1: ~p", [httpc:which_cookies()]),
-
     SetCookieHeaders = [{"set-cookie", "test_cookie=true; path=/;" 
 			 ";max-age=60000"}],
     httpc:store_cookies(SetCookieHeaders, ?URL),
@@ -166,36 +122,22 @@ session_cookies_only(Config) when is_list(Config) ->
 	httpc:cookie_header(?URL),
     application:stop(inets),
     application:start(inets),
-    {"cookie", ""} = httpc:cookie_header(?URL),
-
-    tsp("session_cookies_only -> Cookies 2: ~p", [httpc:which_cookies()]),
-    ok.
+    {"cookie", ""} = httpc:cookie_header(?URL).
 
-netscape_cookies(doc) -> 
-    ["Test that the old (original) format of cookies are accepted."];
-netscape_cookies(suite) -> 
-    [];
+netscape_cookies() -> 
+    [{doc, "Test that the old (original) format of cookies are accepted."}].
 netscape_cookies(Config) when is_list(Config) -> 
-    tsp("netscape_cookies -> Cookies 1: ~p", [httpc:which_cookies()]),
-
     Expires = future_netscape_date(),
     SetCookieHeaders = [{"set-cookie", "test_cookie=true; path=/; " 
 			 "expires=" ++ Expires}],
     httpc:store_cookies(SetCookieHeaders, ?URL),
     {"cookie", "$Version=0; test_cookie=true; $Path=/"} = 
-	httpc:cookie_header(?URL),
+	httpc:cookie_header(?URL).
 
-    tsp("netscape_cookies -> Cookies 2: ~p", [httpc:which_cookies()]),
-    ok.
-
-cookie_cancel(doc) -> 
-    ["A cookie can be canceld by sending the same cookie with max-age=0 "
-     "this test cheks that cookie is canceled."];
-cookie_cancel(suite) -> 
-    [];
+cookie_cancel() -> 
+    [{doc, "A cookie can be canceld by sending the same cookie with max-age=0 "
+     "this test cheks that cookie is canceled."}].
 cookie_cancel(Config) when is_list(Config) -> 
-    tsp("cookie_cancel -> Cookies 1: ~p", [httpc:which_cookies()]),
-
     SetCookieHeaders = [{"set-cookie", "test_cookie=true; path=/;" 
 			 "max-age=60000"}],
     httpc:store_cookies(SetCookieHeaders, ?URL),
@@ -204,155 +146,60 @@ cookie_cancel(Config) when is_list(Config) ->
     NewSetCookieHeaders = 
 	[{"set-cookie", "test_cookie=true; path=/;max-age=0"}],
     httpc:store_cookies(NewSetCookieHeaders, ?URL),
-    {"cookie", ""} = httpc:cookie_header(?URL),
+    {"cookie", ""} = httpc:cookie_header(?URL).
 
-    tsp("cookie_cancel -> Cookies 2: ~p", [httpc:which_cookies()]),
-    ok.
-
-cookie_expires(doc) -> 
-    ["Test that a cookie is not used when it has expired"];
-cookie_expires(suite) -> 
-    [];
+cookie_expires() -> 
+    [{doc, "Test that a cookie is not used when it has expired"}].
 cookie_expires(Config) when is_list(Config) -> 
-    tsp("cookie_expires -> Cookies 1: ~p", [httpc:which_cookies()]),
-
     SetCookieHeaders = [{"set-cookie", "test_cookie=true; path=/;" 
 			 "max-age=5"}],
     httpc:store_cookies(SetCookieHeaders, ?URL),
     {"cookie", "$Version=0; test_cookie=true; $Path=/"} = 
 	httpc:cookie_header(?URL),
-    test_server:sleep(10000),
-    {"cookie", ""} = httpc:cookie_header(?URL),
+    timer:sleep(10000),
+    {"cookie", ""} = httpc:cookie_header(?URL).
 
-    tsp("cookie_expires -> Cookies 2: ~p", [httpc:which_cookies()]),
-    ok.
-
-persistent_cookie(doc) ->
-    ["Test domian cookie attribute"];
-persistent_cookie(suite) ->
-    [];
+persistent_cookie() ->
+    [{doc, "Test domian cookie attribute"}].
 persistent_cookie(Config) when is_list(Config)->
-    tsp("persistent_cookie -> Cookies 1: ~p", [httpc:which_cookies()]),
-
     SetCookieHeaders = [{"set-cookie", "test_cookie=true; path=/;" 
 			 "max-age=60000"}],
     httpc:store_cookies(SetCookieHeaders, ?URL),
     {"cookie", "$Version=0; test_cookie=true; $Path=/"} = 
 	httpc:cookie_header(?URL),
-    CaseDir = ?config(case_top_dir, Config),
+    CaseDir = proplists:get_value(case_top_dir, Config),
     application:stop(inets),
     application:load(inets),
     application:set_env(inets, services, [{httpc, {default, CaseDir}}]),
     application:start(inets), 
     httpc:set_options([{cookies, enabled}]),
-    {"cookie","$Version=0; test_cookie=true; $Path=/"} = httpc:cookie_header(?URL),
+    {"cookie","$Version=0; test_cookie=true; $Path=/"} = httpc:cookie_header(?URL).
 
-    tsp("persistent_cookie -> Cookies 2: ~p", [httpc:which_cookies()]),
-    ok.
-
-
-domain_cookie(doc) ->
-    ["Test the domian cookie attribute"];
-domain_cookie(suite) ->
-    [];
+domain_cookie() ->
+    [{doc, "Test the domian cookie attribute"}].
 domain_cookie(Config) when is_list(Config) ->
-    tsp("domain_cookie -> Cookies 1: ~p", [httpc:which_cookies()]),
-
     SetCookieHeaders = [{"set-cookie", "test_cookie=true; path=/;" 
 			 "domain=.cookie.test.org"}],
     httpc:store_cookies(SetCookieHeaders, ?URL),
     {"cookie","$Version=0; test_cookie=true; $Path=/; "
      "$Domain=.cookie.test.org"} = 
-	httpc:cookie_header(?URL_DOMAIN),
+	httpc:cookie_header(?URL_DOMAIN).
 
-    tsp("domain_cookie -> Cookies 2: ~p", [httpc:which_cookies()]),
-    ok.
-
-
-secure_cookie(doc) ->
-    ["Test the secure cookie attribute"];
-secure_cookie(suite) ->
-    [];
+secure_cookie() ->
+    [{doc, "Test the secure cookie attribute"}].
 secure_cookie(Config) when is_list(Config) ->
-    tsp("secure_cookie -> entry with"
-	"~n   Config: ~p", [Config]),
-    
-    %% httpc:reset_cookies(), 
-
-    tsp("secure_cookie -> Cookies 1: ~p", [httpc:which_cookies()]),
-    
     SetCookieHeaders = [{"set-cookie", "test_cookie=true; path=/; secure"}],
-    tsp("secure_cookie -> store cookies (1)"),
     ok = httpc:store_cookies(SetCookieHeaders, ?URL),
-
-    tsp("secure_cookie -> Cookies 2: ~p", [httpc:which_cookies()]),
-
-    tsp("secure_cookie -> check cookie (secure)"),
     check_cookie("$Version=0; test_cookie=true; $Path=/", ?URL_SECURE), 
-	
-    tsp("secure_cookie -> check cookie (plain)"),
     check_cookie("", ?URL),
-
-    tsp("secure_cookie -> store cookies (2)"),
     SetCookieHeaders1 = [{"set-cookie", "test1_cookie=true; path=/; secure"}],
     ok = httpc:store_cookies(SetCookieHeaders1, ?URL),
-
-    tsp("secure_cookie -> Cookies 3: ~p", [httpc:which_cookies()]),
-
-    tsp("secure_cookie -> cookie header (3)"),
     check_cookie("$Version=0; test_cookie=true; $Path=/; "
 		 "test1_cookie=true; $Path=/",
-		 ?URL_SECURE), 
-%%     {"cookie","$Version=0; test_cookie=true; $Path=/; "
-%%      "test1_cookie=true; $Path=/"} = httpc:cookie_header(?URL_SECURE),
-
-    tsp("secure_cookie -> Cookies 4: ~p", [httpc:which_cookies()]),
-
-    tsp("secure_cookie -> done"),
-    ok.
+		 ?URL_SECURE).
     
-expect_cookie_header(No, ExpectedCookie) ->
-    case httpc:cookie_header(?URL) of
-	{"cookie", ExpectedCookie} ->
-	    ok;
-    	{"cookie", BadCookie} ->
-	    io:format("Bad Cookie ~w: "
-		      "~n   Expected: ~s"
-		      "~n   Received: ~s"
-		      "~n", [No, ExpectedCookie, BadCookie]),
-	    exit({bad_cookie_header, No, ExpectedCookie, BadCookie})
-    end.
-
-print_cookies(Pre) ->
-    io:format("~s: ", [Pre]),
-    print_cookies2(httpc:which_cookies()).
-
-print_cookies2([]) ->
-    ok;
-print_cookies2([{cookies, Cookies}|Rest]) ->
-    print_cookies3("Cookies", Cookies),
-    print_cookies2(Rest);
-print_cookies2([{session_cookies, Cookies}|Rest]) ->
-    print_cookies3("Session Cookies", Cookies),
-    print_cookies2(Rest);
-print_cookies2([_|Rest]) ->
-    print_cookies2(Rest).
-
-print_cookies3(Header, []) ->
-    io:format("   ~s: []", [Header]);
-print_cookies3(Header, Cookies) ->
-    io:format("   ~s: ", [Header]),
-    Prefix      = "      ", 
-    PrintCookie = 
-	fun(Cookie) -> 
-		io:format("~s", [httpc_cookie:image_of(Prefix, Cookie)]) 
-	end, 
-    lists:foreach(PrintCookie, Cookies).
-
-update_cookie(doc)->
-    ["Test that a (plain) cookie can be updated."];
-update_cookie(suite) ->
-    [];
+update_cookie()->
+    [{doc, "Test that a (plain) cookie can be updated."}].
 update_cookie(Config) when is_list(Config) ->
     print_cookies("Cookies before store"),
 
@@ -377,10 +224,8 @@ update_cookie(Config) when is_list(Config) ->
 	"test_cookie=false; $Path=/", 
     expect_cookie_header(2, ExpectCookie2).
 
-update_cookie_session(doc)->
-    ["Test that a session cookie can be updated."];
-update_cookie_session(suite) ->
-    [];
+update_cookie_session()->
+    [{doc, "Test that a session cookie can be updated."}].
 update_cookie_session(Config) when is_list(Config)->
     print_cookies("Cookies before store"),
 
@@ -400,23 +245,57 @@ update_cookie_session(Config) when is_list(Config)->
     expect_cookie_header(2, ExpectedCookie2).
     
 
-cookie_attributes(doc) -> 
-    ["Test attribute not covered by the other test cases"];
-cookie_attributes(suite) -> 
-    [];
+cookie_attributes() -> 
+    [{doc, "Test attribute not covered by the other test cases"}].
 cookie_attributes(Config) when is_list(Config) -> 
     SetCookieHeaders = [{"set-cookie", "test_cookie=true;version=1;"
 			 "comment=foobar; "%% Comment
 			 "foo=bar;" %% Nonsense should be ignored
 			 "max-age=60000"}],
     httpc:store_cookies(SetCookieHeaders, ?URL),
-    {"cookie","$Version=1; test_cookie=true"} = httpc:cookie_header(?URL),
-    ok.
+    {"cookie","$Version=1; test_cookie=true"} = httpc:cookie_header(?URL).
 
 
 %%--------------------------------------------------------------------
 %%% Internal functions
 %%--------------------------------------------------------------------
+print_cookies(Pre) ->
+    io:format("~s: ", [Pre]),
+    print_cookies2(httpc:which_cookies()).
+
+print_cookies2([]) ->
+    ok;
+print_cookies2([{cookies, Cookies}|Rest]) ->
+    print_cookies3("Cookies", Cookies),
+    print_cookies2(Rest);
+print_cookies2([{session_cookies, Cookies}|Rest]) ->
+    print_cookies3("Session Cookies", Cookies),
+    print_cookies2(Rest);
+print_cookies2([_|Rest]) ->
+    print_cookies2(Rest).
+
+print_cookies3(Header, []) ->
+    io:format("   ~s: []", [Header]);
+print_cookies3(Header, Cookies) ->
+    io:format("   ~s: ", [Header]),
+    Prefix      = "      ", 
+    PrintCookie = 
+	fun(Cookie) -> 
+		io:format("~s", [httpc_cookie:image_of(Prefix, Cookie)]) 
+	end, 
+    lists:foreach(PrintCookie, Cookies).
+
+expect_cookie_header(No, ExpectedCookie) ->
+    case httpc:cookie_header(?URL) of
+	{"cookie", ExpectedCookie} ->
+	    ok;
+    	{"cookie", BadCookie} ->
+	    io:format("Bad Cookie ~w: "
+		      "~n   Expected: ~s"
+		      "~n   Received: ~s"
+		      "~n", [No, ExpectedCookie, BadCookie]),
+	    exit({bad_cookie_header, No, ExpectedCookie, BadCookie})
+    end.
 
 check_cookie(Expect, URL) ->
     case httpc:cookie_header(URL) of
@@ -426,12 +305,12 @@ check_cookie(Expect, URL) ->
 	    case lists:prefix(Expect, Unexpected) of
 		true ->
 		    Extra = Unexpected -- Expect, 
-		    tsf({extra_cookie_info, Extra});
+		    ct:fail({extra_cookie_info, Extra});
 		false ->
-		    tsf({unknown_cookie, Expect, Unexpected})
+		    ct:fail({unknown_cookie, Expect, Unexpected})
 	    end;
 	Bad ->
-	    tsf({bad_cookies, Bad})
+	    ct:fail({bad_cookies, Bad})
     end.
 
 
@@ -509,11 +388,3 @@ month_str(11) ->"Nov";
 month_str(12) ->"Dec".
 
 
-tsp(F) ->
-    tsp(F, []).
-tsp(F, A) ->
-    test_server:format("~p ~p:" ++ F ++ "~n", [self(), ?MODULE | A]).
-
-tsf(Reason) ->
-    test_server:fail(Reason).
-