kernel: Clean up as suggested by tidier

1 files changed, 86 insertions, 105 deletions

diff --git a/lib/kernel/src/application_controller.erl b/lib/kernel/src/application_controller.erl
index 5277472ea6..42f527f400 100644
--- a/lib/kernel/src/application_controller.erl
+++ b/lib/kernel/src/application_controller.erl
@@ -40,7 +40,7 @@
 -export([test_change_apps/2]).
 
 -import(lists, [zf/2, map/2, foreach/2, foldl/3,
-		keysearch/3, keydelete/3, keyreplace/4]).
+		keyfind/3, keydelete/3, keyreplace/4]).
 
 -include("application_master.hrl").
 
@@ -524,7 +524,9 @@ init(Init, Kernel) ->
     end.
 
 
-%% Check the syntax of the .config file  [{ApplicationName, [{Parameter, Value}]}].
+%% Check the syntax of the .config file
+%%  [{ApplicationName, [{Parameter, Value}]}].
+
 check_conf_data([]) ->
     ok;
 check_conf_data(ConfData) when is_list(ConfData) ->
@@ -568,8 +570,8 @@ check_para_kernel([]) ->
     ok;
 check_para_kernel([{distributed, Apps} | ParaList]) when is_list(Apps) ->
     case check_distributed(Apps) of
-	{error, ErrorMsg} ->
-	    {error, ErrorMsg};
+	{error, _ErrorMsg} = Error ->
+	    Error;
 	_ ->
 	    check_para_kernel(ParaList)
     end;
@@ -633,9 +635,9 @@ handle_call({load_application, Application}, From, S) ->
 		false ->
 		    {reply, ok, NewS}
 	    end;
-	{error, Error} ->
-	    {reply, {error, Error}, S};
-	{'EXIT',R} -> 
+	{error, _} = Error ->
+	    {reply, Error, S};
+	{'EXIT', R} ->
 	    {reply, {error, R}, S}
     end;
 
@@ -660,7 +662,7 @@ handle_call({start_application, AppName, RestartType}, From, S) ->
     %% Incase of erroneous variables do not start the application,
     %% if the application is permanent crash the node.
     %% Check if the application is already starting.
-    case lists:keysearch(AppName, 1, Start_req) of
+    case lists:keyfind(AppName, 1, Start_req) of
 	false ->
 	    case catch check_start_cond(AppName, RestartType, Started, Running) of
 		{ok, Appl} ->
@@ -689,13 +691,12 @@ handle_call({start_application, AppName, RestartType}, From, S) ->
 				    {reply, ok, SS}
 			    end
 		    end;
-		{error, R} ->
-		    {reply, {error, R}, S}
+		{error, _R} = Error ->
+		    {reply, Error, S}
 	    end;
-	{value, {AppName, _FromX}} ->
+	{AppName, _FromX} ->
 	    SS = S#state{start_req = [{AppName, From} | Start_req]},
 	    {noreply, SS}
-	    
     end;
 
 handle_call({permit_application, AppName, Bool}, From, S) ->
@@ -769,11 +770,11 @@ handle_call({permit_application, AppName, Bool}, From, S) ->
 		    {noreply, SS};
 
 		%%==========================
-		%% unpermit the applicaition
+		%% unpermit the application
 		%%==========================
 		%% running
 		{false, _, _, _,  _, {value, {_AppName, Id}}} ->
-		    {value, {_AppName2, Type}} = keysearch(AppName, 1, Started),
+		    {_AppName2, Type} = lists:keyfind(AppName, 1, Started),
 		    stop_appl(AppName, Id, Type),
 		    NRunning = keydelete(AppName, 1, Running),
 		    {reply, ok, S#state{running = NRunning}};
@@ -803,9 +804,9 @@ handle_call({permit_application, AppName, Bool}, From, S) ->
 
 handle_call({stop_application, AppName}, _From, S) ->
     #state{running = Running, started = Started} = S,
-    case keysearch(AppName, 1, Running) of
-	{value, {_AppName, Id}} ->
-	    {value, {_AppName2, Type}} = keysearch(AppName, 1, Started),
+    case lists:keyfind(AppName, 1, Running) of
+	{_AppName, Id} ->
+	    {_AppName2, Type} = lists:keyfind(AppName, 1, Started),
 	    stop_appl(AppName, Id, Type),
 	    NRunning = keydelete(AppName, 1, Running),
 	    NStarted = keydelete(AppName, 1, Started),
@@ -831,8 +832,8 @@ handle_call({change_application_data, Applications, Config}, _From, S) ->
 			  end,
 			  []),
     case catch do_change_apps(Applications, Config, OldAppls) of
-	{error, R} ->
-	    {reply, {error, R}, S};
+	{error, _} = Error ->
+	    {reply, Error, S};
 	{'EXIT', R} ->
 	    {reply, {error, R}, S};
 	NewAppls ->
@@ -886,10 +887,10 @@ handle_call({control_application, AppName}, {Pid, _Tag}, S) ->
 
 handle_call({start_type, AppName}, _From, S) ->
     Starting = S#state.starting,
-    StartType = case keysearch(AppName, 1, Starting) of
+    StartType = case lists:keyfind(AppName, 1, Starting) of
 		    false ->
 			local;
-		    {value, {_AppName, _RestartType, Type, _F}} ->
+		    {_AppName, _RestartType, Type, _F} ->
 			Type
 		end,
     {reply, StartType, S};
@@ -913,7 +914,7 @@ handle_application_started(AppName, Res, S) ->
     #state{starting = Starting, running = Running, started = Started, 
 	   start_req = Start_req} = S,
     Start_reqN = reply_to_requester(AppName, Start_req, Res),
-    {value, {_AppName, RestartType, _Type, _From}} = keysearch(AppName, 1, Starting),
+    {_AppName, RestartType, _Type, _From} = lists:keyfind(AppName, 1, Starting),
     case Res of
 	{ok, Id} ->
 	    case AppName of
@@ -928,7 +929,6 @@ handle_application_started(AppName, Res, S) ->
 			    running = NRunning,
 			    started = NStarted,
 			    start_req = Start_reqN},
-
 	    %% The permission may have been changed during start
 	    Perm = application:get_env(kernel, permissions),
 	    case {Perm, Id} of
@@ -939,10 +939,10 @@ handle_application_started(AppName, Res, S) ->
 		    case lists:member({AppName, false}, Perms) of
 			true ->
 			    #state{running = StopRunning, started = StopStarted} = NewS,
-			    case keysearch(AppName, 1, StopRunning) of
-				{value, {_AppName, Id}} ->
-				    {value, {_AppName2, Type}} = 
-					keysearch(AppName, 1, StopStarted),
+			    case lists:keyfind(AppName, 1, StopRunning) of
+				{_AppName, Id} ->
+				    {_AppName2, Type} =
+					lists:keyfind(AppName, 1, StopStarted),
 				    stop_appl(AppName, Id, Type),
 				    NStopRunning = keydelete(AppName, 1, StopRunning),
 				    cntrl(AppName, NewS, {ac_application_stopped, AppName}),
@@ -957,12 +957,8 @@ handle_application_started(AppName, Res, S) ->
 		_ ->
 		    {noreply, NewS}
 	    end;
-
-
-
-
-	{error, R} when RestartType =:= temporary ->
-	    notify_cntrl_started(AppName, undefined, S, {error, R}),
+	{error, R} = Error when RestartType =:= temporary ->
+	    notify_cntrl_started(AppName, undefined, S, Error),
 	    info_exited(AppName, R, RestartType),
 	    {noreply, S#state{starting = keydelete(AppName, 1, Starting),
 			      start_req = Start_reqN}};
@@ -987,8 +983,8 @@ handle_application_started(AppName, Res, S) ->
 		    Reason = {application_start_failure, AppName, R},
 		    {stop, to_string(Reason), S}
 	    end;
-	{error, R} -> %% permanent
-	    notify_cntrl_started(AppName, undefined, S, {error, R}),
+	{error, R} = Error -> %% permanent
+	    notify_cntrl_started(AppName, undefined, S, Error),
 	    info_exited(AppName, R, RestartType),
 	    Reason = {application_start_failure, AppName, R},
 	    {stop, to_string(Reason), S};
@@ -1018,12 +1014,12 @@ handle_info({ac_load_application_reply, AppName, Res}, S) ->
 
 handle_info({ac_start_application_reply, AppName, Res}, S) ->
     Start_req = S#state.start_req,
-    case keysearch(AppName, 1, Starting = S#state.starting) of
-	{value, {_AppName, RestartType, Type, From}} ->
+    case lists:keyfind(AppName, 1, Starting = S#state.starting) of
+	{_AppName, RestartType, Type, From} ->
 	    case Res of
 		start_it ->
 		    {true, Appl} = get_loaded(AppName),
-		     spawn_starter(From, Appl, S, Type),
+		    spawn_starter(From, Appl, S, Type),
 		    {noreply, S};
 		{started, Node} ->
 		    handle_application_started(AppName, 
@@ -1037,23 +1033,19 @@ handle_info({ac_start_application_reply, AppName, Res}, S) ->
 		     S#state{starting = keydelete(AppName, 1, Starting),
 			     started = [{AppName, RestartType} | Started],
 			     start_req = Start_reqN}};
-		{takeover, Node} ->
+		{takeover, _Node} = Takeover ->
 		    {true, Appl} = get_loaded(AppName),
-		    spawn_starter(From, Appl, S, {takeover, Node}),
+		    spawn_starter(From, Appl, S, Takeover),
 		    NewStarting1 = keydelete(AppName, 1, Starting),
-		    NewStarting = [{AppName, RestartType, {takeover, Node}, From} | NewStarting1],
+		    NewStarting = [{AppName, RestartType, Takeover, From} | NewStarting1],
 		    {noreply, S#state{starting = NewStarting}};
-		{error, Reason} when RestartType =:= permanent ->
-		    Start_reqN =
-			reply_to_requester(AppName, Start_req,
-					   {error, Reason}),
+		{error, Reason} = Error when RestartType =:= permanent ->
+		    Start_reqN = reply_to_requester(AppName, Start_req, Error),
 		    {stop, to_string(Reason), S#state{start_req = Start_reqN}};
-		{error, Reason} ->
-		    Start_reqN =
-			reply_to_requester(AppName, Start_req,
-					   {error, Reason}),
+		{error, _Reason} = Error ->
+		    Start_reqN = reply_to_requester(AppName, Start_req, Error),
 		    {noreply, S#state{starting =
-				      keydelete(AppName, 1, Starting),
+					  keydelete(AppName, 1, Starting),
 				      start_req = Start_reqN}}
 	    end;
 	false ->
@@ -1064,8 +1056,8 @@ handle_info({ac_change_application_req, AppName, Msg}, S) ->
     Running = S#state.running,
     Started = S#state.started,
     Starting = S#state.starting,
-    case {keysearch(AppName, 1, Running), keysearch(AppName, 1, Started)} of
-	{{value, {AppName, Id}}, {value, {_AppName2, Type}}} ->
+    case {keyfind(AppName, 1, Running), keyfind(AppName, 1, Started)} of
+	{{AppName, Id}, {_AppName2, Type}} ->
 	    case Msg of
 		{started, Node} ->
 		    stop_appl(AppName, Id, Type),
@@ -1158,17 +1150,17 @@ handle_info({'EXIT', Pid, Reason}, S) ->
     ets:match_delete(ac_tab, {{application_master, '_'}, Pid}),
     NRunning = keydelete(Pid, 2, S#state.running),
     NewS = S#state{running = NRunning},
-    case keysearch(Pid, 2, S#state.running) of
-	{value, {AppName, _AmPid}} ->
+    case lists:keyfind(Pid, 2, S#state.running) of
+	{AppName, _AmPid} ->
 	    cntrl(AppName, S, {ac_application_stopped, AppName}),
-	    case keysearch(AppName, 1, S#state.started) of
-		{value, {_AppName, temporary}} ->
+	    case lists:keyfind(AppName, 1, S#state.started) of
+		{_AppName, temporary} ->
 		    info_exited(AppName, Reason, temporary),
 		    {noreply, NewS};
-		{value, {_AppName, transient}} when Reason =:= normal ->
+		{_AppName, transient} when Reason =:= normal ->
 		    info_exited(AppName, Reason, transient),
 		    {noreply, NewS};
-		{value, {_AppName, Type}} ->
+		{_AppName, Type} ->
 		    info_exited(AppName, Reason, Type),
 		    {stop, to_string({application_terminated, AppName, Reason}), NewS}
 	    end;
@@ -1209,8 +1201,8 @@ code_change(_OldVsn, State, _Extra) ->
 %%% Internal functions
 %%%-----------------------------------------------------------------
 cntrl(AppName, #state{control = Control}, Msg) ->
-    case keysearch(AppName, 1, Control) of
-	{value, {_AppName, Pid}} ->
+    case lists:keyfind(AppName, 1, Control) of
+	{_AppName, Pid} ->
 	    Pid ! Msg,
 	    true;
 	false -> 
@@ -1310,8 +1302,8 @@ check_start_cond(AppName, RestartType, Started, Running) ->
     end.
 
 do_start(AppName, RT, Type, From, S) ->
-    RestartType = case keysearch(AppName, 1, S#state.started) of
-		      {value, {_AppName2, OldRT}} ->
+    RestartType = case lists:keyfind(AppName, 1, S#state.started) of
+		      {_AppName2, OldRT} ->
 			  get_restart_type(RT, OldRT);
 		      false ->
 			  RT
@@ -1323,12 +1315,12 @@ do_start(AppName, RT, Type, From, S) ->
 	    {true, Appl} = get_loaded(AppName),
 	    Start_req = S#state.start_req,
 	    spawn_starter(undefined, Appl, S, Type),
-	    Starting = case keysearch(AppName, 1, S#state.starting) of
+	    Starting = case lists:keymember(AppName, 1, S#state.starting) of
 			   false ->
 			       %% UW: don't know if this is necessary
 			       [{AppName, RestartType, Type, From} | 
 				S#state.starting];
-			   _ ->
+			   true ->
 			       S#state.starting
 		       end,
 	    S#state{starting = Starting, 
@@ -1368,10 +1360,10 @@ start_appl(Appl, S, Type) ->
 		      end
 	      end, Appl#appl.apps),
 	    case application_master:start_link(ApplData, Type) of
-		{ok, Pid} ->
-		    {ok, Pid};
-		{error, Reason} ->
-		    throw({error, Reason})
+		{ok, _Pid} = Ok ->
+		    Ok;
+		{error, _Reason} = Error ->
+		    throw(Error)
 	    end
     end.
 
@@ -1463,15 +1455,15 @@ prim_parse(Tokens, Acc) ->
 	    case erl_parse:parse_term(Tokens2 ++ [Dot]) of
 		{ok, Term} ->
 		    prim_parse(Rest, [Term | Acc]);
-		{error, Reason} ->
-		    {error, Reason}
+		{error, _R} = Error ->
+		    Error
 	    end;
 	{Tokens2, []} ->
 	    case erl_parse:parse_term(Tokens2) of
 		{ok, Term} ->
 		    {ok, lists:reverse([Term | Acc])};
-		{error, Reason} ->
-		    {error, Reason}
+		{error, _R} = Error ->
+		    Error
 	    end
     end.
 
@@ -1484,7 +1476,7 @@ make_appl_i({application, Name, Opts}) when is_atom(Name), is_list(Opts) ->
     Apps = get_opt(applications, Opts, []),
     Mod =
 	case get_opt(mod, Opts, []) of
-	    {M,A} when is_atom(M) -> {M,A};
+	    {M,_A}=MA when is_atom(M) -> MA;
 	    [] -> [];
 	    Other -> throw({error, {badstartspec, Other}})
 	end,
@@ -1493,8 +1485,8 @@ make_appl_i({application, Name, Opts}) when is_atom(Name), is_list(Opts) ->
     MaxP = get_opt(maxP, Opts, infinity),
     MaxT = get_opt(maxT, Opts, infinity),
     IncApps = get_opt(included_applications, Opts, []),
-    {#appl_data{name = Name, regs = Regs, mod = Mod, phases = Phases, mods = Mods,
-		inc_apps = IncApps, maxP = MaxP, maxT = MaxT},
+    {#appl_data{name = Name, regs = Regs, mod = Mod, phases = Phases,
+		mods = Mods, inc_apps = IncApps, maxP = MaxP, maxT = MaxT},
      Env, IncApps, Descr, Id, Vsn, Apps};
 make_appl_i({application, Name, Opts}) when is_list(Opts) ->
     throw({error,{invalid_name,Name}});
@@ -1573,12 +1565,12 @@ do_change_appl({ok, {ApplData, Env, IncApps, Descr, Id, Vsn, Apps}},
 		 vsn=Vsn,
 		 inc_apps=IncApps,
 		 apps=Apps};
-do_change_appl({error, R}, _Appl, _ConfData) ->
-    throw({error, R}).
+do_change_appl({error, _R} = Error, _Appl, _ConfData) ->
+    throw(Error).
 
 get_opt(Key, List, Default) ->
-    case keysearch(Key, 1, List) of
-	{value, {_Key, Val}} -> Val;
+    case lists:keyfind(Key, 1, List) of
+	{_Key, Val} -> Val;
 	_ -> Default
     end.
 
@@ -1612,8 +1604,8 @@ make_term(Str) ->
     end.
 
 get_env_i(Name, #state{conf_data = ConfData}) when is_list(ConfData) ->
-    case keysearch(Name, 1, ConfData) of
-	{value, {_Name, Env}} -> Env;
+    case lists:keyfind(Name, 1, ConfData) of
+	{_Name, Env} -> Env;
 	_ -> []
     end;
 get_env_i(_Name, _) -> [].
@@ -1633,9 +1625,6 @@ merge_env([{App, AppEnv1} | T], Env2, Res) ->
 merge_env([], Env2, Res) ->
     Env2 ++ Res.
 
-
-    
-
 %% Merges envs for an application.  Env2 overrides Env1
 merge_app_env(Env1, Env2) ->
     merge_app_env(Env1, Env2, []).
@@ -1699,13 +1688,12 @@ do_config_change([], _EnvBefore, Errors) ->
     {error, Errors};
 do_config_change([{App, _Id} | Apps], EnvBefore, Errors) ->
     AppEnvNow = lists:sort(application:get_all_env(App)),
-    AppEnvBefore = case lists:keysearch(App, 1, EnvBefore) of
+    AppEnvBefore = case lists:keyfind(App, 1, EnvBefore) of
 		       false ->
 			   [];
-		       {value, {App, AppEnvBeforeT}} ->
+		       {App, AppEnvBeforeT} ->
 			   lists:sort(AppEnvBeforeT)
 		   end,
-
     Res = 
 	case AppEnvNow of
 	    AppEnvBefore ->
@@ -1725,12 +1713,12 @@ do_config_change([{App, _Id} | Apps], EnvBefore, Errors) ->
 				    %% if the cb-function is not defined 
 				    {'EXIT', {undef, _}} ->
 					ok;
-				    {error, Error} ->
-					{error, Error};
+				    {error, _} = Error ->
+					Error;
 				    Else ->
 					{error, Else}
 				end;
-			    {ok,[]} ->
+			    {ok, []} ->
 				{error, {module_not_defined, App}};
 			    undefined ->
 				{error, {application_not_found, App}}
@@ -1744,9 +1732,7 @@ do_config_change([{App, _Id} | Apps], EnvBefore, Errors) ->
 	{error, NewError} ->
 	    do_config_change(Apps, EnvBefore,[NewError | Errors])
     end.
-	    
-	    
-   
+
 
 %%-----------------------------------------------------------------
 %% Check if the configuration is changed in anyway.
@@ -1760,21 +1746,17 @@ do_config_diff([], AppEnvBefore, {Changed, New}) ->
 do_config_diff(AppEnvNow, [], {Changed, New}) ->
     {Changed, AppEnvNow++New, []};
 do_config_diff([{Env, Value} | AppEnvNow], AppEnvBefore, {Changed, New}) ->
-    case lists:keysearch(Env, 1, AppEnvBefore) of
-	{value, {Env, Value}} ->
+    case lists:keyfind(Env, 1, AppEnvBefore) of
+	{Env, Value} ->
 	    do_config_diff(AppEnvNow, lists:keydelete(Env,1,AppEnvBefore), {Changed, New});
-	{value, {Env, _OtherValue}} ->
+	{Env, _OtherValue} ->
 	    do_config_diff(AppEnvNow, lists:keydelete(Env,1,AppEnvBefore), 
 			   {[{Env, Value} | Changed], New});
 	false ->
 	    do_config_diff(AppEnvNow, AppEnvBefore, {Changed, [{Env, Value}|New]})
     end.
-    
 
 
-
-    
-
 %%-----------------------------------------------------------------
 %% Read the .config files.
 %%-----------------------------------------------------------------
@@ -1929,14 +1911,13 @@ reply_to_requester(AppName, Start_req, Res) ->
 %% Update the environment variable permission for an application.  
 %%-----------------------------------------------------------------
 update_permissions(AppName, Bool) ->
-    case ets:lookup(ac_tab, {env, kernel, permissions}) of
+    T = {env, kernel, permissions},
+    case ets:lookup(ac_tab, T) of
 	[] ->
-	    ets:insert(ac_tab, {{env, kernel, permissions}, 
-				[{AppName, Bool}]});
+	    ets:insert(ac_tab, {T, [{AppName, Bool}]});
 	[{_, Perm}] ->
 	    Perm2 = lists:keydelete(AppName, 1, Perm),
-	    ets:insert(ac_tab, {{env, kernel, permissions}, 
-				[{AppName, Bool}| Perm2]})
+	    ets:insert(ac_tab, {T, [{AppName, Bool}|Perm2]})
     end.
 
 %%-----------------------------------------------------------------