kernel: inet6_tcp_dist: reuse inet_tcp_dist code

inet6_tcp_dist module is an old copy of inet_tcp_dist with changed
address family.
New features (such as listening port range, interface and generic
options) are implemented in inet_tcp_dist only, inet6_tcp_dist looks
abandoned (it does not even have tests).
This patch makes inet_tcp_dist internals work with abstract driver,
and inet6_tcp_dist becomes just a thin wrapper for it.

1 files changed, 6 insertions, 359 deletions

diff --git a/lib/kernel/src/inet6_tcp_dist.erl b/lib/kernel/src/inet6_tcp_dist.erl
index 459fdc2ad5..1488bf41f3 100644
--- a/lib/kernel/src/inet6_tcp_dist.erl
+++ b/lib/kernel/src/inet6_tcp_dist.erl
@@ -23,28 +23,6 @@
 -export([listen/1, accept/1, accept_connection/5,
          setup/5, close/1, select/1, is_node_name/1]).
 
-%% internal exports
-
--export([accept_loop/2,do_accept/6,do_setup/6, getstat/1,tick/1]).
-
--import(error_logger,[error_msg/2]).
-
--include("net_address.hrl").
-
-
-
--define(to_port(Socket, Data, Opts),
-        case inet6_tcp:send(Socket, Data, Opts) of
-            {error, closed} ->
-                self() ! {tcp_closed, Socket},
-                {error, closed};
-            R ->
-                R
-        end).
-
-
--include("dist.hrl").
--include("dist_util.hrl").
 
 %% ------------------------------------------------------------
 %%  Select this protocol based on node name
@@ -52,14 +30,7 @@
 %% ------------------------------------------------------------
 
 select(Node) ->
-    case split_node(atom_to_list(Node), $@, []) of
-        [_, Host] ->
-            case inet:getaddr(Host,inet6) of
-                {ok,_} -> true;
-                _ -> false
-            end;
-        _ -> false
-    end.
+    inet_tcp_dist:gen_select(inet6_tcp, Node).
 
 %% ------------------------------------------------------------
 %% Create the listen socket, i.e. the port that this erlang
@@ -67,59 +38,14 @@ select(Node) ->
 %% ------------------------------------------------------------
 
 listen(Name) ->
-    case inet6_tcp:listen(0, [{active, false}, {packet,2}]) of
-        {ok, Socket} ->
-            TcpAddress = get_tcp_address(Socket),
-            {_,Port} = TcpAddress#net_address.address,
-            case erl_epmd:register_node(Name, Port) of
-                {ok, Creation} ->
-                    {ok, {Socket, TcpAddress, Creation}};
-                Error ->
-                    Error
-            end;
-        Error ->
-            Error
-    end.
+    inet_tcp_dist:gen_listen(inet6_tcp, Name).
 
 %% ------------------------------------------------------------
 %% Accepts new connection attempts from other Erlang nodes.
 %% ------------------------------------------------------------
 
 accept(Listen) ->
-    spawn_opt(?MODULE, accept_loop, [self(), Listen], [link, {priority, max}]).
-
-accept_loop(Kernel, Listen) ->
-    case inet6_tcp:accept(Listen) of
-        {ok, Socket} ->
-            Kernel ! {accept,self(),Socket,inet6,tcp},
-            _ = controller(Kernel, Socket),
-            accept_loop(Kernel, Listen);
-        Error ->
-            exit(Error)
-    end.
-
-controller(Kernel, Socket) ->
-    receive
-        {Kernel, controller, Pid} ->
-            flush_controller(Pid, Socket),
-            inet6_tcp:controlling_process(Socket, Pid),
-            flush_controller(Pid, Socket),
-            Pid ! {self(), controller};
-        {Kernel, unsupported_protocol} ->
-            exit(unsupported_protocol)
-    end.
-
-flush_controller(Pid, Socket) ->
-    receive
-        {tcp, Socket, Data} ->
-            Pid ! {tcp, Socket, Data},
-            flush_controller(Pid, Socket);
-        {tcp_closed, Socket} ->
-            Pid ! {tcp_closed, Socket},
-            flush_controller(Pid, Socket)
-    after 0 ->
-            ok
-    end.
+    inet_tcp_dist:gen_accept(inet6_tcp, Listen).
 
 %% ------------------------------------------------------------
 %% Accepts a new connection attempt from another Erlang node.
@@ -127,85 +53,7 @@ flush_controller(Pid, Socket) ->
 %% ------------------------------------------------------------
 
 accept_connection(AcceptPid, Socket, MyNode, Allowed, SetupTime) ->
-    spawn_opt(?MODULE, do_accept,
-	      [self(), AcceptPid, Socket, MyNode, Allowed, SetupTime],
-	      [link, {priority, max}]).
-
-do_accept(Kernel, AcceptPid, Socket, MyNode, Allowed, SetupTime) ->
-    receive
-        {AcceptPid, controller} ->
-            Timer = dist_util:start_timer(SetupTime),
-            case check_ip(Socket) of
-                true ->
-                    HSData = #hs_data{
-                      kernel_pid = Kernel,
-                      this_node = MyNode,
-                      socket = Socket,
-                      timer = Timer,
-                      this_flags = 0,
-                      allowed = Allowed,
-                      f_send = fun(S,D) -> inet6_tcp:send(S,D) end,
-                      f_recv = fun(S,N,T) -> inet6_tcp:recv(S,N,T) 
-                               end,
-                      f_setopts_pre_nodeup = 
-                      fun(S) ->
-                              inet:setopts(S, 
-                                           [{active, false},
-                                            {packet, 4},
-                                            nodelay()])
-                      end,
-                      f_setopts_post_nodeup = 
-                      fun(S) ->
-                              inet:setopts(S, 
-                                           [{active, true},
-                                            {deliver, port},
-                                            {packet, 4},
-                                            nodelay()])
-                      end,
-                      f_getll = fun(S) ->
-                                        inet:getll(S)
-                                end,
-                      f_address = fun get_remote_id/2,
-                      mf_tick = fun ?MODULE:tick/1,
-                      mf_getstat = fun ?MODULE:getstat/1
-                     },
-                    dist_util:handshake_other_started(HSData);
-                {false,IP} ->
-                    error_msg("** Connection attempt from "
-                              "disallowed IP ~w ** ~n", [IP]),
-                    ?shutdown(no_node)
-            end
-    end.
-
-
-%% we may not always want the nodelay behaviour
-%% for performance reasons
-
-nodelay() ->
-    case application:get_env(kernel, dist_nodelay) of
-        undefined ->
-            {nodelay, true};
-        {ok, true} ->
-            {nodelay, true};
-        {ok, false} ->
-            {nodelay, false};
-        _ ->
-            {nodelay, true}
-    end.
-            
-
-%% ------------------------------------------------------------
-%% Get remote information about a Socket.
-%% ------------------------------------------------------------
-
-get_remote_id(Socket, Node) ->
-    {ok, Address} = inet:peername(Socket),
-    [_, Host] = split_node(atom_to_list(Node), $@, []),
-    #net_address {
-                  address = Address,
-                  host = Host,
-                  protocol = tcp,
-                  family = inet6 }.
+    inet_tcp_dist:gen_accept_connection(inet6_tcp, AcceptPid, Socket, MyNode, Allowed, SetupTime).
 
 %% ------------------------------------------------------------
 %% Setup a new connection to another Erlang node.
@@ -213,214 +61,13 @@ get_remote_id(Socket, Node) ->
 %% ------------------------------------------------------------
 
 setup(Node, Type, MyNode, LongOrShortNames,SetupTime) ->
-    spawn_opt(?MODULE, do_setup, 
-	      [self(), Node, Type, MyNode, LongOrShortNames, SetupTime],
-	      [link, {priority, max}]).
-
-do_setup(Kernel, Node, Type, MyNode, LongOrShortNames,SetupTime) ->
-    ?trace("~p~n",[{?MODULE,self(),setup,Node}]),
-    [Name, Address] = splitnode(Node, LongOrShortNames),
-    case inet:getaddr(Address, inet6) of
-        {ok, Ip} ->
-            Timer = dist_util:start_timer(SetupTime),
-            case erl_epmd:port_please(Name, Ip) of
-                {port, TcpPort, Version} ->
-                    ?trace("port_please(~p) -> version ~p~n", 
-                           [Node,Version]),
-                    dist_util:reset_timer(Timer),
-                    case inet6_tcp:connect(Ip, TcpPort, 
-                                          [{active, false}, 
-                                           {packet,2}]) of
-                        {ok, Socket} ->
-                            HSData = #hs_data{
-                              kernel_pid = Kernel,
-                              other_node = Node,
-                              this_node = MyNode,
-                              socket = Socket,
-                              timer = Timer,
-                              this_flags = 0,
-                              other_version = Version,
-			      f_send = fun inet6_tcp:send/2,
-			      f_recv = fun inet6_tcp:recv/3,
-                              f_setopts_pre_nodeup = 
-                              fun(S) ->
-                                      inet:setopts
-                                        (S, 
-                                         [{active, false},
-                                          {packet, 4},
-                                          nodelay()])
-                              end,
-                              f_setopts_post_nodeup = 
-                              fun(S) ->
-                                      inet:setopts
-                                        (S, 
-                                         [{active, true},
-                                          {deliver, port},
-                                          {packet, 4},
-                                          nodelay()])
-                              end,
-			      f_getll = fun inet:getll/1,
-                              f_address = 
-                              fun(_,_) ->
-                                      #net_address {
-                                   address = {Ip,TcpPort},
-                                   host = Address,
-                                   protocol = tcp,
-                                   family = inet6}
-                              end,
-			      mf_tick = fun ?MODULE:tick/1,
-			      mf_getstat = fun ?MODULE:getstat/1,
-			      request_type = Type
-                             },
-                            dist_util:handshake_we_started(HSData);
-                        _ ->
-                            %% Other Node may have closed since 
-                            %% port_please !
-                            ?trace("other node (~p) "
-                                   "closed since port_please.~n", 
-                                   [Node]),
-                            ?shutdown(Node)
-                    end;
-                _ ->
-                    ?trace("port_please (~p) "
-                           "failed.~n", [Node]),
-                    ?shutdown(Node)
-            end;
-        __Other ->
-            ?trace("inet_getaddr(~p) "
-                   "failed (~p).~n", [Node,__Other]),
-            ?shutdown(Node)
-    end.
+    inet_tcp_dist:gen_setup(inet6_tcp, Node, Type, MyNode, LongOrShortNames, SetupTime).
 
 %%
 %% Close a socket.
 %%
 close(Socket) ->
     inet6_tcp:close(Socket).
-
-
-%% If Node is illegal terminate the connection setup!!
-splitnode(Node, LongOrShortNames) ->
-    case split_node(atom_to_list(Node), $@, []) of
-        [Name|Tail] when Tail =/= [] ->
-            Host = lists:append(Tail),
-            case split_node(Host, $., []) of
-                [_] when LongOrShortNames =:= longnames ->
-                    case inet_parse:ipv6strict_address(Host) of
-                        {ok, _} ->
-                            [Name, Host];
-                        _ ->
-                            error_msg("** System running to use "
-                                      "fully qualified "
-                                      "hostnames **~n"
-                                      "** Hostname ~s is illegal **~n",
-                                      [Host]),
-                            ?shutdown(Node)
-                    end;
-                L when length(L) > 1, LongOrShortNames =:= shortnames ->
-                    error_msg("** System NOT running to use fully qualified "
-                              "hostnames **~n"
-                              "** Hostname ~s is illegal **~n",
-                              [Host]),
-                    ?shutdown(Node);
-                _ ->
-                    [Name, Host]
-            end;
-        [_] ->
-            error_msg("** Nodename ~p illegal, no '@' character **~n",
-                      [Node]),
-            ?shutdown(Node);
-        _ ->
-            error_msg("** Nodename ~p illegal **~n", [Node]),
-            ?shutdown(Node)
-    end.
-
-split_node([Chr|T], Chr, Ack) -> [lists:reverse(Ack)|split_node(T, Chr, [])];
-split_node([H|T], Chr, Ack)   -> split_node(T, Chr, [H|Ack]);
-split_node([], _, Ack)        -> [lists:reverse(Ack)].
-
-%% ------------------------------------------------------------
-%% Fetch local information about a Socket.
-%% ------------------------------------------------------------
-get_tcp_address(Socket) ->
-    {ok, Address} = inet:sockname(Socket),
-    {ok, Host} = inet:gethostname(),
-    #net_address {
-                  address = Address,
-                  host = Host,
-                  protocol = tcp,
-                  family = inet6
-                 }.
-
-%% ------------------------------------------------------------
-%% Do only accept new connection attempts from nodes at our
-%% own LAN, if the check_ip environment parameter is true.
-%% ------------------------------------------------------------
-check_ip(Socket) ->
-    case application:get_env(check_ip) of
-        {ok, true} ->
-            case get_ifs(Socket) of
-                {ok, IFs, IP} ->
-                    check_ip(IFs, IP);
-                _ ->
-                    ?shutdown(no_node)
-            end;
-        _ ->
-            true
-    end.
-
-get_ifs(Socket) ->
-    case inet:peername(Socket) of
-        {ok, {IP, _}} ->
-            case inet:getif(Socket) of
-                {ok, IFs} -> {ok, IFs, IP};
-                Error     -> Error
-            end;
-        Error ->
-            Error
-    end.
-
-check_ip([{OwnIP, _, Netmask}|IFs], PeerIP) ->
-    case {mask(Netmask, PeerIP), mask(Netmask, OwnIP)} of
-        {M, M} -> true;
-        _      -> check_ip(IFs, PeerIP)
-    end;
-check_ip([], PeerIP) ->
-    {false, PeerIP}.
     
-mask({M1,M2,M3,M4,M5,M6,M7,M8}, {IP1,IP2,IP3,IP4,IP5,IP6,IP7,IP8}) ->
-    {M1 band IP1,
-     M2 band IP2,
-     M3 band IP3,
-     M4 band IP4,
-     M5 band IP5,
-     M6 band IP6,
-     M7 band IP7,
-     M8 band IP8 }.
-
 is_node_name(Node) when is_atom(Node) ->
-    case split_node(atom_to_list(Node), $@, []) of
-        [_,_Host] -> true;
-        _ -> false
-    end;
-is_node_name(_Node) ->
-    false.
-tick(Sock) ->
-    ?to_port(Sock,[],[force]).
-getstat(Socket) ->
-    case inet:getstat(Socket, [recv_cnt, send_cnt, send_pend]) of
-        {ok, Stat} ->
-            split_stat(Stat,0,0,0);
-        Error ->
-            Error
-    end.
-
-split_stat([{recv_cnt, R}|Stat], _, W, P) ->
-    split_stat(Stat, R, W, P);
-split_stat([{send_cnt, W}|Stat], R, _, P) ->
-    split_stat(Stat, R, W, P);
-split_stat([{send_pend, P}|Stat], R, W, _) ->
-    split_stat(Stat, R, W, P);
-split_stat([], R, W, P) ->
-    {ok, R, W, P}.
-
+    inet_tcp_dist:is_node_name(Node).