aboutsummaryrefslogtreecommitdiffstats
path: root/lib/kernel/test/file_SUITE.erl
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2010-05-05 17:51:24 +0200
committerBjörn Gustavsson <[email protected]>2010-05-05 18:03:36 +0200
commit748ba3a9c58a5a12a1423fd0311d8c681e38169e (patch)
tree1ba5bdfe02a54c7916956e8bdafaa7cf3df410fd /lib/kernel/test/file_SUITE.erl
parentc032d352a8610b47b2e88fd871d5047468240f16 (diff)
downloadotp-748ba3a9c58a5a12a1423fd0311d8c681e38169e.tar.gz
otp-748ba3a9c58a5a12a1423fd0311d8c681e38169e.tar.bz2
otp-748ba3a9c58a5a12a1423fd0311d8c681e38169e.zip
Adjust test of file:del_dir("..") to accept {error,einval}
On FreeBSD, file:del_dir("..") will return {error,einval} rather than the expected {error,eexist}, and so will file:del_dir("../.."), and so on. It could be argued that we should change the implementation of file:del_dir/1 to remap the error code (as some other error codes are remapped to reduce the differences between different platforms), but the consistency gained does not seem to be worth the effort. Therefore, until we'll find a real-world use case where it is essential to have consistent error codes for file:del_dir("..") on all platforms, change the test case to accept both errors.
Diffstat (limited to 'lib/kernel/test/file_SUITE.erl')
-rw-r--r--lib/kernel/test/file_SUITE.erl5
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/kernel/test/file_SUITE.erl b/lib/kernel/test/file_SUITE.erl
index d01e1f1fcf..1d170790a3 100644
--- a/lib/kernel/test/file_SUITE.erl
+++ b/lib/kernel/test/file_SUITE.erl
@@ -270,7 +270,10 @@ make_del_dir(Config) when is_list(Config) ->
%% Try deleting some bad directories
%% Deleting the parent directory to the current, sounds dangerous, huh?
%% Don't worry ;-) the parent directory should never be empty, right?
- ?line {error, eexist} = ?FILE_MODULE:del_dir('..'),
+ case ?FILE_MODULE:del_dir('..') of
+ {error, eexist} -> ok;
+ {error, einval} -> ok %FreeBSD
+ end,
?line {error, enoent} = ?FILE_MODULE:del_dir(""),
?line {error, badarg} = ?FILE_MODULE:del_dir([3,2,1,{}]),