Merge branch 'bjorn/kernel/modernize-tests'

* bjorn/kernel/modernize-tests:
  Remove ?line macros
  Fix comments
  gen_tcp_misc_SUITE: Use unique node names
  Eliminate use of the ?t macro
  Eliminate use of doc and suite clauses
  Replace use of test_server:capture*/0 with ct:capture*/0
  Eliminate use test_server:format()
  Eliminate use of test_server:sleep/1
  Eliminate use of test_server:fail/0,1
  Eliminate use of ?config() macro
  Modernize timetraps
  disk_log_SUITE: Remove vestiges of VxWorks support

Conflicts:
	lib/kernel/test/code_SUITE.erl

1 files changed, 244 insertions, 312 deletions

diff --git a/lib/kernel/test/init_SUITE.erl b/lib/kernel/test/init_SUITE.erl
index cb531f7b57..0fa97b585c 100644
--- a/lib/kernel/test/init_SUITE.erl
+++ b/lib/kernel/test/init_SUITE.erl
@@ -25,7 +25,7 @@
 	 init_per_group/2,end_per_group/2]).
 
 -export([get_arguments/1, get_argument/1, boot_var/1, restart/1,
-	 many_restarts/1,
+	 many_restarts/0, many_restarts/1,
 	 get_plain_arguments/1,
 	 reboot/1, stop/1, get_status/1, script_id/1]).
 -export([boot1/1, boot2/1]).
@@ -41,7 +41,9 @@
 %% Should be started in a CC view with:
 %% erl -sname master -rsh ctrsh
 %%-----------------------------------------------------------------
-suite() -> [{ct_hooks,[ts_install_cth]}].
+suite() ->
+    [{ct_hooks,[ts_install_cth]},
+     {timetrap,{minutes,2}}].
 
 all() -> 
     [get_arguments, get_argument, boot_var,
@@ -65,46 +67,35 @@ end_per_group(_GroupName, Config) ->
     Config.
 
 
-init_per_testcase(Func, Config) when is_atom(Func), is_list(Config) ->
-    Dog=?t:timetrap(?t:seconds(?DEFAULT_TIMEOUT_SEC)),
-    [{watchdog, Dog}|Config].
+init_per_testcase(Func, Config) ->
+    Config.
 
-end_per_testcase(_Func, Config) ->
-    Dog=?config(watchdog, Config),
-    ?t:timetrap_cancel(Dog).
+end_per_testcase(_Func, _Config) ->
+    ok.
 
-init(doc) -> [];
-init(suite) -> [];
 init(Config) when is_list(Config) ->
     Config.
 
-fini(doc) -> [];
-fini(suite) -> [];
 fini(Config) when is_list(Config) ->
     Host = list_to_atom(from($@, atom_to_list(node()))),
     Node = list_to_atom(lists:concat([init_test, "@", Host])),
     stop_node(Node),
     Config.
 
-get_arguments(doc) ->[];
-get_arguments(suite) -> {req, [distribution, {local_slave_nodes, 1}]};
 get_arguments(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(10)),
-
     Args = args(),
-    ?line {ok, Node} = start_node(init_test, Args),
-    ?line case rpc:call(Node, init, get_arguments, []) of
-	      Arguments when is_list(Arguments) ->
-		  stop_node(Node),
-		  check_a(Arguments),
-		  check_b(Arguments),
-		  check_c(Arguments),
-		  check_d(Arguments);
-	      _ ->
-		  stop_node(Node),
-		  ?t:fail(get_arguments)
-	  end,
-    ?line ?t:timetrap_cancel(Dog),
+    {ok, Node} = start_node(init_test, Args),
+    case rpc:call(Node, init, get_arguments, []) of
+	Arguments when is_list(Arguments) ->
+	    stop_node(Node),
+	    check_a(Arguments),
+	    check_b(Arguments),
+	    check_c(Arguments),
+	    check_d(Arguments);
+	_ ->
+	    stop_node(Node),
+	    ct:fail(get_arguments)
+    end,
     ok.
 
 check_a(Args) ->
@@ -115,10 +106,10 @@ check_a(Args) ->
 		false ->
 		    ok;
 		_ ->
-		    ?t:fail(check_a1)
+		    ct:fail(check_a1)
 	    end;
 	_ ->
-	    ?t:fail(check_a2)
+	    ct:fail(check_a2)
     end.
 
 check_b(Args) ->
@@ -132,13 +123,13 @@ check_b(Args) ->
 			false ->
 			    ok;
 			_ ->
-			    ?t:fail(check_b1)
+			    ct:fail(check_b1)
 		    end;
 		_ ->
-		    ?t:fail(check_b2)
+		    ct:fail(check_b2)
 	    end;
 	_ ->
-	    ?t:fail(check_b3)
+	    ct:fail(check_b3)
     end.
 
 check_c(Args) ->
@@ -152,13 +143,13 @@ check_c(Args) ->
 			false ->
 			    ok;
 			_ ->
-			    ?t:fail(check_c1)
+			    ct:fail(check_c1)
 		    end;
 		_ ->
-		    ?t:fail(check_c2)
+		    ct:fail(check_c2)
 	    end;
 	_ ->
-	    ?t:fail(check_c3)
+	    ct:fail(check_c3)
     end.
 
 check_d(Args) ->
@@ -169,62 +160,54 @@ check_d(Args) ->
 		false ->
 		    ok;
 		_ ->
-		    ?t:fail(check_d1)
+		    ct:fail(check_d1)
 	    end;
 	_ ->
-	    ?t:fail(check_d2)
+	    ct:fail(check_d2)
     end.
 
-get_argument(doc) ->[];
-get_argument(suite) -> {req, [distribution, {local_slave_nodes, 1}]};
 get_argument(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(10)),
-
     Args = args(),
-    ?line {ok, Node} = start_node(init_test, Args),
-    ?line case rpc:call(Node, init, get_argument, [b]) of
-	      {ok, [["hej", "hopp"],["san", "sa"]]} ->
-		  ok;
-	      _ ->
-		  stop_node(Node),
-		  ?t:fail({get_argument, b})
-	  end,
-    ?line case rpc:call(Node, init, get_argument, [a]) of
-	      {ok, [["kalle"]]} ->
-		  ok;
-	      _ ->
-		  stop_node(Node),
-		  ?t:fail({get_argument, a})
-	  end,
-    ?line case rpc:call(Node, init, get_argument, [c]) of
-	      {ok, [["4", "5", "6"], ["7", "8", "9"]]} ->
-		  ok;
-	      _ ->
-		  stop_node(Node),
-		  ?t:fail({get_argument, c})
-	  end,
-    ?line case rpc:call(Node, init, get_argument, [d]) of
-	      {ok, [[]]} ->
-		  ok;
-	      _ ->
-		  stop_node(Node),
-		  ?t:fail({get_argument, d})
-	  end,
-    ?line case rpc:call(Node, init, get_argument, [e]) of
-	      error ->
-		  ok;
-	      _ ->
-		  stop_node(Node),
-		  ?t:fail({get_argument, e})
-	  end,
+    {ok, Node} = start_node(init_test, Args),
+    case rpc:call(Node, init, get_argument, [b]) of
+	{ok, [["hej", "hopp"],["san", "sa"]]} ->
+	    ok;
+	_ ->
+	    stop_node(Node),
+	    ct:fail({get_argument, b})
+    end,
+    case rpc:call(Node, init, get_argument, [a]) of
+	{ok, [["kalle"]]} ->
+	    ok;
+	_ ->
+	    stop_node(Node),
+	    ct:fail({get_argument, a})
+    end,
+    case rpc:call(Node, init, get_argument, [c]) of
+	{ok, [["4", "5", "6"], ["7", "8", "9"]]} ->
+	    ok;
+	_ ->
+	    stop_node(Node),
+	    ct:fail({get_argument, c})
+    end,
+    case rpc:call(Node, init, get_argument, [d]) of
+	{ok, [[]]} ->
+	    ok;
+	_ ->
+	    stop_node(Node),
+	    ct:fail({get_argument, d})
+    end,
+    case rpc:call(Node, init, get_argument, [e]) of
+	error ->
+	    ok;
+	_ ->
+	    stop_node(Node),
+	    ct:fail({get_argument, e})
+    end,
     stop_node(Node),
-    ?line ?t:timetrap_cancel(Dog),
     ok.
 
-get_plain_arguments(doc) ->[];
-get_plain_arguments(suite) -> {req, [distribution, {local_slave_nodes, 1}]};
 get_plain_arguments(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(10)),
     Longstring = 
 	"fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2"
 	"fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2"
@@ -235,18 +218,17 @@ get_plain_arguments(Config) when is_list(Config) ->
 	"fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2"
 	"fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2"
 	"fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2fjdkfjdkfjfdaa2",
-    ?line true = (length(Longstring) > 255),
+    true = (length(Longstring) > 255),
     Args = long_args(Longstring),
-    ?line {ok, Node} = start_node(init_test, Args),
-    ?line case rpc:call(Node, init, get_plain_arguments, []) of
-	      ["a", "b", "c", Longstring] ->
-		  ok;
-	      As ->
-		  stop_node(Node),
-		  ?t:fail({get_argument, As})
-	  end,
+    {ok, Node} = start_node(init_test, Args),
+    case rpc:call(Node, init, get_plain_arguments, []) of
+	["a", "b", "c", Longstring] ->
+	    ok;
+	As ->
+	    stop_node(Node),
+	    ct:fail({get_argument, As})
+    end,
     stop_node(Node),
-    ?line ?t:timetrap_cancel(Dog),
 
     ok.
 
@@ -254,205 +236,182 @@ get_plain_arguments(Config) when is_list(Config) ->
 %% ------------------------------------------------
 %% Use -boot_var flag to set $TEST_VAR in boot script.
 %% ------------------------------------------------
-boot_var(doc) -> [];
-boot_var(suite) -> {req, [distribution, {local_slave_nodes, 1}]};
 boot_var(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(100)),
-
     {BootScript, TEST_VAR, KernelVsn, StdlibVsn} = create_boot(Config),
 
     %% Should fail as we have not given -boot_var TEST_VAR
-    ?line {error, timeout} =
-    start_node(init_test, "-boot " ++ BootScript),
+    {error, timeout} =
+	start_node(init_test, "-boot " ++ BootScript),
 
     case is_real_system(KernelVsn, StdlibVsn) of
 	true ->
 	    %% Now it should work !!
-	    ?line {ok, Node} =
-	    start_node(init_test,
-		"-boot " ++ BootScript ++
-		" -boot_var TEST_VAR " ++ TEST_VAR),
+	    {ok, Node} =
+		start_node(init_test,
+			   "-boot " ++ BootScript ++
+			       " -boot_var TEST_VAR " ++ TEST_VAR),
 	    stop_node(Node),
 	    Res = ok;
 	_ ->
 	    %% What we need is not so much version numbers on the directories, but
 	    %% for the boot var TEST_VAR to appear in the boot script, and it doesn't
 	    %% if we give the 'local' option to systools:make_script.
-	    ?t:format(
-		"Test case not complete as we are not~n"
-		"running in a real system!~n"
-		"Probably this test is performed in a "
-		"clearcase view or source tree.~n"
-		"Need version numbers on the kernel and "
-		"stdlib directories!~n",
-		[]),
+	    io:format(
+	      "Test case not complete as we are not~n"
+	      "running in a real system!~n"
+	      "Probably this test is performed in a "
+	      "clearcase view or source tree.~n"
+	      "Need version numbers on the kernel and "
+	      "stdlib directories!~n",
+	      []),
 	    Res = {skip,
-		"Test case only partially run since it is run "
-		"in a clearcase view or in a source tree. "
-		"Need an installed system to complete this test."}
+		   "Test case only partially run since it is run "
+		   "in a clearcase view or in a source tree. "
+		   "Need an installed system to complete this test."}
     end,
-    ?line ?t:timetrap_cancel(Dog),
     Res.
 
 create_boot(Config) ->
-    ?line {ok, OldDir} = file:get_cwd(),
-    ?line {LatestDir, LatestName, KernelVsn, StdlibVsn} =
+    {ok, OldDir} = file:get_cwd(),
+    {LatestDir, LatestName, KernelVsn, StdlibVsn} =
 	create_script(Config),
     LibDir = code:lib_dir(),
-    ?line ok = file:set_cwd(LatestDir),
-    ?line ok = systools:make_script(LatestName,
-				    [{variables, [{"TEST_VAR", LibDir}]}]),
-    ?line ok = file:set_cwd(OldDir),
+    ok = file:set_cwd(LatestDir),
+    ok = systools:make_script(LatestName,
+			      [{variables, [{"TEST_VAR", LibDir}]}]),
+    ok = file:set_cwd(OldDir),
     {LatestDir ++ "/" ++ LatestName, LibDir, KernelVsn, StdlibVsn}.
 
 is_real_system(KernelVsn, StdlibVsn) ->
     LibDir = code:lib_dir(),
     filelib:is_dir(filename:join(LibDir, "kernel-"++KernelVsn)) andalso
 	filelib:is_dir(filename:join(LibDir, "stdlib-"++StdlibVsn)).
-    
+
 %% ------------------------------------------------
 %% Slave executes erlang:halt() on master nodedown.
 %% Therefore the slave process must be killed
 %% before restart.
 %% ------------------------------------------------
-many_restarts(doc) -> [];
-many_restarts(suite) ->
-    case ?t:os_type() of
-	{Fam, _} when Fam == unix; Fam == win32 ->
-	    {req, [distribution, {local_slave_nodes, 1}, {time, 5}]};
-	_ ->
-	    {skip, "Only run on unix and win32"}
-    end;
+many_restarts() ->
+    [{timetrap,{minutes,8}}].
 
 many_restarts(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(480)),
-    ?line {ok, Node} = loose_node:start(init_test, "", ?DEFAULT_TIMEOUT_SEC),
-    ?line loop_restart(30,Node,rpc:call(Node,erlang,whereis,[error_logger])),
-    ?line loose_node:stop(Node),
-    ?line ?t:timetrap_cancel(Dog),
+    {ok, Node} = loose_node:start(init_test, "", ?DEFAULT_TIMEOUT_SEC),
+    loop_restart(30,Node,rpc:call(Node,erlang,whereis,[error_logger])),
+    loose_node:stop(Node),
     ok.
 
 loop_restart(0,_,_) ->
     ok;
 loop_restart(N,Node,EHPid) ->
-    ?line erlang:monitor_node(Node, true),
-    ?line ok = rpc:call(Node, init, restart, []),
-    ?line receive
-	      {nodedown, Node} ->
-		  ok
-	  after 10000 ->
-		  loose_node:stop(Node),
-		  ?t:fail(not_stopping)
-	  end,
-    ?line ok = wait_for(30, Node, EHPid),
-    ?line loop_restart(N-1,Node,rpc:call(Node,erlang,whereis,[error_logger])).
+    erlang:monitor_node(Node, true),
+    ok = rpc:call(Node, init, restart, []),
+    receive
+	{nodedown, Node} ->
+	    ok
+    after 10000 ->
+	    loose_node:stop(Node),
+	    ct:fail(not_stopping)
+    end,
+    ok = wait_for(30, Node, EHPid),
+    loop_restart(N-1,Node,rpc:call(Node,erlang,whereis,[error_logger])).
 
 wait_for(0,Node,_) ->
     loose_node:stop(Node),    
     error;
 wait_for(N,Node,EHPid) ->
-    ?line case rpc:call(Node, erlang, whereis, [error_logger]) of
+    case rpc:call(Node, erlang, whereis, [error_logger]) of
 	Pid when is_pid(Pid), Pid =/= EHPid ->
-		  %% ?line erlang:display(ok),
-		  ?line ok;
+	    %% erlang:display(ok),
+	    ok;
 	_X ->
-		  %% ?line erlang:display(_X),
-		  %% ?line Procs = rpc:call(Node, erlang, processes, []),
-		  %% ?line erlang:display(Procs),
-		  %% case is_list(Procs) of
-		  %%     true ->
-		  %% 	  ?line [(catch erlang:display(
-		  %% 			  rpc:call(Node, 
-		  %% 				   erlang, 
-		  %% 				   process_info, 
-		  %% 				   [Y,registered_name]))) 
-		  %% 		 || Y <- Procs];
-		  %%     _ ->
-		  %% 	  ok
-		  %% end,
-		  receive
-		      after 100 ->
-			      ok
-		      end,
-		  ?line wait_for(N-1,Node,EHPid)
-	  end.
+	    %% erlang:display(_X),
+	    %% Procs = rpc:call(Node, erlang, processes, []),
+	    %% erlang:display(Procs),
+	    %% case is_list(Procs) of
+	    %%     true ->
+	    %% 	  [(catch erlang:display(
+	    %% 			  rpc:call(Node,
+	    %% 				   erlang,
+	    %% 				   process_info,
+	    %% 				   [Y,registered_name])))
+	    %% 		 || Y <- Procs];
+	    %%     _ ->
+	    %% 	  ok
+	    %% end,
+	    receive
+	    after 100 ->
+		    ok
+	    end,
+	    wait_for(N-1,Node,EHPid)
+    end.
 
 %% ------------------------------------------------
 %% Slave executes erlang:halt() on master nodedown.
 %% Therefore the slave process must be killed
 %% before restart.
 %% ------------------------------------------------
-restart(doc) -> [];
-restart(suite) ->
-    case ?t:os_type() of
-	{Fam, _} when Fam == unix; Fam == win32 ->
-	    {req, [distribution, {local_slave_nodes, 1}, {time, 5}]};
-	_ ->
-	    {skip, "Only run on unix and win32"}
-    end;
 restart(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(40)),
-    ?line Args = args(),
+    Args = args(),
 
     %% Currently test_server:start_node cannot be used. The restarted
     %% node immediately halts due to the implementation of
     %% test_server:start_node.
-    ?line {ok, Node} = loose_node:start(init_test, Args, ?DEFAULT_TIMEOUT_SEC),
+    {ok, Node} = loose_node:start(init_test, Args, ?DEFAULT_TIMEOUT_SEC),
     %% Ok, the node is up, now the real test test begins.
-    ?line erlang:monitor_node(Node, true),
-    ?line InitPid = rpc:call(Node, erlang, whereis, [init]),
-    ?line PurgerPid = rpc:call(Node, erlang, whereis, [erts_code_purger]),
-    ?line Procs = rpc:call(Node, erlang, processes, []),
-    ?line MaxPid = lists:last(Procs),
-    ?line ok = rpc:call(Node, init, restart, []),
-    ?line receive
-	      {nodedown, Node} ->
-		  ok
-	  after 10000 ->
-		  loose_node:stop(Node),
-		  ?t:fail(not_stopping)
-	  end,
-    ?line ok = wait_restart(30, Node),
+    erlang:monitor_node(Node, true),
+    InitPid = rpc:call(Node, erlang, whereis, [init]),
+    PurgerPid = rpc:call(Node, erlang, whereis, [erts_code_purger]),
+    Procs = rpc:call(Node, erlang, processes, []),
+    MaxPid = lists:last(Procs),
+    ok = rpc:call(Node, init, restart, []),
+    receive
+	{nodedown, Node} ->
+	    ok
+    after 10000 ->
+	    loose_node:stop(Node),
+	    ct:fail(not_stopping)
+    end,
+    ok = wait_restart(30, Node),
 
     %% Still the same init process!
-    ?line InitPid1 = rpc:call(Node, erlang, whereis, [init]),
+    InitPid1 = rpc:call(Node, erlang, whereis, [init]),
     InitP = pid_to_list(InitPid),
-    ?line InitP = pid_to_list(InitPid1),
+    InitP = pid_to_list(InitPid1),
 
     %% and same purger process!
-    ?line PurgerPid1 = rpc:call(Node, erlang, whereis, [erts_code_purger]),
+    PurgerPid1 = rpc:call(Node, erlang, whereis, [erts_code_purger]),
     PurgerP = pid_to_list(PurgerPid),
-    ?line PurgerP = pid_to_list(PurgerPid1),
+    PurgerP = pid_to_list(PurgerPid1),
 
-    ?line NewProcs0 = rpc:call(Node, erlang, processes, []),
+    NewProcs0 = rpc:call(Node, erlang, processes, []),
     NewProcs = NewProcs0 -- [InitPid1, PurgerPid1],
-    ?line case check_processes(NewProcs, MaxPid) of
-	      true ->
-		  ok;
-	      _ ->
-		  loose_node:stop(Node),
-		  ?t:fail(processes_not_greater)
-	  end,
+    case check_processes(NewProcs, MaxPid) of
+	true ->
+	    ok;
+	_ ->
+	    loose_node:stop(Node),
+	    ct:fail(processes_not_greater)
+    end,
 
     %% Test that, for instance, the same argument still exists.
-    ?line case rpc:call(Node, init, get_argument, [c]) of
-	      {ok, [["4", "5", "6"], ["7", "8", "9"]]} ->
-		  ok;
-	      _ ->
-		  loose_node:stop(Node),
-		  ?t:fail({get_argument, restart_fail})
-	  end,
+    case rpc:call(Node, init, get_argument, [c]) of
+	{ok, [["4", "5", "6"], ["7", "8", "9"]]} ->
+	    ok;
+	_ ->
+	    loose_node:stop(Node),
+	    ct:fail({get_argument, restart_fail})
+    end,
     loose_node:stop(Node),
-    ?line ?t:timetrap_cancel(Dog),
     ok.
 
 wait_restart(0, _Node) ->
-    ?t:fail(not_restarted);
+    ct:fail(not_restarted);
 wait_restart(N, Node) ->
     case net_adm:ping(Node) of
 	pong -> ok;
 	_ -> 
-	    ?t:sleep(1000),
+	    ct:sleep(1000),
 	    wait_restart(N - 1, Node)
     end.
 
@@ -480,124 +439,98 @@ apid(Pid) ->
 %% The reboot facility using heart is tested
 %% in the heart_SUITE.
 %% ------------------------------------------------
-reboot(doc) -> [];
-reboot(suite) -> {req, [distribution, {local_slave_nodes, 1}]};
 reboot(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(40)),
-
     Args = args(),
-    ?line {ok, Node} = start_node(init_test, Args),
+    {ok, Node} = start_node(init_test, Args),
     erlang:monitor_node(Node, true),
-    ?line ok = rpc:call(Node, init, reboot, []),
-    ?line receive
-	      {nodedown, Node} ->
-		  ok
-	  after 10000 ->
-		  stop_node(Node),
-		  ?t:fail(not_stopping)
-	  end,
-    ?t:sleep(5000),
-    ?line case net_adm:ping(Node) of
-	      pang ->
-		  ok;
-	      _ ->
-		  stop_node(Node),
-		  ?t:fail(system_rebooted)
-	  end,
-    ?line ?t:timetrap_cancel(Dog),
+    ok = rpc:call(Node, init, reboot, []),
+    receive
+	{nodedown, Node} ->
+	    ok
+    after 10000 ->
+	    stop_node(Node),
+	    ct:fail(not_stopping)
+    end,
+    ct:sleep(5000),
+    case net_adm:ping(Node) of
+	pang ->
+	    ok;
+	_ ->
+	    stop_node(Node),
+	    ct:fail(system_rebooted)
+    end,
     ok.
 
 %% ------------------------------------------------
 %%
 %% ------------------------------------------------
-stop(doc) -> [];
-stop(suite) -> [];
 stop(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(20)),
     Args = args(),
-    ?line {ok, Node} = start_node(init_test, Args),
+    {ok, Node} = start_node(init_test, Args),
     erlang:monitor_node(Node, true),
-    ?line ok = rpc:call(Node, init, reboot, []),
-    ?line receive
-	      {nodedown, Node} ->
-		  ok
-	  after 10000 ->
-		  stop_node(Node),
-		  ?t:fail(not_stopping)
-	  end,
-    ?t:sleep(5000),
-    ?line case net_adm:ping(Node) of
-	      pang ->
-		  ok;
-	      _ ->
-		  stop_node(Node),
-		  ?t:fail(system_rebooted)
-	  end,
-    ?line ?t:timetrap_cancel(Dog),
+    ok = rpc:call(Node, init, reboot, []),
+    receive
+	{nodedown, Node} ->
+	    ok
+    after 10000 ->
+	    stop_node(Node),
+	    ct:fail(not_stopping)
+    end,
+    ct:sleep(5000),
+    case net_adm:ping(Node) of
+	pang ->
+	    ok;
+	_ ->
+	    stop_node(Node),
+	    ct:fail(system_rebooted)
+    end,
     ok.
 
 %% ------------------------------------------------
 %% 
 %% ------------------------------------------------
-get_status(doc) -> [];
-get_status(suite) -> [];
 get_status(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(10)),
-    ?line ?t:timetrap_cancel(Dog),
+    {Start, _} = init:get_status(),
 
-    ?line {Start, _} = init:get_status(),
     %% Depending on how the test_server is started Start has
     %% different values. staring if test_server started with
     %% -s flag.
-    ?line case lists:member(Start, [started, starting]) of
-	      true ->
-		  ok;
-	      _ ->
-		  ?t:fail(get_status)
-	  end.
+    case lists:member(Start, [started, starting]) of
+	true ->
+	    ok;
+	_ ->
+	    ct:fail(get_status)
+    end.
 
 %% ------------------------------------------------
 %% 
 %% ------------------------------------------------
-script_id(doc) -> [];
-script_id(suite) -> [];
 script_id(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(10)),
-
-    ?line {Name, Vsn} = init:script_id(),
-    ?line if
-	      is_list(Name), is_list(Vsn) ->
-		  ok;
-	      true ->
-		  ?t:fail(not_standard_script)
-	  end,
-    ?line ?t:timetrap_cancel(Dog),
+    {Name, Vsn} = init:script_id(),
+    if
+	is_list(Name), is_list(Vsn) ->
+	    ok;
+	true ->
+	    ct:fail(not_standard_script)
+    end,
     ok.
 
 %% ------------------------------------------------
 %% Start the slave system with -boot flag.
 %% ------------------------------------------------
 
-boot1(doc) -> [];
-boot1(suite) -> {req, [distribution, {local_slave_nodes, 1}, {time, 35}]};
 boot1(Config) when is_list(Config) ->
-    ?line Dog = ?t:timetrap(?t:seconds(80)),
     Args = args() ++ " -boot start_sasl",
-    ?line {ok, Node} = start_node(init_test, Args),
-    ?line stop_node(Node),
+    {ok, Node} = start_node(init_test, Args),
+    stop_node(Node),
 
     %% Try to start with non existing boot file.
     Args1 = args() ++ " -boot dummy_script",
-    ?line {error, timeout} = start_node(init_test, Args1),
+    {error, timeout} = start_node(init_test, Args1),
 
-    ?line ?t:timetrap_cancel(Dog),
     ok.
 
-boot2(doc) -> [];
-boot2(suite) -> {req, [distribution, {local_slave_nodes, 1}, {time, 35}]};
 boot2(Config) when is_list(Config) ->
-    Dog = ?t:timetrap(?t:seconds(80)),
-
     %% Absolute boot file name
     Boot = filename:join([code:root_dir(), "bin", "start_sasl"]),
 
@@ -610,9 +543,9 @@ boot2(Config) when is_list(Config) ->
 	    %% Absolute boot file name for Windows -- all slashes are
 	    %% converted to backslashes.
 	    Win_boot = lists:map(fun
-		    ($/) -> $\\;
-		    (C) -> C 
-		end, Boot),
+				     ($/) -> $\\;
+				     (C) -> C
+				end, Boot),
 	    Args2 = args() ++ " -boot \"" ++ Win_boot ++ "\"",
 	    {ok, Node2} = start_node(init_test, Args2),
 	    stop_node(Node2);
@@ -620,16 +553,15 @@ boot2(Config) when is_list(Config) ->
 	    ok
     end,
 
-    ?t:timetrap_cancel(Dog),
     ok.
 
 %% Misc. functions    
 
 start_node(Name, Param) ->
-    ?t:start_node(Name, slave, [{args, Param}]).
+    test_server:start_node(Name, slave, [{args, Param}]).
 
 stop_node(Node) ->
-    ?t:stop_node(Node).
+    test_server:stop_node(Node).
 
 from(H, [H | T]) -> T;
 from(H, [_ | T]) -> from(H, T);
@@ -645,18 +577,18 @@ long_args(A) ->
 		    [A])).
 
 create_script(Config) ->
-    ?line PrivDir = ?config(priv_dir,Config),
-    ?line Name = PrivDir ++ "boot_var_test",
-    ?line Apps = application_controller:which_applications(),
-    ?line {value,{_,_,KernelVer}} = lists:keysearch(kernel,1,Apps),
-    ?line {value,{_,_,StdlibVer}} = lists:keysearch(stdlib,1,Apps),
-    ?line {ok,Fd} = file:open(Name ++ ".rel", [write]),
-    ?line io:format(Fd,
-		    "{release, {\"Test release 3\", \"P2A\"}, \n"
-		    " {erts, \"4.4\"}, \n"
-		    " [{kernel, \"~s\"}, {stdlib, \"~s\"}]}.\n",
-		    [KernelVer,StdlibVer]),
-    ?line file:close(Fd),
+    PrivDir = proplists:get_value(priv_dir,Config),
+    Name = PrivDir ++ "boot_var_test",
+    Apps = application_controller:which_applications(),
+    {value,{_,_,KernelVer}} = lists:keysearch(kernel,1,Apps),
+    {value,{_,_,StdlibVer}} = lists:keysearch(stdlib,1,Apps),
+    {ok,Fd} = file:open(Name ++ ".rel", [write]),
+    io:format(Fd,
+	      "{release, {\"Test release 3\", \"P2A\"}, \n"
+	      " {erts, \"4.4\"}, \n"
+	      " [{kernel, \"~s\"}, {stdlib, \"~s\"}]}.\n",
+	      [KernelVer,StdlibVer]),
+    file:close(Fd),
     {filename:dirname(Name), filename:basename(Name),
-    KernelVer, StdlibVer}.
+     KernelVer, StdlibVer}.