aboutsummaryrefslogtreecommitdiffstats
path: root/lib/kernel/test/loose_node.erl
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2010-01-24 09:28:05 +0100
committerBjörn Gustavsson <[email protected]>2010-01-29 17:43:38 +0100
commitfc1ddbbc8c979bf0dc67ec9bfcb95ac0e18e6161 (patch)
treecbc7c80a0613c00d9b94af0e6e9e128827d6d6b8 /lib/kernel/test/loose_node.erl
parent0cd162311b1ae680fda3374d507a63ffa0605fa9 (diff)
downloadotp-fc1ddbbc8c979bf0dc67ec9bfcb95ac0e18e6161.tar.gz
otp-fc1ddbbc8c979bf0dc67ec9bfcb95ac0e18e6161.tar.bz2
otp-fc1ddbbc8c979bf0dc67ec9bfcb95ac0e18e6161.zip
kernel tests: modernize guard tests
Diffstat (limited to 'lib/kernel/test/loose_node.erl')
-rw-r--r--lib/kernel/test/loose_node.erl17
1 files changed, 9 insertions, 8 deletions
diff --git a/lib/kernel/test/loose_node.erl b/lib/kernel/test/loose_node.erl
index ac1ddb8d9a..59c3ed1887 100644
--- a/lib/kernel/test/loose_node.erl
+++ b/lib/kernel/test/loose_node.erl
@@ -55,7 +55,7 @@
%% Exported functions.
%%
-stop(Node) when atom(Node) ->
+stop(Node) when is_atom(Node) ->
rpc:cast(Node, erlang, halt, []),
io:format("Stopped loose node ~p~n", [Node]),
ok.
@@ -63,9 +63,10 @@ stop(Node) when atom(Node) ->
start(Name, Args) ->
start(Name, Args, -1).
-start(Name, Args, TimeOut) when atom(Name) ->
+start(Name, Args, TimeOut) when is_atom(Name) ->
start(atom_to_list(Name), Args, TimeOut);
-start(Name, Args, TimeOut) when list(Name), list(Args), integer(TimeOut) ->
+start(Name, Args, TimeOut)
+ when is_list(Name), is_list(Args), is_integer(TimeOut) ->
Parent = self(),
Ref = make_ref(),
Starter
@@ -119,7 +120,7 @@ start(Name, Args, TimeOut) when list(Name), list(Args), integer(TimeOut) ->
io:format("Trying to start loose node...~n"
" --> ~p~n", [Cmd]),
Res = case open_port({spawn, Cmd}, []) of
- P when port(P) ->
+ P when is_port(P) ->
receive
{loose_node_started,
Node,
@@ -150,14 +151,14 @@ start(Name, Args, TimeOut) when list(Name), list(Args), integer(TimeOut) ->
%% Exported functions for internal use.
%%
-loose_node_started([Name, Node, TimeOutSecs]) when list(Name),
- list(Node),
- list(TimeOutSecs) ->
+loose_node_started([Name, Node, TimeOutSecs]) when is_list(Name),
+ is_list(Node),
+ is_list(TimeOutSecs) ->
spawn_opt(fun () ->
process_flag(trap_exit, true),
Proc = {list_to_atom(Name), list_to_atom(Node)},
Timeout = case catch list_to_integer(TimeOutSecs) of
- I when integer(I), I >= 0 -> I*1000;
+ I when is_integer(I), I >= 0 -> I*1000;
_ -> infinity
end,
wait_until(fun () -> is_alive() end),