diff options
| author | Aleksandr Vinokurov <[email protected]> | 2012-11-08 13:59:12 +0400 |
|---|---|---|
| committer | Fredrik Gustafsson <[email protected]> | 2013-04-30 11:12:24 +0200 |
| commit | 851f61719985651e769f8df8246d5ddb855cc022 (patch) | |
| tree | 2b678fe413655fe08b17ca60874793f27af93f9c /lib/kernel/test | |
| parent | d93043ca0839e659abada62b0c6cf4d441808acf (diff) | |
| download | otp-851f61719985651e769f8df8246d5ddb855cc022.tar.gz otp-851f61719985651e769f8df8246d5ddb855cc022.tar.bz2 otp-851f61719985651e769f8df8246d5ddb855cc022.zip | |
Fix deep list argument error under Windows in os:cmd/1
Because of leeway in implementing os:cmd/1 under different OS there is
a difference in results when calling it with deep list
argument. os:cmd/1 specifies io_lib:chars() type for its argument and
io_lib functions can produce deep lists inspite of io_lib:chars()
result type specification. This commit flattens the argument for
erlang:open_port/2 (which is used under Windows) and expands the
os_SUITE to regress the bug.
Diffstat (limited to 'lib/kernel/test')
| -rw-r--r-- | lib/kernel/test/os_SUITE.erl | 17 |
1 files changed, 16 insertions, 1 deletions
diff --git a/lib/kernel/test/os_SUITE.erl b/lib/kernel/test/os_SUITE.erl index 382fd6f6a9..e302bf7378 100644 --- a/lib/kernel/test/os_SUITE.erl +++ b/lib/kernel/test/os_SUITE.erl @@ -29,7 +29,8 @@ suite() -> [{ct_hooks,[ts_install_cth]}]. all() -> [space_in_cwd, quoting, space_in_name, bad_command, - find_executable, unix_comment_in_command, evil]. + find_executable, unix_comment_in_command, deep_list_command, + evil]. groups() -> []. @@ -237,6 +238,20 @@ unix_comment_in_command(Config) when is_list(Config) -> ?line test_server:timetrap_cancel(Dog), ok. +deep_list_command(doc) -> + "Check that a deep list in command works equally on unix and on windows."; +deep_list_command(suite) -> []; +deep_list_command(Config) when is_list(Config) -> + %% As a 'io_lib' module description says: "There is no guarantee that the + %% character lists returned from some of the functions are flat, they can + %% be deep lists." + %% That's why os:cmd/1 can have arguments that are deep lists. + %% It is not a problem for unix, but for windows it is (in R15B02 for ex.). + ?line os:cmd([$e, $c, "ho"]), + %% FYI: [$e, $c, "ho"] =:= io_lib:format("ec~s", ["ho"]) + ok. + + -define(EVIL_PROCS, 100). -define(EVIL_LOOPS, 100). -define(PORT_CREATOR, os_cmd_port_creator). |