Merge pull request #1740 from rickard-green/rickard/signals/OTP-14589

Implementation of true asynchronous signaling between processes

4 files changed, 53 insertions, 54 deletions

diff --git a/lib/kernel/src/erts_debug.erl b/lib/kernel/src/erts_debug.erl
index 3456c8511e..6f248626ca 100644
--- a/lib/kernel/src/erts_debug.erl
+++ b/lib/kernel/src/erts_debug.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2016. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2018. All Rights Reserved.
 %% 
 %% Licensed under the Apache License, Version 2.0 (the "License");
 %% you may not use this file except in compliance with the License.
@@ -32,8 +32,7 @@
 %%% BIFs
 
 -export([breakpoint/2, disassemble/1, display/1, dist_ext_to_term/2,
-         dump_monitors/1, dump_links/1, flat_size/1,
-         get_internal_state/1, instructions/0,
+         flat_size/1, get_internal_state/1, instructions/0,
          map_info/1, same/2, set_internal_state/2,
          size_shared/1, copy_shared/1, dirty_cpu/2, dirty_io/2, dirty/3,
          lcnt_control/1, lcnt_control/2, lcnt_collect/0, lcnt_clear/0]).
@@ -70,18 +69,6 @@ display(_) ->
 dist_ext_to_term(_, _) ->
     erlang:nif_error(undef).
 
--spec dump_monitors(Id) -> true when
-      Id :: pid() | atom().
-
-dump_monitors(_) ->
-    erlang:nif_error(undef).
-
--spec dump_links(Id) -> true when
-      Id :: pid() | port() | atom().
-
-dump_links(_) ->
-    erlang:nif_error(undef).
-
 -spec flat_size(Term) -> non_neg_integer() when
       Term :: term().
 
diff --git a/lib/kernel/src/net_kernel.erl b/lib/kernel/src/net_kernel.erl
index f38989d103..669adefdf8 100644
--- a/lib/kernel/src/net_kernel.erl
+++ b/lib/kernel/src/net_kernel.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1996-2017. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2018. All Rights Reserved.
 %%
 %% Licensed under the Apache License, Version 2.0 (the "License");
 %% you may not use this file except in compliance with the License.
@@ -222,8 +222,7 @@ get_net_ticktime() ->
       Error :: error | {error, term()}.
 monitor_nodes(Flag) ->
     case catch process_flag(monitor_nodes, Flag) of
-	true -> ok;
-	false -> ok;
+	N when is_integer(N) -> ok;
 	_ -> mk_monitor_nodes_error(Flag, [])
     end.
 
@@ -236,8 +235,7 @@ monitor_nodes(Flag) ->
       Error :: error | {error, term()}.
 monitor_nodes(Flag, Opts) ->
     case catch process_flag({monitor_nodes, Opts}, Flag) of
-	true -> ok;
-	false -> ok;
+	N when is_integer(N) -> ok;
 	_ -> mk_monitor_nodes_error(Flag, Opts)
     end.
 
diff --git a/lib/kernel/test/erl_distribution_SUITE.erl b/lib/kernel/test/erl_distribution_SUITE.erl
index f6791adf86..0470f09f29 100644
--- a/lib/kernel/test/erl_distribution_SUITE.erl
+++ b/lib/kernel/test/erl_distribution_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1997-2017. All Rights Reserved.
+%% Copyright Ericsson AB 1997-2018. All Rights Reserved.
 %%
 %% Licensed under the Apache License, Version 2.0 (the "License");
 %% you may not use this file except in compliance with the License.
@@ -1144,17 +1144,16 @@ monitor_nodes_otp_6481_test(Config, TestType) when is_list(Config) ->
     TestMonNodeState = monitor_node_state(),
     %% io:format("~p~n", [TestMonNodeState]),
     TestMonNodeState =
-	MonNodeState
+	case TestType of
+	    nodedown -> [];
+	    nodeup -> [{self(), []}]
+	end
+	++ lists:map(fun (_) -> {MN, []} end, Seq)
 	++ case TestType of
 	       nodedown -> [{self(), []}];
 	       nodeup -> []
 	   end
-	++ lists:map(fun (_) -> {MN, []} end, Seq)
-	++ case TestType of
-	       nodedown -> [];
-	       nodeup -> [{self(), []}]
-	   end,
-
+	++ MonNodeState,
 
     {ok, Node} = start_node(Name, "", this),
     receive {nodeup, Node} -> ok end,
diff --git a/lib/kernel/test/init_SUITE.erl b/lib/kernel/test/init_SUITE.erl
index 2b59eb2bfe..c8415b34e5 100644
--- a/lib/kernel/test/init_SUITE.erl
+++ b/lib/kernel/test/init_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1996-2016. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2018. All Rights Reserved.
 %%
 %% Licensed under the Apache License, Version 2.0 (the "License");
 %% you may not use this file except in compliance with the License.
@@ -365,7 +365,9 @@ restart(Config) when is_list(Config) ->
     %% Ok, the node is up, now the real test test begins.
     erlang:monitor_node(Node, true),
     SysProcs0 = rpc:call(Node, ?MODULE, find_system_processes, []),
-    [InitPid, PurgerPid, LitCollectorPid, DirtyCodePid] = SysProcs0,
+    io:format("SysProcs0=~p~n", [SysProcs0]),
+    [InitPid, PurgerPid, LitCollectorPid,
+     DirtySigNPid, DirtySigHPid, DirtySigMPid] = SysProcs0,
     InitPid = rpc:call(Node, erlang, whereis, [init]),
     PurgerPid = rpc:call(Node, erlang, whereis, [erts_code_purger]),
     Procs = rpc:call(Node, erlang, processes, []),
@@ -381,7 +383,9 @@ restart(Config) when is_list(Config) ->
     ok = wait_restart(30, Node),
 
     SysProcs1 = rpc:call(Node, ?MODULE, find_system_processes, []),
-    [InitPid1, PurgerPid1, LitCollectorPid1, DirtyCodePid1] = SysProcs1,
+    io:format("SysProcs1=~p~n", [SysProcs1]),
+    [InitPid1, PurgerPid1, LitCollectorPid1,
+     DirtySigNPid1, DirtySigHPid1, DirtySigMPid1] = SysProcs1,
 
     %% Still the same init process!
     InitPid1 = rpc:call(Node, erlang, whereis, [init]),
@@ -394,20 +398,18 @@ restart(Config) when is_list(Config) ->
     PurgerP = pid_to_list(PurgerPid1),
 
     %% and same literal area collector process!
-    case LitCollectorPid of
-	undefined -> undefined = LitCollectorPid1;
-	_ ->
-	    LitCollectorP = pid_to_list(LitCollectorPid),
-	    LitCollectorP = pid_to_list(LitCollectorPid1)
-    end,
-
-    %% and same dirty process code checker process!
-    case DirtyCodePid of
-	undefined -> undefined = DirtyCodePid1;
-	_ ->
-	    DirtyCodeP = pid_to_list(DirtyCodePid),
-	    DirtyCodeP = pid_to_list(DirtyCodePid1)
-    end,
+    LitCollectorP = pid_to_list(LitCollectorPid),
+    LitCollectorP = pid_to_list(LitCollectorPid1),
+
+    %% and same normal dirty signal handler process!
+    DirtySigNP = pid_to_list(DirtySigNPid),
+    DirtySigNP = pid_to_list(DirtySigNPid1),
+    %% and same high dirty signal handler process!
+    DirtySigHP = pid_to_list(DirtySigHPid),
+    DirtySigHP = pid_to_list(DirtySigHPid1),
+    %% and same max dirty signal handler process!
+    DirtySigMP = pid_to_list(DirtySigMPid),
+    DirtySigMP = pid_to_list(DirtySigMPid1),
 
     NewProcs0 = rpc:call(Node, erlang, processes, []),
     NewProcs = NewProcs0 -- SysProcs1,
@@ -433,7 +435,9 @@ restart(Config) when is_list(Config) ->
 -record(sys_procs, {init,
 		    code_purger,
 		    literal_collector,
-		    dirty_proc_checker}).
+		    dirty_sig_handler_normal,
+		    dirty_sig_handler_high,
+		    dirty_sig_handler_max}).
 
 find_system_processes() ->
     find_system_procs(processes(), #sys_procs{}).
@@ -442,21 +446,32 @@ find_system_procs([], SysProcs) ->
     [SysProcs#sys_procs.init,
      SysProcs#sys_procs.code_purger,
      SysProcs#sys_procs.literal_collector,
-     SysProcs#sys_procs.dirty_proc_checker];
+     SysProcs#sys_procs.dirty_sig_handler_normal,
+     SysProcs#sys_procs.dirty_sig_handler_high,
+     SysProcs#sys_procs.dirty_sig_handler_max];
 find_system_procs([P|Ps], SysProcs) ->
-    case process_info(P, initial_call) of
-	{initial_call,{otp_ring0,start,2}} ->
+    case process_info(P, [initial_call, priority]) of
+	[{initial_call,{otp_ring0,start,2}},_] ->
 	    undefined = SysProcs#sys_procs.init,
 	    find_system_procs(Ps, SysProcs#sys_procs{init = P});
-	{initial_call,{erts_code_purger,start,0}} ->
+	[{initial_call,{erts_code_purger,start,0}},_] ->
 	    undefined = SysProcs#sys_procs.code_purger,
 	    find_system_procs(Ps, SysProcs#sys_procs{code_purger = P});
-	{initial_call,{erts_literal_area_collector,start,0}} ->
+	[{initial_call,{erts_literal_area_collector,start,0}},_] ->
 	    undefined = SysProcs#sys_procs.literal_collector,
 	    find_system_procs(Ps, SysProcs#sys_procs{literal_collector = P});
-	{initial_call,{erts_dirty_process_code_checker,start,0}} ->
-	    undefined = SysProcs#sys_procs.dirty_proc_checker,
-	    find_system_procs(Ps, SysProcs#sys_procs{dirty_proc_checker = P});
+	[{initial_call,{erts_dirty_process_signal_handler,start,0}},
+         {priority,normal}] ->
+	    undefined = SysProcs#sys_procs.dirty_sig_handler_normal,
+	    find_system_procs(Ps, SysProcs#sys_procs{dirty_sig_handler_normal = P});
+	[{initial_call,{erts_dirty_process_signal_handler,start,0}},
+                       {priority,high}] ->
+	    undefined = SysProcs#sys_procs.dirty_sig_handler_high,
+	    find_system_procs(Ps, SysProcs#sys_procs{dirty_sig_handler_high = P});
+	[{initial_call,{erts_dirty_process_signal_handler,start,0}},
+         {priority,max}] ->
+	    undefined = SysProcs#sys_procs.dirty_sig_handler_max,
+	    find_system_procs(Ps, SysProcs#sys_procs{dirty_sig_handler_max = P});
 	_ ->
 	    find_system_procs(Ps, SysProcs)
     end.