Fix unmatched_return warnings in kernel

12 files changed, 94 insertions, 64 deletions

diff --git a/lib/kernel/src/dist_ac.erl b/lib/kernel/src/dist_ac.erl
index 98b9e20007..a4d4ae386c 100644
--- a/lib/kernel/src/dist_ac.erl
+++ b/lib/kernel/src/dist_ac.erl
@@ -283,7 +283,7 @@ handle_cast(init_sync, _S) ->
 	    KernelConfig ! dist_ac_took_control,
 
 	    %% we're really just interested in nodedowns.
-	    net_kernel:monitor_nodes(true),
+	    ok = net_kernel:monitor_nodes(true),
 	    
 	    {Known, NAppls, RStarted} = sync_dacs(Appls),
 
@@ -812,21 +812,21 @@ start_appl(AppName, S, Type) ->
 start_distributed(Appl, Name, Nodes, PermittedNodes, S, Type) ->
     case find_start_node(Nodes, PermittedNodes, Name, S) of
 	{ok, Node} when Node =:= node() ->
-	    case Appl#appl.id of
-		{failover, FoNode} when Type =:= req ->
-		    _ = ac_failover(Name, FoNode, undefined);
-		{distributed, Node2} when Type =:= req ->
-		    _ = ac_takeover(req, Name, Node2, undefined);
-		_ when Type =:= reply ->
-		    case lists:keysearch(Name, 2, S#state.remote_started) of
-			{value, {Node3, _}} ->
-			    _ = ac_takeover(reply, Name, Node3, undefined);
-			_ ->
-			    _ = ac_start_it(Type, Name)
-		    end;
-		_ ->
-		    _ = ac_start_it(Type, Name)
-	    end,
+	    _ = case Appl#appl.id of
+		    {failover, FoNode} when Type =:= req ->
+			ac_failover(Name, FoNode, undefined);
+		    {distributed, Node2} when Type =:= req ->
+			ac_takeover(req, Name, Node2, undefined);
+		    _ when Type =:= reply ->
+			case lists:keysearch(Name, 2, S#state.remote_started) of
+			    {value, {Node3, _}} ->
+				ac_takeover(reply, Name, Node3, undefined);
+			    _ ->
+				ac_start_it(Type, Name)
+			end;
+		    _ ->
+			ac_start_it(Type, Name)
+		end,
 	    {run_waiting, true};
 	{already_started, Node} ->
 	    _ = ac_started(Type, Name, Node),
diff --git a/lib/kernel/src/erl_boot_server.erl b/lib/kernel/src/erl_boot_server.erl
index 33f1b96f8d..9a49655a9f 100644
--- a/lib/kernel/src/erl_boot_server.erl
+++ b/lib/kernel/src/erl_boot_server.erl
@@ -361,7 +361,14 @@ handle_command(S, PS, Msg) ->
     end.
 
 send_file_result(S, Cmd, Result) ->
-    gen_tcp:send(S, term_to_binary({Cmd,Result})).
-
-send_result(S, Result) ->
-    gen_tcp:send(S, term_to_binary(Result)).
+    send_result(S, {Cmd,Result}).
+
+send_result(S, Term) ->
+    case gen_tcp:send(S, term_to_binary(Term)) of
+	ok ->
+	    ok;
+	Error ->
+	    error_logger:error_msg("** Boot server could not send result "
+				   "to socket: ~w** ~n", [Error]),
+	    ok
+    end.
diff --git a/lib/kernel/src/erl_epmd.erl b/lib/kernel/src/erl_epmd.erl
index 0b97559ec2..b4fae24ef3 100644
--- a/lib/kernel/src/erl_epmd.erl
+++ b/lib/kernel/src/erl_epmd.erl
@@ -300,8 +300,14 @@ get_port(Node, EpmdAddress, Timeout) ->
 	{ok, Socket} ->
 	    Name = to_string(Node),
 	    Len = 1+length(Name),
-	    gen_tcp:send(Socket, [?int16(Len),?EPMD_PORT_PLEASE2_REQ, Name]),
-	    wait_for_port_reply(Socket, []);
+	    Msg = [?int16(Len),?EPMD_PORT_PLEASE2_REQ,Name],
+	    case gen_tcp:send(Socket, Msg) of
+		ok ->
+		    wait_for_port_reply(Socket, []);
+		_Error ->
+		    ?port_please_failure2(_Error),
+		    noport
+	    end;
 	_Error -> 
 	    ?port_please_failure2(_Error),
 	    noport
@@ -430,19 +436,24 @@ get_names(EpmdAddress) ->
     end.
 
 do_get_names(Socket) ->
-    gen_tcp:send(Socket, [?int16(1),?EPMD_NAMES]),
-    receive
-	{tcp, Socket, [P0,P1,P2,P3|T]} ->
-	    EpmdPort = ?u32(P0,P1,P2,P3),
-	    case get_epmd_port() of
-		EpmdPort ->
-		    names_loop(Socket, T, []);
-		_ ->
-		    close(Socket),
-		    {error, address}
+    case gen_tcp:send(Socket, [?int16(1),?EPMD_NAMES]) of
+	ok ->
+	    receive
+		{tcp, Socket, [P0,P1,P2,P3|T]} ->
+		    EpmdPort = ?u32(P0,P1,P2,P3),
+		    case get_epmd_port() of
+			EpmdPort ->
+			    names_loop(Socket, T, []);
+			_ ->
+			    close(Socket),
+			    {error, address}
+		    end;
+		{tcp_closed, Socket} ->
+		    {ok, []}
 	    end;
-	{tcp_closed, Socket} ->
-	    {ok, []}
+	_ ->
+	    close(Socket),
+	    {error, address}
     end.
 
 names_loop(Socket, Acc, Ps) ->
diff --git a/lib/kernel/src/erl_reply.erl b/lib/kernel/src/erl_reply.erl
index 1a61e630bc..f0be3ee654 100644
--- a/lib/kernel/src/erl_reply.erl
+++ b/lib/kernel/src/erl_reply.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1997-2009. All Rights Reserved.
+%% Copyright Ericsson AB 1997-2013. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -32,7 +32,7 @@ reply([Addr,Port,Msg]) ->
     P = list_to_integer(atom_to_list(Port)),
     M = atom_to_list(Msg),
     {ok, S} = gen_tcp:connect(Ip,P,[]),
-    gen_tcp:send(S,M),
+    ok = gen_tcp:send(S,M),
     gen_tcp:close(S),
     reply_done;
 reply(_) ->
diff --git a/lib/kernel/src/global.erl b/lib/kernel/src/global.erl
index 3f672c099b..ef878b8d0c 100644
--- a/lib/kernel/src/global.erl
+++ b/lib/kernel/src/global.erl
@@ -2069,7 +2069,7 @@ random_sleep(Times) ->
     case get(random_seed) of
 	undefined ->
 	    {A1, A2, A3} = now(),
-	    random:seed(A1, A2, A3 + erlang:phash(node(), 100000)),
+	    _ = random:seed(A1, A2, A3 + erlang:phash(node(), 100000)),
             ok;
 	_ -> ok
     end,
diff --git a/lib/kernel/src/hipe_unified_loader.erl b/lib/kernel/src/hipe_unified_loader.erl
index e676ca997d..cc51b5ae07 100644
--- a/lib/kernel/src/hipe_unified_loader.erl
+++ b/lib/kernel/src/hipe_unified_loader.erl
@@ -226,14 +226,16 @@ load_common(Mod, Bin, Beam, OldReferencesToPatch) ->
       %%  (patches the BEAM code to redirect to native.)
       case Beam of
 	[] ->
-	  export_funs(Addresses);
+	  export_funs(Addresses),
+	  ok;
 	BeamBinary when is_binary(BeamBinary) ->
 	  %% Find all closures in the code.
 	  ClosurePatches = find_closure_patches(Refs),
 	  AddressesOfClosuresToPatch =
 	    calculate_addresses(ClosurePatches, CodeAddress, Addresses),
 	  export_funs(Addresses),
-	  export_funs(Mod, BeamBinary, Addresses, AddressesOfClosuresToPatch)
+	  export_funs(Mod, BeamBinary, Addresses, AddressesOfClosuresToPatch),
+	  ok
       end,
       %% Redirect references to the old module to the new module's BEAM stub.
       patch_to_emu_step2(OldReferencesToPatch),
diff --git a/lib/kernel/src/inet_res.erl b/lib/kernel/src/inet_res.erl
index 1a30979126..ab9cbf0617 100644
--- a/lib/kernel/src/inet_res.erl
+++ b/lib/kernel/src/inet_res.erl
@@ -921,18 +921,25 @@ query_tcp(Timeout, Id, Buffer, IP, Port, Verbose) ->
 			[{active,false},{packet,2},binary,Family], 
 			Timeout) of
 	{ok, S} ->
-	    gen_tcp:send(S, Buffer),
-	    case gen_tcp:recv(S, 0, Timeout) of
-		{ok, Answer} ->
-		    gen_tcp:close(S),
-		    case decode_answer(Answer, Id, Verbose) of
-			{ok, _} = OK -> OK;
-			{error, badid} -> {error, servfail};
-			Error -> Error
+	    case gen_tcp:send(S, Buffer) of
+		ok ->
+		    case gen_tcp:recv(S, 0, Timeout) of
+			{ok, Answer} ->
+			    gen_tcp:close(S),
+			    case decode_answer(Answer, Id, Verbose) of
+				{ok, _} = OK -> OK;
+				{error, badid} -> {error, servfail};
+				Error -> Error
+			    end;
+			Error ->
+			    gen_tcp:close(S),
+			    ?verbose(Verbose, "TCP server recv error: ~p\n",
+				     [Error]),
+			    Error
 		    end;
 		Error ->
 		    gen_tcp:close(S),
-		    ?verbose(Verbose, "TCP server recv error: ~p\n",
+		    ?verbose(Verbose, "TCP server send error: ~p\n",
 			     [Error]),
 		    Error
 	    end;
diff --git a/lib/kernel/src/kernel_config.erl b/lib/kernel/src/kernel_config.erl
index 48141cfa03..56defcb167 100644
--- a/lib/kernel/src/kernel_config.erl
+++ b/lib/kernel/src/kernel_config.erl
@@ -121,7 +121,7 @@ send_timeout(Timeout, Pid) ->
     end.
 
 wait_nodes(Mandatory, Optional) ->
-    net_kernel:monitor_nodes(true),
+    ok = net_kernel:monitor_nodes(true),
     lists:foreach(fun(Node) -> 
 		     case net_adm:ping(Node) of
 			 pong -> self() ! {nodeup, Node};
@@ -129,7 +129,9 @@ wait_nodes(Mandatory, Optional) ->
 		     end
 		  end,
 		  Mandatory ++ Optional),
-    rec_nodes(Mandatory, Optional).
+    R = rec_nodes(Mandatory, Optional),
+    ok = net_kernel:monitor_nodes(false),
+    R.
 
 rec_nodes([], []) -> ok;
 rec_nodes(Mandatory, Optional) ->
diff --git a/lib/kernel/src/net_adm.erl b/lib/kernel/src/net_adm.erl
index 9b2dac9544..3f5eac7822 100644
--- a/lib/kernel/src/net_adm.erl
+++ b/lib/kernel/src/net_adm.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1996-2011. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2013. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -133,7 +133,7 @@ dns_hostname(Hostname) ->
 -spec ping_list([atom()]) -> [atom()].
 
 ping_list(Nodelist) ->
-    net_kernel:monitor_nodes(true),
+    ok = net_kernel:monitor_nodes(true),
     Sofar = ping_first(Nodelist, nodes()),
     collect_new(Sofar, Nodelist).
 
@@ -159,7 +159,7 @@ collect_new(Sofar, Nodelist) ->
 		    collect_new([Node | Sofar], Nodelist)
 	    end
     after 3000 ->
-	    net_kernel:monitor_nodes(false),
+	    ok = net_kernel:monitor_nodes(false),
 	    Sofar
     end.
 
diff --git a/lib/kernel/src/net_kernel.erl b/lib/kernel/src/net_kernel.erl
index 0c70e5f125..04a0d94ebf 100644
--- a/lib/kernel/src/net_kernel.erl
+++ b/lib/kernel/src/net_kernel.erl
@@ -306,20 +306,20 @@ do_connect(Node, Type, WaitForBarred) -> %% Type = normal | hidden
     end.
 
 passive_connect_monitor(Parent, Node) ->
-    monitor_nodes(true,[{node_type,all}]),
+    ok = monitor_nodes(true,[{node_type,all}]),
     case lists:member(Node,nodes([connected])) of
 	true ->
-	    monitor_nodes(false,[{node_type,all}]),
+	    ok = monitor_nodes(false,[{node_type,all}]),
 	    Parent ! {self(),true};
 	_ ->
 	    Ref = make_ref(),
 	    Tref = erlang:send_after(connecttime(),self(),Ref),
 	    receive
 		Ref ->
-		    monitor_nodes(false,[{node_type,all}]),
+		    ok = monitor_nodes(false,[{node_type,all}]),
 		    Parent ! {self(), false};
 		{nodeup,Node,_} ->
-		    monitor_nodes(false,[{node_type,all}]),
+		    ok = monitor_nodes(false,[{node_type,all}]),
 		    _ = erlang:cancel_timer(Tref),
 		    Parent ! {self(),true}
 	    end
@@ -734,7 +734,7 @@ handle_info(transition_period_end,
 				       how = How}} = State) ->
     ?tckr_dbg(transition_period_ended),
     case How of
-	shorter -> Tckr ! {new_ticktime, T};
+	shorter -> Tckr ! {new_ticktime, T}, done;
 	_       -> done
     end,
     {noreply,State#state{tick = #tick{ticker = Tckr, time = T}}};
@@ -1573,9 +1573,10 @@ async_gen_server_reply(From, Msg) ->
         ok ->
             ok;
         nosuspend ->
-            spawn(fun() -> catch erlang:send(Pid, M, [noconnect]) end);
+            _ = spawn(fun() -> catch erlang:send(Pid, M, [noconnect]) end),
+	    ok;
         noconnect ->
             ok; % The gen module takes care of this case.
-        {'EXIT', _}=EXIT ->
-            EXIT
+        {'EXIT', _} ->
+            ok
     end.
diff --git a/lib/kernel/src/pg2.erl b/lib/kernel/src/pg2.erl
index 2cfbcc9189..b562d4ffd2 100644
--- a/lib/kernel/src/pg2.erl
+++ b/lib/kernel/src/pg2.erl
@@ -165,7 +165,7 @@ get_closest_pid(Name) ->
 
 init([]) ->
     Ns = nodes(),
-    net_kernel:monitor_nodes(true),
+    ok = net_kernel:monitor_nodes(true),
     lists:foreach(fun(N) ->
                           {?MODULE, N} ! {new_pg2, node()},
                           self() ! {nodeup, N}
diff --git a/lib/kernel/src/seq_trace.erl b/lib/kernel/src/seq_trace.erl
index a90b7b07c8..38a61f4644 100644
--- a/lib/kernel/src/seq_trace.erl
+++ b/lib/kernel/src/seq_trace.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1998-2011. All Rights Reserved.
+%% Copyright Ericsson AB 1998-2013. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -125,7 +125,7 @@ get_system_tracer() ->
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
 set_token2([{Type,Val}|T]) ->
-    erlang:seq_trace(Type, Val),
+    _ = erlang:seq_trace(Type, Val),
     set_token2(T);
 set_token2([]) ->
     ok.