Remove erlang:now() and random usage in tests

2 files changed, 30 insertions, 49 deletions

diff --git a/lib/mnesia/examples/bench/bench_generate.erl b/lib/mnesia/examples/bench/bench_generate.erl
index 7a701812a7..e838f07fbb 100644
--- a/lib/mnesia/examples/bench/bench_generate.erl
+++ b/lib/mnesia/examples/bench/bench_generate.erl
@@ -153,9 +153,7 @@ generator_init(Monitor, C) ->
     process_flag(trap_exit, true),
     Tables = mnesia:system_info(tables),
     ok = mnesia:wait_for_tables(Tables, infinity),
-    {_Mega, Sec, Micro} = erlang:now(),
-    Uniq = lists:sum(binary_to_list(term_to_binary(make_ref()))),
-    random:seed(Uniq, Sec, Micro),
+    rand:seed(exsplus),
     Counters = reset_counters(C, C#config.statistics_detail),
     SessionTab = ets:new(bench_sessions, [public, {keypos, 1}]),
     generator_loop(Monitor, C, SessionTab, Counters).
@@ -189,9 +187,9 @@ generator_loop(Monitor, C, SessionTab, Counters) ->
     after 0 ->
 	    {Name, {Nodes, Activity, Wlock}, Fun, CommitSessions} =
 		gen_trans(C, SessionTab),
-	    Before = erlang:now(),
+	    Before = erlang:monotonic_time(),
 	    Res  = call_worker(Nodes, Activity, Fun, Wlock, mnesia_frag),
-	    After = erlang:now(),
+	    After = erlang:monotonic_time(),
 	    Elapsed = elapsed(Before, After),
 	    post_eval(Monitor, C, Elapsed, Res, Name, CommitSessions, SessionTab, Counters)
     end.
@@ -253,10 +251,8 @@ worker_loop(Parent) ->
     end.
 
 
-elapsed({Before1, Before2, Before3}, {After1, After2, After3}) ->
-    After  = After1  * 1000000000000  + After2  * 1000000 + After3,
-    Before = Before1 * 1000000000000  + Before2 * 1000000 + Before3,
-    After - Before.
+elapsed(Before, After) ->
+    erlang:convert_time_unit(After-Before, native, micro_seconds).
 
 %% Lookup counters
 get_counters(_C, {table, Tab}) ->
@@ -351,7 +347,7 @@ commit_session(Fun) when is_function(Fun, 0) ->
 
 %% Randlomly choose a transaction type according to benchmar spec
 gen_trans(C, SessionTab) when C#config.generator_profile == random ->
-    case random:uniform(100) of
+    case rand:uniform(100) of
         Rand when Rand >   0, Rand =<  25 -> gen_t1(C, SessionTab);
         Rand when Rand >  25, Rand =<  50 -> gen_t2(C, SessionTab);
         Rand when Rand >  50, Rand =<  70 -> gen_t3(C, SessionTab);
@@ -369,7 +365,7 @@ gen_trans(C, SessionTab) ->
     end.
         
 gen_t1(C, _SessionTab) ->
-    SubscrId    = random:uniform(C#config.n_subscribers) - 1,
+    SubscrId    = rand:uniform(C#config.n_subscribers) - 1,
     SubscrKey   = bench_trans:number_to_key(SubscrId, C),
     Location    = 4711,
     ChangedBy   = <<4711:(8*25)>>,
@@ -381,7 +377,7 @@ gen_t1(C, _SessionTab) ->
     }.
 
 gen_t2(C, _SessionTab) ->
-    SubscrId  = random:uniform(C#config.n_subscribers) - 1,
+    SubscrId  = rand:uniform(C#config.n_subscribers) - 1,
     SubscrKey = bench_trans:number_to_key(SubscrId, C),
     {t2,
      nearest_node(SubscrId, sync_dirty, C),
@@ -395,9 +391,9 @@ gen_t3(C, SessionTab) ->
 	'$end_of_table' ->
 	    %% This generator does not have any session,
 	    %% try reading someone elses session details
-	    SubscrId  = random:uniform(C#config.n_subscribers) - 1,
+	    SubscrId  = rand:uniform(C#config.n_subscribers) - 1,
 	    SubscrKey = bench_trans:number_to_key(SubscrId, C),
-	    ServerId  = random:uniform(C#config.n_servers) - 1,
+	    ServerId  = rand:uniform(C#config.n_servers) - 1,
 	    ServerBit = 1 bsl ServerId,
 	    {t3,
 	     nearest_node(SubscrId, transaction, C),
@@ -419,12 +415,12 @@ gen_t4(C, SessionTab) ->
     %% This generator may already have sessions,
     %% create a new session and hope that no other
     %% generator already has occupied it
-    SubscrId   = random:uniform(C#config.n_subscribers) - 1,
+    SubscrId   = rand:uniform(C#config.n_subscribers) - 1,
     SubscrKey  = bench_trans:number_to_key(SubscrId, C),
-    ServerId   = random:uniform(C#config.n_servers) - 1,
+    ServerId   = rand:uniform(C#config.n_servers) - 1,
     ServerBit  = 1 bsl ServerId,
     Details    = <<4711:(8*2000)>>,
-    DoRollback = (random:uniform(100) =< 2),
+    DoRollback = (rand:uniform(100) =< 2),
     Insert     = fun() -> ets:insert(SessionTab, {{SubscrId, SubscrKey, ServerId}, self()}) end,
     {t4,
      nearest_node(SubscrId, transaction, C),
@@ -437,11 +433,11 @@ gen_t5(C, SessionTab) ->
 	'$end_of_table' ->
 	    %% This generator does not have any session,
 	    %% try to delete someone elses session details
-	    SubscrId   = random:uniform(C#config.n_subscribers) - 1,
+	    SubscrId   = rand:uniform(C#config.n_subscribers) - 1,
 	    SubscrKey  = bench_trans:number_to_key(SubscrId, C),
-	    ServerId   = random:uniform(C#config.n_servers) - 1,
+	    ServerId   = rand:uniform(C#config.n_servers) - 1,
 	    ServerBit  = 1 bsl ServerId,
-	    DoRollback = (random:uniform(100) =< 2),
+	    DoRollback = (rand:uniform(100) =< 2),
 	    {t5,
 	     nearest_node(SubscrId, transaction, C),
 	     fun(Wlock) -> bench_trans:delete_session_from_server(Wlock, SubscrKey, ServerBit, ServerId, DoRollback) end,
@@ -451,7 +447,7 @@ gen_t5(C, SessionTab) ->
 	    %% This generator do have at least one session,
 	    %% delete it.
 	    ServerBit  = 1 bsl ServerId,	
-	    DoRollback = (random:uniform(100) =< 2),
+	    DoRollback = (rand:uniform(100) =< 2),
 	    Delete     = fun() -> ets:delete(SessionTab, {SubscrId, SubscrKey, ServerId}) end,
 	    {t5,
 	     nearest_node(SubscrId, transaction, C),
@@ -461,7 +457,7 @@ gen_t5(C, SessionTab) ->
     end.
 
 gen_ping(C, _SessionTab) ->
-    SubscrId   = random:uniform(C#config.n_subscribers) - 1,
+    SubscrId   = rand:uniform(C#config.n_subscribers) - 1,
     {ping,
      nearest_node(SubscrId, transaction, C),
      fun(_Wlock) -> {do_commit, true, []} end,
diff --git a/lib/mnesia/examples/mnesia_tpcb.erl b/lib/mnesia/examples/mnesia_tpcb.erl
index fde6cf402e..c6eda1c448 100644
--- a/lib/mnesia/examples/mnesia_tpcb.erl
+++ b/lib/mnesia/examples/mnesia_tpcb.erl
@@ -164,7 +164,7 @@
 -record(history,
 	{
 	 history_id  = {0, 0}, % {DriverId, DriverLocalHistoryid}
-	 time_stamp  = now(),  % Time point during active transaction
+	 time_stamp  = erlang:system_time(),  % Time point during active transaction
 	 branch_id   = 0,      % Branch associated with teller
 	 teller_id   = 0,      % Teller invlolved in transaction
 	 account_id  = 0,      % Account updated by transaction
@@ -412,9 +412,8 @@ config(remote_frag2_test, ReplicaType) ->
 config(conflict_benchmark, ReplicaType) ->
     Remote = nodes(),
     Local = node(),
-    Nodes = [Local | Remote], 
-    [{seed, {1326,448637,337711}},
-     {db_nodes, Nodes},
+    Nodes = [Local | Remote],
+    [{db_nodes, Nodes},
      {driver_nodes, Nodes},
      {replica_nodes, Nodes},
      {n_drivers_per_node, 10},
@@ -758,7 +757,7 @@ reporter_init(Starter, RC) ->
 		     replica_type = Type
 		    },
     Drivers = start_drivers(RC, TC),
-    Now = now_to_micros(erlang:now()),
+    Now = erlang:monotonic_time(),
     State = #reporter_state{driver_pids = Drivers,
 			    run_config = RC,
 			    starter_pid = Starter,
@@ -896,7 +895,7 @@ add_time(Acc, New) ->
 -define(AVOID_DIV_ZERO(_What_), try (_What_) catch _:_ -> 0 end).
 
 show_report(State) ->
-    Now    = now_to_micros(erlang:now()),
+    Now    = erlang:timestamp(),
     Iters  = State#reporter_state.n_iters,
     Cfg    = State#reporter_state.run_config,
     Time   = State#reporter_state.curr,
@@ -924,14 +923,14 @@ show_report(State) ->
     case Cfg#run_config.send_bench_report of
 	true ->
 	    ct_event:notify(
-	      #event{name = benchmark_data, 
+	      #event{name = benchmark_data,
 		     data = [{suite,"mnesia_tpcb"},
 			     {value,Tps}]});
 	_ ->
 	    ok
     end,
 
-    State#reporter_state{prev_tps = Tps, prev_micros = Now}.	    
+    State#reporter_state{prev_tps = Tps, prev_micros = Now}.
 
 signed_diff(Iters, Curr, Prev) ->
     case Iters > 1 of
@@ -941,11 +940,6 @@ signed_diff(Iters, Curr, Prev) ->
     
 sign(N) when N > 0 -> {"+", N};
 sign(N) -> {"", N}.
-
-now_to_micros({Mega, Secs, Micros}) ->
-    DT = calendar:now_to_datetime({Mega, Secs, 0}),
-    S  = calendar:datetime_to_gregorian_seconds(DT),
-    (S * ?SECOND) + Micros.
     
 start_drivers(RC, TC) ->
     LastHistoryId = table_info(history, size),
@@ -998,13 +992,11 @@ alloc_local_branches([], Specs, OrphanBranches) ->
     {Specs, OrphanBranches}.
     
 driver_init(DS, AllBranches) ->
-    case (DS#driver_state.run_config)#run_config.seed of
-	undefined ->
-	    Seed = erlang:now();
-	Seed ->
-	    Seed
+    Seed = case (DS#driver_state.run_config)#run_config.seed of
+	       undefined -> rand:seed(exsplus);
+	       ExpSeed -> rand:seed(ExpSeed)
     end,
-    
+
     DS2 =
 	if
 	    DS#driver_state.n_local_branches =:= 0 ->
@@ -1058,14 +1050,7 @@ calc_trans(DS) ->
 %% Generate teller_id, account_id and delta
 %% Time the TPC-B transaction
 time_trans(DS) ->
-    OldSeed = get(random_seed), % Avoid interference with Mnesia
-    put(random_seed, DS#driver_state.seed),
-    Random    = random:uniform(),
-    NewSeed   = get(random_seed),
-    case OldSeed of
-	undefined -> erase(random_seed);
-	_         -> put(random_seed, OldSeed)
-    end,
+    {Random, NewSeed} = rand:uniform_s(DS#driver_state.seed),
 
     TC = DS#driver_state.tab_config,
     RC = DS#driver_state.run_config,