Merge branch 'richcarl/dcd-dumps'

* richcarl/dcd-dumps:
  Make Mnesia DCD dump behaviour available via API
  Make Mnesia DCD dump behaviour available via configuration

OTP-12481

1 files changed, 39 insertions, 21 deletions

diff --git a/lib/mnesia/src/mnesia_dumper.erl b/lib/mnesia/src/mnesia_dumper.erl
index 14665797a0..509b765dee 100644
--- a/lib/mnesia/src/mnesia_dumper.erl
+++ b/lib/mnesia/src/mnesia_dumper.erl
@@ -34,11 +34,13 @@
 -export([
 	 get_log_writes/0,
 	 incr_log_writes/0,
+         needs_dump_ets/1,
 	 raw_dump_table/2,
 	 raw_named_dump_table/2,
 	 start_regulator/0,
 	 opt_dump_log/1,
-	 update/3
+	 update/3,
+	 snapshot_dcd/1
 	]).
 
  %% Internal stuff
@@ -99,6 +101,19 @@ opt_dump_log(InitBy) ->
 	  end,
     perform_dump(InitBy, Reg).
 
+snapshot_dcd(Tables) ->
+    lists:foreach(
+      fun(Tab) ->
+	      case mnesia_lib:storage_type_at_node(node(), Tab) of
+		  disc_copies ->
+		      mnesia_log:ets2dcd(Tab);
+		  _ ->
+		      %% Storage type was checked before queueing the op, though
+		      skip
+	      end
+      end, Tables),
+    dumped.
+
 %% Scan for decisions
 perform_dump(InitBy, Regulator) when InitBy == scan_decisions ->
     ?eval_debug_fun({?MODULE, perform_dump}, [InitBy]),
@@ -981,28 +996,10 @@ open_files(_Tab, _Storage, _UpdateInPlace, _InitBy) ->
     false.
 
 open_disc_copies(Tab, InitBy) ->
-    DclF = mnesia_lib:tab2dcl(Tab),
-    DumpEts =
-	case file:read_file_info(DclF) of
-	    {error, enoent} ->
-		false;
-	    {ok, DclInfo} ->
-		DcdF =  mnesia_lib:tab2dcd(Tab),
-		case file:read_file_info(DcdF) of
-		    {error, Reason} ->
-			mnesia_lib:dbg_out("File ~p info_error ~p ~n",
-					   [DcdF, Reason]),
-			true;
-		    {ok, DcdInfo} ->
-			Mul = case ?catch_val(dc_dump_limit) of
-				  {'EXIT', _} -> ?DumpToEtsMultiplier;
-				  Val -> Val
-			      end,
-			DcdInfo#file_info.size =< (DclInfo#file_info.size * Mul)
-		end
-	end,
+    DumpEts = needs_dump_ets(Tab),
     if
 	DumpEts == false; InitBy == startup ->
+            DclF = mnesia_lib:tab2dcl(Tab),
 	    mnesia_log:open_log({?MODULE,Tab},
 				mnesia_log:dcl_log_header(),
 				DclF,
@@ -1017,6 +1014,27 @@ open_disc_copies(Tab, InitBy) ->
 	    false
     end.
 
+needs_dump_ets(Tab) ->
+    DclF = mnesia_lib:tab2dcl(Tab),
+    case file:read_file_info(DclF) of
+        {error, enoent} ->
+            false;
+        {ok, DclInfo} ->
+            DcdF =  mnesia_lib:tab2dcd(Tab),
+            case file:read_file_info(DcdF) of
+                {error, Reason} ->
+                    mnesia_lib:dbg_out("File ~p info_error ~p ~n",
+                                       [DcdF, Reason]),
+                    true;
+                {ok, DcdInfo} ->
+                    Mul = case ?catch_val(dc_dump_limit) of
+                              {'EXIT', _} -> ?DumpToEtsMultiplier;
+                              Val -> Val
+                          end,
+                    DcdInfo#file_info.size =< (DclInfo#file_info.size * Mul)
+            end
+    end.
+
 %% Always opens the dcl file for writing overriding already_dumped
 %% mechanismen, used for schema transactions.
 open_dcl(Tab) ->