mnesia: Replace catch with try-catch

Avoids building stacktraces where it is not needed and do
not mask errors, i.e. only catch the relevant classes in each try.

3 files changed, 31 insertions, 13 deletions

diff --git a/lib/mnesia/test/mnesia_config_backup.erl b/lib/mnesia/test/mnesia_config_backup.erl
index 0916e255e2..a7d8c04a45 100644
--- a/lib/mnesia/test/mnesia_config_backup.erl
+++ b/lib/mnesia/test/mnesia_config_backup.erl
@@ -90,7 +90,8 @@ open_read(Name) ->
 	    List = lists:reverse(ReverseList),
 	    {ok, #backup{name = Name, mode = read, items = List}};
 	{error, Reason} ->
-	    {error, {open_read, Reason}}
+	    %% {error, {open_read, Reason}}
+	    {Reason, error} %% Testing error handling in mnesia
     end.
 
 read(Opaque) when Opaque#backup.mode == read ->
diff --git a/lib/mnesia/test/mnesia_config_test.erl b/lib/mnesia/test/mnesia_config_test.erl
index c495bce63f..a8fb93b28e 100644
--- a/lib/mnesia/test/mnesia_config_test.erl
+++ b/lib/mnesia/test/mnesia_config_test.erl
@@ -37,7 +37,6 @@
 	
 	 dump_log_update_in_place/1,
 	 event_module/1,
-	 ignore_fallback_at_startup/1,
 	 inconsistent_database/1,
 	 max_wait_for_decision/1,
 	 send_compressed/1,
@@ -104,7 +103,7 @@ all() ->
     [access_module, auto_repair, backup_module, debug, dir,
      dump_log_load_regulation, {group, dump_log_thresholds},
      dump_log_update_in_place,
-     event_module, ignore_fallback_at_startup,
+     event_module,
      inconsistent_database, max_wait_for_decision,
      send_compressed, app_test, {group, schema_config},
      unknown_config].
@@ -317,11 +316,17 @@ backup_module(Config) when is_list(Config) ->
     ?match([], mnesia_test_lib:start_mnesia(Nodes, [test_table, test_table2])),
 
     %% Now check newly started tables
-    ?match({atomic, [1,2]}, 
+    ?match({atomic, [1,2]},
 	   mnesia:transaction(fun() -> lists:sort(mnesia:all_keys(test_table)) end)),
-    ?match({atomic, [3,4]}, 
+    ?match({atomic, [3,4]},
 	   mnesia:transaction(fun() -> lists:sort(mnesia:all_keys(test_table2)) end)),
-    
+
+    %% Test some error cases
+    mnesia:set_debug_level(debug),
+    ?match({error, _}, mnesia:install_fallback("NonExisting.FILE")),
+    ?match({error, _}, mnesia:install_fallback(filename:join(mnesia_lib:dir(), "LATEST.LOG"))),
+
+    %% Cleanup
     file:delete(File),
     ?verify_mnesia(Nodes, []),
     ?cleanup(1, Config),
@@ -609,13 +614,6 @@ dump_log_load_regulation(Config) when is_list(Config) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-ignore_fallback_at_startup(doc) ->
-    ["Start Mnesia without rollback of the database to the fallback. ",
-     "Once Mnesia has been (re)started the installed fallback should",
-     "be handled as a normal active fallback.",
-     "Install a customized event module which disables the termination",
-     "of Mnesia when mnesia_down occurrs with an active fallback."].
-
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
 max_wait_for_decision(doc) ->
diff --git a/lib/mnesia/test/mnesia_evil_backup.erl b/lib/mnesia/test/mnesia_evil_backup.erl
index 9e0a8db1ae..68efa3f6ea 100644
--- a/lib/mnesia/test/mnesia_evil_backup.erl
+++ b/lib/mnesia/test/mnesia_evil_backup.erl
@@ -142,6 +142,9 @@ restore_errors(Config) when is_list(Config) ->
     ?match({aborted, {badarg, _}}, mnesia:restore(notAfile, [{skip_tables, xxx}])),
     ?match({aborted, {badarg, _}}, mnesia:restore(notAfile, [{recreate_tables, [schema]}])),
     ?match({aborted, {badarg, _}}, mnesia:restore(notAfile, [{default_op, asdklasd}])),
+    MnesiaDir = mnesia_lib:dir(),
+    ?match({aborted, {not_a_log_file, _}}, mnesia:restore(filename:join(MnesiaDir, "schema.DAT"), [])),
+    ?match({aborted, _}, mnesia:restore(filename:join(MnesiaDir, "LATEST.LOG"), [])),
     ok.
 
 restore_clear(suite) -> [];
@@ -488,6 +491,14 @@ install_fallback(Config) when is_list(Config) ->
     mnesia_test_lib:kill_mnesia([Node1, Node2]),
     timer:sleep(timer:seconds(1)), % Let it die!
 
+    ok = mnesia:start([{ignore_fallback_at_startup, true}]),
+    ok = mnesia:wait_for_tables([Tab, Tab2, Tab3], 10000),
+    ?match([{Tab, 6, test_nok}], mnesia:dirty_read({Tab, 6})),
+    mnesia_test_lib:kill_mnesia([Node1]),
+    application:set_env(mnesia, ignore_fallback_at_startup, false),
+
+    timer:sleep(timer:seconds(1)), % Let it die!
+
     ?match([], mnesia_test_lib:start_mnesia([Node1, Node2], [Tab, Tab2, Tab3])),
 
     % Verify 
@@ -510,6 +521,13 @@ install_fallback(Config) when is_list(Config) ->
     file:delete(File3),
     ?match({error, _}, mnesia:install_fallback(File3)),
     ?match({error, _}, mnesia:install_fallback(File2, mnesia_badmod)),
+    ?match({error, _}, mnesia:install_fallback(File2, {foo, foo})),
+    ?match({error, _}, mnesia:install_fallback(File2, [{foo, foo}])),
+    ?match({error, {badarg, {skip_tables, _}}},
+	   mnesia:install_fallback(File2, [{default_op, skip_tables},
+					   {default_op, keep_tables},
+					   {keep_tables, [Tab, Tab2, Tab3]},
+					   {skip_tables, [foo,{asd}]}])),
     ?match(ok, mnesia:install_fallback(File2, mnesia_backup)),
     ?match(ok, file:delete(File)),
     ?match(ok, file:delete(File2)),
@@ -535,6 +553,7 @@ uninstall_fallback(Config) when is_list(Config) ->
     ?match(ok, mnesia:install_fallback(File2)),
     ?match(ok, file:delete(File)),
     ?match(ok, file:delete(File2)),
+    ?match({error, _}, mnesia:uninstall_fallback([foobar])),
     ?match(ok, mnesia:uninstall_fallback()),
     
     mnesia_test_lib:kill_mnesia([Node1, Node2]),