Merge branch 'dgud/mnesia/use_now_in_tests' into maint

* dgud/mnesia/use_now_in_tests:
  Remove erlang:now() and random usage in tests

8 files changed, 91 insertions, 63 deletions

diff --git a/lib/mnesia/test/mnesia_atomicity_test.erl b/lib/mnesia/test/mnesia_atomicity_test.erl
index 1d9d9c35bc..e3e0eaaf75 100644
--- a/lib/mnesia/test/mnesia_atomicity_test.erl
+++ b/lib/mnesia/test/mnesia_atomicity_test.erl
@@ -557,8 +557,8 @@ start_lock_waiter(BlockOpA, BlockOpB, Config) ->
     ?verify_mnesia([N1], [N2]).
 
 mk_tab_name(Prefix) ->
-    {Mega, Sec, Micro} = erlang:now(),
-    list_to_atom(lists:concat([Prefix , Mega, '_', Sec, '_', Micro])).
+    Count = erlang:unique_integer([monotonic,positive]),
+    list_to_atom(lists:concat([Prefix , '_', Count])).
 
 lock_waiter_fun(Op, TabName, Val) ->
     case Op of
diff --git a/lib/mnesia/test/mnesia_config_test.erl b/lib/mnesia/test/mnesia_config_test.erl
index c8a6a000c6..089fbc06dc 100644
--- a/lib/mnesia/test/mnesia_config_test.erl
+++ b/lib/mnesia/test/mnesia_config_test.erl
@@ -1206,7 +1206,7 @@ dynamic_ext(Config) when is_list(Config) ->
 	    end,
     [Check(Test) || Test <- [{tab1, ram_copies},{tab2, disc_copies},{tab3, disc_only_copies}]],
     
-    T = now(),
+    T = erlang:unique_integer(),
     ?match(ok, mnesia:dirty_write({tab0, 42, T})),
     ?match(ok, mnesia:dirty_write({tab1, 42, T})),
     ?match(ok, mnesia:dirty_write({tab2, 42, T})),
@@ -1284,7 +1284,7 @@ check_storage(Me, Orig, Other) ->
     
     mnesia_test_lib:kill_mnesia([Orig]),
     mnesia_test_lib:kill_mnesia(Other),
-    T = now(),
+    T = erlang:unique_integer(),
     ?match(ok, rpc:call(Me, mnesia, dirty_write, [{tab2, 42, T}])),
     ?match(stopped, rpc:call(Me, mnesia, stop, [])),
     ?match(ok, rpc:call(Me, mnesia, start, [])),   
diff --git a/lib/mnesia/test/mnesia_cost.erl b/lib/mnesia/test/mnesia_cost.erl
index ff0108ced1..714dbaef27 100644
--- a/lib/mnesia/test/mnesia_cost.erl
+++ b/lib/mnesia/test/mnesia_cost.erl
@@ -108,11 +108,11 @@ run(What, OtherInfo, Ops, F) ->
     run(t, What, OtherInfo, Ops, F).
 
 run(How, What, OtherInfo, Ops, F) ->
-    T1 = erlang:now(),
+    T1 = erlang:monotonic_time(),
     statistics(runtime),
     do_times(How, ?TIMES, F),
     {_, RunTime} = statistics(runtime),
-    T2 = erlang:now(),
+    T2 = erlang:monotonic_time(),
     RealTime = subtr(T1, T2),
     report(How, What, OtherInfo, Ops, RunTime, RealTime).
 
@@ -140,11 +140,7 @@ report(dirty, What, OtherInfo, Ops, RunTime, RealTime) ->
 
 
 subtr(Before, After) ->
-    E =(element(1,After)*1000000000000
-	+element(2,After)*1000000+element(3,After)) -
-        (element(1,Before)*1000000000000
-         +element(2,Before)*1000000+element(3,Before)),
-    E div 1000.
+    erlang:convert_time_unit(After-Before, native, milli_seconds).
 
 do_times(t, I, F) ->
     do_trans_times(I, F);
diff --git a/lib/mnesia/test/mnesia_dbn_meters.erl b/lib/mnesia/test/mnesia_dbn_meters.erl
index f97bd973fc..5c3ea08a1d 100644
--- a/lib/mnesia/test/mnesia_dbn_meters.erl
+++ b/lib/mnesia/test/mnesia_dbn_meters.erl
@@ -93,7 +93,7 @@ some_meters() ->
 report_meter(Meter) ->
     Times = 100,
     Micros = repeat_meter(Meter,{atomic,{0,ignore}},Times) div Times,
-    io:format("\t~-30w ~-10w micro seconds (mean of ~p repetitions)~n",[Meter,Micros,Times]).
+    io:format("\t~-30w ~-10w nano seconds (mean of ~p repetitions)~n",[Meter,Micros,Times]).
 
 repeat_meter(_Meter,{atomic,{Micros,_Result}},0) ->
     Micros;
@@ -110,9 +110,9 @@ meter(create) ->
     Key = 1,
     mnesia:transaction(fun() -> mnesia:delete({simple,Key}) end),
     Fun = fun() ->
-		  BeforeT = erlang:now(),
+		  BeforeT = erlang:monotonic_time(),
 		  R = mnesia:write(#simple{key=Key}),
-		  AfterT = erlang:now(),
+		  AfterT = erlang:monotonic_time(),
 		  elapsed_time(BeforeT,AfterT,R)
 	  end,
     mnesia:transaction(Fun);
@@ -121,9 +121,9 @@ meter(open_safe_read) ->
     Key = 2,
     mnesia:transaction(fun() -> mnesia:write(#simple{key=Key}) end),
     Fun = fun() ->
-		  BeforeT = erlang:now(),
+		  BeforeT = erlang:monotonic_time(),
 		  R = mnesia:read({simple,Key}),
-		  AfterT = erlang:now(),
+		  AfterT = erlang:monotonic_time(),
 		  elapsed_time(BeforeT,AfterT,R)
 	  end,
     mnesia:transaction(Fun);
@@ -132,9 +132,9 @@ meter(open_dirty_read) ->
     Key = 21,
     mnesia:transaction(fun() -> mnesia:write(#simple{key=Key}) end),
     Fun = fun() ->
-		  BeforeT = erlang:now(),
+		  BeforeT = erlang:monotonic_time(),
 		  R = mnesia:dirty_read({simple,Key}),
-		  AfterT = erlang:now(),
+		  AfterT = erlang:monotonic_time(),
 		  elapsed_time(BeforeT,AfterT,R)
 	  end,
     mnesia:transaction(Fun);
@@ -144,9 +144,9 @@ meter(get_int) ->
     mnesia:transaction(fun() -> mnesia:write(#simple{key=Key}) end),
     Fun = fun() ->
 		  [Simple] = mnesia:read({simple,Key}),
-		  BeforeT = erlang:now(),
+		  BeforeT = erlang:monotonic_time(),
 		  Int = Simple#simple.val,
-		  AfterT = erlang:now(),
+		  AfterT = erlang:monotonic_time(),
 		  elapsed_time(BeforeT,AfterT,Int)
 	  end,
     mnesia:transaction(Fun);
@@ -155,9 +155,9 @@ meter(open_update) ->
     Key = 3,
     mnesia:transaction(fun() -> mnesia:write(#simple{key=Key}) end),
     Fun = fun() ->
-		  BeforeT = erlang:now(),
+		  BeforeT = erlang:monotonic_time(),
 		  R = mnesia:wread({simple,Key}),
-		  AfterT = erlang:now(),
+		  AfterT = erlang:monotonic_time(),
 		  elapsed_time(BeforeT,AfterT,R)
 	  end,
     mnesia:transaction(Fun);
@@ -167,9 +167,9 @@ meter(put_int) ->
     mnesia:transaction(fun() -> mnesia:write(#simple{key=Key}) end),
     Fun = fun() ->
 		  [Simple] = mnesia:wread({simple,Key}),
-		  BeforeT = erlang:now(),
+		  BeforeT = erlang:monotonic_time(),
 		  R = Simple#simple{val=7},
-		  AfterT = erlang:now(),
+		  AfterT = erlang:monotonic_time(),
 		  elapsed_time(BeforeT,AfterT,R)
 	  end,
     mnesia:transaction(Fun);
@@ -179,10 +179,10 @@ meter(put_int_and_copy) ->
     mnesia:transaction(fun() -> mnesia:write(#simple{key=Key}) end),
     Fun = fun() ->
 		  [Simple] = mnesia:wread({simple,Key}),
-		  BeforeT = erlang:now(),
+		  BeforeT = erlang:monotonic_time(),
 		  Simple2 = Simple#simple{val=17},
 		  R = mnesia:write(Simple2),
-		  AfterT = erlang:now(),
+		  AfterT = erlang:monotonic_time(),
 		  elapsed_time(BeforeT,AfterT,R)
 	  end,
     mnesia:transaction(Fun);
@@ -191,15 +191,15 @@ meter(dirty_put_int_and_copy) ->
     Key = 55,
     mnesia:dirty_write(#simple{key=Key}),
     [Simple] = mnesia:dirty_read({simple,Key}),
-    BeforeT = erlang:now(),
+    BeforeT = erlang:monotonic_time(),
     Simple2 = Simple#simple{val=17},
     R = mnesia:dirty_write(Simple2),
-    AfterT = erlang:now(),
+    AfterT = erlang:monotonic_time(),
     {atomic,elapsed_time(BeforeT,AfterT,R)};
 
 meter(start_trans) ->
-    BeforeT = erlang:now(),
-    {atomic,AfterT} = mnesia:transaction(fun() -> erlang:now() end),
+    BeforeT = erlang:monotonic_time(),
+    {atomic,AfterT} = mnesia:transaction(fun() -> erlang:monotonic_time() end),
     {atomic,elapsed_time(BeforeT,AfterT,ok)};
 
 meter(commit_one_update) ->
@@ -209,19 +209,19 @@ meter(commit_one_update) ->
 		  [Simple] = mnesia:wread({simple,Key}),
 		  Simple2 = Simple#simple{val=27},
 		  _R = mnesia:write(Simple2),
-		  erlang:now()
+		  erlang:monotonic_time()
 	  end,
     {atomic,BeforeT} = mnesia:transaction(Fun),
-    AfterT = erlang:now(),
+    AfterT = erlang:monotonic_time(),
     {atomic,elapsed_time(BeforeT,AfterT,ok)};
 
 meter(delete) ->
     Key = 7,
     mnesia:transaction(fun() -> mnesia:write(#simple{key=Key}) end),
     Fun = fun() ->
-		  BeforeT = erlang:now(),
+		  BeforeT = erlang:monotonic_time(),
 		  R = mnesia:delete({simple,Key}),
-		  AfterT = erlang:now(),
+		  AfterT = erlang:monotonic_time(),
 		  elapsed_time(BeforeT,AfterT,R)
 	  end,
     mnesia:transaction(Fun);
@@ -229,15 +229,12 @@ meter(delete) ->
 meter(dirty_delete) ->
     Key = 75,
     mnesia:dirty_write(#simple{key=Key}),
-    BeforeT = erlang:now(),
+    BeforeT = erlang:monotonic_time(),
     R = mnesia:dirty_delete({simple,Key}),
-    AfterT = erlang:now(),
+    AfterT = erlang:monotonic_time(),
     {atomic, elapsed_time(BeforeT,AfterT,R)}.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %% Calculate the elapsed time
 elapsed_time(BeforeT,AfterT,Result) ->
-    {(element(1,AfterT)*1000000000000
-     +element(2,AfterT)*1000000+element(3,AfterT)) -
-	(element(1,BeforeT)*1000000000000
-	 +element(2,BeforeT)*1000000+element(3,BeforeT)),Result}.
+    {erlang:convert_time_unit(AfterT-BeforeT, native, nano_seconds),Result}.
diff --git a/lib/mnesia/test/mnesia_evil_backup.erl b/lib/mnesia/test/mnesia_evil_backup.erl
index 5392267f79..89f2861661 100644
--- a/lib/mnesia/test/mnesia_evil_backup.erl
+++ b/lib/mnesia/test/mnesia_evil_backup.erl
@@ -229,7 +229,7 @@ restore(Config, Op)  ->
     [mnesia:dirty_write({Tab1, N, N+1}) || N <- lists:seq(1, 11)],
     [mnesia:dirty_write({Tab2, N, N+1}) || N <- lists:seq(1, 11)],
     [mnesia:dirty_write({Tab3, N, N+1}) || N <- lists:seq(1, 11)],
-    _Res11 = [{Tab1, N, N+1} || N <- lists:seq(1, 11)],
+
     Res21 = [{Tab2, N, N+1} || N <- lists:seq(1, 11)],
     Res31 = [[{Tab3, N, N+1}, {Tab3, N, N+44}] || N <- lists:seq(1, 10)],
     
diff --git a/lib/mnesia/test/mnesia_isolation_test.erl b/lib/mnesia/test/mnesia_isolation_test.erl
index 6abb1f7cdc..b66da6e390 100644
--- a/lib/mnesia/test/mnesia_isolation_test.erl
+++ b/lib/mnesia/test/mnesia_isolation_test.erl
@@ -1127,7 +1127,9 @@ update_shared(Tab, Me, Acc) ->
 	0 -> 
 	    case mnesia:transaction(Update) of
 		{atomic, {ok,Term,W2}} ->
-		    io:format("~p:~p:(~p,~p) ~w@~w~n", [erlang:now(),node(),Me,Acc,Term,W2]),
+		    io:format("~p:~p:(~p,~p) ~w@~w~n",
+			      [erlang:unique_integer([monotonic,positive]),
+			       node(),Me,Acc,Term,W2]),
 		    update_shared(Tab, Me, Acc+1);
 		Else -> 
 		    ?error("Trans failed on ~p with ~p~n"
diff --git a/lib/mnesia/test/mnesia_test_lib.erl b/lib/mnesia/test/mnesia_test_lib.erl
index 035d6bde87..9d3b277e07 100644
--- a/lib/mnesia/test/mnesia_test_lib.erl
+++ b/lib/mnesia/test/mnesia_test_lib.erl
@@ -238,8 +238,8 @@ slave_start_link() ->
 
 slave_start_link(Node) ->
     [Local, Host] = node_to_name_and_host(Node),
-    {Mega, Sec, Micro} = erlang:now(),
-    List = [Local, "_", Mega, "_", Sec, "_", Micro],
+    Count = erlang:unique_integer([positive]),
+    List = [Local, "_", Count],
     Name = list_to_atom(lists:concat(List)),
     slave_start_link(list_to_atom(Host), Name).
 
diff --git a/lib/mnesia/test/mnesia_tpcb.erl b/lib/mnesia/test/mnesia_tpcb.erl
index 3f936591b0..c6eda1c448 100644
--- a/lib/mnesia/test/mnesia_tpcb.erl
+++ b/lib/mnesia/test/mnesia_tpcb.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1996-2010. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2013. All Rights Reserved.
 %% 
 %% Licensed under the Apache License, Version 2.0 (the "License");
 %% you may not use this file except in compliance with the License.
@@ -100,9 +100,13 @@
 	 replica_test/1,
 	 sticky_replica_test/1,
 	 remote_test/1,
-	 remote_frag2_test/1
+	 remote_frag2_test/1,
+
+	 conflict_benchmark/1
 	]).
 
+-include_lib("common_test/include/ct_event.hrl").
+
 -define(SECOND, 1000000).
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -160,7 +164,7 @@
 -record(history,
 	{
 	 history_id  = {0, 0}, % {DriverId, DriverLocalHistoryid}
-	 time_stamp  = now(),  % Time point during active transaction
+	 time_stamp  = erlang:system_time(),  % Time point during active transaction
 	 branch_id   = 0,      % Branch associated with teller
 	 teller_id   = 0,      % Teller invlolved in transaction
 	 account_id  = 0,      % Account updated by transaction
@@ -192,8 +196,10 @@
 	  driver_nodes = [node()],
 	  n_drivers_per_node = 1,
 	  use_running_mnesia = false,
+	  seed,
 	  stop_after = timer:minutes(15), % Minimum 15 min
 	  report_interval = timer:minutes(1),
+	  send_bench_report = false,
 	  use_sticky_locks = false,
 	  spawn_near_branch = false,
 	  activity_type = transaction,
@@ -398,8 +404,29 @@ config(remote_frag2_test, ReplicaType) ->
      {stop_after, timer:minutes(1)},
      {report_interval, timer:seconds(10)},
      {reuse_history_id, true}
+    ];
+
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+%% Ten drivers per node, tables replicated to all nodes, single branch
+
+config(conflict_benchmark, ReplicaType) ->
+    Remote = nodes(),
+    Local = node(),
+    Nodes = [Local | Remote],
+    [{db_nodes, Nodes},
+     {driver_nodes, Nodes},
+     {replica_nodes, Nodes},
+     {n_drivers_per_node, 10},
+     {n_branches, 1},
+     {n_accounts_per_branch, 10},
+     {replica_type, ReplicaType},
+     {stop_after, timer:minutes(1)},
+     {report_interval, timer:seconds(10)},
+     {send_bench_report, true},
+     {reuse_history_id, true}
     ].
 
+
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
 start(What, ReplicaType) ->
@@ -423,6 +450,9 @@ remote_test(ReplicaType) ->
 remote_frag2_test(ReplicaType) ->
     start(remote_frag2_test, ReplicaType).
 
+conflict_benchmark(ReplicaType) ->
+    start(config(conflict_benchmark, ReplicaType)).
+
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %% Args is a list of {Key, Val} tuples where Key is a field name
 %% in either the record tab_config or run_config. Unknown keys are ignored.
@@ -727,7 +757,7 @@ reporter_init(Starter, RC) ->
 		     replica_type = Type
 		    },
     Drivers = start_drivers(RC, TC),
-    Now = now_to_micros(erlang:now()),
+    Now = erlang:monotonic_time(),
     State = #reporter_state{driver_pids = Drivers,
 			    run_config = RC,
 			    starter_pid = Starter,
@@ -865,8 +895,9 @@ add_time(Acc, New) ->
 -define(AVOID_DIV_ZERO(_What_), try (_What_) catch _:_ -> 0 end).
 
 show_report(State) ->
-    Now    = now_to_micros(erlang:now()),
+    Now    = erlang:timestamp(),
     Iters  = State#reporter_state.n_iters,
+    Cfg    = State#reporter_state.run_config,
     Time   = State#reporter_state.curr,
     Max    = Time#time.max_time,
     N      = Time#time.n_trans,
@@ -889,6 +920,16 @@ show_report(State) ->
 		      "duration of longest transaction was ~p milliseconds~n",
 		      [Tps, BruttoTps, Max div 1000])
     end,
+    case Cfg#run_config.send_bench_report of
+	true ->
+	    ct_event:notify(
+	      #event{name = benchmark_data,
+		     data = [{suite,"mnesia_tpcb"},
+			     {value,Tps}]});
+	_ ->
+	    ok
+    end,
+
     State#reporter_state{prev_tps = Tps, prev_micros = Now}.
 
 signed_diff(Iters, Curr, Prev) ->
@@ -899,11 +940,6 @@ signed_diff(Iters, Curr, Prev) ->
     
 sign(N) when N > 0 -> {"+", N};
 sign(N) -> {"", N}.
-
-now_to_micros({Mega, Secs, Micros}) ->
-    DT = calendar:now_to_datetime({Mega, Secs, 0}),
-    S  = calendar:datetime_to_gregorian_seconds(DT),
-    (S * ?SECOND) + Micros.
     
 start_drivers(RC, TC) ->
     LastHistoryId = table_info(history, size),
@@ -956,7 +992,11 @@ alloc_local_branches([], Specs, OrphanBranches) ->
     {Specs, OrphanBranches}.
     
 driver_init(DS, AllBranches) ->
-    Seed = erlang:now(),
+    Seed = case (DS#driver_state.run_config)#run_config.seed of
+	       undefined -> rand:seed(exsplus);
+	       ExpSeed -> rand:seed(ExpSeed)
+    end,
+
     DS2 =
 	if
 	    DS#driver_state.n_local_branches =:= 0 ->
@@ -1010,14 +1050,7 @@ calc_trans(DS) ->
 %% Generate teller_id, account_id and delta
 %% Time the TPC-B transaction
 time_trans(DS) ->
-    OldSeed = get(random_seed), % Avoid interference with Mnesia
-    put(random_seed, DS#driver_state.seed),
-    Random    = random:uniform(),
-    NewSeed   = get(random_seed),
-    case OldSeed of
-	undefined -> erase(random_seed);
-	_         -> put(random_seed, OldSeed)
-    end,
+    {Random, NewSeed} = rand:uniform_s(DS#driver_state.seed),
 
     TC = DS#driver_state.tab_config,
     RC = DS#driver_state.run_config,