observer: Polish crashdump viewer for ETS

Replaced "Id" column with "Is Named".
Removed "Slot" column.
Sort by name instead if id.
Use name in right-click menu instead of id.

1 files changed, 8 insertions, 11 deletions

diff --git a/lib/observer/src/cdv_ets_cb.erl b/lib/observer/src/cdv_ets_cb.erl
index ddd2d42df6..18f0c86fd3 100644
--- a/lib/observer/src/cdv_ets_cb.erl
+++ b/lib/observer/src/cdv_ets_cb.erl
@@ -30,26 +30,23 @@
 -include("crashdump_viewer.hrl").
 
 %% Defines
--define(COL_ID,    0).
--define(COL_NAME,  ?COL_ID+1).
--define(COL_SLOT,  ?COL_NAME+1).
--define(COL_OWNER, ?COL_SLOT+1).
+-define(COL_NAME,  0).
+-define(COL_IS_NAMED,  ?COL_NAME+1).
+-define(COL_OWNER, ?COL_IS_NAMED+1).
 -define(COL_OBJ,   ?COL_OWNER+1).
 -define(COL_MEM,   ?COL_OBJ+1).
 
 %% Callbacks for cdv_virtual_list_wx
-col_to_elem(id) -> col_to_elem(?COL_ID);
-col_to_elem(?COL_ID)    -> #ets_table.id;
+col_to_elem(id) -> col_to_elem(?COL_NAME);
+col_to_elem(?COL_IS_NAMED) -> #ets_table.is_named;
 col_to_elem(?COL_NAME)  -> #ets_table.name;
-col_to_elem(?COL_SLOT)  -> #ets_table.slot;
 col_to_elem(?COL_OWNER) -> #ets_table.pid;
 col_to_elem(?COL_OBJ)   -> #ets_table.size;
 col_to_elem(?COL_MEM)   -> #ets_table.memory.
 
 col_spec() ->
-    [{"Id",      ?wxLIST_FORMAT_LEFT,   200},
-     {"Name",    ?wxLIST_FORMAT_LEFT,   200},
-     {"Slot",    ?wxLIST_FORMAT_RIGHT,  50},
+    [{"Name",    ?wxLIST_FORMAT_LEFT,   200},
+     {"Is Named", ?wxLIST_FORMAT_CENTRE, 70},
      {"Owner",   ?wxLIST_FORMAT_CENTRE, 120},
      {"Objects", ?wxLIST_FORMAT_RIGHT,  80},
      {"Memory",  ?wxLIST_FORMAT_RIGHT,  80}
@@ -68,7 +65,7 @@ get_details(Id, Data) ->
     {ok,{"Table:" ++ Id,Proplist,""}}.
 
 get_detail_cols(all) ->
-    {[{ets, ?COL_ID}, {process, ?COL_OWNER}],true};
+    {[{ets, ?COL_NAME}, {process, ?COL_OWNER}],true};
 get_detail_cols(_W) ->
     {[],true}.