Merge branch 'siri/cdv-bugs/OTP-11650'

* siri/cdv-bugs/OTP-11650:
  Improve crashdump_viewer_SUITE:start_stop test case
  Fix crash in crashdump_viewer when node has multiple creations
  Change spawn/1 + monitor/2 to spawn_monitor/1 to avoid deadlock

3 files changed, 21 insertions, 7 deletions

diff --git a/lib/observer/src/cdv_dist_cb.erl b/lib/observer/src/cdv_dist_cb.erl
index 3860324d6f..f7e6c9aded 100644
--- a/lib/observer/src/cdv_dist_cb.erl
+++ b/lib/observer/src/cdv_dist_cb.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2013. All Rights Reserved.
+%% Copyright Ericsson AB 2013-2014. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -22,7 +22,8 @@
 	 get_info/1,
 	 get_detail_cols/1,
 	 get_details/1,
-	 detail_pages/0]).
+	 detail_pages/0,
+	 format/1]).
 
 -include_lib("wx/include/wx.hrl").
 -include("crashdump_viewer.hrl").
@@ -75,6 +76,11 @@ init_gen_page(Parent, Info) ->
     Fields = info_fields(),
     cdv_info_wx:start_link(Parent,{Fields,Info,[]}).
 
+format({creations,Creations}) ->
+    string:join([integer_to_list(C) || C <- Creations],",");
+format(D) ->
+    D.
+
 %%%-----------------------------------------------------------------
 %%% Internal
 info_fields() ->
@@ -83,7 +89,7 @@ info_fields() ->
        {"Type",               conn_type},
        {"Channel",            channel},
        {"Controller",         {click,controller}},
-       {"Creation",           creation},
+       {"Creation",           {{format,fun format/1},creation}},
        {"Extra Info",         error}]},
     {scroll_boxes,
      [{"Remote Links",1,{click,remote_links}},
diff --git a/lib/observer/src/crashdump_viewer.erl b/lib/observer/src/crashdump_viewer.erl
index a17efbccb0..a08d27d070 100644
--- a/lib/observer/src/crashdump_viewer.erl
+++ b/lib/observer/src/crashdump_viewer.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2003-2013. All Rights Reserved.
+%% Copyright Ericsson AB 2003-2014. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -1576,7 +1576,13 @@ get_nodeinfo(Fd,Nod) ->
 	"Controller" ->
 	    get_nodeinfo(Fd,Nod#nod{controller=val(Fd)});
 	"Creation" ->
-	    get_nodeinfo(Fd,Nod#nod{creation=list_to_integer(val(Fd))});
+	    %% Throwing away elements like "(refc=1)", which might be
+	    %% printed from a debug compiled emulator.
+	    Creations = lists:flatmap(fun(C) -> try [list_to_integer(C)]
+						catch error:badarg -> []
+						end
+				      end, string:tokens(val(Fd)," ")),
+	    get_nodeinfo(Fd,Nod#nod{creation={creations,Creations}});
 	"Remote link" ->
 	    Procs = val(Fd), % e.g. "<0.31.0> <4322.54.0>"
 	    {Local,Remote} = split(Procs),
@@ -2559,11 +2565,11 @@ progress_pmap(Report,File,Fun,List) ->
 		  {L1,L2} = if length(L)>=NPerProc -> lists:split(NPerProc,L);
 			       true -> {L,[]} % last chunk
 			    end,
-		  P = spawn(
+		  {P,_Ref} =
+		      spawn_monitor(
 			fun() ->
 				progress_map(Collector,ReportInterval,File,Fun,L1)
 			end),
-		  erlang:monitor(process,P),
 		  {L2,[P|Ps]}
 	  end,
 	  {List,[]},
diff --git a/lib/observer/src/observer_lib.erl b/lib/observer/src/observer_lib.erl
index cedaf7d2b8..34c7b127ff 100644
--- a/lib/observer/src/observer_lib.erl
+++ b/lib/observer/src/observer_lib.erl
@@ -249,6 +249,8 @@ to_str({func, {F,A}}) when is_atom(F), is_integer(A) ->
     lists:concat([F, "/", A]);
 to_str({func, {F,'_'}}) when is_atom(F) ->
     atom_to_list(F);
+to_str({{format,Fun},Value}) when is_function(Fun) ->
+    Fun(Value);
 to_str({A, B}) when is_atom(A), is_atom(B) ->
     lists:concat([A, ":", B]);
 to_str({M,F,A}) when is_atom(M), is_atom(F), is_integer(A) ->