aboutsummaryrefslogtreecommitdiffstats
path: root/lib/observer/test
diff options
context:
space:
mode:
authorSiri Hansen <[email protected]>2017-09-07 15:46:35 +0200
committerSiri Hansen <[email protected]>2017-09-13 17:55:47 +0200
commit903a289213aa22b5c9c42ead2599174c2cf15b95 (patch)
tree868c0bc634a88952aceaaaa22735461fe1b4b4cd /lib/observer/test
parent858254fc02e4c9ef2ea16275b2dfe60707ebb069 (diff)
downloadotp-903a289213aa22b5c9c42ead2599174c2cf15b95.tar.gz
otp-903a289213aa22b5c9c42ead2599174c2cf15b95.tar.bz2
otp-903a289213aa22b5c9c42ead2599174c2cf15b95.zip
cdv: Find end of 'Last calls' section
This is a bug fix: the end of the 'Last calls' section is meant to be an empty line, but in some situations this is not the case. This could cause the complete dump to be read and stored as 'Last calls', causing very unexpected behavior in the crashdump viewer. This commit adds a check for ": ", which indicates that a new heading has occured and thus the 'Last calls' section is completly read.
Diffstat (limited to 'lib/observer/test')
-rw-r--r--lib/observer/test/crashdump_viewer_SUITE.erl3
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/observer/test/crashdump_viewer_SUITE.erl b/lib/observer/test/crashdump_viewer_SUITE.erl
index 77cf086d4b..4b0127bcfb 100644
--- a/lib/observer/test/crashdump_viewer_SUITE.erl
+++ b/lib/observer/test/crashdump_viewer_SUITE.erl
@@ -364,6 +364,9 @@ special(File,Procs) ->
crashdump_viewer:expand_binary({SOffset,SSize,SPos}),
io:format(" expand binary ok",[]),
+ #proc{last_calls=LastCalls} = ProcDetails,
+ true = length(LastCalls) =< 4,
+
['#CDVPid',X1,Y1,Z1] = proplists:get_value(ext_pid,Dict),
ChannelStr1 = integer_to_list(X1),
ExtPid =