Merge branch 'dgud/observer/allocator-graphs/OTP-12631'

* dgud/observer/allocator-graphs/OTP-12631:
  observer: Fix menu code (for mac)
  observer: Add a new tab memory allocator charts

6 files changed, 442 insertions, 195 deletions

diff --git a/lib/observer/src/Makefile b/lib/observer/src/Makefile
index c120865213..a42967644a 100644
--- a/lib/observer/src/Makefile
+++ b/lib/observer/src/Makefile
@@ -61,6 +61,7 @@ MODULES= \
 	etop_txt \
 	observer \
 	observer_app_wx \
+	observer_alloc_wx \
 	observer_html_lib \
 	observer_lib \
 	observer_perf_wx \
diff --git a/lib/observer/src/observer.app.src b/lib/observer/src/observer.app.src
index 197d0a2a95..e293990d64 100644
--- a/lib/observer/src/observer.app.src
+++ b/lib/observer/src/observer.app.src
@@ -44,6 +44,7 @@
 	       etop_tr,
 	       etop_txt,
 	       observer,
+	       observer_alloc_wx,
 	       observer_app_wx,
 	       observer_html_lib,
 	       observer_lib,
diff --git a/lib/observer/src/observer_alloc_wx.erl b/lib/observer/src/observer_alloc_wx.erl
new file mode 100644
index 0000000000..0c4bc9ee4b
--- /dev/null
+++ b/lib/observer/src/observer_alloc_wx.erl
@@ -0,0 +1,256 @@
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 2015. All Rights Reserved.
+%%
+%% The contents of this file are subject to the Erlang Public License,
+%% Version 1.1, (the "License"); you may not use this file except in
+%% compliance with the License. You should have received a copy of the
+%% Erlang Public License along with this software. If not, it can be
+%% retrieved online at http://www.erlang.org/.
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
+%% the License for the specific language governing rights and limitations
+%% under the License.
+%%
+%% %CopyrightEnd%
+-module(observer_alloc_wx).
+
+-export([start_link/2]).
+
+%% wx_object callbacks
+-export([init/1, handle_info/2, terminate/2, code_change/3, handle_call/3,
+	 handle_event/2, handle_sync_event/3, handle_cast/2]).
+
+-behaviour(wx_object).
+-include_lib("wx/include/wx.hrl").
+-include("observer_defs.hrl").
+
+-record(state,
+	{
+	  offset = 0.0,
+	  active = false,
+	  parent,
+	  windows,
+	  data = {0, queue:new()},
+	  panel,
+	  paint,
+	  appmon,
+	  async
+	}).
+
+-define(ALLOC_W,  1).
+-define(UTIL_W,  2).
+
+start_link(Notebook, Parent) ->
+    wx_object:start_link(?MODULE, [Notebook, Parent], []).
+
+init([Notebook, Parent]) ->
+    try
+	Panel = wxPanel:new(Notebook),
+	Main  = wxBoxSizer:new(?wxVERTICAL),
+	Style = ?wxFULL_REPAINT_ON_RESIZE bor ?wxCLIP_CHILDREN,
+	Carrier = wxPanel:new(Panel, [{winid, ?ALLOC_W}, {style,Style}]),
+	Utilz = wxPanel:new(Panel, [{winid, ?UTIL_W}, {style,Style}]),
+	BorderFlags = ?wxLEFT bor ?wxRIGHT,
+	wxSizer:add(Main, Carrier, [{flag, ?wxEXPAND bor BorderFlags bor ?wxTOP},
+				    {proportion, 1}, {border, 5}]),
+
+	wxSizer:add(Main, Utilz, [{flag, ?wxEXPAND bor BorderFlags},
+				  {proportion, 1}, {border, 5}]),
+
+	MemWin = {MemPanel,_} = create_mem_info(Panel),
+	wxSizer:add(Main, MemPanel, [{flag, ?wxEXPAND bor BorderFlags bor ?wxBOTTOM},
+				     {proportion, 1}, {border, 5}]),
+	wxWindow:setSizer(Panel, Main),
+
+	PaintInfo = observer_perf_wx:setup_graph_drawing([Carrier, Utilz]),
+	{Panel, #state{parent=Parent,
+		       panel =Panel,
+		       windows = {Carrier, Utilz, MemWin},
+		       paint=PaintInfo}
+	}
+    catch _:Err ->
+	    io:format("~p crashed ~p: ~p~n",[?MODULE, Err, erlang:get_stacktrace()]),
+	    {stop, Err}
+    end.
+
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+
+handle_event(#wx{event=#wxCommand{type=command_menu_selected}},
+	     State = #state{}) ->
+    {noreply, State};
+
+handle_event(Event, _State) ->
+    error({unhandled_event, Event}).
+
+%%%%%%%%%%
+handle_sync_event(#wx{obj=Panel, event = #wxPaint{}},_,
+		  #state{active=Active, offset=Offset, paint=Paint,
+			 windows=Windows, data=Data}) ->
+    %% Sigh workaround bug on MacOSX (Id in paint event is always 0)
+    Id = if Panel =:= element(?ALLOC_W, Windows)  -> alloc;
+	    Panel =:= element(?UTIL_W, Windows)  -> utilz
+	 end,
+    observer_perf_wx:refresh_panel(Panel, Id, Offset, Data, Active, Paint),
+    ok.
+%%%%%%%%%%
+handle_call(Event, From, _State) ->
+    error({unhandled_call, Event, From}).
+
+handle_cast(Event, _State) ->
+    error({unhandled_cast, Event}).
+%%%%%%%%%%
+
+handle_info({Key, {promise_reply, {badrpc, _}}}, #state{async=Key} = State) ->
+    {noreply, State#state{active=false, appmon=undefined}};
+
+handle_info({Key, {promise_reply, SysInfo}}, #state{async=Key, data=Data} = State) ->
+    Info = alloc_info(SysInfo),
+    update_alloc(State, Info),
+    {noreply, State#state{offset=0.0, data = add_data(Info, Data), async=undefined}};
+
+handle_info({refresh, Seq, Freq, Node}, #state{panel=Panel, appmon=Node, async=Key} = State) ->
+    wxWindow:refresh(Panel),
+    Next = Seq+1,
+    if
+	Next > Freq, Key =:= undefined ->
+	    erlang:send_after(trunc(1000 / Freq), self(), {refresh, 1, Freq, Node}),
+	    Req = rpc:async_call(Node, observer_backend, sys_info, []),
+	    {noreply, State#state{offset=Seq/Freq, async=Req}};
+       true ->
+	    erlang:send_after(trunc(1000 / Freq), self(), {refresh, Next, Freq, Node}),
+	    {noreply, State#state{offset=Seq/Freq}}
+    end;
+handle_info({refresh, _Seq, _Freq, _Node}, State) ->
+    {noreply, State};
+
+handle_info({active, Node}, State = #state{parent=Parent, panel=Panel, appmon=Old}) ->
+    create_menus(Parent, []),
+    try
+	Node = Old,
+	wxWindow:refresh(Panel),
+	{noreply, State#state{active=true}}
+    catch _:_ ->
+	    SysInfo = observer_wx:try_rpc(Node, observer_backend, sys_info, []),
+	    Info = alloc_info(SysInfo),
+	    Freq = 6,
+	    erlang:send_after(trunc(1000 / Freq), self(), {refresh, 1, Freq, Node}),
+	    wxWindow:refresh(Panel),
+	    {noreply, State#state{active=true, appmon=Node, offset=0.0,
+				  data = add_data(Info, {0, queue:new()})}}
+    end;
+
+handle_info(not_active, State = #state{appmon=_Pid}) ->
+    {noreply, State#state{active=false}};
+
+handle_info({'EXIT', Old, _}, State = #state{appmon=Old}) ->
+    {noreply, State#state{active=false, appmon=undefined}};
+
+handle_info(_Event, State) ->
+    %% io:format("~p:~p: ~p~n",[?MODULE,?LINE,_Event]),
+    {noreply, State}.
+
+terminate(_Event, #state{}) ->
+    ok.
+code_change(_, _, State) ->
+    State.
+
+%%%%%%%%%%
+
+add_data(Stats, {N, Q}) when N > 60 ->
+    {N, queue:drop(queue:in(Stats, Q))};
+add_data(Stats, {N, Q}) ->
+    {N+1, queue:in(Stats, Q)}.
+
+update_alloc(#state{windows={_, _, {_, Grid}}}, Fields) ->
+    Max = wxListCtrl:getItemCount(Grid),
+    Update = fun({Name, BS, CS}, Row) ->
+		     (Row >= Max) andalso wxListCtrl:insertItem(Grid, Row, ""),
+		     wxListCtrl:setItem(Grid, Row, 0, observer_lib:to_str(Name)),
+		     wxListCtrl:setItem(Grid, Row, 1, observer_lib:to_str(BS div 1024)),
+		     wxListCtrl:setItem(Grid, Row, 2, observer_lib:to_str(CS div 1024)),
+		     Row + 1
+	     end,
+    lists:foldl(Update, 0, Fields),
+    Fields.
+
+alloc_info(SysInfo) ->
+    AllocInfo = proplists:get_value(alloc_info, SysInfo, []),
+    alloc_info(AllocInfo, [], 0, 0, true).
+
+alloc_info([{Type,Instances}|Allocators],TypeAcc,TotalBS,TotalCS,IncludeTotal) ->
+    {BS,CS,NewTotalBS,NewTotalCS,NewIncludeTotal} =
+	sum_alloc_instances(Instances,0,0,TotalBS,TotalCS),
+    alloc_info(Allocators,[{Type,BS,CS}|TypeAcc],NewTotalBS,NewTotalCS,
+	       IncludeTotal andalso NewIncludeTotal);
+alloc_info([],TypeAcc,TotalBS,TotalCS,IncludeTotal) ->
+    Types = [X || X={_,BS,CS} <- TypeAcc, (BS>0 orelse CS>0)],
+    case IncludeTotal of
+	true ->
+	    [{total,TotalBS,TotalCS} | lists:reverse(Types)];
+	false ->
+	    lists:reverse(Types)
+    end.
+
+sum_alloc_instances(false,BS,CS,TotalBS,TotalCS) ->
+    {BS,CS,TotalBS,TotalCS,false};
+sum_alloc_instances([{_,_,Data}|Instances],BS,CS,TotalBS,TotalCS) ->
+    {NewBS,NewCS,NewTotalBS,NewTotalCS} =
+	sum_alloc_one_instance(Data,BS,CS,TotalBS,TotalCS),
+    sum_alloc_instances(Instances,NewBS,NewCS,NewTotalBS,NewTotalCS);
+sum_alloc_instances([],BS,CS,TotalBS,TotalCS) ->
+    {BS,CS,TotalBS,TotalCS,true}.
+
+sum_alloc_one_instance([{sbmbcs,[{blocks_size,BS,_,_},{carriers_size,CS,_,_}]}|
+			Rest],OldBS,OldCS,TotalBS,TotalCS) ->
+    sum_alloc_one_instance(Rest,OldBS+BS,OldCS+CS,TotalBS,TotalCS);
+sum_alloc_one_instance([{_,[{blocks_size,BS,_,_},{carriers_size,CS,_,_}]}|
+			Rest],OldBS,OldCS,TotalBS,TotalCS) ->
+    sum_alloc_one_instance(Rest,OldBS+BS,OldCS+CS,TotalBS+BS,TotalCS+CS);
+sum_alloc_one_instance([{_,[{blocks_size,BS},{carriers_size,CS}]}|
+			Rest],OldBS,OldCS,TotalBS,TotalCS) ->
+    sum_alloc_one_instance(Rest,OldBS+BS,OldCS+CS,TotalBS+BS,TotalCS+CS);
+sum_alloc_one_instance([_|Rest],BS,CS,TotalBS,TotalCS) ->
+    sum_alloc_one_instance(Rest,BS,CS,TotalBS,TotalCS);
+sum_alloc_one_instance([],BS,CS,TotalBS,TotalCS) ->
+    {BS,CS,TotalBS,TotalCS}.
+
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+
+create_mem_info(Parent) ->
+    Panel = wxPanel:new(Parent),
+    wxWindow:setBackgroundColour(Panel, {255,255,255}),
+    Style = ?wxLC_REPORT bor ?wxLC_SINGLE_SEL bor ?wxLC_HRULES bor ?wxLC_VRULES,
+    Grid = wxListCtrl:new(Panel, [{style, Style}]),
+    Li = wxListItem:new(),
+    AddListEntry = fun({Name, Align, DefSize}, Col) ->
+			   wxListItem:setText(Li, Name),
+			   wxListItem:setAlign(Li, Align),
+			   wxListCtrl:insertColumn(Grid, Col, Li),
+			   wxListCtrl:setColumnWidth(Grid, Col, DefSize),
+			   Col + 1
+		   end,
+    ListItems = [{"Allocator Type",  ?wxLIST_FORMAT_LEFT,  200},
+		 {"Block size (kB)",  ?wxLIST_FORMAT_RIGHT, 150},
+		 {"Carrier size (kB)",?wxLIST_FORMAT_RIGHT, 150}],
+    lists:foldl(AddListEntry, 0, ListItems),
+    wxListItem:destroy(Li),
+
+    Sizer = wxBoxSizer:new(?wxVERTICAL),
+    wxSizer:add(Sizer, Grid, [{flag, ?wxEXPAND bor ?wxLEFT bor ?wxRIGHT},
+			      {border, 5}, {proportion, 1}]),
+    wxWindow:setSizerAndFit(Panel, Sizer),
+    {Panel, Grid}.
+
+
+create_menus(Parent, _) ->
+    MenuEntries =
+	[{"File",
+	  [
+	  ]}
+	],
+    observer_wx:create_menus(Parent, MenuEntries).
+
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
diff --git a/lib/observer/src/observer_perf_wx.erl b/lib/observer/src/observer_perf_wx.erl
index 8173349ed7..4df9218087 100644
--- a/lib/observer/src/observer_perf_wx.erl
+++ b/lib/observer/src/observer_perf_wx.erl
@@ -24,7 +24,8 @@
 	 handle_event/2, handle_sync_event/3, handle_cast/2]).
 
 %% Drawing wrappers for DC and GC areas
--export([haveGC/0,
+-export([setup_graph_drawing/1, refresh_panel/6,
+	 haveGC/0,
 	 setPen/2, setFont/3, setBrush/2,
 	 strokeLine/5, strokeLines/2, drawRoundedRectangle/6,
 	 drawText/4, getTextExtent/2]).
@@ -42,13 +43,12 @@
 	  data = {0, queue:new()},
 	  panel,
 	  paint,
-	  appmon,
-	  usegc = false
+	  appmon
 	}).
 
 -define(wxGC, wxGraphicsContext).
 
--record(paint, {font, small, pen, pen2, pens}).
+-record(paint, {font, small, pen, pen2, pens, usegc = false}).
 
 -define(RQ_W,  1).
 -define(MEM_W, 2).
@@ -63,14 +63,11 @@ init([Notebook, Parent]) ->
     Main  = wxBoxSizer:new(?wxVERTICAL),
     Style = ?wxFULL_REPAINT_ON_RESIZE bor ?wxCLIP_CHILDREN,
     CPU = wxPanel:new(Panel, [{winid, ?RQ_W}, {style,Style}]),
-    wxWindow:setBackgroundColour(CPU, ?wxWHITE),
     wxSizer:add(Main, CPU, [{flag, ?wxEXPAND bor ?wxALL},
 				 {proportion, 1}, {border, 5}]),
     MemIO = wxBoxSizer:new(?wxHORIZONTAL),
     MEM = wxPanel:new(Panel, [{winid, ?MEM_W}, {style,Style}]),
-    wxWindow:setBackgroundColour(MEM, ?wxWHITE),
     IO  = wxPanel:new(Panel, [{winid, ?IO_W}, {style,Style}]),
-    wxWindow:setBackgroundColour(IO, ?wxWHITE),
     wxSizer:add(MemIO, MEM, [{flag, ?wxEXPAND bor ?wxLEFT},
 			     {proportion, 1}, {border, 5}]),
     wxSizer:add(MemIO, IO,  [{flag, ?wxEXPAND bor ?wxLEFT bor ?wxRIGHT},
@@ -79,53 +76,56 @@ init([Notebook, Parent]) ->
 			      {proportion, 1}, {border, 5}]),
     wxWindow:setSizer(Panel, Main),
 
-    wxPanel:connect(CPU, paint, [callback]),
-    wxPanel:connect(IO, paint, [callback]),
-    wxPanel:connect(MEM, paint, [callback]),
-    case os:type() of
-	{win32, _} -> %% Ignore erase on windows
-	    wxPanel:connect(CPU, erase_background, [{callback, fun(_,_) -> ok end}]),
-	    wxPanel:connect(IO,  erase_background, [{callback, fun(_,_) -> ok end}]),
-	    wxPanel:connect(MEM, erase_background, [{callback, fun(_,_) -> ok end}]);
-	_ -> ok
-    end,
+    PaintInfo = setup_graph_drawing([CPU, MEM, IO]),
 
+    process_flag(trap_exit, true),
+    {Panel, #state{parent=Parent,
+		   panel =Panel,
+		   windows = {CPU, MEM, IO},
+		   paint=PaintInfo
+		  }}
+   catch _:Err ->
+	   io:format("~p crashed ~p: ~p~n",[?MODULE, Err, erlang:get_stacktrace()]),
+	   {stop, Err}
+   end.
+
+setup_graph_drawing(Panels) ->
+    IsWindows = element(1, os:type()) =:= win32,
+    IgnoreCB = {callback, fun(_,_) -> ok end},
+    Do = fun(Panel) ->
+		 wxWindow:setBackgroundColour(Panel, ?wxWHITE),
+		 wxPanel:connect(Panel, paint, [callback]),
+		 IsWindows andalso
+		     wxPanel:connect(Panel, erase_background, [IgnoreCB])
+	 end,
+    _ = [Do(Panel) || Panel <- Panels],
     UseGC = haveGC(),
     Version28 = ?wxMAJOR_VERSION =:= 2 andalso ?wxMINOR_VERSION =:= 8,
     {Font, SmallFont}
-	= case os:type() of
-	      {unix, _} when UseGC, Version28 ->
+	= if UseGC, Version28 ->
 		  %% Def font is really small when using Graphics contexts in 2.8
 		  %% Hardcode it
 		  F = wxFont:new(12,?wxFONTFAMILY_DECORATIVE,?wxFONTSTYLE_NORMAL,?wxFONTWEIGHT_BOLD),
 		  SF = wxFont:new(10, ?wxFONTFAMILY_DECORATIVE, ?wxFONTSTYLE_NORMAL, ?wxFONTWEIGHT_NORMAL),
 		  {F, SF};
-	      _ ->
+	     true ->
 		  DefFont = wxSystemSettings:getFont(?wxSYS_DEFAULT_GUI_FONT),
 		  DefSize = wxFont:getPointSize(DefFont),
 		  DefFamily = wxFont:getFamily(DefFont),
-		  F = wxFont:new(DefSize, DefFamily, ?wxFONTSTYLE_NORMAL, ?wxFONTWEIGHT_BOLD),
-		  SF = wxFont:new(DefSize-1, DefFamily, ?wxFONTSTYLE_NORMAL, ?wxFONTWEIGHT_NORMAL),
+		  F = wxFont:new(DefSize-1, DefFamily, ?wxFONTSTYLE_NORMAL, ?wxFONTWEIGHT_BOLD),
+		  SF = wxFont:new(DefSize-2, DefFamily, ?wxFONTSTYLE_NORMAL, ?wxFONTWEIGHT_NORMAL),
 		  {F, SF}
 	  end,
     BlackPen = wxPen:new({0,0,0}, [{width, 2}]),
-    Pens = [wxPen:new(Col, [{width, 2}]) || Col <- tuple_to_list(colors())],
-    process_flag(trap_exit, true),
-    {Panel, #state{parent=Parent,
-		   panel =Panel,
-		   windows = {CPU, MEM, IO},
-		   usegc=UseGC,
-		   paint=#paint{font = Font,
-				small = SmallFont,
-				pen  = ?wxGREY_PEN,
-				pen2 = BlackPen,
-				pens = list_to_tuple(Pens)
-			       }
-		  }}
-   catch _:Err ->
-	   io:format("~p crashed ~p: ~p~n",[?MODULE, Err, erlang:get_stacktrace()]),
-	   {stop, Err}
-   end.
+    Pens = [wxPen:new(Col, [{width, 3}]) || Col <- tuple_to_list(colors())],
+    #paint{usegc = UseGC,
+	   font  = Font,
+	   small = SmallFont,
+	   pen   = ?wxGREY_PEN,
+	   pen2  = BlackPen,
+	   pens  = list_to_tuple(Pens)
+	  }.
+
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
@@ -139,21 +139,25 @@ handle_event(Event, _State) ->
 %%%%%%%%%%
 handle_sync_event(#wx{obj=Panel, event = #wxPaint{}},_,
 		  #state{active=Active, offset=Offset, paint=Paint,
-			 windows=Windows, data=Data, usegc=UseGC}) ->
-    %% PaintDC must be created in a callback to work on windows.
+			 windows=Windows, data=Data}) ->
     %% Sigh workaround bug on MacOSX (Id in paint event is always 0)
     %% Panel = element(Id, Windows),
-    Id = if Panel =:= element(?RQ_W, Windows)  -> ?RQ_W;
-	    Panel =:= element(?MEM_W, Windows) -> ?MEM_W;
-	    Panel =:= element(?IO_W, Windows)  -> ?IO_W
+    Id = if Panel =:= element(?RQ_W, Windows)  -> runq;
+	    Panel =:= element(?MEM_W, Windows) -> memory;
+	    Panel =:= element(?IO_W, Windows)  -> io
 	 end,
-    IsWindows = element(1, os:type()) =:= win32,
 
-    DC = if IsWindows -> 
+    refresh_panel(Panel, Id, Offset, Data, Active, Paint),
+    ok.
+
+refresh_panel(Panel, Id, Offset, Data, Active, #paint{usegc=UseGC} = Paint) ->
+    %% PaintDC must be created in a callback to work on windows.
+    IsWindows = element(1, os:type()) =:= win32,
+    DC = if IsWindows ->
 		 %% Ugly hack to aviod flickering on windows, works on windows only
 		 %% But the other platforms are doublebuffered by default
 		 wx:typeCast(wxBufferedPaintDC:new(Panel), wxPaintDC);
-	    true -> 
+	    true ->
 		 wxPaintDC:new(Panel)
 	 end,
     IsWindows andalso wxDC:clear(DC),
@@ -167,8 +171,9 @@ handle_sync_event(#wx{obj=Panel, event = #wxPaint{}},_,
 	    io:format("Internal error ~p ~p~n",[Err, erlang:get_stacktrace()])
     end,
     UseGC andalso ?wxGC:destroy(GC),
-    wxPaintDC:destroy(DC),
-    ok.
+    wxPaintDC:destroy(DC).
+
+
 %%%%%%%%%%
 handle_call(Event, From, _State) ->
     error({unhandled_call, Event, From}).
@@ -247,10 +252,10 @@ create_menus(Parent, _) ->
     observer_wx:create_menus(Parent, MenuEntries).
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
-collect_data(?RQ_W, {N, Q}) ->
+collect_data(runq, {N, Q}) ->
     case queue:to_list(Q) of
-	[] ->  {0, 0, []};
-	[_] ->  {0, 0, []};
+	[] ->  {0, 0, [], []};
+	[_] ->  {0, 0, [], []};
 	[{stats, _Ver, Init0, _IO, _Mem}|Data0] ->
 	    Init = lists:sort(Init0),
 	    [_|Data=[First|_]] = lists:foldl(fun({stats, _, T0, _, _}, [Prev|Acc]) ->
@@ -258,25 +263,46 @@ collect_data(?RQ_W, {N, Q}) ->
 					   Delta = calc_delta(TN, Prev),
 					   [TN, list_to_tuple(Delta)|Acc]
 				   end, [Init], Data0),
-	    {N, lmax(Data), lists:reverse([First|Data])}
+	    NoGraphs = tuple_size(First),
+	    {N, lmax(Data), lists:reverse([First|Data]), lists:seq(1, NoGraphs)}
     end;
-collect_data(?MEM_W, {N, Q}) ->
+collect_data(memory, {N, Q}) ->
     MemT = mem_types(),
     Data = [list_to_tuple([Value || {Type,Value} <- MemInfo,
 				    lists:member(Type, MemT)])
 	    || {stats, _Ver, _RQ, _IO, MemInfo} <- queue:to_list(Q)],
-    {N, lmax(Data), Data};
-collect_data(?IO_W, {N, Q}) ->
+    {N, lmax(Data), Data,  MemT};
+collect_data(io, {N, Q}) ->
     case queue:to_list(Q) of
-	[] ->  {0, 0, []};
-	[_] -> {0, 0, []};
+	[] ->  {0, 0, [], []};
+	[_] -> {0, 0, [], []};
 	[{stats, _Ver, _RQ, {{_,In0}, {_,Out0}}, _Mem}|Data0] ->
 	    [_,_|Data=[First|_]] =
 		lists:foldl(fun({stats, _, _, {{_,In}, {_,Out}}, _}, [PIn,Pout|Acc]) ->
 				    [In,Out,{In-PIn,Out-Pout}|Acc]
 			    end, [In0,Out0], Data0),
-	    {N, lmax(Data), lists:reverse([First|Data])}
-    end.
+	    {N, lmax(Data), lists:reverse([First|Data]), [input, output]}
+    end;
+collect_data(alloc, {N, Q}) ->
+    List = queue:to_list(Q),
+    Data = [list_to_tuple([Carrier || {_Type,_Block,Carrier} <- MemInfo])
+	    || MemInfo <- List],
+    Info = case List of  %% Varies depending on erlang build config/platform
+	       [MInfo|_] -> [Type || {Type, _, _} <- MInfo];
+	       _ -> []
+	   end,
+    {N, lmax(Data), Data, Info};
+
+collect_data(utilz, {N, Q}) ->
+    List = queue:to_list(Q),
+    Data = [list_to_tuple([round(100*Block/Carrier) || {_Type,Block,Carrier} <- MemInfo])
+	    || MemInfo <- List],
+    Info = case List of  %% Varies depending on erlang build config/platform
+	       [MInfo|_] -> [Type || {Type, _, _} <- MInfo];
+	       _ -> []
+	   end,
+    {N, lmax(Data), Data, Info}.
+
 
 mem_types() ->
     [total, processes, atom, binary, code, ets].
@@ -299,14 +325,14 @@ draw(Offset, Id, DC, Panel, Paint=#paint{pens=Pens, small=Small}, Data, Active)
     %% This can be optimized a lot by collecting data once
     %% and draw to memory and then blit memory and only draw new entries in new memory
     %% area.  Hmm now rewritten to use ?wxGC I don't now if it is feasable.
-    {Len, Max0, Hs} = collect_data(Id, Data),
-    Max = calc_max(Max0),
-    NoGraphs = try tuple_size(hd(Hs)) catch _:_ -> 0 end,
+    {Len, Max0, Hs, Info} = collect_data(Id, Data),
+    {Max,_,_} = MaxDisp = calc_max(Id, Max0),
     Size = wxWindow:getClientSize(Panel),
-    {X0,Y0,WS,HS} = draw_borders(Id, NoGraphs, DC, Size, Max, Paint),
+    {X0,Y0,WS,HS, DrawBs} = draw_borders(Id, Info, DC, Size, MaxDisp, Paint),
     Last = 60*WS+X0-1,
     Start = max(61-Len, 0)*WS+X0 - Offset*WS,
     Samples = length(Hs),
+    NoGraphs = try tuple_size(hd(Hs)) catch _:_ -> 0 end,
     case Active andalso Samples > 1 andalso NoGraphs > 0 of
 	true ->
 	    Draw = fun(N) ->
@@ -315,14 +341,16 @@ draw(Offset, Id, DC, Panel, Paint=#paint{pens=Pens, small=Small}, Data, Active)
 			   strokeLines(DC, Lines),
 			   N+1
 		   end,
-	    [Draw(I) || I <- lists:seq(NoGraphs, 1, -1)];
+	    [Draw(I) || I <- lists:seq(NoGraphs, 1, -1)],
+	    DrawBs();
 	false ->
-	    Info = case Active andalso Samples =< 1 of
-		       true -> "Waiting on data";
+	    DrawBs(),
+	    Text = case Active andalso Samples =< 1 of
+		       true  -> "Waiting for data";
 		       false -> "Information not available"
 		   end,
 	    setFont(DC, Small, {0,0,0}),
-	    drawText(DC, Info, X0 + 100, element(2,Size) div 2)
+	    drawText(DC, Text, X0 + 100, element(2,Size) div 2)
     end,
     ok.
 
@@ -397,9 +425,8 @@ spline_tan(Y0, Y1, Y2, Y3) ->
 -define(BW, 5).
 -define(BH, 5).
 
-draw_borders(Type, NoGraphs, DC, {W,H}, Max,
+draw_borders(Type, Info, DC, {W,H}, {Max, Unit, MaxUnit},
 	     #paint{pen=Pen, pen2=Pen2, font=Font, small=Small}) ->
-    {Unit, MaxUnit} = bytes(Type, Max),
     Str1 = observer_lib:to_str(MaxUnit),
     Str2 = observer_lib:to_str(MaxUnit div 2),
     Str3 = observer_lib:to_str(0),
@@ -410,10 +437,10 @@ draw_borders(Type, NoGraphs, DC, {W,H}, Max,
 
     GraphX0 = ?BW+TW+?BW,
     GraphX1 = W-?BW*4,
-    TopTextX = ?BW+TW+?BW,
-    MaxTextY = ?BH+TH+?BH,
+    TopTextX = ?BW*3+TW,
+    MaxTextY = TH+?BH,
     BottomTextY = H-?BH-TH,
-    SecondsY = BottomTextY - ?BH - TH,
+    SecondsY = BottomTextY - TH,
     GraphY0 = MaxTextY + (TH / 2),
     GraphY1 = SecondsY - ?BH,
     GraphW = GraphX1-GraphX0-1,
@@ -447,17 +474,7 @@ draw_borders(Type, NoGraphs, DC, {W,H}, Max,
     strokeLine(DC, GraphX0-3, GraphY50, GraphX1, GraphY50),
     strokeLine(DC, GraphX0-3, GraphY75, GraphX1, GraphY75),
 
-    setPen(DC, Pen2),
-    strokeLines(DC, [{GraphX0, GraphY0-1}, {GraphX0, GraphY1+1},
-		     {GraphX1, GraphY1+1}, {GraphX1, GraphY0-1},
-		     {GraphX0, GraphY0-1}]),
-
     setFont(DC, Font, {0,0,0}),
-    case Type of
-	?RQ_W ->  drawText(DC, "Scheduler Utilization (%) ", TopTextX,?BH);
-	?MEM_W -> drawText(DC, "Memory Usage " ++ Unit, TopTextX,?BH);
-	?IO_W ->  drawText(DC, "IO Usage " ++ Unit, TopTextX,?BH)
-    end,
 
     Text = fun(X,Y, Str, PenId) ->
 		   if PenId == 0 ->
@@ -468,32 +485,65 @@ draw_borders(Type, NoGraphs, DC, {W,H}, Max,
 		   end,
 		   drawText(DC, Str, X, Y),
 		   {StrW, _} = getTextExtent(DC, Str),
-		   StrW + X + SpaceW
+		   StrW + X + ?BW*2
 	   end,
+
     case Type of
-	?RQ_W ->
-	    TN0 = Text(?BW, BottomTextY, "Scheduler: ", 0),
+	runq ->
+	    drawText(DC, "Scheduler Utilization (%) ", TopTextX, ?BH),
+	    TN0 = Text(TopTextX, BottomTextY, "Scheduler: ", 0),
 	    lists:foldl(fun(Id, Pos0) ->
 				Text(Pos0, BottomTextY, integer_to_list(Id), Id)
-			end, TN0, lists:seq(1, NoGraphs));
-	?MEM_W ->
+			end, TN0, Info);
+	memory ->
+	    drawText(DC, "Memory Usage " ++ Unit, TopTextX,?BH),
+	    lists:foldl(fun(MType, {PenId, Pos0}) ->
+				Str = to_string(MType),
+				Pos = Text(Pos0, BottomTextY, Str, PenId),
+				{PenId+1, Pos}
+			end, {1, TopTextX}, Info);
+	io ->
+	    drawText(DC, "IO Usage " ++ Unit, TopTextX,?BH),
+	    lists:foldl(fun(MType, {PenId, Pos0}) ->
+				Str = to_string(MType),
+				Pos = Text(Pos0, BottomTextY, Str, PenId),
+				{PenId+1, Pos}
+			end, {1, TopTextX}, Info);
+	alloc ->
+	    drawText(DC, "Carrier Size " ++ Unit, TopTextX,?BH);
+	utilz ->
+	    drawText(DC, "Carrier Utilization (%)" ++ Unit, TopTextX,?BH),
 	    lists:foldl(fun(MType, {PenId, Pos0}) ->
-				Str = uppercase(atom_to_list(MType)),
+				Str = to_string(MType),
 				Pos = Text(Pos0, BottomTextY, Str, PenId),
 				{PenId+1, Pos}
-			end, {1, ?BW}, mem_types());
-	?IO_W ->
-	    TN0 = Text(?BW, BottomTextY, "Input", 1),
-	    Text(TN0, BottomTextY, "Output", 2)
+			end, {1, TopTextX}, Info)
     end,
-    {GraphX0+1, GraphY1, ScaleW, ScaleH}.
+    DrawBorder = fun() ->
+			 setPen(DC, Pen2),
+			 strokeLines(DC, [{GraphX0, GraphY0-1}, {GraphX0, GraphY1+1},
+					  {GraphX1, GraphY1+1}, {GraphX1, GraphY0-1},
+					  {GraphX0, GraphY0-1}])
+		 end,
+    {GraphX0+1, GraphY1, ScaleW, ScaleH, DrawBorder}.
+
+to_string(Atom) ->
+    Name = atom_to_list(Atom),
+    case lists:reverse(Name) of
+	"colla_" ++ Rev ->
+	    uppercase(lists:reverse(Rev));
+	_ ->
+	    uppercase(Name)
+    end.
 
 uppercase([C|Rest]) ->
     [C-$a+$A|Rest].
 
-calc_max(Max) when Max < 10 -> 10;
-calc_max(Max) -> calc_max1(Max).
+calc_max(Type, Max) ->
+    bytes(Type, Max).
 
+calc_max1(Max) when Max < 10 ->
+    10;
 calc_max1(Max) ->
     case Max div 10 of
 	X when X < 10 ->
@@ -506,23 +556,36 @@ calc_max1(Max) ->
 	    10*calc_max1(X)
     end.
 
-bytes(?RQ_W, Val) -> {"", Val};
+bytes(runq, Val) ->
+    Upper = calc_max1(Val),
+    {Upper, "", Upper};
+bytes(utilz, Val) ->
+    Upper = calc_max1(Val),
+    {Upper, "", Upper};
 bytes(_, B) ->
     KB = B div 1024,
     MB = KB div 1024,
     GB = MB div 1024,
     if
-	GB > 10 -> {"(GB)", GB};
-	MB > 10 -> {"(MB)", MB};
-	KB >  0 -> {"(KB)", KB};
-	true    -> {"(B)", B}
+	GB > 10 ->
+	    Upper = calc_max1(GB),
+	    {Upper*1024*1024*1024, "(GB)", Upper};
+	MB > 10 ->
+	    Upper = calc_max1(MB),
+	    {Upper*1024*1024, "(MB)", Upper};
+	KB >  0 ->
+	    Upper = calc_max1(KB),
+	    {Upper*1024, "(KB)", Upper};
+	true  ->
+	    Upper = calc_max1(B),
+	    {Upper, "(B)", Upper}
     end.
 
 colors() ->
-    {{200, 50, 50}, {50, 200, 50}, {50, 50, 200},
-     {255, 110, 0}, {50, 200, 200}, {200, 50, 200},
-     {240, 200, 80}, {140, 2, 140},
-     {100, 200, 240}, {100, 240, 100}
+    {{240, 100, 100}, {100, 240, 100}, {100, 100, 240},
+     {220, 220, 80}, {100, 240, 240}, {240, 100, 240},
+     {100, 25, 25}, {25, 100, 25}, {25, 25, 100},
+     {120, 120, 0}, {25, 100, 100}, {100, 50, 100}
     }.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
diff --git a/lib/observer/src/observer_sys_wx.erl b/lib/observer/src/observer_sys_wx.erl
index f989f9cf97..ea89590e84 100644
--- a/lib/observer/src/observer_sys_wx.erl
+++ b/lib/observer/src/observer_sys_wx.erl
@@ -37,7 +37,6 @@
 	 parent_notebook,
 	 panel, sizer,
 	 menubar,
-	 alloc,
 	 fields,
 	 timer}).
 
@@ -48,7 +47,6 @@ start_link(Notebook, Parent) ->
 
 init([Notebook, Parent]) ->
     SysInfo = observer_backend:sys_info(),
-    AllocInfo = proplists:get_value(alloc_info, SysInfo, []),
     {Info, Stat} = info_fields(),
     Panel = wxPanel:new(Notebook),
     Sizer = wxBoxSizer:new(?wxVERTICAL),
@@ -60,16 +58,13 @@ init([Notebook, Parent]) ->
     wxSizer:add(TopSizer, FPanel0, [{flag, ?wxEXPAND}, {proportion, 1}]),
     wxSizer:add(TopSizer, FPanel1, [{flag, ?wxEXPAND}, {proportion, 1}]),
     BorderFlags = ?wxLEFT bor ?wxRIGHT,
-    {MemPanel, MemoryInfo} = create_mem_info(Panel, AllocInfo),
     wxSizer:add(Sizer, TopSizer, [{flag, ?wxEXPAND bor BorderFlags bor ?wxTOP},
 				  {proportion, 0}, {border, 5}]),
-    wxSizer:add(Sizer, MemPanel, [{flag, ?wxEXPAND bor BorderFlags bor ?wxBOTTOM},
-				    {proportion, 1}, {border, 5}]),
     wxPanel:setSizer(Panel, Sizer),
     Timer = observer_lib:start_timer(10),
     {Panel, #sys_wx_state{parent=Parent,
 			  parent_notebook=Notebook,
-			  panel=Panel, sizer=Sizer, alloc=MemoryInfo,
+			  panel=Panel, sizer=Sizer,
 			  timer=Timer, fields=Fields0 ++ Fields1}}.
 
 create_sys_menu(Parent) ->
@@ -77,91 +72,13 @@ create_sys_menu(Parent) ->
 		     #create_menu{id = ?ID_REFRESH_INTERVAL, text = "Refresh interval"}]},
     observer_wx:create_menus(Parent, [View]).
 
-update_syspage(#sys_wx_state{node = Node, fields=Fields, sizer=Sizer, alloc=AllocCtrl}) ->
+update_syspage(#sys_wx_state{node = Node, fields=Fields, sizer=Sizer}) ->
     SysInfo = observer_wx:try_rpc(Node, observer_backend, sys_info, []),
-    AllocInfo = proplists:get_value(alloc_info, SysInfo, []),
     {Info, Stat} = info_fields(),
     observer_lib:update_info(Fields, observer_lib:fill_info(Info, SysInfo) ++
 				 observer_lib:fill_info(Stat, SysInfo)),
-    update_alloc(AllocCtrl, AllocInfo),
     wxSizer:layout(Sizer).
 
-create_mem_info(Parent, Fields) ->
-    Panel = wxPanel:new(Parent),
-    wxWindow:setBackgroundColour(Panel, {255,255,255}),
-    Style = ?wxLC_REPORT bor ?wxLC_SINGLE_SEL bor ?wxLC_HRULES bor ?wxLC_VRULES,
-    Grid = wxListCtrl:new(Panel, [{style, Style}]),
-    Li = wxListItem:new(),
-    AddListEntry = fun({Name, Align, DefSize}, Col) ->
-			   wxListItem:setText(Li, Name),
-			   wxListItem:setAlign(Li, Align),
-			   wxListCtrl:insertColumn(Grid, Col, Li),
-			   wxListCtrl:setColumnWidth(Grid, Col, DefSize),
-			   Col + 1
-		   end,
-    ListItems = [{"Allocator Type",  ?wxLIST_FORMAT_LEFT,  200},
-		 {"Block size (kB)",  ?wxLIST_FORMAT_RIGHT, 150},
-		 {"Carrier size (kB)",?wxLIST_FORMAT_RIGHT, 150}],
-    lists:foldl(AddListEntry, 0, ListItems),
-    wxListItem:destroy(Li),
-    update_alloc(Grid, Fields),
-
-    Sizer = wxBoxSizer:new(?wxVERTICAL),
-    wxSizer:add(Sizer, Grid, [{flag, ?wxEXPAND bor ?wxLEFT bor ?wxRIGHT},
-			      {border, 5}, {proportion, 1}]),
-    wxWindow:setSizerAndFit(Panel, Sizer),
-    {Panel, Grid}.
-
-update_alloc(Grid, AllocInfo) ->
-    Fields = alloc_info(AllocInfo, [], 0, 0, true),
-    wxListCtrl:deleteAllItems(Grid),
-    Update = fun({Name, BS, CS}, Row) ->
-		     wxListCtrl:insertItem(Grid, Row, ""),
-		     wxListCtrl:setItem(Grid, Row, 0, observer_lib:to_str(Name)),
-		     wxListCtrl:setItem(Grid, Row, 1, observer_lib:to_str(BS div 1024)),
-		     wxListCtrl:setItem(Grid, Row, 2, observer_lib:to_str(CS div 1024)),
-		     Row + 1
-	     end,
-    lists:foldl(Update, 0, Fields),
-    Fields.
-
-alloc_info([{Type,Instances}|Allocators],TypeAcc,TotalBS,TotalCS,IncludeTotal) ->
-    {BS,CS,NewTotalBS,NewTotalCS,NewIncludeTotal} =
-	sum_alloc_instances(Instances,0,0,TotalBS,TotalCS),
-    alloc_info(Allocators,[{Type,BS,CS}|TypeAcc],NewTotalBS,NewTotalCS,
-	       IncludeTotal andalso NewIncludeTotal);
-alloc_info([],TypeAcc,TotalBS,TotalCS,IncludeTotal) ->
-    Types = [X || X={_,BS,CS} <- TypeAcc, (BS>0 orelse CS>0)],
-    case IncludeTotal of
-	true ->
-	    [{total,TotalBS,TotalCS} | lists:reverse(Types)];
-	false ->
-	    lists:reverse(Types)
-    end.
-
-sum_alloc_instances(false,BS,CS,TotalBS,TotalCS) ->
-    {BS,CS,TotalBS,TotalCS,false};
-sum_alloc_instances([{_,_,Data}|Instances],BS,CS,TotalBS,TotalCS) ->
-    {NewBS,NewCS,NewTotalBS,NewTotalCS} =
-	sum_alloc_one_instance(Data,BS,CS,TotalBS,TotalCS),
-    sum_alloc_instances(Instances,NewBS,NewCS,NewTotalBS,NewTotalCS);
-sum_alloc_instances([],BS,CS,TotalBS,TotalCS) ->
-    {BS,CS,TotalBS,TotalCS,true}.
-
-sum_alloc_one_instance([{sbmbcs,[{blocks_size,BS,_,_},{carriers_size,CS,_,_}]}|
-			Rest],OldBS,OldCS,TotalBS,TotalCS) ->
-    sum_alloc_one_instance(Rest,OldBS+BS,OldCS+CS,TotalBS,TotalCS);
-sum_alloc_one_instance([{_,[{blocks_size,BS,_,_},{carriers_size,CS,_,_}]}|
-			Rest],OldBS,OldCS,TotalBS,TotalCS) ->
-    sum_alloc_one_instance(Rest,OldBS+BS,OldCS+CS,TotalBS+BS,TotalCS+CS);
-sum_alloc_one_instance([{_,[{blocks_size,BS},{carriers_size,CS}]}|
-			Rest],OldBS,OldCS,TotalBS,TotalCS) ->
-    sum_alloc_one_instance(Rest,OldBS+BS,OldCS+CS,TotalBS+BS,TotalCS+CS);
-sum_alloc_one_instance([_|Rest],BS,CS,TotalBS,TotalCS) ->
-    sum_alloc_one_instance(Rest,BS,CS,TotalBS,TotalCS);
-sum_alloc_one_instance([],BS,CS,TotalBS,TotalCS) ->
-    {BS,CS,TotalBS,TotalCS}.
-
 info_fields() ->
     Info = [{"System and Architecture",
 	     [{"System Version", otp_release},
diff --git a/lib/observer/src/observer_wx.erl b/lib/observer/src/observer_wx.erl
index 54c4092a78..cf602569aa 100644
--- a/lib/observer/src/observer_wx.erl
+++ b/lib/observer/src/observer_wx.erl
@@ -43,6 +43,7 @@
 -define(LAST_NODES_MENU_ID,  2000).
 
 -define(TRACE_STR, "Trace Overview").
+-define(ALLOC_STR, "Memory Allocators").
 
 %% Records
 -record(state,
@@ -58,6 +59,7 @@
 	 trace_panel,
 	 app_panel,
 	 perf_panel,
+	 allc_panel,
 	 active_tab,
 	 node,
 	 nodes,
@@ -149,6 +151,10 @@ setup(#state{frame = Frame} = State) ->
     PerfPanel = observer_perf_wx:start_link(Notebook, self()),
     wxNotebook:addPage(Notebook, PerfPanel, "Load Charts", []),
 
+    %% Memory Allocator Viewer Panel
+    AllcPanel = observer_alloc_wx:start_link(Notebook, self()),
+    wxNotebook:addPage(Notebook, AllcPanel, ?ALLOC_STR, []),
+
     %% App Viewer Panel
     AppPanel = observer_app_wx:start_link(Notebook, self()),
     wxNotebook:addPage(Notebook, AppPanel, "Applications", []),
@@ -184,6 +190,7 @@ setup(#state{frame = Frame} = State) ->
 			   trace_panel = TracePanel,
 			   app_panel = AppPanel,
 			   perf_panel = PerfPanel,
+			   allc_panel = AllcPanel,
 			   active_tab = SysPid,
 			   node  = node(),
 			   nodes = Nodes
@@ -505,7 +512,7 @@ check_page_title(Notebook) ->
 
 get_active_pid(#state{notebook=Notebook, pro_panel=Pro, sys_panel=Sys,
 		      tv_panel=Tv, trace_panel=Trace, app_panel=App,
-		      perf_panel=Perf
+		      perf_panel=Perf, allc_panel=Alloc
 		     }) ->
     Panel = case check_page_title(Notebook) of
 		"Processes" -> Pro;
@@ -513,13 +520,14 @@ get_active_pid(#state{notebook=Notebook, pro_panel=Pro, sys_panel=Sys,
 		"Table Viewer" -> Tv;
 		?TRACE_STR -> Trace;
 		"Load Charts" -> Perf;
-		"Applications" -> App
+		"Applications" -> App;
+		?ALLOC_STR -> Alloc
 	    end,
     wx_object:get_pid(Panel).
 
 pid2panel(Pid, #state{pro_panel=Pro, sys_panel=Sys,
 		      tv_panel=Tv, trace_panel=Trace, app_panel=App,
-		      perf_panel=Perf}) ->
+		      perf_panel=Perf, allc_panel=Alloc}) ->
     case Pid of
 	Pro -> "Processes";
 	Sys -> "System";
@@ -527,6 +535,7 @@ pid2panel(Pid, #state{pro_panel=Pro, sys_panel=Sys,
 	Trace -> ?TRACE_STR;
 	Perf -> "Load Charts";
 	App -> "Applications";
+	Alloc -> ?ALLOC_STR;
 	_ -> "unknown"
     end.
 
@@ -617,8 +626,8 @@ default_menus(NodesMenuItems) ->
 	    %% automagicly, so just add them to a menu that always exist.
 	    %% But not to the help menu for some reason
 
-	    {Tag, Menus} = NodeMenu,
-	    [{Tag, Menus ++ [Quit,About]}, LogMenu, {"&Help", [Help]}]
+	    {Tag, Menus} = FileMenu,
+	    [{Tag, Menus ++ [Quit,About]}, NodeMenu, LogMenu, {"&Help", [Help]}]
     end.
 
 clean_menus(Menus, MenuBar) ->