Merge branch 'siri/unicode-atoms/OTP-14285'

* siri/unicode-atoms/OTP-14285:
  [sasl] Improve handling of unicode in rb
  [ttb] Handle unicode atoms in trace data and config files
  [dbg] Update default trace handler to print unicode atoms correctly
  [etop] Fix handling of unicode atoms
  [stdlib] Open sys debug logs as utf8
  [stdlib] Open error log file as utf8
  [sasl] Improve handling of unicode atoms
  [ct] Print unicode atoms and strings correctly in common_test logs

3 files changed, 35 insertions, 18 deletions

diff --git a/lib/observer/src/etop.erl b/lib/observer/src/etop.erl
index 3d56a1e64d..f0990f1f25 100644
--- a/lib/observer/src/etop.erl
+++ b/lib/observer/src/etop.erl
@@ -81,7 +81,7 @@ check_runtime_config(accumulate,A) when A=:=true; A=:=false -> ok;
 check_runtime_config(_Key,_Value) -> error.
 
 dump(File) ->
-    case file:open(File,[write]) of
+    case file:open(File,[write,{encoding,utf8}]) of
 	{ok,Fd} -> etop_server ! {dump,Fd};
 	Error -> Error
     end.
@@ -161,7 +161,7 @@ data_handler(Reader, Opts) ->
 	{'EXIT', EPid, Reason} when EPid == Opts#opts.out_proc ->
 	    case Reason of
 		normal -> ok;
-		_ -> io:format("Output server crashed: ~p~n",[Reason])
+		_ -> io:format("Output server crashed: ~tp~n",[Reason])
 	    end,
 	    stop(Opts),
 	    out_proc_stopped;
diff --git a/lib/observer/src/etop_txt.erl b/lib/observer/src/etop_txt.erl
index 6b8f9df24f..f772d5cc6d 100644
--- a/lib/observer/src/etop_txt.erl
+++ b/lib/observer/src/etop_txt.erl
@@ -29,8 +29,6 @@
 
 -import(etop,[loadinfo/2,meminfo/2]).
 
--define(PROCFORM,"~-15w~-20s~8w~8w~8w~8w ~-20s~n").
-
 stop(Pid) -> Pid ! stop.
 
 init(Config) ->
@@ -50,6 +48,7 @@ do_update(Prev,Config) ->
     do_update(standard_io,Info,Prev,Config).
 
 do_update(Fd,Info,Prev,Config) ->
+    Encoding = encoding(Fd),
     {Cpu,NProcs,RQ,Clock} = loadinfo(Info,Prev),
     io:nl(Fd),
     writedoubleline(Fd),
@@ -73,7 +72,7 @@ do_update(Fd,Info,Prev,Config) ->
     io:nl(Fd),
     writepinfo_header(Fd),
     writesingleline(Fd),
-    writepinfo(Fd,Info#etop_info.procinfo),
+    writepinfo(Fd,Info#etop_info.procinfo,Encoding),
     writedoubleline(Fd),
     io:nl(Fd),
     Info.
@@ -93,19 +92,37 @@ writepinfo(Fd,[#etop_proc_info{pid=Pid,
 			       runtime=Time,
 			       cf=MFA,
 			       mq=MQ}
-	       |T]) ->
-    io:fwrite(Fd,?PROCFORM,[Pid,to_list(Name),Time,Reds,Mem,MQ,formatmfa(MFA)]), 
-    writepinfo(Fd,T);
-writepinfo(_Fd,[]) ->
+	       |T],
+           Encoding) ->
+    io:fwrite(Fd,proc_format(Encoding),
+              [Pid,to_list(Name,Encoding),Time,Reds,Mem,MQ,
+               formatmfa(MFA,Encoding)]),
+    writepinfo(Fd,T,Encoding);
+writepinfo(_Fd,[],_) ->
     ok.
 
 
-formatmfa({M, F, A}) ->
+formatmfa({M, F, A},latin1) ->
     io_lib:format("~w:~w/~w",[M, F, A]);
-formatmfa(Other) ->
+formatmfa({M, F, A},_) ->
+    io_lib:format("~w:~tw/~w",[M, F, A]);
+formatmfa(Other,_) ->
     %% E.g. when running hipe - the current_function for some
     %% processes will be 'undefined'
     io_lib:format("~w",[Other]).
 
-to_list(Name) when is_atom(Name) -> atom_to_list(Name);
-to_list({_M,_F,_A}=MFA) -> formatmfa(MFA).
+to_list(Name,_) when is_atom(Name) -> atom_to_list(Name);
+to_list({_M,_F,_A}=MFA,Encoding) -> formatmfa(MFA,Encoding).
+
+encoding(Device) ->
+    case io:getopts(Device) of
+        List when is_list(List) ->
+            proplists:get_value(encoding,List,latin1);
+        _ ->
+            latin1
+    end.
+
+proc_format(latin1) ->
+    "~-15w~-20s~8w~8w~8w~8w ~-20s~n";
+proc_format(_) ->
+    "~-15w~-20ts~8w~8w~8w~8w ~-20ts~n".
diff --git a/lib/observer/src/ttb.erl b/lib/observer/src/ttb.erl
index 87a50e046b..cc7bc8d906 100644
--- a/lib/observer/src/ttb.erl
+++ b/lib/observer/src/ttb.erl
@@ -391,16 +391,16 @@ run_config(ConfigFile,N) ->
     
 print_func(M,F,A) ->
     Args = arg_list(A,[]),
-    io:format("~w:~w(~s) ->~n",[M,F,Args]).
+    io:format("~w:~tw(~ts) ->~n",[M,F,Args]).
 print_result(R) ->
-    io:format("~p~n~n",[R]).
+    io:format("~tp~n~n",[R]).
 
 arg_list([],[]) ->
     "";
 arg_list([A1],Acc) ->
-    Acc++io_lib:format("~w",[A1]);
+    Acc++io_lib:format("~tw",[A1]);
 arg_list([A1|A],Acc) ->
-    arg_list(A,Acc++io_lib:format("~w,",[A1])).
+    arg_list(A,Acc++io_lib:format("~tw,",[A1])).
 
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -1117,7 +1117,7 @@ get_fd(Out) ->
 	    Out;
 	_file ->
 	    file:delete(Out),
-	    case file:open(Out,[append]) of
+	    case file:open(Out,[append,{encoding,utf8}]) of
 		{ok,Fd} -> Fd;
 		Error -> exit(Error)
 	    end