Test odbc with MySQL

Updated test framework to also be able to test the erlang odbc application
with MySQL as database.

Made minor changes to error-handling to improve interoperability
with MySQL-drivers.

10 files changed, 564 insertions, 291 deletions

diff --git a/lib/odbc/test/Makefile b/lib/odbc/test/Makefile
index ec2bcc67b5..bc6449242e 100644
--- a/lib/odbc/test/Makefile
+++ b/lib/odbc/test/Makefile
@@ -34,7 +34,8 @@ MODULES= \
 	odbc_test_lib \
 	oracle \
 	sqlserver \
-	postgres
+	postgres  \
+	mysql
 
 EBIN = .
 
diff --git a/lib/odbc/test/mysql.erl b/lib/odbc/test/mysql.erl
new file mode 100644
index 0000000000..76ffd3ecc9
--- /dev/null
+++ b/lib/odbc/test/mysql.erl
@@ -0,0 +1,266 @@
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 2011-2011. All Rights Reserved.
+%%
+%% The contents of this file are subject to the Erlang Public License,
+%% Version 1.1, (the "License"); you may not use this file except in
+%% compliance with the License. You should have received a copy of the
+%% Erlang Public License along with this software. If not, it can be
+%% retrieved online at http://www.erlang.org/.
+%%
+%% Software distributed under the License is distributed on an "AS IS"
+%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
+%% the License for the specific language governing rights and limitations
+%% under the License.
+%%
+%% %CopyrightEnd%
+%%
+
+%%
+
+-module(mysql).
+
+%% Note: This directive should only be used in test suites.
+-compile(export_all).
+
+%-------------------------------------------------------------------------
+connection_string() ->
+    "DSN=MySQL;Database=odbctest;Uid=odbctest;Pwd=gurka;CHARSET=utf8;SSTMT=SET NAMES 'utf8';".
+
+%-------------------------------------------------------------------------
+insert_result() ->
+    {selected,["ID","DATA"],[{1,"bar"}]}.
+
+update_result() ->
+    {selected,["ID","DATA"],[{1,"foo"}]}.
+
+selected_ID(N, next) ->
+    {selected,["ID"],[{N}]};
+
+selected_ID(_, _) ->
+    {error, driver_does_not_support_function}.
+
+selected_next_N(1)->
+    {selected,["ID"],
+     [{1},
+      {2},
+      {3}]};
+
+selected_next_N(2)->
+    {selected,["ID"],
+     [{4},
+      {5}]}.
+
+selected_relative_N(_)->
+    {error, driver_does_not_support_function}.
+
+selected_absolute_N(_)->
+    {error, driver_does_not_support_function}.
+
+selected_list_rows() ->
+    {selected,["ID", "DATA"],[[1, "bar"],[2,"foo"]]}.
+
+first_list_rows() ->
+    {error, driver_does_not_support_function}.
+last_list_rows() ->
+    {error, driver_does_not_support_function}.
+prev_list_rows() ->
+    {error, driver_does_not_support_function}.
+next_list_rows() ->
+    {selected,["ID","DATA"],[[1,"bar"]]}.
+
+multiple_select()->
+    [{selected,["ID", "DATA"],[{1, "bar"},{2, "foo"}]},
+     {selected,["ID"],[{"foo"}]}].
+
+multiple_mix()->
+    [{updated, 1},{updated, 1},
+     {selected,["ID", "DATA"],[{1, "foobar"},{2, "foo"}]},
+     {updated, 1}, {selected,["DATA"],[{"foo"}]}].
+
+%-------------------------------------------------------------------------
+var_char_min() ->
+    0.
+var_char_max() ->
+    65535.
+
+create_var_char_table(Size) ->
+    " (FIELD varchar(" ++ integer_to_list(Size) ++ "))".
+
+%-------------------------------------------------------------------------
+text_min() ->
+    1.
+text_max() ->
+   2147483646. % 2147483647. %% 2^31 - 1
+
+create_text_table() ->
+    " (FIELD text)".
+
+%-------------------------------------------------------------------------
+create_unicode_table() ->
+    " (FIELD text)".
+
+%-------------------------------------------------------------------------
+create_timestamp_table() ->
+    " (FIELD TIMESTAMP)".
+
+%-------------------------------------------------------------------------
+tiny_int_min() ->
+    -128.
+tiny_int_max() ->
+    127.
+
+create_tiny_int_table() ->
+     " (FIELD tinyint)".
+
+tiny_int_min_selected() ->
+    {selected,["FIELD"],[{tiny_int_min()}]}.
+
+tiny_int_max_selected() ->
+    {selected,["FIELD"], [{tiny_int_max()}]}.
+
+%-------------------------------------------------------------------------
+small_int_min() ->
+    -32768.
+small_int_max() ->
+    32767.
+
+create_small_int_table() ->
+     " (FIELD smallint)".
+
+small_int_min_selected() ->
+    {selected,["FIELD"],[{-32768}]}.
+
+small_int_max_selected() ->
+    {selected,["FIELD"], [{32767}]}.
+
+%-------------------------------------------------------------------------
+int_min() ->
+   -2147483648.
+int_max() ->
+    2147483647.
+
+create_int_table() ->
+     " (FIELD int)".
+
+int_min_selected() ->
+    {selected,["FIELD"],[{-2147483648}]}.
+
+int_max_selected() ->
+    {selected,["FIELD"], [{2147483647}]}.
+
+%-------------------------------------------------------------------------
+big_int_min() ->
+    -9223372036854775808.
+
+big_int_max() ->
+    9223372036854775807.
+
+create_big_int_table() ->
+     " (FIELD bigint )".
+
+big_int_min_selected() ->
+    {selected,["FIELD"], [{"-9223372036854775808"}]}.
+
+big_int_max_selected() ->
+    {selected,["FIELD"], [{"9223372036854775807"}]}.
+
+%-------------------------------------------------------------------------
+bit_false() ->
+    0.
+bit_true() ->
+    1.
+
+create_bit_table() ->
+     " (FIELD bit)".
+
+bit_false_selected() ->
+    {selected,["FIELD"],[{"0"}]}.
+
+bit_true_selected() ->
+    {selected,["FIELD"], [{"1"}]}.
+
+%-------------------------------------------------------------------------
+
+%% Do not test float min/max as value is only theoretical defined in
+%% mysql and may vary depending on hardware.
+
+create_float_table() ->
+    " (FIELD float)".
+
+float_zero_selected() ->
+    {selected,["FIELD"],[{0.00000e+0}]}.
+
+%-------------------------------------------------------------------------
+real_min() ->
+    -3.40e+38.
+real_max() ->
+    3.40e+38.
+
+real_underflow() ->
+    "-3.41e+38".
+
+real_overflow() ->
+    "3.41e+38".
+
+create_real_table() ->
+    " (FIELD real)".
+
+real_zero_selected() ->
+    {selected,["FIELD"],[{0.00000e+0}]}.
+
+%-------------------------------------------------------------------------
+param_select_small_int() ->
+    {selected,["FIELD"],[{1}, {2}]}.
+
+param_select_int() ->
+    Int = small_int_max() + 1,
+    {selected,["FIELD"],[{1}, {Int}]}.
+
+param_select_decimal() ->
+    {selected,["FIELD"],[{1},{2}]}.
+
+param_select_numeric() ->
+    {selected,["FIELD"],[{1},{2}]}.
+
+param_select_float() ->
+    {selected,["FIELD"],[{1.30000},{1.20000}]}.
+
+param_select_real() ->
+    {selected,["FIELD"],[{1.30000},{1.20000}]}.
+
+param_select_double() ->
+    {selected,["FIELD"],[{1.30000},{1.20000}]}.
+
+param_select_mix() ->
+    {selected,["ID","DATA"],[{1, "foo"}, {2, "bar"}]}.
+
+param_update() ->
+    {selected,["ID","DATA"],[{1, "foobar"}, {2, "foobar"}, {3, "baz"}]}.
+
+param_delete() ->
+    {selected,["ID","DATA"],[{3, "baz"}]}.
+
+param_select() ->
+    {selected,["ID","DATA"],[{1, "foo"},{3, "foo"}]}.
+
+%-------------------------------------------------------------------------
+describe_integer() ->
+    {ok,[{"myint1",sql_smallint},
+	 {"myint2",sql_integer},
+	 {"myint3",sql_integer}]}.
+
+describe_string() ->
+    {ok,[{"str1",{sql_char,10}},
+	 {"str2",{sql_char,10}},
+	 {"str3",{sql_varchar,10}},
+	 {"str4",{sql_varchar,10}}]}.
+
+describe_floating() ->
+     {ok,[{"f",sql_real},{"r",sql_double},{"d",sql_double}]}.
+describe_dec_num() ->
+    {ok,[{"mydec",{sql_decimal,9,3}},{"mynum",{sql_decimal,9,2}}]}.
+
+describe_timestamp() ->
+    {ok, [{"FIELD", sql_timestamp}]}.
diff --git a/lib/odbc/test/odbc_connect_SUITE.erl b/lib/odbc/test/odbc_connect_SUITE.erl
index 4772d1a6fc..6eaf3a81c4 100644
--- a/lib/odbc/test/odbc_connect_SUITE.erl
+++ b/lib/odbc/test/odbc_connect_SUITE.erl
@@ -77,15 +77,18 @@ end_per_group(_GroupName, Config) ->
 %% variable, but should NOT alter/remove any existing entries.
 %%--------------------------------------------------------------------
 init_per_suite(Config) ->
-    %% application:start(odbc),
-    odbc:start(), % make sure init_per_suite fails if odbc is not built
-    case catch odbc:connect(?RDBMS:connection_string(), 
-		      [{auto_commit, off}]) of
-	{ok, Ref} ->
-	    odbc:disconnect(Ref),
-	    [{tableName, odbc_test_lib:unique_table_name()} | Config];
-	_  ->
-	    {skip, "ODBC is not properly setup"}
+    case (catch odbc:start()) of
+	ok ->
+	    case catch odbc:connect(?RDBMS:connection_string(),
+				    [{auto_commit, off}]) of
+		{ok, Ref} ->
+		    odbc:disconnect(Ref),
+		    [{tableName, odbc_test_lib:unique_table_name()} | Config];
+		_  ->
+		    {skip, "ODBC is not properly setup"}
+	    end;
+	_ ->
+	    {skip,"ODBC not startable"}
     end.	    
 %%--------------------------------------------------------------------
 %% Function: end_per_suite(Config) -> _
@@ -94,8 +97,7 @@ init_per_suite(Config) ->
 %% Description: Cleanup after the whole suite
 %%--------------------------------------------------------------------
 end_per_suite(_Config) ->
-    application:stop(odbc),
-    ok.
+    application:stop(odbc).
 
 %%--------------------------------------------------------------------
 %% Function: init_per_testcase(Case, Config) -> Config
@@ -114,6 +116,12 @@ init_per_testcase(_TestCase, Config) ->
     Dog = test_server:timetrap(?default_timeout),
     Temp = lists:keydelete(connection_ref, 1, Config),
     NewConfig = lists:keydelete(watchdog, 1, Temp),
+    %% Clean up if needed
+    Table = ?config(tableName, Config),
+    {ok, Ref} = odbc:connect(?RDBMS:connection_string(), []),
+    Result = odbc:sql_query(Ref, "DROP TABLE " ++ Table),
+    io:format("Drop table: ~p ~p~n", [Table, Result]),
+    odbc:disconnect(Ref),
     [{watchdog, Dog} | NewConfig].
 
 %%--------------------------------------------------------------------
@@ -125,15 +133,8 @@ init_per_testcase(_TestCase, Config) ->
 %% Description: Cleanup after each test case
 %%--------------------------------------------------------------------
 end_per_testcase(_TestCase, Config) ->
-     %% Clean up if needed 
-    Table = ?config(tableName, Config),
-    {ok, Ref} = odbc:connect(?RDBMS:connection_string(), []),
-    Result = odbc:sql_query(Ref, "DROP TABLE " ++ Table), 
-    io:format("Drop table: ~p ~p~n", [Table, Result]),
-    odbc:disconnect(Ref),
     Dog = ?config(watchdog, Config),
-    test_server:timetrap_cancel(Dog),
-    ok.
+    test_server:timetrap_cancel(Dog).
 
 %%-------------------------------------------------------------------------
 %% Test cases starts here.
@@ -146,10 +147,12 @@ commit(Config)  ->
 			      [{auto_commit, off}]),
 
     Table = ?config(tableName, Config),
+    TransStr = transaction_support_str(?RDBMS),
+
     {updated, _} = 
 	odbc:sql_query(Ref, 
 		       "CREATE TABLE " ++ Table ++
-		       " (ID integer, DATA varchar(10))"),
+		       " (ID integer, DATA varchar(10))" ++ TransStr),
 
     {updated, 1} = 
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(1,'bar')"),
@@ -174,50 +177,44 @@ commit(Config)  ->
     {'EXIT', {function_clause, _}} = 
 	(catch odbc:commit(Ref, commit, -1)),
 
-    ok = odbc:disconnect(Ref),
-
-    ok.
+    ok = odbc:disconnect(Ref).
 %%-------------------------------------------------------------------------
 
 rollback(doc)->
     ["Test the use of explicit rollback"];
 rollback(suite) -> [];
 rollback(Config)  ->
-    {ok, Ref} =  odbc:connect(?RDBMS:connection_string(), 
-			      [{auto_commit, off}]),
-
+    {ok, Ref} =  odbc:connect(?RDBMS:connection_string(), [{auto_commit, off}]),
     Table = ?config(tableName, Config),
+    TransStr = transaction_support_str(?RDBMS),
 
-    {updated, _} = 
-	odbc:sql_query(Ref, 
+    {updated, _} =
+	odbc:sql_query(Ref,
 		       "CREATE TABLE " ++ Table ++
-		       " (ID integer, DATA varchar(10))"),
-    {updated, 1} = 
+			   " (ID integer, DATA varchar(10))" ++ TransStr),
+    {updated, 1} =
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++ " VALUES(1,'bar')"),
     ok = odbc:commit(Ref, commit),
 
-    {updated, 1} = 
+    {updated, 1} =
 	odbc:sql_query(Ref, "UPDATE " ++ Table ++
-		       " SET DATA = 'foo' WHERE ID = 1"),
+			   " SET DATA = 'foo' WHERE ID = 1"),
     ok = odbc:commit(Ref, rollback),
     InsertResult = ?RDBMS:insert_result(),
-    InsertResult = 
+    InsertResult =
 	odbc:sql_query(Ref, "SELECT * FROM " ++ Table),
-
-    {updated, 1} = 
+    {updated, 1} =
 	odbc:sql_query(Ref, "UPDATE " ++ Table ++
-		       " SET DATA = 'foo' WHERE ID = 1"),
+			   " SET DATA = 'foo' WHERE ID = 1"),
     ok = odbc:commit(Ref, rollback, ?TIMEOUT),
     InsertResult = ?RDBMS:insert_result(),
-    InsertResult = 
+    InsertResult =
 	odbc:sql_query(Ref, "SELECT * FROM " ++ Table),
 
+    {'EXIT', {function_clause, _}} =
+	(catch odbc:commit(Ref, rollback, -1)),
 
-    {'EXIT', {function_clause, _}} = 
-	(catch odbc:commit(Ref, rollback, -1)), 
-
-    ok = odbc:disconnect(Ref),
-    ok.
+    ok = odbc:disconnect(Ref).
 
 %%-------------------------------------------------------------------------
 not_explicit_commit(doc) ->
@@ -227,8 +224,7 @@ not_explicit_commit(_Config) ->
     {ok, Ref} = 
 	odbc:connect(?RDBMS:connection_string(), [{auto_commit, on}]),
     {error, _} = odbc:commit(Ref, commit),
-    ok = odbc:disconnect(Ref),
-    ok.
+    ok = odbc:disconnect(Ref).
 
 %%-------------------------------------------------------------------------
 not_exist_db(doc) ->
@@ -237,8 +233,7 @@ not_exist_db(suite) -> [];
 not_exist_db(_Config)  ->
     {error, _} = odbc:connect("DSN=foo;UID=bar;PWD=foobar", []),
     %% So that the odbc control server can be stoped "in the correct way"
-    test_server:sleep(100),
-    ok.
+    test_server:sleep(100).
 
 %%-------------------------------------------------------------------------
 no_c_node(doc) ->
@@ -276,9 +271,8 @@ port_dies(_Config) ->
     %% Wait for exit_status from port 5000 ms (will not get a exit
     %% status in this case), then wait a little longer to make sure
     %% the port and the controlprocess has had time to terminate.
-    test_server:sleep(7000), 
-    undefined = process_info(Ref, status),   
-    ok.
+    test_server:sleep(10000),
+    undefined = process_info(Ref, status).
 
 %%-------------------------------------------------------------------------
 control_process_dies(doc) ->
@@ -290,12 +284,10 @@ control_process_dies(_Config) ->
     Port = lists:last(erlang:ports()),      
     {connected, Ref} = erlang:port_info(Port, connected),  
     exit(Ref, kill),
-    test_server:sleep(100),
-    undefined = erlang:port_info(Port, connected),   
+    test_server:sleep(500),
+    undefined = erlang:port_info(Port, connected).
     %% Check for c-program still running, how?
-    ok.
 
-%%-------------------------------------------------------------------------
 
 %%-------------------------------------------------------------------------
 client_dies_normal(doc) ->
@@ -400,6 +392,8 @@ connect_timeout(suite) -> [];
 connect_timeout(Config) when is_list(Config) ->
     {'EXIT',timeout} = (catch odbc:connect(?RDBMS:connection_string(),
 					   [{timeout, 0}])),
+    %% Need to return ok here "{'EXIT',timeout} return value" will
+    %% be interpreted as that the testcase has timed out.
     ok.
 %%-------------------------------------------------------------------------
 timeout(doc) ->
@@ -412,10 +406,12 @@ timeout(Config)  when is_list(Config) ->
 			      [{auto_commit, off}]),
     Table = ?config(tableName, Config),
 
+    TransStr = transaction_support_str(?RDBMS),
+
     {updated, _} = 
 	odbc:sql_query(Ref, 
 		       "CREATE TABLE " ++ Table ++
-		       " (ID integer, DATA varchar(10), PRIMARY KEY(ID))"),
+		       " (ID integer, DATA varchar(10), PRIMARY KEY(ID))" ++ TransStr),
 
     {updated, 1} = 
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++ " VALUES(1,'bar')"),
@@ -447,9 +443,7 @@ timeout(Config)  when is_list(Config) ->
     ["DATA"] = odbc_test_lib:to_upper(Fields),
 
     ok = odbc:commit(Ref, commit),
-    ok = odbc:disconnect(Ref),
-    ok.
-
+    ok = odbc:disconnect(Ref).
 
 update_table_timeout(Table, TimeOut, Pid) ->
 
@@ -475,15 +469,16 @@ update_table_timeout(Table, TimeOut, Pid) ->
 	odbc:sql_query(Ref, "SELECT DATA FROM " ++ Table ++ " WHERE ID = 2"),
     ["DATA"] = odbc_test_lib:to_upper(Fields),
 
-    {updated, 1} = odbc:sql_query(Ref, UpdateQuery, TimeOut),
+    %% Do not check {updated, 1} as some drivers will return 0
+    %% even though the update is done, which is checked by the test
+    %% case when the altered message is recived.
+    {updated, _} = odbc:sql_query(Ref, UpdateQuery, TimeOut),
 
     ok = odbc:commit(Ref, commit),
 
     Pid ! altered,
 
-    ok = odbc:disconnect(Ref),
-
-    ok.
+    ok = odbc:disconnect(Ref).
 %%-------------------------------------------------------------------------
 many_timeouts(doc) ->
     ["Tests that many consecutive timeouts lead to that the connection "
@@ -494,11 +489,12 @@ many_timeouts(Config) when is_list(Config) ->
 			      [{auto_commit, off}]),
 
     Table = ?config(tableName, Config),
+    TransStr = transaction_support_str(?RDBMS),
 
     {updated, _} = 
 	odbc:sql_query(Ref, 
 		       "CREATE TABLE " ++ Table ++
-		       " (ID integer, DATA varchar(10), PRIMARY KEY(ID))"),
+		       " (ID integer, DATA varchar(10), PRIMARY KEY(ID))" ++ TransStr),
 
     {updated, 1} = 
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++ " VALUES(1,'bar')"),
@@ -518,8 +514,7 @@ many_timeouts(Config) when is_list(Config) ->
     end,
 
     ok = odbc:commit(Ref, commit),
-    ok = odbc:disconnect(Ref),
-    ok.
+    ok = odbc:disconnect(Ref).
 
 
 update_table_many_timeouts(Table, TimeOut, Pid) ->
@@ -532,8 +527,7 @@ update_table_many_timeouts(Table, TimeOut, Pid) ->
 
     Pid ! many_timeouts_occurred, 
 
-    ok = odbc:disconnect(Ref),
-    ok.
+    ok = odbc:disconnect(Ref).
 
 
 loop_many_timouts(Ref, UpdateQuery, TimeOut) ->
@@ -547,18 +541,19 @@ loop_many_timouts(Ref, UpdateQuery, TimeOut) ->
     end.
 %%-------------------------------------------------------------------------
 timeout_reset(doc) ->
-    ["Check that the number of consecutive timouts is reset to 0 when " 
+    ["Check that the number of consecutive timouts is reset to 0 when "
      "a successful call to the database is made."];
 timeout_reset(suite) -> [];
 timeout_reset(Config) when is_list(Config) ->
     {ok, Ref} =  odbc:connect(?RDBMS:connection_string(),
 			      [{auto_commit, off}]),
     Table = ?config(tableName, Config),
+    TransStr = transaction_support_str(?RDBMS),
 
     {updated, _} = 
 	odbc:sql_query(Ref, 
 		       "CREATE TABLE " ++ Table ++
-		       " (ID integer, DATA varchar(10), PRIMARY KEY(ID))"),
+		       " (ID integer, DATA varchar(10), PRIMARY KEY(ID))" ++  TransStr),
 
     {updated, 1} = 
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++ " VALUES(1,'bar')"),
@@ -594,8 +589,7 @@ timeout_reset(Config) when is_list(Config) ->
     ["DATA"] = odbc_test_lib:to_upper(Fields),
 
     ok = odbc:commit(Ref, commit),
-    ok = odbc:disconnect(Ref),
-    ok.
+    ok = odbc:disconnect(Ref).
 
 update_table_timeout_reset(Table, TimeOut, Pid) ->
 
@@ -617,15 +611,16 @@ update_table_timeout_reset(Table, TimeOut, Pid) ->
 	odbc:sql_query(Ref, "SELECT DATA FROM " ++ Table ++ " WHERE ID = 2"),
     ["DATA"] = odbc_test_lib:to_upper(Fields),
 
-    {updated,1} = odbc:sql_query(Ref, UpdateQuery, TimeOut),
+    %% Do not check {updated, 1} as some drivers will return 0
+    %% even though the update is done, which is checked by the test
+    %% case when the altered message is recived.
+    {updated, _} = odbc:sql_query(Ref, UpdateQuery, TimeOut),
 
     ok = odbc:commit(Ref, commit),
 
     Pid ! altered,
 
-    ok = odbc:disconnect(Ref),
-
-    ok.
+    ok = odbc:disconnect(Ref).
 
 loop_timout_reset(_, _, _, 0) ->
     ok;
@@ -651,11 +646,12 @@ disconnect_on_timeout(Config) when is_list(Config) ->
     {ok, Ref} =  odbc:connect(?RDBMS:connection_string(),
 			      [{auto_commit, off}]),
     Table = ?config(tableName, Config),
+    TransStr = transaction_support_str(?RDBMS),
 
     {updated, _} = 
 	odbc:sql_query(Ref, 
 		       "CREATE TABLE " ++ Table ++
-		       " (ID integer, DATA varchar(10), PRIMARY KEY(ID))"),
+		       " (ID integer, DATA varchar(10), PRIMARY KEY(ID))" ++ TransStr),
 
     {updated, 1} = 
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++ " VALUES(1,'bar')"),
@@ -715,8 +711,7 @@ connection_closed(Config) when is_list(Config) ->
     {error, connection_closed} = odbc:next(Ref),
     {error, connection_closed} = odbc:prev(Ref),
     {error, connection_closed} = odbc:select(Ref, next, 3),
-    {error, connection_closed} = odbc:commit(Ref, commit),
-    ok.
+    {error, connection_closed} = odbc:commit(Ref, commit).
 
 %%-------------------------------------------------------------------------
 disable_scrollable_cursors(doc) ->
@@ -754,8 +749,7 @@ disable_scrollable_cursors(Config) when is_list(Config) ->
     {error, scrollable_cursors_disabled} =
 	odbc:select(Ref, {absolute, 2}, 5),
 
-    {selected, _ColNames,[]} = odbc:select(Ref, next, 1),
-    ok.
+    {selected, _ColNames,[]} = odbc:select(Ref, next, 1).
 
 %%-------------------------------------------------------------------------
 return_rows_as_lists(doc)->
@@ -793,8 +787,7 @@ return_rows_as_lists(Config) when is_list(Config) ->
     Last = odbc:last(Ref),
     Prev = odbc:prev(Ref),
     First = odbc:first(Ref),
-    Next = odbc:next(Ref),
-    ok.   
+    Next = odbc:next(Ref).
 
 %%-------------------------------------------------------------------------
 
@@ -819,6 +812,9 @@ api_missuse(Config) when is_list(Config)->
     %% Could be an innocent misstake the connection lives. 
     Ref3 ! foobar, 
     test_server:sleep(10),
-    {status, _} = process_info(Ref3, status),
-    ok.
+    {status, _} = process_info(Ref3, status).
 
+transaction_support_str(mysql) ->
+    "ENGINE = InnoDB";
+transaction_support_str(_) ->
+    "".
diff --git a/lib/odbc/test/odbc_data_type_SUITE.erl b/lib/odbc/test/odbc_data_type_SUITE.erl
index 633ddec27f..3585446ec8 100644
--- a/lib/odbc/test/odbc_data_type_SUITE.erl
+++ b/lib/odbc/test/odbc_data_type_SUITE.erl
@@ -44,24 +44,29 @@ suite() -> [{ct_hooks,[ts_install_cth]}].
 all() -> 
     case odbc_test_lib:odbc_check() of
 	ok ->
-	    [{group, char}, {group, int}, {group, floats},
+	    [{group, char},{group, fixed_char}, {group, binary_char},
+	     {group, fixed_binary_char},
+	     {group, int}, {group, floats},
 	     {group, dec_and_num}, timestamp];
 	Other -> {skip, Other}
     end.
 
 groups() -> 
     [{char, [],
-      [char_fixed_lower_limit, char_fixed_upper_limit,
-       char_fixed_padding, varchar_lower_limit,
+      [varchar_lower_limit,
        varchar_upper_limit, varchar_no_padding,
        text_lower_limit, text_upper_limit, unicode]},
+     {fixed_char, [],
+      [char_fixed_lower_limit, char_fixed_upper_limit,
+       char_fixed_padding]},
      {binary_char, [],
-      [binary_char_fixed_lower_limit,
-       binary_char_fixed_upper_limit,
-       binary_char_fixed_padding, binary_varchar_lower_limit,
+      [binary_varchar_lower_limit,
        binary_varchar_upper_limit, binary_varchar_no_padding,
        binary_text_lower_limit, binary_text_upper_limit,
        unicode]},
+     {fixed_binary_char, [], [binary_char_fixed_lower_limit,
+			      binary_char_fixed_upper_limit,
+			      binary_char_fixed_padding]},
      {int, [],
       [tiny_int_lower_limit, tiny_int_upper_limit,
        small_int_lower_limit, small_int_upper_limit,
@@ -74,6 +79,15 @@ groups() ->
       [dec_long, dec_double, dec_bignum, num_long, num_double,
        num_bignum]}].
 
+init_per_group(GroupName, Config) when GroupName == fixed_char;
+				       GroupName == fixed_binary_char ->
+    case ?RDBMS of
+	mysql ->
+	    {skip, "No supported by MYSQL"};
+	_ ->
+	    Config
+    end;
+
 init_per_group(_GroupName, Config) ->
     Config.
 
@@ -92,9 +106,12 @@ end_per_group(_GroupName, Config) ->
 %% variable, but should NOT alter/remove any existing entries.
 %%--------------------------------------------------------------------
 init_per_suite(Config) ->
-    %%application:start(odbc),
-    odbc:start(), % make sure init_per_suite fails if odbc is not built
-    [{tableName, odbc_test_lib:unique_table_name()} | Config].
+    case (catch odbc:start()) of
+	ok ->
+	    [{tableName, odbc_test_lib:unique_table_name()} | Config];
+	_ ->
+	    {skip, "ODBC not startable"}
+    end.
 
 %%--------------------------------------------------------------------
 %% Function: end_per_suite(Config) -> _
@@ -118,23 +135,22 @@ end_per_suite(_Config) ->
 %% Note: This function is free to add any key/value pairs to the Config
 %% variable, but should NOT alter/remove any existing entries.
 %%--------------------------------------------------------------------
-init_per_testcase(varchar_upper_limit, _Config) ->
-    {skip, "Known bug in database"};
-init_per_testcase(text_upper_limit, _Config) ->
-    {skip, "Consumes too much resources"};
-
-init_per_testcase(Case, Config) when Case == bit_true; Case == bit_false ->
-    case is_supported_bit(?RDBMS) of
+init_per_testcase(Case, Config) when Case == varchar_upper_limit;
+				     Case == binary_varchar_upper_limit;
+				     Case == varchar_no_padding;
+				     Case == binary_varchar_no_padding ->
+    case is_fixed_upper_limit(?RDBMS) of
 	true ->
 	    common_init_per_testcase(Case, Config);
 	false ->
-	    {skip, "Not supported by driver"}
+	    {skip, "Upper limit is not fixed in" ++ atom_to_list(?RDBMS)}
     end;
 
-init_per_testcase(Case, Config) when Case == multiple_select_result_sets;
-				     Case == multiple_mix_result_sets;
-				     Case == multiple_result_sets_error ->
-   case is_supported_multiple_resultsets(?RDBMS) of
+init_per_testcase(text_upper_limit, _Config) ->
+    {skip, "Consumes too much resources"};
+
+init_per_testcase(Case, Config) when Case == bit_true; Case == bit_false ->
+    case is_supported_bit(?RDBMS) of
 	true ->
 	    common_init_per_testcase(Case, Config);
 	false ->
@@ -151,11 +167,6 @@ init_per_testcase(param_insert_tiny_int = Case, Config) ->
 init_per_testcase(Case, Config) ->
     common_init_per_testcase(Case, Config).
 
-is_supported_multiple_resultsets(sqlserver) ->
-    true;
-is_supported_multiple_resultsets(_) ->
-    false.
-
 is_supported_tinyint(sqlserver) ->
     true;
 is_supported_tinyint(_) ->
@@ -166,6 +177,11 @@ is_supported_bit(sqlserver) ->
 is_supported_bit(_) ->
     false.
 
+is_fixed_upper_limit(mysql) ->
+    false;
+is_fixed_upper_limit(_) ->
+    true.
+
 common_init_per_testcase(Case, Config) ->
     case atom_to_list(Case) of
 	"binary" ++ _  ->
@@ -177,6 +193,7 @@ common_init_per_testcase(Case, Config) ->
 	_ ->
 	    {ok, Ref} = odbc:connect(?RDBMS:connection_string(), [])
     end,
+    odbc_test_lib:strict(Ref, ?RDBMS),
     Dog = test_server:timetrap(?default_timeout),
     Temp = lists:keydelete(connection_ref, 1, Config),
     NewConfig = lists:keydelete(watchdog, 1, Temp),
@@ -218,18 +235,18 @@ char_fixed_lower_limit(Config) when is_list(Config) ->
     {error, _} = 
 	odbc:sql_query(Ref, 
 		       "CREATE TABLE " ++ Table ++    
-		       ?RDBMS:create_fixed_char_table(
+			   ?RDBMS:create_fixed_char_table(
 			  (?RDBMS:fixed_char_min() - 1))), 
     %% Lower limit
     {updated, _} =  % Value == 0 || -1 driver dependent!
 	odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++ 
-		       ?RDBMS:create_fixed_char_table(
-			  ?RDBMS:fixed_char_min())), 
+			   ?RDBMS:create_fixed_char_table(
+			      ?RDBMS:fixed_char_min())),
 
     %% Right length data
     {updated, _} =  
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++
-		       "'" ++ string:chars($a, ?RDBMS:fixed_char_min())
+			   "'" ++ string:chars($a, ?RDBMS:fixed_char_min())
 		       ++ "')"),
     %% Select data
     {selected, Fields,[{"a"}]} =
@@ -240,11 +257,11 @@ char_fixed_lower_limit(Config) when is_list(Config) ->
     %% Too long data
     {error, _}  =  
 	odbc:sql_query(Ref,"INSERT INTO " ++ Table ++" VALUES(" ++
-		       "'" ++ string:chars($a, 
-					   (?RDBMS:fixed_char_min()
-					    + 1)) 
-		       ++ "')"),		
-    ok.
+			   "'" ++ string:chars($a,
+					       (?RDBMS:fixed_char_min()
+						+ 1))
+		       ++ "')").
+
 %%-------------------------------------------------------------------------
 
 char_fixed_upper_limit(doc) ->
@@ -292,8 +309,7 @@ char_fixed_upper_limit(Config) when is_list(Config) ->
 	    {error, _} =
 		odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++  
 			       ?RDBMS:create_fixed_char_table(
-				  (?RDBMS:fixed_char_max() + 1))), 
-	    ok
+				  (?RDBMS:fixed_char_max() + 1)))
     end.
 
 %%-------------------------------------------------------------------------
@@ -310,20 +326,20 @@ char_fixed_padding(Config) when is_list(Config) ->
     %% Data should be padded with blanks
     {updated, _} =  % Value == 0 || -1 driver dependent!
 	odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++ 
-		       ?RDBMS:create_fixed_char_table(
-			  ?RDBMS:fixed_char_max())), 
+			   ?RDBMS:create_fixed_char_table(
+			      ?RDBMS:fixed_char_max())),
 
-    {updated, _} =  
+    {updated, _} =
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
-		       "'" ++ string:chars($a, 
-					   ?RDBMS:fixed_char_min())
+			   "'" ++ string:chars($a,
+					       ?RDBMS:fixed_char_min())
 		       ++ "')"),
 
     {selected, Fields, [{CharStr}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
     true = length(CharStr) == ?RDBMS:fixed_char_max(),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields),
-    ok.
+	    ["FIELD"] = odbc_test_lib:to_upper(Fields).
+
 %%-------------------------------------------------------------------------
 
 varchar_lower_limit(doc) ->
@@ -336,33 +352,33 @@ varchar_lower_limit(Config) when is_list(Config) ->
 
     %% Below limit
     {error, _} = 
-	odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++ 
-		       ?RDBMS:create_var_char_table(
-			  ?RDBMS:var_char_min() - 1)), 
+	odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++
+			   ?RDBMS:create_var_char_table(
+			      ?RDBMS:var_char_min() - 1)),
     %% Lower limit
     {updated, _} =  % Value == 0 || -1 driver dependent!
 	odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++ 
-		       ?RDBMS:create_var_char_table(
-			  ?RDBMS:var_char_min())), 
+				   ?RDBMS:create_var_char_table(
+				      ?RDBMS:var_char_min())),
+
+    Str = string:chars($a, ?RDBMS:var_char_min()),
 
     %% Right length data
     {updated, _} =  
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
-		       "'" ++ string:chars($a, ?RDBMS:var_char_min())
-		       ++ "')"),
+			   "'" ++ Str ++ "')"),
     %% Select data
-    {selected, Fields, [{"a"}]} =
+    {selected, Fields, [{Str}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
     
     ["FIELD"] = odbc_test_lib:to_upper(Fields),
 
-    %% Too long data
-    {error, _} =  
-	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
-		       "'" ++ string:chars($a, 
-					   (?RDBMS:var_char_min()+1)) 
-		       ++ "')"),		
-    ok.
+    %% Too long datae
+    {error, _} =
+		odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++
+				   "'" ++ string:chars($a,
+						       (?RDBMS:var_char_min()+1))
+			       ++ "')").
 
 %%-------------------------------------------------------------------------
 
@@ -438,8 +454,7 @@ varchar_no_padding(Config) when is_list(Config) ->
     {selected, Fields, [{CharStr}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
     true = length(CharStr) /= ?RDBMS:var_char_max(),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields).
 
 %%-------------------------------------------------------------------------
 
@@ -462,8 +477,7 @@ text_lower_limit(Config) when is_list(Config) ->
 
     {selected, Fields, [{"a"}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields).
 
 %%-------------------------------------------------------------------------
 
@@ -493,8 +507,7 @@ text_upper_limit(Config) when is_list(Config) ->
 %%     {error, _} =  
 %% 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 %% 		       "'" ++ string:chars($a, (?RDBMS:text_max()+1)) 
-%% 		       ++ "')"),		
-%%     ok.
+%% 		       ++ "')").
 
 %%-------------------------------------------------------------------------
 
@@ -518,13 +531,18 @@ binary_char_fixed_lower_limit(Config) when is_list(Config) ->
 		       ?RDBMS:create_fixed_char_table(
 			  ?RDBMS:fixed_char_min())), 
 
+    Str = string:chars($a, ?RDBMS:fixed_char_min()),
+
     %% Right length data
     {updated, _} =  
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++
-		       "'" ++ string:chars($a, ?RDBMS:fixed_char_min())
+		       "'" ++ Str
 		       ++ "')"),
+
+    Bin = list_to_binary(Str),
+
     %% Select data
-    {selected, Fields,[{<<"a">>}]} =
+    {selected, Fields,[{Bin}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
 
     ["FIELD"] = odbc_test_lib:to_upper(Fields),
@@ -535,8 +553,7 @@ binary_char_fixed_lower_limit(Config) when is_list(Config) ->
 		       "'" ++ string:chars($a, 
 					   (?RDBMS:fixed_char_min()
 					    + 1)) 
-		       ++ "')"),		
-    ok.
+		       ++ "')").
 %%-------------------------------------------------------------------------
 
 binary_char_fixed_upper_limit(doc) ->
@@ -614,8 +631,8 @@ binary_char_fixed_padding(Config) when is_list(Config) ->
     {selected, Fields, [{CharBin}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
     true = size(CharBin) == ?RDBMS:fixed_char_max(),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields).
+
 %%-------------------------------------------------------------------------
 
 binary_varchar_lower_limit(doc) ->
@@ -637,13 +654,17 @@ binary_varchar_lower_limit(Config) when is_list(Config) ->
 		       ?RDBMS:create_var_char_table(
 			  ?RDBMS:var_char_min())), 
 
+    Str = string:chars($a, ?RDBMS:var_char_min()),
+
     %% Right length data
     {updated, _} =  
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
-		       "'" ++ string:chars($a, ?RDBMS:var_char_min())
+		       "'" ++ Str
 		       ++ "')"),
+    BinStr = list_to_binary(Str),
+
     %% Select data
-    {selected, Fields, [{<<"a">>}]} =
+    {selected, Fields, [{BinStr}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
     
     ["FIELD"] = odbc_test_lib:to_upper(Fields),
@@ -653,8 +674,7 @@ binary_varchar_lower_limit(Config) when is_list(Config) ->
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 		       "'" ++ string:chars($a, 
 					   (?RDBMS:var_char_min()+1)) 
-		       ++ "')"),		
-    ok.
+		       ++ "')").
 
 %%-------------------------------------------------------------------------
 
@@ -703,8 +723,7 @@ binary_varchar_upper_limit(Config) when is_list(Config) ->
 	    {error, _} =
 		odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++ 
 			       ?RDBMS:create_var_char_table(
-				  (?RDBMS:var_char_max() + 1))),
-	    ok
+				  (?RDBMS:var_char_max() + 1)))
     end.
 %%-------------------------------------------------------------------------
 
@@ -730,8 +749,7 @@ binary_varchar_no_padding(Config) when is_list(Config) ->
     {selected, Fields, [{CharBin}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
     true = size(CharBin) /= ?RDBMS:var_char_max(),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields).
 
 %%-------------------------------------------------------------------------
 
@@ -754,8 +772,7 @@ binary_text_lower_limit(Config) when is_list(Config) ->
 
     {selected, Fields, [{<<"a">>}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields).
 
 %%-------------------------------------------------------------------------
 
@@ -785,11 +802,7 @@ binary_text_upper_limit(Config) when is_list(Config) ->
 %%     {error, _} =  
 %% 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 %% 		       "'" ++ string:chars($a, (?RDBMS:text_max()+1)) 
-%% 		       ++ "')"),		
-%%     ok.
-
-
-%%-------------------------------------------------------------------------
+%% 		       ++ "')").
 
 
 %%-------------------------------------------------------------------------
@@ -823,8 +836,7 @@ tiny_int_lower_limit(Config) when is_list(Config) ->
 		odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 			       "'" ++ integer_to_list(?RDBMS:tiny_int_min() 
 						      - 1)
-			       ++ "')"),
-	    ok
+			       ++ "')")
     end.
 
 %%-------------------------------------------------------------------------
@@ -858,8 +870,7 @@ tiny_int_upper_limit(Config) when is_list(Config) ->
 		odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 			       "'" ++ integer_to_list(?RDBMS:tiny_int_max()
 						      + 1)
-			       ++ "')"),
-	    ok
+			       ++ "')")
     end.
 
 %%-------------------------------------------------------------------------
@@ -889,8 +900,7 @@ small_int_lower_limit(Config) when is_list(Config) ->
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 		       "'"  ++ integer_to_list(?RDBMS:small_int_min()
 					       - 1)
-		       ++ "')"),
-    ok.
+		       ++ "')").
 
 %%-------------------------------------------------------------------------
 
@@ -919,8 +929,7 @@ small_int_upper_limit(Config) when is_list(Config) ->
 	odbc:sql_query(Ref,"INSERT INTO " ++ Table ++" VALUES(" ++  
 		       "'" ++ integer_to_list(?RDBMS:small_int_max() 
 					      + 1)
-		       ++ "')"),
-    ok.
+		       ++ "')").
 
 %%-------------------------------------------------------------------------
 int_lower_limit(doc) ->
@@ -947,8 +956,7 @@ int_lower_limit(Config) when is_list(Config) ->
     {error, _} =  
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 		       "'" ++ integer_to_list(?RDBMS:int_min() - 1)
-		       ++ "')"),
-    ok.
+		       ++ "')").
 
 %%-------------------------------------------------------------------------
 
@@ -976,8 +984,7 @@ int_upper_limit(Config) when is_list(Config) ->
     {error, _} =  
 	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 		       "'" ++ integer_to_list(?RDBMS:int_max() + 1)
-		       ++ "')"),    
-    ok.
+		       ++ "')").
 
 
 %%-------------------------------------------------------------------------
@@ -1006,8 +1013,7 @@ big_int_lower_limit(Config) when is_list(Config) ->
  	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 		       "'" ++ integer_to_list(?RDBMS:big_int_min() 
 					      - 1)
-		       ++ "')"),
-    ok.
+		       ++ "')").
 
 %%-------------------------------------------------------------------------
 
@@ -1036,8 +1042,7 @@ big_int_upper_limit(Config) when is_list(Config) ->
  	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 		       "'" ++ integer_to_list(?RDBMS:big_int_max() 
 					      + 1)
-		       ++ "')"),
-    ok.
+		       ++ "')").
 %%-------------------------------------------------------------------------
 
 bit_false(doc) ->
@@ -1069,8 +1074,7 @@ bit_false(Config) when is_list(Config) ->
 	    {error, _} =  
 		odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 			       "'" ++ integer_to_list(-1)
-			       ++ "')"),
-	    ok
+			       ++ "')")
     end.
 
 %%-------------------------------------------------------------------------
@@ -1105,14 +1109,10 @@ bit_true(Config) when is_list(Config) ->
 	    {error, _} =  
 		odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
 			       "'" ++ integer_to_list(-1)
-			       ++ "')"),
-	    ok
+			       ++ "')")
     end.
 
 %%-------------------------------------------------------------------------
-
-
-%%-------------------------------------------------------------------------
 float_lower_limit(doc) ->
     [""];
 float_lower_limit(suite) ->
@@ -1122,44 +1122,45 @@ float_lower_limit(Config) when is_list(Config) ->
     Ref = ?config(connection_ref, Config),   
     Table = ?config(tableName, Config),
 
-    {updated, _} =  % Value == 0 || -1 driver dependent!
-	odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++ 
-		       ?RDBMS:create_float_table()), 
-
-    {updated, _} =  
-	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
-		       "'" ++ float_to_list(
-				?RDBMS:float_min())
-		       ++ "')"),
-    {selected,[_ColName],[{MinFloat}]} = 
-	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-
-    true = ?RDBMS:float_min() == MinFloat,
-
     case ?RDBMS of
-	oracle ->
-	    {updated, _} =  % Value == 0 || -1 driver dependent!
-		odbc:sql_query(Ref, "DROP TABLE " ++ Table), 
-
+	mysql ->
+	    {skip, "Not clearly defined in MYSQL"};
+	_ ->
 	    {updated, _} =  % Value == 0 || -1 driver dependent!
 		odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++ 
-			       ?RDBMS:create_float_table()), 
+				   ?RDBMS:create_float_table()),
 
 	    {updated, _} =  
-		odbc:sql_query(Ref, 
-			       "INSERT INTO " ++ Table ++" VALUES(" ++ 
-			       ?RDBMS:float_underflow() ++ ")"),
-
-	    SelectResult = ?RDBMS:float_zero_selected(),
-	    SelectResult =
-		odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table);
-	_ ->
-	    {error, _} =  
 		odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
-			       ?RDBMS:float_underflow() ++ ")")
-    end,
-    ok.
+				   "'" ++ float_to_list(
+					    ?RDBMS:float_min())
+			       ++ "')"),
+	    {selected,[_ColName],[{MinFloat}]} =
+		odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
 
+	    true = ?RDBMS:float_min() == MinFloat,
+
+	    case ?RDBMS of
+		oracle ->
+		    {updated, _} =  % Value == 0 || -1 driver dependent!
+			odbc:sql_query(Ref, "DROP TABLE " ++ Table),
+
+		    {updated, _} =  % Value == 0 || -1 driver dependent!
+			odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++
+					   ?RDBMS:create_float_table()),
+		    {updated, _} =
+			odbc:sql_query(Ref,
+				       "INSERT INTO " ++ Table ++" VALUES(" ++
+				       ?RDBMS:float_underflow() ++ ")"),
+		    SelectResult = ?RDBMS:float_zero_selected(),
+		    SelectResult =
+			odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table);
+		_ ->
+		    {error, _} =
+			odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++
+					   ?RDBMS:float_underflow() ++ ")")
+	    end
+    end.
 
 %%-------------------------------------------------------------------------
 float_upper_limit(doc) ->
@@ -1170,26 +1171,28 @@ float_upper_limit(Config) when is_list(Config) ->
     Ref = ?config(connection_ref, Config),   
     Table = ?config(tableName, Config),
 
-    {updated, _} =  % Value == 0 || -1 driver dependent!
-	odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++ 
-		       ?RDBMS:create_float_table()), 
-
-    {updated, _} =  
-	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
-		       "'" ++ float_to_list(
-				?RDBMS:float_max())
-		       ++ "')"),
-
+    case ?RDBMS of
+	mysql ->
+	    {skip, "Not clearly defined in MYSQL"};
+	_->
+	    {updated, _} =  % Value == 0 || -1 driver dependent!
+		odbc:sql_query(Ref,  "CREATE TABLE " ++ Table ++
+				   ?RDBMS:create_float_table()),
 
-    {selected,[_ColName],[{MaxFloat}]}
-	= odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
+	    {updated, _} =
+		odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++
+				   "'" ++ float_to_list(
+					    ?RDBMS:float_max())
+			       ++ "')"),
+	    {selected,[_ColName],[{MaxFloat}]}
+		= odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
 
-    true = ?RDBMS:float_max() == MaxFloat,
+	    true = ?RDBMS:float_max() == MaxFloat,
 
-    {error, _} =  
-	odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++ 
-		       ?RDBMS:float_overflow() ++ ")"),
-    ok.
+	    {error, _} =
+		odbc:sql_query(Ref, "INSERT INTO " ++ Table ++" VALUES(" ++
+				   ?RDBMS:float_overflow() ++ ")")
+    end.
 
 %%-------------------------------------------------------------------------
 float_zero(doc) ->
@@ -1209,8 +1212,7 @@ float_zero(Config) when is_list(Config) ->
 
     SelectResult = ?RDBMS:float_zero_selected(),
     SelectResult =
-	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-    ok.
+	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table).
 %%-------------------------------------------------------------------------
 real_zero(doc) ->
     ["Test the real value zero."];
@@ -1234,10 +1236,8 @@ real_zero(Config) when is_list(Config) ->
 
 	    SelectResult = ?RDBMS:real_zero_selected(),
 	    SelectResult =
-		odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-	    ok
+		odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table)
     end.
-%%-------------------------------------------------------------------------
 %%------------------------------------------------------------------------
 dec_long(doc) ->
     [""];
@@ -1256,8 +1256,7 @@ dec_long(Config) when is_list(Config) ->
 
     {selected, Fields, [{2}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields).
 %%------------------------------------------------------------------------
 dec_double(doc) ->
     [""];
@@ -1304,8 +1303,7 @@ dec_double(Config) when is_list(Config) ->
 
     {selected, Fields2, [{1.60000}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields2),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields2).
 
 %%------------------------------------------------------------------------
 dec_bignum(doc) ->
@@ -1338,8 +1336,7 @@ dec_bignum(Config) when is_list(Config) ->
 
     {selected, Fields1, [{"1.6"}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields1),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields1).
 %%------------------------------------------------------------------------
 num_long(doc) ->
     [""];
@@ -1358,8 +1355,7 @@ num_long(Config) when is_list(Config) ->
 
     {selected, Fields, [{2}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields).
 %%------------------------------------------------------------------------
 num_double(doc) ->
     [""];
@@ -1405,8 +1401,7 @@ num_double(Config) when is_list(Config) ->
 
     {selected, Fields2, [{1.6000}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-     ["FIELD"] = odbc_test_lib:to_upper(Fields2),
-    ok.
+     ["FIELD"] = odbc_test_lib:to_upper(Fields2).
 %%------------------------------------------------------------------------
 num_bignum(doc) ->
     [""];
@@ -1438,8 +1433,7 @@ num_bignum(Config) when is_list(Config) ->
 
     {selected, Fields1, [{"1.6"}]} =
 	odbc:sql_query(Ref,"SELECT FIELD FROM " ++ Table),
-    ["FIELD"] = odbc_test_lib:to_upper(Fields1),
-    ok.
+    ["FIELD"] = odbc_test_lib:to_upper(Fields1).
 
 %%------------------------------------------------------------------------
 unicode(doc) ->
@@ -1471,6 +1465,8 @@ unicode(Config) when is_list(Config) ->
 	    w_char_support_win(Ref, Table, Latin1Data);
 	postgres ->
 	    direct_utf8(Ref, Table, Latin1Data);
+	mysql ->
+	    direct_utf8(Ref, Table, Latin1Data);
 	oracle ->
 	    {skip, "not currently supported"}
     end.
diff --git a/lib/odbc/test/odbc_query_SUITE.erl b/lib/odbc/test/odbc_query_SUITE.erl
index 61106fbf84..6dee588076 100644
--- a/lib/odbc/test/odbc_query_SUITE.erl
+++ b/lib/odbc/test/odbc_query_SUITE.erl
@@ -47,15 +47,17 @@ all() ->
 	     select_next, select_relative, select_absolute,
 	     create_table_twice, delete_table_twice, duplicate_key,
 	     not_connection_owner, no_result_set, query_error,
-	     multiple_select_result_sets, multiple_mix_result_sets,
-	     multiple_result_sets_error,
+	     {group, multiple_result_sets},
 	     {group, parameterized_queries}, {group, describe_table},
 	     delete_nonexisting_row];
 	Other -> {skip, Other}
     end.
 
 groups() -> 
-    [{parameterized_queries, [],
+    [{multiple_result_sets, [], [multiple_select_result_sets,
+				 multiple_mix_result_sets,
+				 multiple_result_sets_error]},
+     {parameterized_queries, [],
       [{group, param_integers}, param_insert_decimal,
        param_insert_numeric, {group, param_insert_string},
        param_insert_float, param_insert_real,
@@ -72,9 +74,15 @@ groups() ->
       [describe_integer, describe_string, describe_floating,
        describe_dec_num, describe_no_such_table]}].
 
-init_per_group(_GroupName, Config) ->
+init_per_group(multiple_result_sets, Config) ->
+    case is_supported_multiple_resultsets(?RDBMS) of
+	true ->
+	    Config;
+	false ->
+	    {skip, "Not supported by " ++ atom_to_list(?RDBMS) ++ "driver"}
+    end;
+init_per_group(_, Config) ->
     Config.
-
 end_per_group(_GroupName, Config) ->
     Config.
 
@@ -88,9 +96,12 @@ end_per_group(_GroupName, Config) ->
 %% variable, but should NOT alter/remove any existing entries.
 %%--------------------------------------------------------------------
 init_per_suite(Config) when is_list(Config) ->
-    %% application:start(odbc),
-    odbc:start(), % make sure init_per_suite fails if odbc is not built
-    [{tableName, odbc_test_lib:unique_table_name()}| Config].
+    case (catch odbc:start()) of
+	ok ->
+	    [{tableName, odbc_test_lib:unique_table_name()}| Config];
+	_ ->
+	    {skip, "ODBC not startable"}
+    end.
 
 %%--------------------------------------------------------------------
 %% Function: end_per_suite(Config) -> _
@@ -116,6 +127,7 @@ end_per_suite(_Config) ->
 %%--------------------------------------------------------------------
 init_per_testcase(_Case, Config) ->
     {ok, Ref} = odbc:connect(?RDBMS:connection_string(), []),
+    odbc_test_lib:strict(Ref, ?RDBMS),
     Dog = test_server:timetrap(?default_timeout),
     Temp = lists:keydelete(connection_ref, 1, Config),
     NewConfig = lists:keydelete(watchdog, 1, Temp),
@@ -661,9 +673,6 @@ multiple_result_sets_error(Config) when is_list(Config) ->
     end.   
 
 %%-------------------------------------------------------------------------
-
-%%-------------------------------------------------------------------------
-%%-------------------------------------------------------------------------
 param_insert_tiny_int(doc)->
     ["Test insertion of tiny ints by parameterized queries."];
 param_insert_tiny_int(suite) ->
@@ -899,8 +908,6 @@ param_insert_numeric(Config) when is_list(Config) ->
     ok.
 
 %%-------------------------------------------------------------------------
-
-%%-------------------------------------------------------------------------
 param_insert_char(doc)->
     ["Test insertion of fixed length string by parameterized queries."];
 param_insert_char(suite) ->
@@ -1323,8 +1330,6 @@ param_select(Config) when is_list(Config) ->
     ok.
 
 %%-------------------------------------------------------------------------
-
-%%-------------------------------------------------------------------------
 describe_integer(doc) ->
     ["Test describe_table/[2,3] for integer columns."];
 describe_integer(suite) ->
@@ -1336,7 +1341,7 @@ describe_integer(Config) when is_list(Config) ->
     {updated, _} = 
 	odbc:sql_query(Ref, 
 		       "CREATE TABLE " ++ Table ++
-		       " (int1 SMALLINT, int2 INT, int3 INTEGER)"),
+		       " (myint1 SMALLINT, myint2 INT, myint3 INTEGER)"),
 
     Decs = ?RDBMS:describe_integer(),
     %% Make sure to test timeout clause
@@ -1397,7 +1402,7 @@ describe_dec_num(Config) when is_list(Config) ->
     {updated, _} = 
 	odbc:sql_query(Ref, 
 		       "CREATE TABLE " ++ Table ++
-		       " (dec DECIMAL(9,3), num NUMERIC(9,2))"),
+		       " (mydec DECIMAL(9,3), mynum NUMERIC(9,2))"),
 
     Decs = ?RDBMS:describe_dec_num(),
 
@@ -1449,3 +1454,7 @@ is_driver_error(Error) ->
 	false ->
 	    test_server:fail(Error)
     end.
+is_supported_multiple_resultsets(sqlserver) ->
+    true;
+is_supported_multiple_resultsets(_) ->
+    false.
diff --git a/lib/odbc/test/odbc_test.hrl b/lib/odbc/test/odbc_test.hrl
index 87f50043db..7d2522d667 100644
--- a/lib/odbc/test/odbc_test.hrl
+++ b/lib/odbc/test/odbc_test.hrl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2002-2010. All Rights Reserved.
+%% Copyright Ericsson AB 2002-2011. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -27,7 +27,7 @@
 		   {unix, sunos} ->
 		       postgres;
 		   {unix,linux} ->
-		       postgres;
+		       mysql;
 		   {win32, _} ->
 		       sqlserver
 	       end).
diff --git a/lib/odbc/test/odbc_test_lib.erl b/lib/odbc/test/odbc_test_lib.erl
index 012eb96e43..9956d74d24 100644
--- a/lib/odbc/test/odbc_test_lib.erl
+++ b/lib/odbc/test/odbc_test_lib.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2002-2010. All Rights Reserved.
+%% Copyright Ericsson AB 2002-2011. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -75,3 +75,8 @@ check_row_count(Expected, Count) ->
 
 to_upper(List) ->
     lists:map(fun(Str) -> string:to_upper(Str) end, List).
+
+strict(Ref, mysql) ->
+    odbc:sql_query(Ref, "SET sql_mode='STRICT_ALL_TABLES,STRICT_TRANS_TABLES';");
+strict(_,_) ->
+    ok.
diff --git a/lib/odbc/test/oracle.erl b/lib/odbc/test/oracle.erl
index ebf6dbb6bf..786280701d 100644
--- a/lib/odbc/test/oracle.erl
+++ b/lib/odbc/test/oracle.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2002-2010. All Rights Reserved.
+%% Copyright Ericsson AB 2002-2011. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -231,8 +231,8 @@ param_select() ->
 
 %-------------------------------------------------------------------------
 describe_integer() ->
-    {ok,[{"INT1",{sql_decimal,38,0}},{"INT2",{sql_decimal,38,0}},
-	 {"INT3",{sql_decimal,38,0}}]}.
+    {ok,[{"MYINT1",{sql_decimal,38,0}},{"MYINT2",{sql_decimal,38,0}},
+	 {"MYINT3",{sql_decimal,38,0}}]}.
     
 describe_string() ->
     {ok,[{"STR1",{sql_char,10}},                           
@@ -243,4 +243,4 @@ describe_string() ->
 describe_floating() ->
     {ok,[{"F",sql_double},{"R",sql_double},{"D",sql_double}]}.
 describe_dec_num() ->
-    {ok,[{"DEC",{sql_decimal,9,3}},{"NUM",{sql_decimal,9,2}}]}.
+    {ok,[{"MYDEC",{sql_decimal,9,3}},{"MYNUM",{sql_decimal,9,2}}]}.
diff --git a/lib/odbc/test/postgres.erl b/lib/odbc/test/postgres.erl
index 169ca26e43..9c7eed271f 100644
--- a/lib/odbc/test/postgres.erl
+++ b/lib/odbc/test/postgres.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2006-2010. All Rights Reserved.
+%% Copyright Ericsson AB 2006-2011. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -275,9 +275,9 @@ param_select() ->
 
 %-------------------------------------------------------------------------
 describe_integer() ->
-    {ok,[{"int1",sql_smallint},
-	 {"int2",sql_integer},
-	 {"int3",sql_integer}]}.
+    {ok,[{"myint1",sql_smallint},
+	 {"myint2",sql_integer},
+	 {"myint3",sql_integer}]}.
 
 describe_string() ->
     {ok,[{"str1",{sql_char,10}},                           
@@ -288,7 +288,7 @@ describe_string() ->
 describe_floating() ->
     {ok,[{"f",sql_real},{"r",sql_real},{"d",{sql_float,15}}]}.
 describe_dec_num() ->
-    {ok,[{"dec",{sql_numeric,9,3}},{"num",{sql_numeric,9,2}}]}.
+    {ok,[{"mydec",{sql_numeric,9,3}},{"mynum",{sql_numeric,9,2}}]}.
 
 describe_timestamp() ->
     {ok, [{"field", sql_timestamp}]}.
diff --git a/lib/odbc/test/sqlserver.erl b/lib/odbc/test/sqlserver.erl
index e3fe30e0bc..13930cd5ae 100644
--- a/lib/odbc/test/sqlserver.erl
+++ b/lib/odbc/test/sqlserver.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2002-2010. All Rights Reserved.
+%% Copyright Ericsson AB 2002-2011. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -279,8 +279,8 @@ param_select() ->
 %-------------------------------------------------------------------------
 
 describe_integer() ->
-    {ok,[{"int1", sql_smallint},{"int2", sql_integer},
-	 {"int3", sql_integer}]}.
+    {ok,[{"myint1", sql_smallint},{"myint2", sql_integer},
+	 {"myint3", sql_integer}]}.
 
 describe_string() ->
     {ok,[{"str1",{sql_char,10}},                           
@@ -292,7 +292,7 @@ describe_floating() ->
     {ok,[{"f", sql_real},{"r", sql_real}, {"d", {sql_float, 53}}]}.
 
 describe_dec_num() ->
-    {ok,[{"dec",{sql_decimal,9,3}},{"num",{sql_numeric,9,2}}]}.
+    {ok,[{"mydec",{sql_decimal,9,3}},{"mynum",{sql_numeric,9,2}}]}.
 
 describe_timestamp() ->
     {ok, [{"field", sql_timestamp}]}.