diff options
author | Christopher Meiklejohn <[email protected]> | 2013-10-02 16:26:19 -0500 |
---|---|---|
committer | Fredrik Gustafsson <[email protected]> | 2013-10-31 16:23:26 +0100 |
commit | 6cc7d88683f581fd6a1619aea8c3c5309f4f4013 (patch) | |
tree | e884a7bb755f325b90f4492d503327523f1301ce /lib/os_mon/src | |
parent | 77bf7dfa0cc6d99c426d4057da8446dc51cea7aa (diff) | |
download | otp-6cc7d88683f581fd6a1619aea8c3c5309f4f4013.tar.gz otp-6cc7d88683f581fd6a1619aea8c3c5309f4f4013.tar.bz2 otp-6cc7d88683f581fd6a1619aea8c3c5309f4f4013.zip |
Fix incorrect reporting of memory on OS X via memsup.
Application memsup should be calculating free memory using the
speculative pages, in the same manner that the Activity Monitor and top
programs on OS X do. In addition, correct page size to 4096, based on
verification of available memory between top, vm_stat and Activity
Monitor.
Diffstat (limited to 'lib/os_mon/src')
-rw-r--r-- | lib/os_mon/src/memsup.erl | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/lib/os_mon/src/memsup.erl b/lib/os_mon/src/memsup.erl index a1b8591c8c..b178732fae 100644 --- a/lib/os_mon/src/memsup.erl +++ b/lib/os_mon/src/memsup.erl @@ -721,20 +721,19 @@ reply(Pending, MemUsage, SysMemUsage) -> %% get_memory_usage(OS) -> {Alloc, Total} %% Darwin: -%% Uses vm_stat command. This appears to lie about the page size in -%% Mac OS X 10.2.2 - the pages given are based on 4000 bytes, but -%% the vm_stat command tells us that it is 4096... +%% Uses vm_stat command. get_memory_usage({unix,darwin}) -> Str1 = os:cmd("/usr/bin/vm_stat"), - - {[Free], Str2} = fread_value("Pages free:~d.", Str1), - {[Active], Str3} = fread_value("Pages active:~d.", Str2), - {[Inactive], Str4} = fread_value("Pages inactive:~d.", Str3), - {[_], Str5} = fread_value("Pages speculative:~d.", Str4), + PageSize = 4096, + + {[Free], Str2} = fread_value("Pages free:~d.", Str1), + {[Active], Str3} = fread_value("Pages active:~d.", Str2), + {[Inactive], Str4} = fread_value("Pages inactive:~d.", Str3), + {[Speculative], Str5} = fread_value("Pages speculative:~d.", Str4), {[Wired], _} = fread_value("Pages wired down:~d.", Str5), - NMemUsed = (Wired + Active + Inactive) * 4000, - NMemTotal = NMemUsed + Free * 4000, + NMemUsed = (Wired + Active + Inactive) * PageSize, + NMemTotal = NMemUsed + (Free + Speculative) * PageSize, {NMemUsed,NMemTotal}; %% FreeBSD: Look in /usr/include/sys/vmmeter.h for the format of struct |