diff options
author | Björn-Egil Dahlberg <[email protected]> | 2010-12-29 18:37:21 +0100 |
---|---|---|
committer | Björn-Egil Dahlberg <[email protected]> | 2010-12-29 18:37:25 +0100 |
commit | 99372cc4053c2fa7662da2f871c9813fbf45ba7e (patch) | |
tree | 68fc7986c118ffc247fb02ed9f0890ef95388773 /lib/percept/src | |
parent | db945cc0cb32457903854d9b4b1c00af3d68cde6 (diff) | |
parent | b5505246856d905d3981f8e1f82dbd3ca08a6ead (diff) | |
download | otp-99372cc4053c2fa7662da2f871c9813fbf45ba7e.tar.gz otp-99372cc4053c2fa7662da2f871c9813fbf45ba7e.tar.bz2 otp-99372cc4053c2fa7662da2f871c9813fbf45ba7e.zip |
Merge branch 'ao/percept-web-stop-rebased' into dev
* ao/percept-web-stop-rebased:
Verifies the consistency of stopping behavior.
Fixes a bug found in percept:stop_webserver/1, where it doesn't stop the webserver completely
OTP-9012
Diffstat (limited to 'lib/percept/src')
-rw-r--r-- | lib/percept/src/percept.erl | 32 |
1 files changed, 22 insertions, 10 deletions
diff --git a/lib/percept/src/percept.erl b/lib/percept/src/percept.erl index f5e0f7e469..3a2d9f7601 100644 --- a/lib/percept/src/percept.erl +++ b/lib/percept/src/percept.erl @@ -185,10 +185,27 @@ stop_webserver() -> undefined -> {error, not_started}; Pid -> - Pid ! {self(), get_port}, - receive Port -> ok end, - Pid ! quit, - stop_webserver(Port) + do_stop([], Pid) + end. + +do_stop([], Pid)-> + Pid ! {self(), get_port}, + Port = receive P -> P end, + do_stop(Port, Pid); +do_stop(Port, [])-> + case whereis(percept_httpd) of + undefined -> + {error, not_started}; + Pid -> + do_stop(Port, Pid) + end; +do_stop(Port, Pid)-> + case find_service_pid_from_port(inets:services_info(), Port) of + undefined -> + {error, not_started}; + Pid2 -> + Pid ! quit, + inets:stop(httpd, Pid2) end. %% @spec stop_webserver(integer()) -> ok | {error, not_started} @@ -196,12 +213,7 @@ stop_webserver() -> %% @hidden stop_webserver(Port) -> - case find_service_pid_from_port(inets:services_info(), Port) of - undefined -> - {error, not_started}; - Pid -> - inets:stop(httpd, Pid) - end. + do_stop(Port,[]). %%========================================================================== %% |