Modernize test suites

1 files changed, 34 insertions, 80 deletions

diff --git a/lib/percept/test/percept_SUITE.erl b/lib/percept/test/percept_SUITE.erl
index afb8bbdd5b..141035c631 100644
--- a/lib/percept/test/percept_SUITE.erl
+++ b/lib/percept/test/percept_SUITE.erl
@@ -22,51 +22,23 @@
 -include_lib("common_test/include/ct.hrl").
 
 %% Test server specific exports
--export([all/0, suite/0,groups/0,init_per_group/2,end_per_group/2]).
--export([init_per_suite/1, end_per_suite/1]).
--export([init_per_testcase/2, end_per_testcase/2]).
+-export([all/0, suite/0]).
 
 %% Test cases
--export([
-	app/1,
-	appup/1,
-	profile/1,
-	analyze/1,
-	analyze_dist/1,
-	webserver/1
-	]).
-
-%% Default timetrap timeout (set in init_per_testcase)
--define(default_timeout, ?t:minutes(2)).
-
-init_per_suite(Config) when is_list(Config) ->
-    Config.
-
-end_per_suite(Config) when is_list(Config) ->
-    Config.
-
-init_per_testcase(_Case, Config) ->
-    Dog = ?t:timetrap(?default_timeout),
-    [{max_size, 300}, {watchdog,Dog} | Config].
-
-end_per_testcase(_Case, Config) ->
-    Dog = ?config(watchdog, Config),
-    ?t:timetrap_cancel(Dog),
-    ok.
+-export([app/1,
+         appup/1,
+         profile/1,
+         analyze/1,
+         analyze_dist/1,
+         webserver/1]).
 
-suite() -> [{ct_hooks,[ts_install_cth]}].
+suite() ->
+    [{ct_hooks,[ts_install_cth]},
+     {timetrap, {minutes, 2}}].
 
 all() -> 
-    [app, appup, webserver, profile, analyze, analyze_dist].
-
-groups() -> 
-    [].
-
-init_per_group(_GroupName, Config) ->
-    Config.
-
-end_per_group(_GroupName, Config) ->
-    Config.
+    [app, appup, webserver, profile,
+     analyze, analyze_dist].
 
 
 %%----------------------------------------------------------------------
@@ -75,68 +47,56 @@ end_per_group(_GroupName, Config) ->
 
 %% Test that the percept app file is ok
 app(Config) when is_list(Config) ->
-    ok = ?t:app_test(percept).
+    ok = test_server:app_test(percept).
 
 %% Test that the percept appup file is ok
 appup(Config) when is_list(Config) ->
-    ok = ?t:appup_test(percept).
+    ok = test_server:appup_test(percept).
 
-webserver(suite) ->
-    [];
-webserver(doc) ->
-    ["Percept webserver test."];
+%% Percept webserver test.
 webserver(Config) when is_list(Config) ->
     % Explicit start inets?
-    ?line {started, _, Port} = percept:start_webserver(),
-    ?line ok = percept:stop_webserver(Port), 
-    ?line {started, _, _} = percept:start_webserver(),
-    ?line ok = percept:stop_webserver(),
-    ?line {started, _, NewPort} = percept:start_webserver(),
-    ?line ok = percept:stop_webserver(NewPort),
-    ?line application:stop(inets),
+    {started, _, Port} = percept:start_webserver(),
+    ok = percept:stop_webserver(Port), 
+    {started, _, _} = percept:start_webserver(),
+    ok = percept:stop_webserver(),
+    {started, _, NewPort} = percept:start_webserver(),
+    ok = percept:stop_webserver(NewPort),
+    application:stop(inets),
     ok.
 
-profile(suite) ->
-    [];
-profile(doc) ->
-    ["Percept profile test."];
+%% Percept profile test.
 profile(Config) when is_list(Config) ->
-    Path = ?config(data_dir, Config),
+    Path = proplists:get_value(data_dir, Config),
     File = filename:join([Path,"profile_test.dat"]),
-    ?line {ok, _} = percept:profile(File, [procs]),
+    {ok, _} = percept:profile(File, [procs]),
     ipc_tree:go(7),
-    ?line ok = percept:stop_profile(),
+    ok = percept:stop_profile(),
     ok.
 
-analyze(suite) ->
-    [];
-analyze(doc) ->
-    ["Percept analyze test."];
+%% Percept analyze test.
 analyze(Config) when is_list(Config) ->
     Begin = processes(),
-    Path = ?config(data_dir, Config),
+    Path = proplists:get_value(data_dir, Config),
     File = filename:join([Path,"profile_test.dat"]),
     T0 = erlang:monotonic_time(milli_seconds),
-    ?line ok = percept:analyze(File),
+    ok = percept:analyze(File),
     T1 = erlang:monotonic_time(milli_seconds),
     io:format("percept:analyze/1 took ~w ms.~n", [T1 - T0]),
-    ?line {stopped, _} = percept_db:stop(),
+    {stopped, _} = percept_db:stop(),
     print_remainers(remainers(Begin, processes())),
     ok.
 
-analyze_dist(suite) ->
-    [];
-analyze_dist(doc) ->
-    ["Percept analyze distribution test."];
+%% Percept analyze distribution test.
 analyze_dist(Config) when is_list(Config) ->
     Begin = processes(),
-    Path = ?config(data_dir, Config),
+    Path = proplists:get_value(data_dir, Config),
     File = filename:join([Path,"ipc-dist.dat"]),
     T0 = erlang:monotonic_time(milli_seconds),
-    ?line ok = percept:analyze(File),
+    ok = percept:analyze(File),
     T1 = erlang:monotonic_time(milli_seconds),
     io:format("percept:analyze/1 took ~w ms.~n", [T1 - T0]),
-    ?line {stopped, _} = percept_db:stop(),
+    {stopped, _} = percept_db:stop(),
     print_remainers(remainers(Begin, processes())),
     ok.
 
@@ -164,9 +124,3 @@ remainers(Begin, [Pid|End], Out) ->
 	true  -> remainers(Begin, End, Out);
 	false -> remainers(Begin, End, [Pid|Out])
     end.
-
-
-
-    
-
-