Merge tag 'OTP-19.0' into sverker/19/binary_to_atom-utf8-crash/ERL-474/OTP-14590

5 files changed, 362 insertions, 380 deletions

diff --git a/lib/percept/test/Makefile b/lib/percept/test/Makefile
index 156ef5dd0a..87fde49410 100644
--- a/lib/percept/test/Makefile
+++ b/lib/percept/test/Makefile
@@ -1,18 +1,19 @@
 #
 # %CopyrightBegin%
 # 
-# Copyright Ericsson AB 2007-2012. All Rights Reserved.
+# Copyright Ericsson AB 2007-2016. All Rights Reserved.
 # 
-# The contents of this file are subject to the Erlang Public License,
-# Version 1.1, (the "License"); you may not use this file except in
-# compliance with the License. You should have received a copy of the
-# Erlang Public License along with this software. If not, it can be
-# retrieved online at http://www.erlang.org/.
-# 
-# Software distributed under the License is distributed on an "AS IS"
-# basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-# the License for the specific language governing rights and limitations
-# under the License.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
 # 
 # %CopyrightEnd%
 #
@@ -51,8 +52,7 @@ RELSYSDIR = $(RELEASE_PATH)/percept_test
 # FLAGS
 # ----------------------------------------------------
 ERL_MAKE_FLAGS += 
-ERL_COMPILE_FLAGS += -I$(ERL_TOP)/lib/test_server/include \
-	-I$(ERL_TOP)/lib/percept/include 
+ERL_COMPILE_FLAGS += -I$(ERL_TOP)/lib/percept/include
 
 # ----------------------------------------------------
 # Targets
diff --git a/lib/percept/test/egd_SUITE.erl b/lib/percept/test/egd_SUITE.erl
index 51f090b39c..401695dddd 100644
--- a/lib/percept/test/egd_SUITE.erl
+++ b/lib/percept/test/egd_SUITE.erl
@@ -1,215 +1,204 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2007-2011. All Rights Reserved.
+%% Copyright Ericsson AB 2007-2016. All Rights Reserved.
 %%
-%% The contents of this file are subject to the Erlang Public License,
-%% Version 1.1, (the "License"); you may not use this file except in
-%% compliance with the License. You should have received a copy of the
-%% Erlang Public License along with this software. If not, it can be
-%% retrieved online at http://www.erlang.org/.
+%% Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
 %%
-%% Software distributed under the License is distributed on an "AS IS"
-%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-%% the License for the specific language governing rights and limitations
-%% under the License.
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
 %%
 %% %CopyrightEnd%
 %%
 
 -module(egd_SUITE).
--include_lib("test_server/include/test_server.hrl").
+-include_lib("common_test/include/ct.hrl").
 
 %% Test server specific exports
--export([all/0, suite/0,groups/0,init_per_group/2,end_per_group/2]).
+-export([all/0, suite/0]).
 -export([init_per_suite/1, end_per_suite/1]).
 -export([init_per_testcase/2, end_per_testcase/2]).
 
 %% Test cases
--export([
-	image_create_and_destroy/1, 
-	image_shape/1, 
-	image_primitives/1,
-	image_colors/1, 
-	image_font/1,
-	image_png_compliant/1
-	]).
-
-%% Default timetrap timeout (set in init_per_testcase)
--define(default_timeout, ?t:minutes(1)).
-
-init_per_suite(Config) when is_list(Config) ->
-    random:seed(now()),
-    Config.
-
-end_per_suite(Config) when is_list(Config) ->
-    Config.
-
-init_per_testcase(_Case, Config) ->
-    Dog = ?t:timetrap(?default_timeout),
-    [{max_size, 800}, {watchdog,Dog} | Config].
-
-end_per_testcase(_Case, Config) ->
-    Dog = ?config(watchdog, Config),
-    ?t:timetrap_cancel(Dog),
-    ok.
-
-suite() -> [{ct_hooks,[ts_install_cth]}].
+-export([image_create_and_destroy/1,
+         image_shape/1,
+         image_primitives/1,
+         image_colors/1,
+         image_font/1,
+         image_fans/1,
+         image_png_compliant/1]).
+
+suite() ->
+    [{ct_hooks,[ts_install_cth]},
+     {timetrap, {minutes, 1}}].
 
 all() -> 
     [image_create_and_destroy, image_shape,
      image_primitives, image_colors, image_font,
+     image_fans,
      image_png_compliant].
 
-groups() -> 
-    [].
 
-init_per_group(_GroupName, Config) ->
+init_per_suite(Config) when is_list(Config) ->
+    rand:seed(exsplus),
     Config.
 
-end_per_group(_GroupName, Config) ->
+end_per_suite(Config) when is_list(Config) ->
     Config.
 
+init_per_testcase(_Case, Config) ->
+    [{max_size, 800}|Config].
+
+end_per_testcase(_Case, _Config) ->
+    ok.
 
 %%----------------------------------------------------------------------
 %% Tests
 %%----------------------------------------------------------------------
 
-image_create_and_destroy(suite) ->
-    [];
-image_create_and_destroy(doc) ->
-    ["Image creation and destroy test."];
+%% Image creation and destroy test.
 image_create_and_destroy(Config) when is_list(Config) ->
-    {W,H} = get_size(?config(max_size, Config)),
-    ?line Image = egd:create(W, H),
-    ?line ok = egd:destroy(Image),
+    {W,H} = get_size(proplists:get_value(max_size, Config)),
+    Image = egd:create(W, H),
+    ok = egd:destroy(Image),
     ok.
 
-image_colors(suite) ->
-    [];
-image_colors(doc) ->
-    ["Image color test."];
+%% Image color test.
 image_colors(Config) when is_list(Config) ->
-    {W,H} = get_size(?config(max_size, Config)),
-    ?line Image = egd:create(W, H),
+    {W,H} = get_size(proplists:get_value(max_size, Config)),
+    Dir = proplists:get_value(priv_dir, Config),
+    Image = egd:create(W, H),
     put(image_size, {W,H}),
 
     RGB = get_rgb(),
-    ?line Black = egd:color({0,0,0}),
-    ?line Red = egd:color({255,0,0}),
-    ?line Green = egd:color({0,255,0}),
-    ?line Blue = egd:color({0,0,255}),
-    ?line Random = egd:color(Image, RGB),  
-
-    ?line ok = egd:line(Image, get_point(), get_point(), Random),
-    ?line ok = egd:line(Image, get_point(), get_point(), Red),
-    ?line ok = egd:line(Image, get_point(), get_point(), Green),
-    ?line ok = egd:line(Image, get_point(), get_point(), Black),
-    ?line ok = egd:line(Image, get_point(), get_point(), Blue),
+    Black = egd:color({0,0,0}),
+    Red = egd:color({255,0,0}),
+    Green = egd:color({0,255,0}),
+    Blue = egd:color({0,0,255}),
+    Random = egd:color(Image, RGB),
+
+    ok = egd:line(Image, get_point(), get_point(), Random),
+    ok = egd:line(Image, get_point(), get_point(), Red),
+    ok = egd:line(Image, get_point(), get_point(), Green),
+    ok = egd:line(Image, get_point(), get_point(), Black),
+    ok = egd:line(Image, get_point(), get_point(), Blue),
 
     HtmlDefaultNames = [black,silver,gray,white,maroon,red,
-    	purple,fuchia,green,lime,olive,yellow,navy,blue,teal,
-      	aqua],
-    
-    lists:foreach(fun
-    	(ColorName) ->
-	    ?line Color = egd:color(ColorName),
-	    ?line ok    = egd:line(Image, get_point(), get_point(), Color)
-	end, HtmlDefaultNames),
- 
-    ?line <<_/binary>>  = egd:render(Image),
-    ?line ok = egd:destroy(Image),
+                        purple,fuchia,green,lime,olive,yellow,navy,blue,teal,
+                        aqua],
+
+    lists:foreach(fun (ColorName) ->
+                          Color = egd:color(ColorName),
+                          ok    = egd:line(Image, get_point(), get_point(), Color)
+                  end, HtmlDefaultNames),
+
+    Png1 = <<_/binary>> = egd:render(Image,png,[{render_engine, alpha}]),
+    File1 = filename:join(Dir,"image_colors_alpha.png"),
+    ok = egd:save(Png1,File1),
+    ct:log("<p>Image alpha:</p><img src=\"~s\" />~n", [File1]),
+    Png2 = <<_/binary>> = egd:render(Image,png,[{render_engine, opaque}]),
+    File2 = filename:join(Dir,"image_colors_opaque.png"),
+    ok = egd:save(Png2,File2),
+    ct:log("<p>Image opaque:</p><img src=\"~s\" />~n", [File2]),
+
+    ok = egd:destroy(Image),
     erase(image_size),
     ok.
 
-image_shape(suite) ->
-    [];
-image_shape(doc) ->
-    ["Image shape api test."];
+%% Image shape API test.
 image_shape(Config) when is_list(Config) ->
-    {W,H} = get_size(?config(max_size, Config)),
+    {W,H} = get_size(proplists:get_value(max_size, Config)),
+    Dir = proplists:get_value(priv_dir, Config),
     put(image_size, {W,H}),
-    ?line Im = egd:create(W, H),
-    
-    ?line Fgc = egd:color({255,0,0}),
-
-    ?line ok = egd:line(Im, get_point(), get_point(), Fgc), 
-    ?line ok = egd:rectangle(Im, get_point(), get_point(), Fgc),
-    ?line ok = egd:filledEllipse(Im, get_point(), get_point(), Fgc),
-    ?line ok = egd:arc(Im, get_point(), get_point(), Fgc),
-    ?line ok = egd:arc(Im, get_point(), get_point(), 100, Fgc),
-    
+    Im = egd:create(W, H),
+
+    Fgc = egd:color({255,0,0}),
+
+    ok = egd:line(Im, get_point(), get_point(), Fgc),
+    ok = egd:rectangle(Im, get_point(), get_point(), Fgc),
+    ok = egd:filledEllipse(Im, get_point(), get_point(), Fgc),
+    ok = egd:arc(Im, get_point(), get_point(), Fgc),
+    ok = egd:arc(Im, get_point(), get_point(), 100, Fgc),
+
     Pt1 = get_point(),
     Pt2 = get_point(), 
 
-    ?line ok = egd:filledRectangle(Im, Pt1, Pt2, Fgc),
+    ok = egd:filledRectangle(Im, Pt1, Pt2, Fgc),
+
+    Bitmap = egd:render(Im, raw_bitmap),
 
-    ?line Bitmap = egd:render(Im, raw_bitmap),
+    ok = bitmap_point_has_color(Bitmap, {W,H}, Pt2, Fgc),
+    ok = bitmap_point_has_color(Bitmap, {W,H}, Pt1, Fgc),
 
-    ?line ok = bitmap_point_has_color(Bitmap, {W,H}, Pt2, Fgc),
-    ?line ok = bitmap_point_has_color(Bitmap, {W,H}, Pt1, Fgc),
+    Bin = <<_/binary>> = egd:render(Im, raw_bitmap, [{render_engine, alpha}]),
+    Png = egd_png:binary(W,H,Bin),
+    File = filename:join(Dir,"image_shape.png"),
+    ok = egd:save(Png,File),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File]),
 
-    ?line <<_/binary>> = egd:render(Im, raw_bitmap, [{render_engine, alpha}]),
+    ok = egd:destroy(Im),
 
-    ?line ok = egd:destroy(Im),
     erase(image_size),
     ok.
 
-image_primitives(suite) ->
-    [];
-image_primitives(doc) ->
-    ["Image shape api test."];
+%% Image shape API test.
 image_primitives(Config) when is_list(Config) ->
-    {W,H} = get_size(?config(max_size, Config)),
+    {W,H} = get_size(proplists:get_value(max_size, Config)),
+    Dir = proplists:get_value(priv_dir, Config),
     put(image_size, {W,H}),
 
-    ?line Im0 = egd_primitives:create(W, H),
-    ?line Fgc = egd:color({25,25,255}),
-    ?line Bgc = egd:color({0,250,25}),
+    Im0 = egd_primitives:create(W, H),
+    Fgc = egd:color({25,25,255}),
+    Bgc = egd:color({0,250,25}),
 
-    ?line Im1 = lists:foldl(fun
-    	({Function, Arguments}, Im) ->
-	    ?line erlang:apply(egd_primitives, Function, [Im|Arguments])
-	end, Im0, 
-	[{Fs, [get_point(), get_point(), Bgc]} || Fs <- [line, rectangle, filledEllipse, arc]] ++
-	[{pixel,          [get_point(), Bgc]},
-	 {filledTriangle, [get_point(), get_point(), get_point(), Bgc]}]),
+    Im1 = lists:foldl(fun ({Function, Arguments}, Im) ->
+                              erlang:apply(egd_primitives, Function, [Im|Arguments])
+                      end, Im0,
+                      [{Fs, [get_point(), get_point(), Bgc]} || Fs <- [line, rectangle, filledEllipse, arc]] ++
+                      [{pixel,          [get_point(), Bgc]},
+                       {filledTriangle, [get_point(), get_point(), get_point(), Bgc]}]),
 
     Pt1 = get_point(),
     Pt2 = get_point(), 
 
-    ?line Im2 = egd_primitives:filledRectangle(Im1, Pt1, Pt2, Fgc),
+    Im2 = egd_primitives:filledRectangle(Im1, Pt1, Pt2, Fgc),
 
-    ?line Bitmap = egd_render:binary(Im2, opaque),
+    Bitmap = egd_render:binary(Im2, opaque),
 
-    ?line ok = bitmap_point_has_color(Bitmap, {W,H}, Pt2, Fgc),
-    ?line ok = bitmap_point_has_color(Bitmap, {W,H}, Pt1, Fgc),
+    ok = bitmap_point_has_color(Bitmap, {W,H}, Pt2, Fgc),
+    ok = bitmap_point_has_color(Bitmap, {W,H}, Pt1, Fgc),
 
-    ?line <<_/binary>> = egd_render:binary(Im2, alpha),
+    Bin = <<_/binary>> = egd_render:binary(Im2, alpha),
+    Png = egd_png:binary(W,H,Bin),
+    File = filename:join(Dir,"image_primitives.png"),
+    ok = egd:save(Png,File),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File]),
 
     erase(image_size),
     ok.
- 
 
-
-
-image_font(suite) ->
-    [];
-image_font(doc) ->
-    ["Image font test."];
+%% Image font test.
 image_font(Config) when is_list(Config) ->
-    {W,H} = get_size(?config(max_size, Config)),
+    {W,H} = get_size(proplists:get_value(max_size, Config)),
+    Dir = proplists:get_value(priv_dir, Config),
     put(image_size, {W,H}),
-    ?line Im = egd:create(W, H),
-    ?line Fgc = egd:color({0,130,0}),
-  
-    ?line Filename = filename:join([code:priv_dir(percept),"fonts","6x11_latin1.wingsfont"]),
-    ?line Font = egd_font:load(Filename),
-   
+    Im = egd:create(W, H),
+    Fgc = egd:color({0,130,0}),
+
+    Filename = filename:join([code:priv_dir(percept),"fonts","6x11_latin1.wingsfont"]),
+    Font = egd_font:load(Filename),
+
     % simple text
-    ?line ok = egd:text(Im, get_point(), Font, "Hello World", Fgc),
-    ?line <<_/binary>> = egd:render(Im, png),
-    
+    ok = egd:text(Im, get_point(), Font, "Hello World", Fgc),
+    <<_/binary>> = egd:render(Im, png),
+
     GlyphStr1   = " !\"#$%&'()*+,-./",            % Codes  32 ->  47
     NumericStr  = "0123456789",                   % Codes  48 ->  57
     GlyphStr2   = ":;<=>?@",                      % Codes  58 ->  64
@@ -218,99 +207,149 @@ image_font(Config) when is_list(Config) ->
     AlphaSmStr  = "abcdefghijklmnopqrstuvwxyz",   % Codes  97 -> 122
     GlyphStr4   = "{|}~",                         % Codes 123 -> 126
 
-    ?line ok = egd:text(Im, get_point(), Font, GlyphStr1, Fgc),
-    ?line <<_/binary>> = egd:render(Im, png),
-
-    ?line ok = egd:text(Im, get_point(), Font, NumericStr, Fgc),
-    ?line <<_/binary>> = egd:render(Im, png),
- 
-    ?line ok = egd:text(Im, get_point(), Font, GlyphStr2, Fgc),
-    ?line <<_/binary>> = egd:render(Im, png),
-
-    ?line ok = egd:text(Im, get_point(), Font, AlphaBigStr, Fgc),
-    ?line <<_/binary>> = egd:render(Im, png),
-    
-    ?line ok = egd:text(Im, get_point(), Font, GlyphStr3, Fgc),
-    ?line <<_/binary>> = egd:render(Im, png),
-
-    ?line ok = egd:text(Im, get_point(), Font, AlphaSmStr, Fgc),
-    ?line <<_/binary>> = egd:render(Im, png),
-    
-    ?line ok = egd:text(Im, get_point(), Font, GlyphStr4, Fgc),
-    ?line <<_/binary>> = egd:render(Im, png),
-
-    ?line ok = egd:destroy(Im),
+    ok = egd:text(Im, get_point(), Font, GlyphStr1, Fgc),
+    Png1 = <<_/binary>> = egd:render(Im, png),
+    File1 = filename:join(Dir,"text1.png"),
+    ok = egd:save(Png1,File1),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File1]),
+
+    ok = egd:text(Im, get_point(), Font, NumericStr, Fgc),
+    Png2 = <<_/binary>> = egd:render(Im, png),
+    File2 = filename:join(Dir,"text2.png"),
+    ok = egd:save(Png2,File2),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File2]),
+
+    ok = egd:text(Im, get_point(), Font, GlyphStr2, Fgc),
+    Png3 = <<_/binary>> = egd:render(Im, png),
+    File3 = filename:join(Dir,"text3.png"),
+    ok = egd:save(Png3,File3),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File3]),
+
+    ok = egd:text(Im, get_point(), Font, AlphaBigStr, Fgc),
+    Png4 = <<_/binary>> = egd:render(Im, png),
+    File4 = filename:join(Dir,"text4.png"),
+    ok = egd:save(Png4,File4),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File4]),
+
+    ok = egd:text(Im, get_point(), Font, GlyphStr3, Fgc),
+    Png5 = <<_/binary>> = egd:render(Im, png),
+    File5 = filename:join(Dir,"text5.png"),
+    ok = egd:save(Png5,File5),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File5]),
+
+    ok = egd:text(Im, get_point(), Font, AlphaSmStr, Fgc),
+    Png6 = <<_/binary>> = egd:render(Im, png),
+    File6 = filename:join(Dir,"text6.png"),
+    ok = egd:save(Png6,File6),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File6]),
+
+    ok = egd:text(Im, get_point(), Font, GlyphStr4, Fgc),
+    Png7 = <<_/binary>> = egd:render(Im, png),
+    File7 = filename:join(Dir,"text7.png"),
+    ok = egd:save(Png7,File7),
+    ct:log("<p>Image:</p><img src=\"~s\" />~n", [File7]),
+
+    ok = egd:destroy(Im),
     erase(image_size),
     ok.
 
-image_png_compliant(suite) ->
-    [];
-image_png_compliant(doc) ->
-    ["Image png compliant test."];
+%% Image png compliant test.
 image_png_compliant(Config) when is_list(Config) ->
-    {W,H} = get_size(?config(max_size, Config)),
+    {W,H} = get_size(proplists:get_value(max_size, Config)),
     put(image_size, {W,H}),
-    ?line Im = egd:create(W, H),
-    ?line Fgc = egd:color({0,0,0}),
-    ?line ok = egd:filledRectangle(Im, get_point(), get_point(), Fgc),
-    
-    ?line Bin = egd:render(Im, png),
-    ?line true = binary_is_png_compliant(Bin),
-    
-    ?line ok = egd:destroy(Im),
+    Im = egd:create(W, H),
+    Fgc = egd:color({0,0,0}),
+    ok = egd:filledRectangle(Im, get_point(), get_point(), Fgc),
+
+    Bin = egd:render(Im, png),
+    true = binary_is_png_compliant(Bin),
+
+    ok = egd:destroy(Im),
     erase(image_size),
     ok.
 
+image_fans(Config) when is_list(Config) ->
+    W = 1024,
+    H = 800,
+    Dir = proplists:get_value(priv_dir, Config),
+
+    Fun = fun({F,Args},Im) ->
+                  erlang:apply(egd_primitives,F,[Im|Args])
+          end,
+
+    %% fan1
+    Ops1 = gen_vertical_fan(1,{0,400},egd:color(red),1024,800,-15),
+    Ops2 = gen_horizontal_fan(1,{512,800},egd:color(green),1024,0,-15),
+
+    Im0 = egd_primitives:create(W,H),
+    Im1 = lists:foldl(Fun, Im0, Ops1 ++ Ops2),
+    Bin1 = egd_render:binary(Im1, opaque),
+    Png1 = egd_png:binary(W,H,Bin1),
+
+    File1 = filename:join(Dir,"fan1_opaque.png"),
+    ok = egd:save(Png1,File1),
+    ct:log("<p>Image opaque width 1:</p><img src=\"~s\" />~n", [File1]),
+
+    Bin2 = egd_render:binary(Im1, alpha),
+    Png2 = egd_png:binary(W,H,Bin2),
+
+    File2 = filename:join(Dir,"fan1_alpha.png"),
+    ok = egd:save(Png2,File2),
+    ct:log("<p>Image alpha width 1:</p><img src=\"~s\" />~n", [File2]),
+
+
+    %% fan2
+    Ops3 = gen_vertical_fan(7,{0,400},egd:color(red),1024,800,-15),
+    Ops4 = gen_horizontal_fan(7,{512,800},egd:color(green),1024,0,-15),
+
+    Im2 = lists:foldl(Fun, Im0, Ops3 ++ Ops4),
+    Bin3 = egd_render:binary(Im2, opaque),
+    Png3 = egd_png:binary(W,H,Bin3),
+
+    File3 = filename:join(Dir,"fan2_opaque.png"),
+    ok = egd:save(Png3,File3),
+    ct:log("<p>Image opaque width 7:</p><img src=\"~s\" />~n", [File3]),
+
+    Bin4 = egd_render:binary(Im2, alpha),
+    Png4 = egd_png:binary(W,H,Bin4),
+
+    File4 = filename:join(Dir,"fan2_alpha.png"),
+    ok = egd:save(Png4,File4),
+    ct:log("<p>Image alpha width 7:</p><img src=\"~s\" />~n", [File4]),
+    ok.
+
+gen_vertical_fan(Wd,Pt,C,X,Y,Step) when Y > 0 ->
+    [{line,[Pt,{X,Y},Wd,C]}|gen_vertical_fan(Wd,Pt,C,X,Y + Step,Step)];
+gen_vertical_fan(_,_,_,_,_,_) -> [].
+
+gen_horizontal_fan(Wd,Pt,C,X,Y,Step) when X > 0 ->
+    [{line,[Pt,{X,Y},Wd,C]}|gen_horizontal_fan(Wd,Pt,C,X + Step,Y,Step)];
+gen_horizontal_fan(_,_,_,_,_,_) -> [].
+
+
 %%----------------------------------------------------------------------
 %% Auxiliary tests
 %%----------------------------------------------------------------------
-    
+
 bitmap_point_has_color(Bitmap, {W,_}, {X,Y}, C) ->
     {CR,CG,CB,_} = egd_primitives:rgb_float2byte(C),
     N = W*Y*3 + X*3,
     << _:N/binary, R,G,B, _/binary>> = Bitmap,
     case {R,G,B} of
-	{CR,CG,CB} -> ok;
-	Other ->
-	    io:format("bitmap_point_has_color: error color was ~p, should be ~p~n", [Other, {CR,CG,CB}]),
-	    {error, {Other,{CR,CG,CB}}}
-    end.
-
-%% jfif header by specification
-%% 2 bytes, length
-%% 5 bytes, identifier ="JFIF\0"
-%% 2 bytes, version, (major, minor)
-%% 1 byte , units
-%% However, JFIF seems to start at 6 (7 with 1-index)?
-   
-binary_is_jfif_compliant(JpegBin) ->
-    ?line {Bin, _} = split_binary(JpegBin, 11),
-    List = binary_to_list(Bin),
-    case lists:sublist(List, 7, 4) of 
-	"JFIF" -> true;
-	Other ->
-	   io:format("img -> ~p~n", [Other]),
-	   false
-    end.
-
-binary_is_gif_compliant(GifBin) ->
-    ?line {Bin, _} = split_binary(GifBin, 10),
-    List = binary_to_list(Bin),
-    case lists:sublist(List, 1,5) of
-	"GIF87" -> true;
-	Other -> 
-	   io:format("img -> ~p~n", [Other]),
-	   false
+        {CR,CG,CB} -> ok;
+        Other ->
+            io:format("bitmap_point_has_color: error color was ~p, should be ~p~n", [Other, {CR,CG,CB}]),
+            {error, {Other,{CR,CG,CB}}}
     end.
 
 binary_is_png_compliant(PngBin) ->
-    ?line {Bin, _} = split_binary(PngBin, 10),
+    {Bin, _} = split_binary(PngBin, 10),
     List = binary_to_list(Bin),
     case lists:sublist(List, 2,3) of
-	"PNG" -> true;
-	Other ->
-	   io:format("img -> ~p~n", [Other]),
-	   false
+        "PNG" -> true;
+        Other ->
+            io:format("img -> ~p~n", [Other]),
+            false
     end.
 
 %%----------------------------------------------------------------------
@@ -319,20 +358,20 @@ binary_is_png_compliant(PngBin) ->
 
 
 get_rgb() ->
-   R = random(255), 
-   G = random(255),   
-   B = random(255),
-   {R,G,B}.
+    R = random(255),
+    G = random(255),
+    B = random(255),
+    {R,G,B}.
 
 get_angle() ->
-   random(359).
+    random(359).
 
 get_point() ->
     get_point(get(image_size)).
 get_point({W,H}) ->
-   X = random(W - 1),
-   Y = random(H - 1),
-   {X,Y}.
+    X = random(W - 1),
+    Y = random(H - 1),
+    {X,Y}.
 
 get_size(Max) ->
     W = trunc(random(Max/2) + Max/2 + 1),
@@ -343,8 +382,8 @@ get_size(Max) ->
 get_points(N) ->
     get_points(N, []).
 get_points(0, Out) ->
-   Out;
+    Out;
 get_points(N, Out) ->
     get_points(N - 1, [get_point() | Out]).
 
-random(N) -> trunc(random:uniform(trunc(N + 1)) - 1).
+random(N) -> trunc(rand:uniform(trunc(N + 1)) - 1).
diff --git a/lib/percept/test/ipc_tree.erl b/lib/percept/test/ipc_tree.erl
index f7639eed1b..29da20e83f 100644
--- a/lib/percept/test/ipc_tree.erl
+++ b/lib/percept/test/ipc_tree.erl
@@ -1,13 +1,14 @@
-%% ``The contents of this file are subject to the Erlang Public License,
-%% Version 1.1, (the "License"); you may not use this file except in
-%% compliance with the License. You should have received a copy of the
-%% Erlang Public License along with this software. If not, it can be
-%% retrieved via the world wide web at http://www.erlang.org/.
-%% 
-%% Software distributed under the License is distributed on an "AS IS"
-%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-%% the License for the specific language governing rights and limitations
-%% under the License.
+%% ``Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
+%%
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
 %% 
 %% The Initial Developer of the Original Code is Ericsson Utvecklings AB.
 %% Portions created by Ericsson are Copyright 1999, Ericsson Utvecklings
@@ -45,4 +46,4 @@ gather([]) -> ok;
 gather([_|Pids]) -> receive _ -> gather(Pids) end.
 
 workload(0) -> ok;
-workload(N) -> math:sin(2), workload(N - 1).
+workload(N) -> _ = math:sin(2), workload(N - 1).
diff --git a/lib/percept/test/percept_SUITE.erl b/lib/percept/test/percept_SUITE.erl
index e415d92a04..fbc77302ae 100644
--- a/lib/percept/test/percept_SUITE.erl
+++ b/lib/percept/test/percept_SUITE.erl
@@ -1,133 +1,102 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2007-2011. All Rights Reserved.
+%% Copyright Ericsson AB 2007-2016. All Rights Reserved.
 %% 
-%% The contents of this file are subject to the Erlang Public License,
-%% Version 1.1, (the "License"); you may not use this file except in
-%% compliance with the License. You should have received a copy of the
-%% Erlang Public License along with this software. If not, it can be
-%% retrieved online at http://www.erlang.org/.
-%% 
-%% Software distributed under the License is distributed on an "AS IS"
-%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-%% the License for the specific language governing rights and limitations
-%% under the License.
+%% Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
+%%
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
 %% 
 %% %CopyrightEnd%
 %%
 
 -module(percept_SUITE).
--include_lib("test_server/include/test_server.hrl").
+-include_lib("common_test/include/ct.hrl").
 
 %% Test server specific exports
--export([all/0, suite/0,groups/0,init_per_group/2,end_per_group/2]).
--export([init_per_suite/1, end_per_suite/1]).
--export([init_per_testcase/2, end_per_testcase/2]).
+-export([all/0, suite/0]).
 
 %% Test cases
--export([
-	profile/1,
-	analyze/1,
-	analyze_dist/1,
-	webserver/1
-	]).
-
-%% Default timetrap timeout (set in init_per_testcase)
--define(default_timeout, ?t:minutes(2)).
-
-init_per_suite(Config) when is_list(Config) ->
-    Config.
+-export([app/1,
+         appup/1,
+         profile/1,
+         analyze/1,
+         analyze_dist/1,
+         webserver/1]).
 
-end_per_suite(Config) when is_list(Config) ->
-    Config.
-
-init_per_testcase(_Case, Config) ->
-    Dog = ?t:timetrap(?default_timeout),
-    [{max_size, 300}, {watchdog,Dog} | Config].
-
-end_per_testcase(_Case, Config) ->
-    Dog = ?config(watchdog, Config),
-    ?t:timetrap_cancel(Dog),
-    ok.
-
-suite() -> [{ct_hooks,[ts_install_cth]}].
+suite() ->
+    [{ct_hooks,[ts_install_cth]},
+     {timetrap, {minutes, 2}}].
 
 all() -> 
-    [webserver, profile, analyze, analyze_dist].
-
-groups() -> 
-    [].
-
-init_per_group(_GroupName, Config) ->
-    Config.
-
-end_per_group(_GroupName, Config) ->
-    Config.
+    [app, appup, webserver, profile,
+     analyze, analyze_dist].
 
 
 %%----------------------------------------------------------------------
 %% Tests
 %%----------------------------------------------------------------------
 
-webserver(suite) ->
-    [];
-webserver(doc) ->
-    ["Percept webserver test."];
+%% Test that the percept app file is ok
+app(Config) when is_list(Config) ->
+    ok = test_server:app_test(percept).
+
+%% Test that the percept appup file is ok
+appup(Config) when is_list(Config) ->
+    ok = test_server:appup_test(percept).
+
+%% Percept webserver test.
 webserver(Config) when is_list(Config) ->
     % Explicit start inets?
-    ?line {started, _, Port} = percept:start_webserver(),
-    ?line ok = percept:stop_webserver(Port), 
-    ?line {started, _, _} = percept:start_webserver(),
-    ?line ok = percept:stop_webserver(),
-    ?line {started, _, NewPort} = percept:start_webserver(),
-    ?line ok = percept:stop_webserver(NewPort),
-    ?line application:stop(inets),
+    {started, _, Port} = percept:start_webserver(),
+    ok = percept:stop_webserver(Port), 
+    {started, _, _} = percept:start_webserver(),
+    ok = percept:stop_webserver(),
+    {started, _, NewPort} = percept:start_webserver(),
+    ok = percept:stop_webserver(NewPort),
+    application:stop(inets),
     ok.
 
-profile(suite) ->
-    [];
-profile(doc) ->
-    ["Percept profile test."];
+%% Percept profile test.
 profile(Config) when is_list(Config) ->
-    Path = ?config(data_dir, Config),
+    Path = proplists:get_value(data_dir, Config),
     File = filename:join([Path,"profile_test.dat"]),
-    ?line {ok, _} = percept:profile(File, [procs]),
+    {ok, _} = percept:profile(File, [procs]),
     ipc_tree:go(7),
-    ?line ok = percept:stop_profile(),
+    ok = percept:stop_profile(),
     ok.
 
-analyze(suite) ->
-    [];
-analyze(doc) ->
-    ["Percept analyze test."];
+%% Percept analyze test.
 analyze(Config) when is_list(Config) ->
     Begin = processes(),
-    Path = ?config(data_dir, Config),
+    Path = proplists:get_value(data_dir, Config),
     File = filename:join([Path,"profile_test.dat"]),
-    T0 = erlang:now(),
-    ?line ok = percept:analyze(File),
-    T1 = erlang:now(),
-    Secs = timer:now_diff(T1,T0)/1000000,
-    io:format("percept:analyze/1 took ~.2f s.~n", [Secs]),
-    ?line {stopped, _} = percept_db:stop(),
+    T0 = erlang:monotonic_time(milli_seconds),
+    ok = percept:analyze(File),
+    T1 = erlang:monotonic_time(milli_seconds),
+    io:format("percept:analyze/1 took ~w ms.~n", [T1 - T0]),
+    {stopped, _} = percept_db:stop(),
     print_remainers(remainers(Begin, processes())),
     ok.
 
-analyze_dist(suite) ->
-    [];
-analyze_dist(doc) ->
-    ["Percept analyze distribution test."];
+%% Percept analyze distribution test.
 analyze_dist(Config) when is_list(Config) ->
     Begin = processes(),
-    Path = ?config(data_dir, Config),
+    Path = proplists:get_value(data_dir, Config),
     File = filename:join([Path,"ipc-dist.dat"]),
-    T0 = erlang:now(),
-    ?line ok = percept:analyze(File),
-    T1 = erlang:now(),
-    Secs = timer:now_diff(T1,T0)/1000000,
-    io:format("percept:analyze/1 took ~.2f s.~n", [Secs]),
-    ?line {stopped, _} = percept_db:stop(),
+    T0 = erlang:monotonic_time(milli_seconds),
+    ok = percept:analyze(File),
+    T1 = erlang:monotonic_time(milli_seconds),
+    io:format("percept:analyze/1 took ~w ms.~n", [T1 - T0]),
+    {stopped, _} = percept_db:stop(),
     print_remainers(remainers(Begin, processes())),
     ok.
 
@@ -155,9 +124,3 @@ remainers(Begin, [Pid|End], Out) ->
 	true  -> remainers(Begin, End, Out);
 	false -> remainers(Begin, End, [Pid|Out])
     end.
-
-
-
-    
-
-
diff --git a/lib/percept/test/percept_db_SUITE.erl b/lib/percept/test/percept_db_SUITE.erl
index 79be9714ba..b2827e0e42 100644
--- a/lib/percept/test/percept_db_SUITE.erl
+++ b/lib/percept/test/percept_db_SUITE.erl
@@ -1,74 +1,53 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2007-2010. All Rights Reserved.
+%% Copyright Ericsson AB 2007-2016. All Rights Reserved.
 %%
-%% The contents of this file are subject to the Erlang Public License,
-%% Version 1.1, (the "License"); you may not use this file except in
-%% compliance with the License. You should have received a copy of the
-%% Erlang Public License along with this software. If not, it can be
-%% retrieved online at http://www.erlang.org/.
+%% Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
 %%
-%% Software distributed under the License is distributed on an "AS IS"
-%% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
-%% the License for the specific language governing rights and limitations
-%% under the License.
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
 %%
 %% %CopyrightEnd%
 %%
 
 -module(percept_db_SUITE).
--include("test_server.hrl").
+-include_lib("common_test/include/ct.hrl").
 
 %% Test server specific exports
--export([all/1]).
--export([init_per_suite/1, end_per_suite/1]).
--export([init_per_testcase/2, end_per_testcase/2]).
+-export([all/0, suite/0]).
 
 %% Test cases
--export([
-	start/1
-	]).
+-export([start/1]).
 
 %% Default timetrap timeout (set in init_per_testcase)
--define(default_timeout, ?t:minutes(2)).
 -define(restarts, 10).
 -define(alive_timeout, 500).
 
-init_per_suite(Config) when is_list(Config) ->
-    Config.
-
-end_per_suite(Config) when is_list(Config) ->
-    Config.
-
-init_per_testcase(_Case, Config) ->
-    Dog = ?t:timetrap(?default_timeout),
-    [{max_size, 300}, {watchdog,Dog} | Config].
-
-end_per_testcase(_Case, Config) ->
-    Dog = ?config(watchdog, Config),
-    ?t:timetrap_cancel(Dog),
-    ok.
+suite() ->
+    [{timetrap, {minutes, 2}}].
 
-all(suite) ->
-    % Test cases
+all() ->
     [start].
 
 %%----------------------------------------------------------------------
 %% Tests
 %%----------------------------------------------------------------------
 
-start(suite) ->
-    [];
-start(doc) ->
-    ["Percept_db start and restart test."];
+%% Percept_db start and restart test.
 start(Config) when is_list(Config) ->
     ok = restart(?restarts),
     {stopped, _DB} = percept_db:stop(),
     ok.
 
-restart(0)->
-    ok;
+restart(0)-> ok;
 restart(N)->
     {_, DB} = percept_db:start(),
     timer:sleep(?alive_timeout),