diff options
| author | Raimo Niskanen <[email protected]> | 2014-08-29 11:19:52 +0200 |
|---|---|---|
| committer | Raimo Niskanen <[email protected]> | 2014-09-03 16:03:19 +0200 |
| commit | 5bd1edc7b53dbcea6f63e0a7fb57925935e6b293 (patch) | |
| tree | 34c29df796dea4ee090e8c787010eca5a3c05649 /lib/snmp/src/agent/snmp_framework_mib.erl | |
| parent | 46f752b15205977cb1191c1693e942a499d351f9 (diff) | |
| download | otp-5bd1edc7b53dbcea6f63e0a7fb57925935e6b293.tar.gz otp-5bd1edc7b53dbcea6f63e0a7fb57925935e6b293.tar.bz2 otp-5bd1edc7b53dbcea6f63e0a7fb57925935e6b293.zip | |
Clean up some config warts
Diffstat (limited to 'lib/snmp/src/agent/snmp_framework_mib.erl')
| -rw-r--r-- | lib/snmp/src/agent/snmp_framework_mib.erl | 34 |
1 files changed, 20 insertions, 14 deletions
diff --git a/lib/snmp/src/agent/snmp_framework_mib.erl b/lib/snmp/src/agent/snmp_framework_mib.erl index 9d3f7ef5e7..6ff9224d34 100644 --- a/lib/snmp/src/agent/snmp_framework_mib.erl +++ b/lib/snmp/src/agent/snmp_framework_mib.erl @@ -207,22 +207,28 @@ check_agent({intAgentIpAddress = Tag, Ip} = Entry, {Domain, Port} = State) -> [{Tag, FixedIp}, {intAgentTransports, [{Domain, {FixedIp, Port}}]}] end, State}; -check_agent({intAgentTransports = Tag, Transports}, {_, Port} = State) -> +check_agent({intAgentTransports = Tag, Transports}, {_, Port} = State) + when is_list(Transports) -> CheckedTransports = - [case - case Port of - undefined -> - snmp_conf:check_address(Domain, Address); - _ -> - snmp_conf:check_address(Domain, Address, Port) - end - of - ok -> - Transport; - {ok, FixedAddress} -> - {Domain, FixedAddress} + [case Transport of + {Domain, Address} -> + case + case Port of + undefined -> + snmp_conf:check_address(Domain, Address); + _ -> + snmp_conf:check_address(Domain, Address, Port) + end + of + ok -> + Transport; + {ok, FixedAddress} -> + {Domain, FixedAddress} + end; + _ -> + error({bad_transport, Transport}) end - || {Domain, Address} = Transport <- Transports], + || Transport <- Transports], {{ok, {Tag, CheckedTransports}}, State}; check_agent(Entry, State) -> {check_agent(Entry), State}. |